[jira] [Commented] (HBASE-3641) LruBlockCache.CacheStats.getHitCount() is not using the correct variable

2011-03-22 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009955#comment-13009955
 ] 

Hudson commented on HBASE-3641:
---

Integrated in HBase-TRUNK #1803 (See 
[https://hudson.apache.org/hudson/job/HBase-TRUNK/1803/])


> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> 
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
>  Issue Type: Bug
>  Components: io
>Affects Versions: 0.90.1, 0.92.0
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch, HBASE-3641-v2.patch
>
>
> {code}
> public long getHitCount() {
>   return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3641) LruBlockCache.CacheStats.getHitCount() is not using the correct variable

2011-03-14 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006752#comment-13006752
 ] 

stack commented on HBASE-3641:
--

+1 (You must be a little busy Jon -- smile)

> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> 
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
>  Issue Type: Bug
>  Components: io
>Affects Versions: 0.90.1, 0.92.0
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch, HBASE-3641-v2.patch
>
>
> {code}
> public long getHitCount() {
>   return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3641) LruBlockCache.CacheStats.getHitCount() is not using the correct variable

2011-03-14 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006726#comment-13006726
 ] 

stack commented on HBASE-3641:
--

Patch looks odd:

{code}
 public long getHitCachingCount() {
-  return hitCachingCount.get();
+  return hitCount.get();
 }
{code}

The method is called getHitCachingCount and it was returning state of 
hitCachingCount... which seems right?

> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> 
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
>  Issue Type: Bug
>  Components: io
>Affects Versions: 0.90.1, 0.92.0
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch
>
>
> {code}
> public long getHitCount() {
>   return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira