Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
stoty commented on code in PR #5766:
URL: https://github.com/apache/hbase/pull/5766#discussion_r1607692557
##
hbase-assembly-byo-hadoop/pom.xml:
##
@@ -0,0 +1,684 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ 4.0.0
+
+org.apache.hbase
+hbase-build-configuration
+${revision}
+../hbase-build-configuration
+
+ hbase-assembly-byo-hadoop
+ pom
+ Apache HBase - Assembly without Hadoop and its transitive
dependencies
+ Module that does project assembly without Hadoop and its
transitive dependencies jars and that is all that it does.
+
+true
+
+
+
+
+
+
+
+ org.apache.hbase
+ hbase-shaded-client
+
+
+ org.apache.hbase
+ hbase-shaded-client-byo-hadoop
+
+
+ org.apache.hbase
+ hbase-shaded-mapreduce
+
+
+
+ org.apache.hbase
+ hbase-it
+ test-jar
+
+
+
+ org.hamcrest
+ hamcrest-core
+
+ compile
+
+
+ org.apache.hbase
+ hbase-openssl
+
+
+ org.apache.hbase
+ hbase-server
+
+
+ org.apache.hbase
+ hbase-mapreduce
+
+
+ org.apache.hbase
+ hbase-mapreduce
+ test-jar
+
+
+ org.apache.hbase
+ hbase-annotations
+
+
+org.apache.hbase
+hbase-hadoop-compat
+
+
+
+ org.apache.hbase
+ hbase-procedure
+
+
+ org.apache.hbase
+ hbase-procedure
+ test-jar
+ test
+
+
+ org.apache.hbase
+ hbase-hadoop-compat
+
+
+ com.google.guava
+ guava
+
+
+
+
+ org.apache.hbase
+ hbase-shell
+
+
+ org.apache.hbase
+ hbase-thrift
+
+
+ org.apache.hbase
+ hbase-rest
+
+
+ org.apache.hbase
+ hbase-external-blockcache
+
+
+ org.apache.hbase
+ hbase-testing-util
+
+
+ org.apache.hbase
+ hbase-metrics-api
+
+
+ org.apache.hbase
+ hbase-metrics
+
+
+ org.apache.hbase
+ hbase-protocol-shaded
+
+
+ org.apache.hbase
+ hbase-resource-bundle
+ true
+
+
+ org.apache.httpcomponents
+ httpclient
+
+
+ org.apache.httpcomponents
+ httpcore
+
+
+ org.apache.hbase
+ hbase-backup
+
+
+ org.apache.hbase
+ hbase-balancer
+
+
+ org.apache.hbase
+ hbase-replication
+
+
+ org.apache.hbase
+ hbase-http
+
+
+ org.apache.hbase
+ hbase-zookeeper
+
+
+ org.apache.hbase
+ hbase-hbtop
+
+
+ org.apache.hbase
+ hbase-compression-aircompressor
+
+
+ org.apache.hbase
+ hbase-compression-brotli
+
+
+ org.apache.hbase
+ hbase-compression-lz4
+
+
+ org.apache.hbase
+ hbase-compression-snappy
+
+
+ org.apache.hbase
+ hbase-compression-xz
+
+
+ org.apache.hbase
+ hbase-compression-zstd
+
+
+
+
+
+
+
+ jline
+ jline
+
+
+ com.sun.xml.ws
+ jaxws-ri
+ pom
+
+
+
+ org.slf4j
+ jcl-over-slf4j
+
+
+ org.slf4j
+ jul-to-slf4j
+
+
+ org.apache.logging.log4j
+ log4j-api
+
+
+ org.apache.logging.log4j
+ log4j-core
+
+
+ org.apache.logging.log4j
+ log4j-slf4j-impl
+
+
+ org.apache.logging.log4j
+ log4j-1.2-api
+
+
+
+ io.opentelemetry.javaagent
+ opentelemetry-javaagent
+
+
+ junit
+ junit
+
+
+ org.mockito
+ mockito-core
+
+
+ compile
+
+
+
+
+
+
+org.apache.hadoop
+hadoop-yarn-api
+${hadoop-three.version}
+
Review Comment:
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
stoty commented on code in PR #5766:
URL: https://github.com/apache/hbase/pull/5766#discussion_r1607691886
##
hbase-assembly-byo-hadoop/pom.xml:
##
@@ -0,0 +1,684 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ 4.0.0
+
+org.apache.hbase
+hbase-build-configuration
+${revision}
+../hbase-build-configuration
+
+ hbase-assembly-byo-hadoop
+ pom
+ Apache HBase - Assembly without Hadoop and its transitive
dependencies
+ Module that does project assembly without Hadoop and its
transitive dependencies jars and that is all that it does.
+
+true
+
+
+
+
+
+
+
+ org.apache.hbase
+ hbase-shaded-client
+
+
+ org.apache.hbase
+ hbase-shaded-client-byo-hadoop
+
+
+ org.apache.hbase
+ hbase-shaded-mapreduce
+
+
+
+ org.apache.hbase
+ hbase-it
+ test-jar
+
+
+
+ org.hamcrest
+ hamcrest-core
+
+ compile
+
+
+ org.apache.hbase
+ hbase-openssl
+
+
+ org.apache.hbase
+ hbase-server
+
+
+ org.apache.hbase
+ hbase-mapreduce
+
+
+ org.apache.hbase
+ hbase-mapreduce
+ test-jar
+
+
+ org.apache.hbase
+ hbase-annotations
+
+
+org.apache.hbase
+hbase-hadoop-compat
+
+
+
+ org.apache.hbase
+ hbase-procedure
+
+
+ org.apache.hbase
+ hbase-procedure
+ test-jar
+ test
+
+
+ org.apache.hbase
+ hbase-hadoop-compat
+
+
+ com.google.guava
+ guava
+
+
+
+
+ org.apache.hbase
+ hbase-shell
+
+
+ org.apache.hbase
+ hbase-thrift
+
+
+ org.apache.hbase
+ hbase-rest
+
+
+ org.apache.hbase
+ hbase-external-blockcache
+
+
+ org.apache.hbase
+ hbase-testing-util
+
+
+ org.apache.hbase
+ hbase-metrics-api
+
+
+ org.apache.hbase
+ hbase-metrics
+
+
+ org.apache.hbase
+ hbase-protocol-shaded
+
+
+ org.apache.hbase
+ hbase-resource-bundle
+ true
+
+
+ org.apache.httpcomponents
+ httpclient
+
+
+ org.apache.httpcomponents
+ httpcore
+
+
+ org.apache.hbase
+ hbase-backup
+
+
+ org.apache.hbase
+ hbase-balancer
+
+
+ org.apache.hbase
+ hbase-replication
+
+
+ org.apache.hbase
+ hbase-http
+
+
+ org.apache.hbase
+ hbase-zookeeper
+
+
+ org.apache.hbase
+ hbase-hbtop
+
+
+ org.apache.hbase
+ hbase-compression-aircompressor
+
+
+ org.apache.hbase
+ hbase-compression-brotli
+
+
+ org.apache.hbase
+ hbase-compression-lz4
+
+
+ org.apache.hbase
+ hbase-compression-snappy
+
+
+ org.apache.hbase
+ hbase-compression-xz
+
+
+ org.apache.hbase
+ hbase-compression-zstd
+
+
+
+
+
+
+
+ jline
+ jline
+
+
+ com.sun.xml.ws
+ jaxws-ri
+ pom
+
+
+
+ org.slf4j
+ jcl-over-slf4j
+
+
+ org.slf4j
+ jul-to-slf4j
+
+
+ org.apache.logging.log4j
+ log4j-api
+
+
+ org.apache.logging.log4j
+ log4j-core
+
+
+ org.apache.logging.log4j
+ log4j-slf4j-impl
+
+
+ org.apache.logging.log4j
+ log4j-1.2-api
+
+
+
+ io.opentelemetry.javaagent
+ opentelemetry-javaagent
+
+
+ junit
+ junit
+
+
+ org.mockito
+ mockito-core
+
+
+ compile
+
+
+
+
+
+
+org.apache.hadoop
+hadoop-yarn-api
+${hadoop-three.version}
+
Review Comment:
They probably can.
I wil test it for the next patch version, and remove them if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
ndimiduk commented on code in PR #5766:
URL: https://github.com/apache/hbase/pull/5766#discussion_r1605103265
##
hbase-assembly-byo-hadoop/pom.xml:
##
@@ -0,0 +1,684 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ 4.0.0
+
+org.apache.hbase
+hbase-build-configuration
+${revision}
+../hbase-build-configuration
+
+ hbase-assembly-byo-hadoop
+ pom
+ Apache HBase - Assembly without Hadoop and its transitive
dependencies
+ Module that does project assembly without Hadoop and its
transitive dependencies jars and that is all that it does.
+
+true
+
+
+
+
+
+
+
+ org.apache.hbase
+ hbase-shaded-client
+
+
+ org.apache.hbase
+ hbase-shaded-client-byo-hadoop
+
+
+ org.apache.hbase
+ hbase-shaded-mapreduce
+
+
+
+ org.apache.hbase
+ hbase-it
+ test-jar
+
+
+
+ org.hamcrest
+ hamcrest-core
+
+ compile
+
+
+ org.apache.hbase
+ hbase-openssl
+
+
+ org.apache.hbase
+ hbase-server
+
+
+ org.apache.hbase
+ hbase-mapreduce
+
+
+ org.apache.hbase
+ hbase-mapreduce
+ test-jar
+
+
+ org.apache.hbase
+ hbase-annotations
+
+
+org.apache.hbase
+hbase-hadoop-compat
+
+
+
+ org.apache.hbase
+ hbase-procedure
+
+
+ org.apache.hbase
+ hbase-procedure
+ test-jar
+ test
+
+
+ org.apache.hbase
+ hbase-hadoop-compat
+
+
+ com.google.guava
+ guava
+
+
+
+
+ org.apache.hbase
+ hbase-shell
+
+
+ org.apache.hbase
+ hbase-thrift
+
+
+ org.apache.hbase
+ hbase-rest
+
+
+ org.apache.hbase
+ hbase-external-blockcache
+
+
+ org.apache.hbase
+ hbase-testing-util
+
+
+ org.apache.hbase
+ hbase-metrics-api
+
+
+ org.apache.hbase
+ hbase-metrics
+
+
+ org.apache.hbase
+ hbase-protocol-shaded
+
+
+ org.apache.hbase
+ hbase-resource-bundle
+ true
+
+
+ org.apache.httpcomponents
+ httpclient
+
+
+ org.apache.httpcomponents
+ httpcore
+
+
+ org.apache.hbase
+ hbase-backup
+
+
+ org.apache.hbase
+ hbase-balancer
+
+
+ org.apache.hbase
+ hbase-replication
+
+
+ org.apache.hbase
+ hbase-http
+
+
+ org.apache.hbase
+ hbase-zookeeper
+
+
+ org.apache.hbase
+ hbase-hbtop
+
+
+ org.apache.hbase
+ hbase-compression-aircompressor
+
+
+ org.apache.hbase
+ hbase-compression-brotli
+
+
+ org.apache.hbase
+ hbase-compression-lz4
+
+
+ org.apache.hbase
+ hbase-compression-snappy
+
+
+ org.apache.hbase
+ hbase-compression-xz
+
+
+ org.apache.hbase
+ hbase-compression-zstd
+
+
+
+
+
+
+
+ jline
+ jline
+
+
+ com.sun.xml.ws
+ jaxws-ri
+ pom
+
+
+
+ org.slf4j
+ jcl-over-slf4j
+
+
+ org.slf4j
+ jul-to-slf4j
+
+
+ org.apache.logging.log4j
+ log4j-api
+
+
+ org.apache.logging.log4j
+ log4j-core
+
+
+ org.apache.logging.log4j
+ log4j-slf4j-impl
+
+
+ org.apache.logging.log4j
+ log4j-1.2-api
+
+
+
+ io.opentelemetry.javaagent
+ opentelemetry-javaagent
+
+
+ junit
+ junit
+
+
+ org.mockito
+ mockito-core
+
+
+ compile
+
+
+
+
+
+
+org.apache.hadoop
+hadoop-yarn-api
+${hadoop-three.version}
+
Review Comment:
if these are at scope:provided, is it necessary to also have the exclusions
list? Can these `exclusion`s be omitted enitrely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
Apache-HBase commented on PR #5766: URL: https://github.com/apache/hbase/pull/5766#issuecomment-2010340828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | master passed | | +1 :green_heart: | compile | 2m 34s | master passed | | +1 :green_heart: | shadedjars | 6m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 2m 9s | the patch passed | | +1 :green_heart: | javac | 2m 9s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 390m 17s | root in the patch failed. | | | | 424m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5766 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 88a659345c52 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0763a74096 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/testReport/ | | Max. process+thread count | 5302 (vs. ulimit of 3) | | modules | C: hbase-assembly-byo-hadoop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
Apache-HBase commented on PR #5766: URL: https://github.com/apache/hbase/pull/5766#issuecomment-2010268403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 2m 34s | master passed | | +1 :green_heart: | shadedjars | 6m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 49s | the patch passed | | +1 :green_heart: | compile | 2m 29s | the patch passed | | +1 :green_heart: | javac | 2m 29s | the patch passed | | +1 :green_heart: | shadedjars | 6m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 343m 23s | root in the patch passed. | | | | 381m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5766 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 62a12debffdb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0763a74096 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/testReport/ | | Max. process+thread count | 8484 (vs. ulimit of 3) | | modules | C: hbase-assembly-byo-hadoop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
Apache-HBase commented on PR #5766: URL: https://github.com/apache/hbase/pull/5766#issuecomment-2010108670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 3m 1s | master passed | | +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 10s | the patch passed | | +1 :green_heart: | compile | 2m 32s | the patch passed | | +1 :green_heart: | javac | 2m 32s | the patch passed | | +1 :green_heart: | shadedjars | 5m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 30s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 299m 34s | root in the patch failed. | | | | 336m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5766 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8498f85875b6 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0763a74096 | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/testReport/ | | Max. process+thread count | 5291 (vs. ulimit of 3) | | modules | C: hbase-assembly-byo-hadoop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
Apache-HBase commented on PR #5766: URL: https://github.com/apache/hbase/pull/5766#issuecomment-2009425733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | compile | 6m 21s | master passed | | +1 :green_heart: | spotless | 0m 55s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 6m 27s | the patch passed | | +1 :green_heart: | javac | 6m 27s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -0 :warning: | whitespace | 0m 0s | The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -0 :warning: | whitespace | 0m 0s | The patch 4 line(s) with tabs. | | +1 :green_heart: | xml | 0m 7s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 6m 47s | Patch does not cause any errors with Hadoop 3.3.6. | | -1 :x: | spotless | 0m 9s | patch has 58 errors when running spotless:check, run spotless:apply to fix. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 36m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5766 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile shellcheck shelldocs | | uname | Linux de6f60a78c60 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0763a74096 | | Default Java | Eclipse Adoptium-11.0.17+8 | | whitespace | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-general-check/output/whitespace-eol.txt | | whitespace | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-assembly-byo-hadoop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5766/1/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28434 Update assembly to create a tarball with hadoop and witho… [hbase]
stoty commented on PR #5766: URL: https://github.com/apache/hbase/pull/5766#issuecomment-2009353046 Just a very rough draft of how this could be done. It's probably better to leave this after the test dependencies have been cleaned up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
