[jira] [Updated] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18185:

Fix Version/s: 1.2.7
   1.3.2
   1.4.0
   2.0.0
   Status: Patch Available  (was: Open)

> IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails 
> with AssertionError
> ---
>
> Key: HBASE-18185
> URL: https://issues.apache.org/jira/browse/HBASE-18185
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Affects Versions: 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-18185-BM-0001.patch
>
>
> We got the following error:
> Exception in thread "main" java.lang.AssertionError: Verification failed with 
> error code 1
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106)
> at 
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123)
> at 
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362)
> The reason why we got it because another assertion fails in 
> UnbalanceKillAndRebalanceAction:
> Exception in thread "Thread-57" java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-17898:

Attachment: HBASE-17898-BM-0002.patch

Here is a smaller patch only with the safe updates.

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-17898:

Status: Patch Available  (was: Open)

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041876#comment-16041876
 ] 

Balazs Meszaros commented on HBASE-18185:
-

Thanks for your comments [~huaxiang], here is a safer version which will work 
even victimServers.size() is 0, 1 or 2.

> IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails 
> with AssertionError
> ---
>
> Key: HBASE-18185
> URL: https://issues.apache.org/jira/browse/HBASE-18185
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Affects Versions: 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-18185-BM-0001.patch, HBASE-18185-BM-0002.patch
>
>
> We got the following error:
> Exception in thread "main" java.lang.AssertionError: Verification failed with 
> error code 1
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106)
> at 
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123)
> at 
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362)
> The reason why we got it because another assertion fails in 
> UnbalanceKillAndRebalanceAction:
> Exception in thread "Thread-57" java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-17898:

Fix Version/s: 2.0.0

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch, 
> HBASE-17898-BM-0003.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18185:

Status: Patch Available  (was: Open)

> IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails 
> with AssertionError
> ---
>
> Key: HBASE-18185
> URL: https://issues.apache.org/jira/browse/HBASE-18185
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Affects Versions: 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-18185-BM-0001.patch, HBASE-18185-BM-0002.patch
>
>
> We got the following error:
> Exception in thread "main" java.lang.AssertionError: Verification failed with 
> error code 1
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106)
> at 
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123)
> at 
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362)
> The reason why we got it because another assertion fails in 
> UnbalanceKillAndRebalanceAction:
> Exception in thread "Thread-57" java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18185:

Status: Open  (was: Patch Available)

> IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails 
> with AssertionError
> ---
>
> Key: HBASE-18185
> URL: https://issues.apache.org/jira/browse/HBASE-18185
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Affects Versions: 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-18185-BM-0001.patch, HBASE-18185-BM-0002.patch
>
>
> We got the following error:
> Exception in thread "main" java.lang.AssertionError: Verification failed with 
> error code 1
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106)
> at 
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123)
> at 
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362)
> The reason why we got it because another assertion fails in 
> UnbalanceKillAndRebalanceAction:
> Exception in thread "Thread-57" java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18185:

Attachment: HBASE-18185-BM-0002.patch

> IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails 
> with AssertionError
> ---
>
> Key: HBASE-18185
> URL: https://issues.apache.org/jira/browse/HBASE-18185
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Affects Versions: 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-18185-BM-0001.patch, HBASE-18185-BM-0002.patch
>
>
> We got the following error:
> Exception in thread "main" java.lang.AssertionError: Verification failed with 
> error code 1
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123)
> at 
> org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106)
> at 
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123)
> at 
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at 
> org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362)
> The reason why we got it because another assertion fails in 
> UnbalanceKillAndRebalanceAction:
> Exception in thread "Thread-57" java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-17898:

Attachment: HBASE-17898-BM-0003.patch

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch, 
> HBASE-17898-BM-0003.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-17898:

Status: Open  (was: Patch Available)

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch, 
> HBASE-17898-BM-0003.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-17898:

Status: Patch Available  (was: Open)

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch, 
> HBASE-17898-BM-0003.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17898) Update dependencies

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051006#comment-16051006
 ] 

Balazs Meszaros commented on HBASE-17898:
-

It seems that these tests also fails on other commits, too.

> Update dependencies
> ---
>
> Key: HBASE-17898
> URL: https://issues.apache.org/jira/browse/HBASE-17898
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-17898-BM-0001.patch, HBASE-17898-BM-0002.patch, 
> HBASE-17898-BM-0003.patch, HBASE-17898-BM-0004.patch
>
>
> General issue to cover updating old, stale dependencies for hbase2 release. 
> Lets make subissues doing each.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18224) Upgrate jetty and thrift

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-18224:
---

 Summary: Upgrate jetty and thrift
 Key: HBASE-18224
 URL: https://issues.apache.org/jira/browse/HBASE-18224
 Project: HBase
  Issue Type: Sub-task
Reporter: Balazs Meszaros


Jetty can be updated to 9.4.6 and thrift can be updated to 0.10.0. I tried to 
update them in HBASE-17898 but some unit tests failed, so created a sub-task 
for them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Attachment: HBASE-18350.master.001.patch

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Status: Patch Available  (was: Open)

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Attachment: HBASE-18350.master.005.patch

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.004.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.005.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205793#comment-16205793
 ] 

Balazs Meszaros commented on HBASE-18350:
-

Sometimes TestRSGroups.testKillRS fails, but I do not know why. I found these 
messages in the logs:
{code}
2017-10-16 13:43:14,292 WARN  [ProcExecTimeout] 
assignment.AssignmentManager(1148): TODO Handle stuck in transition: 
rit=CLOSING, location=172.30.64.72,56004,1508154046320, 
table=Group_ns:testKillRS, region=18cd7f5a5a2c6da1dd0f848ad409a90b
2017-10-16 13:43:19,297 WARN  [ProcExecTimeout] 
assignment.AssignmentManager(1148): TODO Handle stuck in transition: 
rit=CLOSING, location=172.30.64.72,56004,1508154046320, 
table=Group_ns:testKillRS, region=18cd7f5a5a2c6da1dd0f848ad409a90b
2017-10-16 13:43:24,301 WARN  [ProcExecTimeout] 
assignment.AssignmentManager(1148): TODO Handle stuck in transition: 
rit=CLOSING, location=172.30.64.72,56004,1508154046320, 
table=Group_ns:testKillRS, region=18cd7f5a5a2c6da1dd0f848ad409a90b
2017-10-16 13:43:29,308 WARN  [ProcExecTimeout] 
assignment.AssignmentManager(1148): TODO Handle stuck in transition: 
rit=CLOSING, location=172.30.64.72,56004,1508154046320, 
table=Group_ns:testKillRS, region=18cd7f5a5a2c6da1dd0f848ad409a90b
{code}

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.004.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.005.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207562#comment-16207562
 ] 

Balazs Meszaros commented on HBASE-18350:
-

FindBugs fixed. Previously I fixed the ruby issues, only these left.

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.004.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.005.patch, 
> HBASE-18350.master.006.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Attachment: HBASE-18350.master.006.patch

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.004.patch, 
> HBASE-18350.master.004.patch, HBASE-18350.master.005.patch, 
> HBASE-18350.master.006.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200264#comment-16200264
 ] 

Balazs Meszaros commented on HBASE-18350:
-

Thanks for your comments [~busbey].

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Attachment: HBASE-18350.master.003.patch

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Attachment: HBASE-18350.master.004.patch

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch, 
> HBASE-18350.master.004.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202388#comment-16202388
 ] 

Balazs Meszaros commented on HBASE-18350:
-

These tests are enabled and pass on my machine.

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch, HBASE-18350.master.003.patch, 
> HBASE-18350.master.004.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158526#comment-16158526
 ] 

Balazs Meszaros commented on HBASE-18106:
-

Test runs locally.

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, 
> HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, 
> HBASE-18106.master.010.patch, HBASE-18106.master.011.patch, 
> HBASE-18106.master.011.patch, HBASE-18106.master.012.patch, 
> HBASE-18106.master.012.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (HBASE-14998) Unify synchronous and asynchronous methods in Admin and cleanup

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-14998 started by Balazs Meszaros.
---
> Unify synchronous and asynchronous methods in Admin and cleanup
> ---
>
> Key: HBASE-14998
> URL: https://issues.apache.org/jira/browse/HBASE-14998
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
>
> Admin has a bunch of methods, some are asnyc, some are sync. Needs some 
> unification in method naming, and method signatures. 
>  - We use modify and alter interchangeably. Pick one and stick with it 
> (modifyTable(), versus getAlterStatus()). Shell uses {{alter}}. 
>  - Remove getAlterStatus(), should not be needed. 
>  - remove already deprecated methods 
>  -  isTableAvailable(TableName tableName, byte[][] splitKeys) should be 
> removed. 
>  - Consistently use Aysnc as a prefix for all async methods. 
>  - Other ideas? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-14998) Unify synchronous and asynchronous methods in Admin and cleanup

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros reassigned HBASE-14998:
---

Assignee: Balazs Meszaros

> Unify synchronous and asynchronous methods in Admin and cleanup
> ---
>
> Key: HBASE-14998
> URL: https://issues.apache.org/jira/browse/HBASE-14998
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
>
> Admin has a bunch of methods, some are asnyc, some are sync. Needs some 
> unification in method naming, and method signatures. 
>  - We use modify and alter interchangeably. Pick one and stick with it 
> (modifyTable(), versus getAlterStatus()). Shell uses {{alter}}. 
>  - Remove getAlterStatus(), should not be needed. 
>  - remove already deprecated methods 
>  -  isTableAvailable(TableName tableName, byte[][] splitKeys) should be 
> removed. 
>  - Consistently use Aysnc as a prefix for all async methods. 
>  - Other ideas? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.011.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, 
> HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, 
> HBASE-18106.master.010.patch, HBASE-18106.master.011.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156809#comment-16156809
 ] 

Balazs Meszaros commented on HBASE-18106:
-

I did my best with JRuby issues.

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, 
> HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, 
> HBASE-18106.master.010.patch, HBASE-18106.master.011.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.010.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, 
> HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, 
> HBASE-18106.master.010.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-14998) Unify synchronous and asynchronous methods in Admin and cleanup

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-14998:

Attachment: HBASE-14998.master.003.patch

+1

Fixed some typos (s/< Unify synchronous and asynchronous methods in Admin and cleanup
> ---
>
> Key: HBASE-14998
> URL: https://issues.apache.org/jira/browse/HBASE-14998
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
> Attachments: 14998.txt, HBASE-14998.master.001.patch, 
> HBASE-14998.master.002.patch, HBASE-14998.master.003.patch
>
>
> Admin has a bunch of methods, some are asnyc, some are sync. Needs some 
> unification in method naming, and method signatures. 
>  - We use modify and alter interchangeably. Pick one and stick with it 
> (modifyTable(), versus getAlterStatus()). Shell uses {{alter}}. 
>  - Remove getAlterStatus(), should not be needed. 
>  - remove already deprecated methods 
>  -  isTableAvailable(TableName tableName, byte[][] splitKeys) should be 
> removed. 
>  - Consistently use Aysnc as a prefix for all async methods. 
>  - Other ideas? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18805) Unify Admin and AsyncAdmin

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-18805:
---

 Summary: Unify Admin and AsyncAdmin
 Key: HBASE-18805
 URL: https://issues.apache.org/jira/browse/HBASE-18805
 Project: HBase
  Issue Type: Sub-task
Reporter: Balazs Meszaros


Admin and AsyncAdmin differ some places:
- some methods missing from AsyncAdmin (e.g. methods with String regex),
- some methods have different names (listTables vs listTableDescriptors),
- some method parameters are different (e.g. AsyncAdmin has Optional<> 
parameters),
- AsyncAdmin returns Lists instead of arrays (e.g. listTableNames),
- unify Javadoc comments,
- ...




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-14998) Unify synchronous and asynchronous methods in Admin and cleanup

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163054#comment-16163054
 ] 

Balazs Meszaros commented on HBASE-14998:
-

[~stack] Yes, I am working on it. I have also noticed that:
- deprecated methods has been removed,
- async methods have the same signature as their synchronous equivalent expect 
takeSnapshotAsync (it should be renamed to snapshotAsync),
- this listTableDescriptor is also wierd.

But why do we need async methods in Admin, if we have a full asynchronous 
AsyncAdmin API?

And here come the problems, because I think we should provide the same methods 
in AsyncAdmin as in Admin. I have compared them, and added the missing 
functions to AsyncAdmin. There are also some differences, what we should 
address:
- the return values are arrays in Admin at some places (e.g. 
Admin.listTableNames) and List in AsyncAdmin (e.g. AsyncAdmin.listTableNames),
- there are some Optional<> stuff in AsyncAdmin, what we should remove in my 
opinion,
- there are some different parameters like Admin.stopRegionServer vs 
AsyncAdmin.stopRegionServer, Admin.getQuotaRetriever vs AsyncAdmin.getQuota, 
etc,
- I renamed (deprecate the old ones and create new ones) some functions in 
Admin, like setSplitOn, etc...

I think we should unify these two APIs too, before beta1.

> Unify synchronous and asynchronous methods in Admin and cleanup
> ---
>
> Key: HBASE-14998
> URL: https://issues.apache.org/jira/browse/HBASE-14998
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
> Attachments: 14998.txt
>
>
> Admin has a bunch of methods, some are asnyc, some are sync. Needs some 
> unification in method naming, and method signatures. 
>  - We use modify and alter interchangeably. Pick one and stick with it 
> (modifyTable(), versus getAlterStatus()). Shell uses {{alter}}. 
>  - Remove getAlterStatus(), should not be needed. 
>  - remove already deprecated methods 
>  -  isTableAvailable(TableName tableName, byte[][] splitKeys) should be 
> removed. 
>  - Consistently use Aysnc as a prefix for all async methods. 
>  - Other ideas? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-14998) Unify synchronous and asynchronous methods in Admin and cleanup

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163302#comment-16163302
 ] 

Balazs Meszaros commented on HBASE-14998:
-

bq. You going to put up a patch to deprecate and add snapshotAsync? That makes 
sense.

Yes.

bq. Is this ok?

I think we should unify it, but it will be hard, because then we should 
introduce new functions :( Or we can change AsyncAdmin to use arrays instead of 
lists in those cases. (I think we can modify AsyncAdmin freely, because it is 
an unreleased API.) But I prefer Lists to arrays.

bq. There is a bunch of it. Optional is jdk8, new. I could go either way. It is 
a clean message that null is ok and it cuts down on number of overrides needed.

I agree that optional is a nice stuff, but we can also use @Nullable to mark 
parameters as optional.

> Unify synchronous and asynchronous methods in Admin and cleanup
> ---
>
> Key: HBASE-14998
> URL: https://issues.apache.org/jira/browse/HBASE-14998
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
> Attachments: 14998.txt
>
>
> Admin has a bunch of methods, some are asnyc, some are sync. Needs some 
> unification in method naming, and method signatures. 
>  - We use modify and alter interchangeably. Pick one and stick with it 
> (modifyTable(), versus getAlterStatus()). Shell uses {{alter}}. 
>  - Remove getAlterStatus(), should not be needed. 
>  - remove already deprecated methods 
>  -  isTableAvailable(TableName tableName, byte[][] splitKeys) should be 
> removed. 
>  - Consistently use Aysnc as a prefix for all async methods. 
>  - Other ideas? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18705) bin/hbase does not find cached_classpath.txt

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-18705:
---

 Summary: bin/hbase does not find cached_classpath.txt
 Key: HBASE-18705
 URL: https://issues.apache.org/jira/browse/HBASE-18705
 Project: HBase
  Issue Type: Task
Affects Versions: 3.0.0
Reporter: Balazs Meszaros
Assignee: Balazs Meszaros


Starting hbase with {{bin/start-hbase.sh}} reports the following error:
{code:none}
As this is a development environment, we need 
/.../hbase/bin/../target/cached_classpath.txt to be generated from maven 
(command: mvn install -DskipTests)
{code}

The {{cached_classpath.txt}} is generated by hbase-assembly but it saves that 
file in {{$project.parent.basedir/...}}. Since hbase-build-configuration is the 
parent of hbase-assembly, the script searches the file at the wrong place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18705) bin/hbase does not find cached_classpath.txt

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18705:

Attachment: HBASE-18705.master.001.patch

> bin/hbase does not find cached_classpath.txt
> 
>
> Key: HBASE-18705
> URL: https://issues.apache.org/jira/browse/HBASE-18705
> Project: HBase
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
> Attachments: HBASE-18705.master.001.patch
>
>
> Starting hbase with {{bin/start-hbase.sh}} reports the following error:
> {code:none}
> As this is a development environment, we need 
> /.../hbase/bin/../target/cached_classpath.txt to be generated from maven 
> (command: mvn install -DskipTests)
> {code}
> The {{cached_classpath.txt}} is generated by hbase-assembly but it saves that 
> file in {{$project.parent.basedir/...}}. Since hbase-build-configuration is 
> the parent of hbase-assembly, the script searches the file at the wrong place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18705) bin/hbase does not find cached_classpath.txt

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18705:

Fix Version/s: 3.0.0
   Status: Patch Available  (was: Open)

> bin/hbase does not find cached_classpath.txt
> 
>
> Key: HBASE-18705
> URL: https://issues.apache.org/jira/browse/HBASE-18705
> Project: HBase
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
> Fix For: 3.0.0
>
> Attachments: HBASE-18705.master.001.patch
>
>
> Starting hbase with {{bin/start-hbase.sh}} reports the following error:
> {code:none}
> As this is a development environment, we need 
> /.../hbase/bin/../target/cached_classpath.txt to be generated from maven 
> (command: mvn install -DskipTests)
> {code}
> The {{cached_classpath.txt}} is generated by hbase-assembly but it saves that 
> file in {{$project.parent.basedir/...}}. Since hbase-build-configuration is 
> the parent of hbase-assembly, the script searches the file at the wrong place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18706) Remove / fix not working pages from backup master web UI

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-18706:
---

 Summary: Remove / fix not working pages from backup master web UI
 Key: HBASE-18706
 URL: https://issues.apache.org/jira/browse/HBASE-18706
 Project: HBase
  Issue Type: Bug
Reporter: Balazs Meszaros


When I connect to a locally started backup master web interface, I have the 
following issues:
1. {{/tablesDetailed.jsp}} times out, we should remove the links from the menu, 
or we should connect to the active master.
2. {{/procedures.jsp}} throws an exception. The link to it is missing from 
{{/master-status}}, but it is visible under Process Metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18706) Remove / fix not working pages from backup master web UI

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18706:

Affects Version/s: 3.0.0
   1.2.6

> Remove / fix not working pages from backup master web UI
> 
>
> Key: HBASE-18706
> URL: https://issues.apache.org/jira/browse/HBASE-18706
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0, 1.2.6
>Reporter: Balazs Meszaros
>
> When I connect to a locally started backup master web interface, I have the 
> following issues:
> 1. {{/tablesDetailed.jsp}} times out, we should remove the links from the 
> menu, or we should connect to the active master.
> 2. {{/procedures.jsp}} throws an exception. The link to it is missing from 
> {{/master-status}}, but it is visible under Process Metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.007.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch, HBASE-18106.master.007.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.006.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Release Note: 
Admin.listProcedures and Admin.listLocks were renamed to getProcedures and 
getLocks.

listProcedures permission has been renamed to getProcedures and getLocks 
permission was introduced.

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.008.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, 
> HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, 
> HBASE-18106.master.008.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.005.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch, HBASE-18106.master.005.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18106:

Attachment: HBASE-18106.master.004.patch

> Redo ProcedureInfo and LockInfo
> ---
>
> Key: HBASE-18106
> URL: https://issues.apache.org/jira/browse/HBASE-18106
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18106.master.001.patch, 
> HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, 
> HBASE-18106.master.004.patch
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18350:

Attachment: HBASE-18350.master.002.patch

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch, 
> HBASE-18350.master.002.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18350) RSGroups are broken under AMv2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200288#comment-16200288
 ] 

Balazs Meszaros commented on HBASE-18350:
-

The result of list_rsgroups and get_rsgroup changed slightly.

list_rsgroups also includes the contained servers and tables:
{code}
hbase(main):001:0> list_rsgroups
NAME  SERVER / TABLE
 default  server 172.30.64.72:51649
  server 172.30.64.72:51654
  server 172.30.64.72:51656
  table hbase:meta
  table hbase:namespace
  table hbase:rsgroup
1 row(s)
Took 0.4248 seconds
{code}

get_rsgroups:
{code}
hbase(main):002:0> get_rsgroup 'default'
SERVERS
172.30.64.72:51649
172.30.64.72:51654
172.30.64.72:51656
3 row(s)
TABLES
hbase:meta
hbase:namespace
hbase:rsgroup
3 row(s)
Took 0.0202 seconds
{code}

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18350.master.001.patch
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266964#comment-16266964
 ] 

Balazs Meszaros commented on HBASE-18601:
-

Many thanks [~chia7712] for digging into it. I am working on the fix.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Improvement
>  Components: dependencies, tracing
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, 
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18601:

Attachment: HBASE-18601.master.016.patch

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Improvement
>  Components: dependencies, tracing
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, 
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch, 
> HBASE-18601.master.016.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19242) Add MOB compact support for AsyncAdmin

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19242:

Attachment: HBASE-19242.master.003.patch

Fixed some checkstyle warnings.

> Add MOB compact support for AsyncAdmin
> --
>
> Key: HBASE-19242
> URL: https://issues.apache.org/jira/browse/HBASE-19242
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin, mob
>Reporter: Duo Zhang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19242.master.001.patch, 
> HBASE-19242.master.002.patch, HBASE-19242.master.002.patch, 
> HBASE-19242.master.003.patch
>
>
> {code}
>   private CompletableFuture compact(TableName tableName, byte[] 
> columnFamily, boolean major,
>   CompactType compactType) {
> if (CompactType.MOB.equals(compactType)) {
>   // TODO support MOB compact.
>   return failedFuture(new UnsupportedOperationException("MOB compact does 
> not support"));
> }
> {code}
> We need to support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19328) Remove asked if splittable log messages

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19328:

Status: Patch Available  (was: Open)

> Remove asked if splittable log messages
> ---
>
> Key: HBASE-19328
> URL: https://issues.apache.org/jira/browse/HBASE-19328
> Project: HBase
>  Issue Type: Task
>  Components: proc-v2
>Affects Versions: 3.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Attachments: HBASE-19328.master.001.patch
>
>
> I have found this log message in HBase log:
> {code}
> 2017-11-22 11:16:54,133 INFO  
> [RpcServer.priority.FPBQ.Fifo.handler=5,queue=0,port=52586] 
> regionserver.HRegion(1309): ASKED IF SPLITTABLE true 
> 0a66d6e20801eec2c6cd1204fedde592
> java.lang.Throwable: LOGGING: REMOVE
>   at 
> org.apache.hadoop.hbase.regionserver.HRegion.isSplittable(HRegion.java:1310)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1665)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:28159)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> Still we need this?
> It was introduced in commit {{dc1065a85}} by [~stack] and [~mbertozzi].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19328) Remove asked if splittable log messages

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19328:

Attachment: HBASE-19328.master.001.patch

> Remove asked if splittable log messages
> ---
>
> Key: HBASE-19328
> URL: https://issues.apache.org/jira/browse/HBASE-19328
> Project: HBase
>  Issue Type: Task
>  Components: proc-v2
>Affects Versions: 3.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Attachments: HBASE-19328.master.001.patch
>
>
> I have found this log message in HBase log:
> {code}
> 2017-11-22 11:16:54,133 INFO  
> [RpcServer.priority.FPBQ.Fifo.handler=5,queue=0,port=52586] 
> regionserver.HRegion(1309): ASKED IF SPLITTABLE true 
> 0a66d6e20801eec2c6cd1204fedde592
> java.lang.Throwable: LOGGING: REMOVE
>   at 
> org.apache.hadoop.hbase.regionserver.HRegion.isSplittable(HRegion.java:1310)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1665)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:28159)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> Still we need this?
> It was introduced in commit {{dc1065a85}} by [~stack] and [~mbertozzi].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-19328) Remove asked if splittable log messages

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros reassigned HBASE-19328:
---

Assignee: Balazs Meszaros

> Remove asked if splittable log messages
> ---
>
> Key: HBASE-19328
> URL: https://issues.apache.org/jira/browse/HBASE-19328
> Project: HBase
>  Issue Type: Task
>  Components: proc-v2
>Affects Versions: 3.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
>
> I have found this log message in HBase log:
> {code}
> 2017-11-22 11:16:54,133 INFO  
> [RpcServer.priority.FPBQ.Fifo.handler=5,queue=0,port=52586] 
> regionserver.HRegion(1309): ASKED IF SPLITTABLE true 
> 0a66d6e20801eec2c6cd1204fedde592
> java.lang.Throwable: LOGGING: REMOVE
>   at 
> org.apache.hadoop.hbase.regionserver.HRegion.isSplittable(HRegion.java:1310)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1665)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:28159)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> Still we need this?
> It was introduced in commit {{dc1065a85}} by [~stack] and [~mbertozzi].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19242) Add MOB compact support for AsyncAdmin

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19242:

Attachment: HBASE-19242.master.002.patch

> Add MOB compact support for AsyncAdmin
> --
>
> Key: HBASE-19242
> URL: https://issues.apache.org/jira/browse/HBASE-19242
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin, mob
>Reporter: Duo Zhang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19242.master.001.patch, 
> HBASE-19242.master.002.patch
>
>
> {code}
>   private CompletableFuture compact(TableName tableName, byte[] 
> columnFamily, boolean major,
>   CompactType compactType) {
> if (CompactType.MOB.equals(compactType)) {
>   // TODO support MOB compact.
>   return failedFuture(new UnsupportedOperationException("MOB compact does 
> not support"));
> }
> {code}
> We need to support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-19328) Remove asked if splittable log messages

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-19328:
---

 Summary: Remove asked if splittable log messages
 Key: HBASE-19328
 URL: https://issues.apache.org/jira/browse/HBASE-19328
 Project: HBase
  Issue Type: Task
  Components: proc-v2
Affects Versions: 3.0.0
Reporter: Balazs Meszaros
Priority: Minor


I have found this log message in HBase log:
{code}
2017-11-22 11:16:54,133 INFO  
[RpcServer.priority.FPBQ.Fifo.handler=5,queue=0,port=52586] 
regionserver.HRegion(1309): ASKED IF SPLITTABLE true 
0a66d6e20801eec2c6cd1204fedde592
java.lang.Throwable: LOGGING: REMOVE
at 
org.apache.hadoop.hbase.regionserver.HRegion.isSplittable(HRegion.java:1310)
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1665)
at 
org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:28159)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
{code}

Still we need this?

It was introduced in commit {{dc1065a85}} by [~stack] and [~mbertozzi].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264484#comment-16264484
 ] 

Balazs Meszaros commented on HBASE-19093:
-

I have started to modify the test, where I check the methods of 
{{MasterService.Interface}}. It is possible to find theirs corresponding 
methods in {{AccessController}}, but the names of some methods are different 
(e.g. {{moveRegion}} -> {{preMove}}, {{assignRegion}} -> {{preAssign}}, 
{{addColumn}} -> {{modifyTable}}, ...). I can set up some rules for these 
cases, but the test will be a little bit more complicated. This approach seems 
to be better, because for example {{setBalancerRunning}} does not call 
{{MasterObserver}} at all.

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19242) Add MOB compact support for AsyncAdmin

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19242:

Status: Patch Available  (was: In Progress)

> Add MOB compact support for AsyncAdmin
> --
>
> Key: HBASE-19242
> URL: https://issues.apache.org/jira/browse/HBASE-19242
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin, mob
>Reporter: Duo Zhang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19242.master.001.patch
>
>
> {code}
>   private CompletableFuture compact(TableName tableName, byte[] 
> columnFamily, boolean major,
>   CompactType compactType) {
> if (CompactType.MOB.equals(compactType)) {
>   // TODO support MOB compact.
>   return failedFuture(new UnsupportedOperationException("MOB compact does 
> not support"));
> }
> {code}
> We need to support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19242) Add MOB compact support for AsyncAdmin

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19242:

Attachment: HBASE-19242.master.001.patch

> Add MOB compact support for AsyncAdmin
> --
>
> Key: HBASE-19242
> URL: https://issues.apache.org/jira/browse/HBASE-19242
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin, mob
>Reporter: Duo Zhang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19242.master.001.patch
>
>
> {code}
>   private CompletableFuture compact(TableName tableName, byte[] 
> columnFamily, boolean major,
>   CompactType compactType) {
> if (CompactType.MOB.equals(compactType)) {
>   // TODO support MOB compact.
>   return failedFuture(new UnsupportedOperationException("MOB compact does 
> not support"));
> }
> {code}
> We need to support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270454#comment-16270454
 ] 

Balazs Meszaros commented on HBASE-18601:
-

Thanks [~Apache9] for digging into it. We knew that tracing affects the program 
flow but we tried to keep the same behavior as it was before.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Improvement
>  Components: dependencies, tracing
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, 
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch, 
> HBASE-18601.master.016.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270921#comment-16270921
 ] 

Balazs Meszaros commented on HBASE-19093:
-

Yes [~stack]. I am done with {{MasterObserver}}. I am checking other observers 
and filing jiras tomorrow.

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272893#comment-16272893
 ] 

Balazs Meszaros commented on HBASE-19093:
-

I have checked 5 RPC interface and I found some methods which server side 
implementation does not call AccessController at all or AccessController does 
not have an implementation for them. I excluded those methods from the list 
which names start with {{get}}, {{is}} and {{list}}.

{{MasterService.Interface}}
- normalize
- setNormalizerRunning
- runCatalogScan
- enableCatalogJanitor
- runCleanerChore
- setCleanerChoreRunning
- execMasterService
- execProcedure
- execProcedureWithRet

{{AdminService.Interface}}
- replay
- warmupRegion
- updateFavoredNodes
- clearRegionBlockCache
- updateConfiguration

{{RegionServerStatusService.Interface}}
- regionServerStartup
- regionServerReport
- reportRSFatalError
- reportRegionStateTransition
- reportRegionSpaceUse

{{LockService.Interface}}
No missing security checks.

{{ClientService.Interface}}
- execRegionServerService

What do you think, all of these method should have AccessController hooks?

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268282#comment-16268282
 ] 

Balazs Meszaros commented on HBASE-18601:
-

[~chia7712] {{TraceTree}} class comes from HTrace 3.2.0, but it has been 
removed in 4.2.0. I noticed the comparator duplication, but I tried to minimize 
the number of modifications at all.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Improvement
>  Components: dependencies, tracing
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, 
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch, 
> HBASE-18601.master.016.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19390) Revert to older version of Jetty 9.3

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274232#comment-16274232
 ] 

Balazs Meszaros commented on HBASE-19390:
-

+1

> Revert to older version of Jetty 9.3 
> -
>
> Key: HBASE-19390
> URL: https://issues.apache.org/jira/browse/HBASE-19390
> Project: HBase
>  Issue Type: Bug
>Reporter: Esteban Gutierrez
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19390.patch, HBASE-19390.v2.patch
>
>
> As discussed in HBASE-19256 we will have to temporarily revert to Jetty 9.3 
> due existing issues with 9.4 and Hadoop3. Once HBASE-19256 is resolved we can 
> revert to 9.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274171#comment-16274171
 ] 

Balazs Meszaros commented on HBASE-19093:
-

Here is the full report:

{{MasterProtos$MasterService$Interface}}
- getLocks -> ignored
- getSchemaAlterStatus -> ignored
- getTableDescriptors -> ignored
- getTableNames -> ignored
- getClusterStatus -> ignored
- isMasterRunning -> ignored
- isMasterInMaintenanceMode -> ignored
- isBalancerEnabled -> ignored
- isSplitOrMergeEnabled -> ignored
- isNormalizerEnabled -> ignored
- isCatalogJanitorEnabled -> ignored
- isCleanerChoreEnabled -> ignored
- getCompletedSnapshots -> ignored
- isSnapshotDone -> ignored
- isProcedureDone -> ignored
- getNamespaceDescriptor -> ignored
- listNamespaceDescriptors -> ignored
- listTableDescriptorsByNamespace -> ignored
- listTableNamesByNamespace -> ignored
- getTableState -> ignored
- getLastMajorCompactionTimestamp -> ignored
- getLastMajorCompactionTimestampForRegion -> ignored
- getProcedureResult -> ignored
- getSecurityCapabilities -> ignored
- getProcedures -> ignored
- getReplicationPeerConfig -> ignored
- listReplicationPeers -> ignored
- listDecommissionedRegionServers -> ignored
- getSpaceQuotaRegionSizes -> ignored
- getQuotaStates -> ignored

- shutdown -> implemented by preShutdown
- modifyTable -> implemented by preModifyTable
- addColumn -> implemented by preModifyTable
- deleteColumn -> implemented by preModifyTable
- modifyColumn -> implemented by preModifyTable
- moveRegion -> implemented by preMove
- mergeTableRegions -> implemented by preMergeRegions
- assignRegion -> implemented by preAssign
- unassignRegion -> implemented by preUnassign
- offlineRegion -> implemented by preRegionOffline
{color:#d04437}# we have table and namespace quota, too{color}
- setQuota -> implemented by preSetUserQuota
- setBalancerRunning -> implemented by preBalanceSwitch
- balance -> implemented by preBalance
- splitRegion -> implemented by preSplitRegion
- deleteTable -> implemented by preDeleteTable
- truncateTable -> implemented by preTruncateTable
- enableTable -> implemented by preEnableTable
- disableTable -> implemented by preDisableTable
- createTable -> implemented by preCreateTable
- stopMaster -> implemented by preStopMaster
- setSplitOrMergeEnabled -> implemented by preSetSplitOrMergeEnabled
- deleteSnapshot -> implemented by preDeleteSnapshot
- restoreSnapshot -> implemented by preRestoreSnapshot
- modifyNamespace -> implemented by preModifyNamespace
- createNamespace -> implemented by preCreateNamespace
- deleteNamespace -> implemented by preDeleteNamespace
- abortProcedure -> implemented by preAbortProcedure
- addReplicationPeer -> implemented by preAddReplicationPeer
- removeReplicationPeer -> implemented by preRemoveReplicationPeer
- enableReplicationPeer -> implemented by preEnableReplicationPeer
- disableReplicationPeer -> implemented by preDisableReplicationPeer
- updateReplicationPeerConfig -> implemented by preUpdateReplicationPeerConfig
- decommissionRegionServers -> implemented by preDecommissionRegionServers
- recommissionRegionServer -> implemented by preRecommissionRegionServer
- clearDeadServers -> implemented by preClearDeadServers
- snapshot -> implemented by preSnapshot

- normalize -> missing
- setNormalizerRunning -> missing
- runCatalogScan -> missing
- enableCatalogJanitor -> missing
- runCleanerChore -> missing
- setCleanerChoreRunning -> missing
- execMasterService -> missing
- execProcedure -> missing
- execProcedureWithRet -> missing

{{ClientProtos$ClientService$Interface}}
- get -> implemented by preExists
- multi -> implemented by prePut
{color:#d04437}# I did not check every case, but in a mutate we call append, 
put, delete, etc...{color}
- mutate -> implemented by preAppend
- execService -> implemented by preEndpointInvocation
- bulkLoadHFile -> implemented by preBulkLoadHFile
- prepareBulkLoad -> implemented by prePrepareBulkLoad
- cleanupBulkLoad -> implemented by preCleanupBulkLoad
- scan -> implemented by preScannerOpen

- execRegionServerService -> missing

{{LockServiceProtos$LockService$Interface}}
- requestLock -> implemented by preRequestLock
- lockHeartbeat -> implemented by preLockHeartbeat

{{RegionServerStatusProtos$RegionServerStatusService$Interface}}
- getLastFlushedSequenceId -> ignored

- regionServerStartup -> missing
- regionServerReport -> missing
- reportRSFatalError -> missing
- reportRegionStateTransition -> missing
- reportRegionSpaceUse -> missing

{{AdminProtos$AdminService$Interface}}
- getRegionInfo -> ignored
- getRegionLoad -> ignored
- getStoreFile -> ignored
- getOnlineRegion -> ignored
- getServerInfo -> ignored
- getSpaceQuotaSnapshots -> ignored

- closeRegion -> implemented by preClose
- flushRegion -> implemented by preFlush
- compactRegion -> implemented by preCompact
- openRegion -> implemented by preOpen
- stopServer -> implemented by stop
- 

[jira] [Created] (HBASE-19403) Add missing security hooks for AdminService RPCs

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-19403:
---

 Summary: Add missing security hooks for AdminService RPCs
 Key: HBASE-19403
 URL: https://issues.apache.org/jira/browse/HBASE-19403
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 2.0.0-beta-1
Reporter: Balazs Meszaros


The following RPC methods do not call the observers, therefore they are not 
guarded by AccessController:
- updateConfiguration
- replay
- warmupRegion
- updateFavoredNodes
- clearRegionBlockCache



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274218#comment-16274218
 ] 

Balazs Meszaros commented on HBASE-19093:
-

I filed the jiras.

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-19400) Add missing security hooks for MasterService RPCs

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-19400:
---

 Summary: Add missing security hooks for MasterService RPCs
 Key: HBASE-19400
 URL: https://issues.apache.org/jira/browse/HBASE-19400
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 2.0.0-beta-1
Reporter: Balazs Meszaros


The following RPC methods do not call the observers, therefore they are not 
guarded by AccessController:
- normalize
- setNormalizerRunning
- runCatalogScan
- enableCatalogJanitor
- runCleanerChore
- setCleanerChoreRunning
- execMasterService
- execProcedure
- execProcedureWithRet



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-19401) Add missing security hooks for ClientService RPCs

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-19401:
---

 Summary: Add missing security hooks for ClientService RPCs
 Key: HBASE-19401
 URL: https://issues.apache.org/jira/browse/HBASE-19401
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 2.0.0-beta-1
Reporter: Balazs Meszaros


The following RPC method does not call the observers, therefore it is not 
guarded by AccessController:
- execRegionServerService



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-19402) Add missing security hooks for RegionServerStatusService RPCs

[Balazs Meszaros (JIRA)]

Balazs Meszaros created HBASE-19402:
---

 Summary: Add missing security hooks for RegionServerStatusService 
RPCs
 Key: HBASE-19402
 URL: https://issues.apache.org/jira/browse/HBASE-19402
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 2.0.0-beta-1
Reporter: Balazs Meszaros


The following RPC methods do not call the observers, therefore they are not 
guarded by AccessController:
- regionServerStartup
- regionServerReport
- reportRSFatalError
- reportRegionStateTransition
- reportRegionSpaceUse



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19400) Add missing security hooks for MasterService RPCs

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19400:

Attachment: HBASE-19400.master.001.patch

> Add missing security hooks for MasterService RPCs
> -
>
> Key: HBASE-19400
> URL: https://issues.apache.org/jira/browse/HBASE-19400
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-beta-1
>Reporter: Balazs Meszaros
> Attachments: HBASE-19400.master.001.patch
>
>
> The following RPC methods do not call the observers, therefore they are not 
> guarded by AccessController:
> - normalize
> - setNormalizerRunning
> - runCatalogScan
> - enableCatalogJanitor
> - runCleanerChore
> - setCleanerChoreRunning
> - execMasterService
> - execProcedure
> - execProcedureWithRet



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-10092:

Attachment: HBASE-10092.master.002.patch

> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Alex Newman
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-10092:

Attachment: HBASE-10092.master.001.patch

I have replaced commons loggers with slf4j loggers:

* replaced commons-logging to slf4j everywhere except hbase-backup and 
hbase-http
* log.XXX(Throwable) calls were replaced with log.XXX(t.toString(), t)
* log.XXX(Object) calls were replaced with log.XXX(Objects.toString(obj))
* programmatic log4j configuration was removed


> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Alex Newman
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-10092:

Attachment: HBASE-10092.master.003.patch

> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, 
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296926#comment-16296926
 ] 

Balazs Meszaros commented on HBASE-10092:
-

Thanks for your comments.

1. Currently I have commons-logging with slf4j, without exceptions (including 
hbase-backup and hbase-http).
2. I have not updated log4j to log4j2, so the property files are still 
compatible. Log4j is compatible with slf4j through the slf4j-log4j12 dependency 
which was already on our classpath. I think we should do the update in a 
different patch, because this one conflicts with everything.
3. Unfortunately there are some dependencies on log4j apis, we set the log 
levels programmatically (e.g. web ui). They are still there.

[~appy] your list is great:
1. I did some verification, setting log levels still works through web ui.
2. I have added fatal markers.
3. Property files still works, because log4j has not been updated yet.
4. Adding missing guards would be another huge commit :(
5. I updated them finally.
6. I added some extra information to the commit message.

> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, 
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-10092:

Attachment: HBASE-10092.master.003.patch

> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, 
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-10092:

Attachment: (was: HBASE-10092.master.003.patch)

> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, 
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-10092) Move up on to log4j2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297151#comment-16297151
 ] 

Balazs Meszaros commented on HBASE-10092:
-

bq. What does this mean Balazs Meszaros?

Oops, sorry, so I have *replaced* commons-logging with slf4j.

bq. We are not going to move to log4j2. You suggesting we are sir?

The description of this issue suggests that.

bq. Does 'FATAL' show in log when a FATAL marker? Or it depends on what backend 
is?

I think it needs to be configured.

bq. Why would we add guards. We want to go away from guards?

Appy mentioned it, guards are useful if it is expensive to build the log 
message. Parameterized loggers are also useful, because they only build the log 
message if it is going to be logged.

> Move up on to log4j2
> 
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, 
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-13696) Prune retired hbase versions from ref guide prereq support tables

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-13696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249520#comment-16249520
 ] 

Balazs Meszaros commented on HBASE-13696:
-

[~chia7712] could you please rebase it? There were some conflicts after 
applying the patch on the latest master. Thanks!

> Prune retired hbase versions from ref guide prereq support tables
> -
>
> Key: HBASE-13696
> URL: https://issues.apache.org/jira/browse/HBASE-13696
> Project: HBase
>  Issue Type: Task
>Reporter: Sean Busbey
>Assignee: Chia-Ping Tsai
>  Labels: beginner
> Attachments: HBASE-13696.1.patch, HBASE-13696.2.patch, 
> HBASE-13696.v3.patch
>
>
> the java table still contains HBase 0.96, and the Hadoop table still has 
> HBase 0.92 and 0.96. We should remove these. Their details can still be found 
> in their last release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249721#comment-16249721
 ] 

Balazs Meszaros edited comment on HBASE-18601 at 11/13/17 3:33 PM:
---

TraceTree is located in the hbase-server project. I had to modify it slightly 
but it passed on my machine. Under HTrace-4.2, the id of the root span is not 
0, therefore I changed the test too.


was (Author: balazs.meszaros):
TraceTree is located in the hbase-server project. I had to modify it slightly 
but it passed on my machine. Under HTrace-4.2, the id of the root span is not 
0, therefore I had to change the test slightly.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, 
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19075) Task tabs on master UI cause page scroll

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249575#comment-16249575
 ] 

Balazs Meszaros commented on HBASE-19075:
-

When I switch the tabs, it does not scrolls, so it works fine. But if I click 
to 'View as JSON' then it returns the JSON for the general filter, it ignores 
the currently selected tab (on master it returns the JSONs for the selected 
tab).

> Task tabs on master UI cause page scroll
> 
>
> Key: HBASE-19075
> URL: https://issues.apache.org/jira/browse/HBASE-19075
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-19075.master.001.patch
>
>
> On the master info page, the clicking the tabs under Tasks causes the page to 
> scroll back to the top of the page.
> {noformat}
> Tasks
> Show All Monitored Tasks Show non-RPC Tasks Show All RPC Handler Tasks Show 
> Active RPC Calls Show Client Operations View as JSON
> {noformat}
> ^^ Any of those
> The other tab-like links on the page keep the scroll in the same location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249721#comment-16249721
 ] 

Balazs Meszaros commented on HBASE-18601:
-

TraceTree is located in the hbase-server project. I had to modify it slightly 
but it passed on my machine. Under HTrace-4.2, the id of the root span is not 
0, therefore I had to change the test slightly.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, 
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros reassigned HBASE-19093:
---

Assignee: Balazs Meszaros

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: HBASE-19093.master.002.patch

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Status: Patch Available  (was: Open)

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.001.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259295#comment-16259295
 ] 

Balazs Meszaros commented on HBASE-19093:
-

I created a test ({{TestAccessControllerMethods}}) which checks that every 
methods from the implemented interfaces of {{AccessController}} are implemented 
by {{AccessController}}. Considerations:
- Most events have pre and post callbacks. It is enough to implement only one 
of them. (E.g. it is not an error, if preCreateTable is implemented, but 
postCreateTable is not.)
- Methods ending with "Action" are ignored, because they are asynchronous 
events and they have synchronous equivalent.

Currently the test does not check the implemented methods of {{RegionObserver}} 
interface, because it contains lots of methods which are not important for 
security checks. What do you think about it?

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.001.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: HBASE-19093.001.patch

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.001.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: (was: HBASE-19093.001.patch)

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: HBASE-19093.master.001.patch

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: HBASE-19093.master.001.patch

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: (was: HBASE-19093.master.001.patch)

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-19093:

Attachment: RegionObserver.txt

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260898#comment-16260898
 ] 

Balazs Meszaros commented on HBASE-19093:
-

[~chia7712] The missing methods can be found in the attached 
{{RegionObserver.txt}} file. In my opinion these are internal events, so they 
cannot be triggered through the API.

The {{SecurableHook}} annotation is a good idea, but since we have {{pre}} and 
{{post}} methods, we should not expect that both of them are implemented.

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-19242) Add MOB compact support for AsyncAdmin

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros reassigned HBASE-19242:
---

Assignee: Balazs Meszaros

> Add MOB compact support for AsyncAdmin
> --
>
> Key: HBASE-19242
> URL: https://issues.apache.org/jira/browse/HBASE-19242
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin, mob
>Reporter: Duo Zhang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
>
> {code}
>   private CompletableFuture compact(TableName tableName, byte[] 
> columnFamily, boolean major,
>   CompactType compactType) {
> if (CompactType.MOB.equals(compactType)) {
>   // TODO support MOB compact.
>   return failedFuture(new UnsupportedOperationException("MOB compact does 
> not support"));
> }
> {code}
> We need to support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (HBASE-19242) Add MOB compact support for AsyncAdmin

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-19242 started by Balazs Meszaros.
---
> Add MOB compact support for AsyncAdmin
> --
>
> Key: HBASE-19242
> URL: https://issues.apache.org/jira/browse/HBASE-19242
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin, mob
>Reporter: Duo Zhang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
>
> {code}
>   private CompletableFuture compact(TableName tableName, byte[] 
> columnFamily, boolean major,
>   CompactType compactType) {
> if (CompactType.MOB.equals(compactType)) {
>   // TODO support MOB compact.
>   return failedFuture(new UnsupportedOperationException("MOB compact does 
> not support"));
> }
> {code}
> We need to support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18601:

Attachment: HBASE-18601.master.014.patch

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245574#comment-16245574
 ] 

Balazs Meszaros commented on HBASE-18601:
-

Fixed some checkstyle errors.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246236#comment-16246236
 ] 

Balazs Meszaros commented on HBASE-18601:
-

JVM crashed during the unit testing.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18601:

Attachment: HBASE-18601.master.013.patch

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-18601:

Status: Patch Available  (was: Open)

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18601) Update Htrace to 4.2

[Balazs Meszaros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros reassigned HBASE-18601:
---

Assignee: Balazs Meszaros  (was: Tamas Penzes)

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, 
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, 
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, 
> HBASE-18601.master.013.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-19093) Check Admin/Table to ensure all operations go via AccessControl

[Balazs Meszaros (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274218#comment-16274218
 ] 

Balazs Meszaros edited comment on HBASE-19093 at 12/12/17 9:00 AM:
---

I filed the jiras:
* HBASE-19400
* HBASE-19401
* HBASE-19402
* HBASE-19403


was (Author: balazs.meszaros):
I filed the jiras.

> Check Admin/Table to ensure all operations go via AccessControl
> ---
>
> Key: HBASE-19093
> URL: https://issues.apache.org/jira/browse/HBASE-19093
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)