[jira] [Commented] (HIVE-23300) alter_partitions codahale mertric does not close properly
[ https://issues.apache.org/jira/browse/HIVE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092513#comment-17092513 ] Hive QA commented on HIVE-23300: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 18s{color} | {color:blue} standalone-metastore/metastore-server in master has 189 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 24s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21945/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21945/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > alter_partitions codahale mertric does not close properly > - > > Key: HIVE-23300 > URL: https://issues.apache.org/jira/browse/HIVE-23300 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: All Versions >Reporter: Akash Katipally >Priority: Major > Attachments: HIVE-23300.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hello, > > We were noticing in a rise in the number of alter partition calls in our > metric dashboard. Upon further investigation, it seems like we do not close > the call properly. Here is the error. > > {code:java} > org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics Scope named > api_alter_partitions is not closed, cannot be opened. > {code} > The piece of line that looks incorrect is here: > [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L5542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22737) Concurrency: FunctionRegistry::getFunctionInfo is static object locked
[ https://issues.apache.org/jira/browse/HIVE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092505#comment-17092505 ] Rajesh Balamohan commented on HIVE-22737: - Thanks for the patch [~ashutoshc] . Would it invoke "getFunctionInfo::addToCurrentFunctions" for all invocations with the patch? > Concurrency: FunctionRegistry::getFunctionInfo is static object locked > -- > > Key: HIVE-22737 > URL: https://issues.apache.org/jira/browse/HIVE-22737 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer, UDF >Reporter: Gopal Vijayaraghavan >Assignee: Ashutosh Chauhan >Priority: Major > Attachments: FunctionRegistry-lock.png, HIVE-22737.patch > > > The lock is inside a HS2-wide static object > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java#L191 > {code} > // registry for system functions > private static final Registry system = new Registry(true); > {code} > And this is the lock itself > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java#L332 > {code} > public FunctionInfo getFunctionInfo(String functionName) throws > SemanticException { > lock.lock(); > {code} > !FunctionRegistry-lock.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly
[ https://issues.apache.org/jira/browse/HIVE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092491#comment-17092491 ] Hive QA commented on HIVE-23275: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001172/HIVE-23275.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17143 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21944/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21944/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21944/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13001172 - PreCommit-HIVE-Build > Represent UNBOUNDED in window functions in CBO correctly > > > Key: HIVE-23275 > URL: https://issues.apache.org/jira/browse/HIVE-23275 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23275.01.patch, HIVE-23275.01.patch, > HIVE-23275.01.patch, HIVE-23275.patch, HIVE-23275.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we use a bounded representation with bound set to > Integer.MAX_VALUE, which works correctly since that is the Hive > implementation. However, Calcite has a specific boundary class > {{RexWindowBoundUnbounded}} that we should be using instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly
[ https://issues.apache.org/jira/browse/HIVE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092484#comment-17092484 ] Hive QA commented on HIVE-23275: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 2s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21944/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21944/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Represent UNBOUNDED in window functions in CBO correctly > > > Key: HIVE-23275 > URL: https://issues.apache.org/jira/browse/HIVE-23275 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23275.01.patch, HIVE-23275.01.patch, > HIVE-23275.01.patch, HIVE-23275.patch, HIVE-23275.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we use a bounded representation with bound set to > Integer.MAX_VALUE, which works correctly since that is the Hive > implementation. However, Calcite has a specific boundary class > {{RexWindowBoundUnbounded}} that we should be using instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23244) Extract Create View analyzer from SemanticAnalyzer
[ https://issues.apache.org/jira/browse/HIVE-23244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092472#comment-17092472 ] Hive QA commented on HIVE-23244: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001152/HIVE-23244.03.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17143 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schq_ingest] (batchId=102) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitions (batchId=219) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitionsUnionAll (batchId=219) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighShuffleBytes (batchId=219) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21943/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21943/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21943/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001152 - PreCommit-HIVE-Build > Extract Create View analyzer from SemanticAnalyzer > -- > > Key: HIVE-23244 > URL: https://issues.apache.org/jira/browse/HIVE-23244 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23244.01.patch, HIVE-23244.02.patch, > HIVE-23244.03.patch > > > Create View commands are not queries, but commands which have queries as a > part of them. Therefore a separate CreateViewAnalyzer is needed which uses > SemanticAnalyer to analyze it's query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23244) Extract Create View analyzer from SemanticAnalyzer
[ https://issues.apache.org/jira/browse/HIVE-23244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092469#comment-17092469 ] Hive QA commented on HIVE-23244: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 15s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 36s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 57s{color} | {color:blue} parser in master has 3 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 2s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 48s{color} | {color:red} ql: The patch generated 2 new + 590 unchanged - 8 fixed = 592 total (was 598) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 8s{color} | {color:red} ql generated 1 new + 1529 unchanged - 1 fixed = 1530 total (was 1530) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 4s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | The field org.apache.hadoop.hive.ql.plan.LoadFileDesc.createViewDesc is transient but isn't set by deserialization In LoadFileDesc.java:but isn't set by deserialization In LoadFileDesc.java | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21943/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21943/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-21943/yetus/new-findbugs-ql.html | | modules | C: common parser ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21943/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Extract Create View analyzer from SemanticAnalyzer > -- > > Key: HIVE-23244 > URL: https://issues.apache.org/jira/browse/HIVE-23244 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23244.01.patch, HIVE-23244.02.patch, > HIVE-23244.03.patch > > > Create View commands are not queries,
[jira] [Commented] (HIVE-23230) "get_splits" udf ignores limit constraint while creating splits
[ https://issues.apache.org/jira/browse/HIVE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092457#comment-17092457 ] Hive QA commented on HIVE-23230: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001129/HIVE-23230.4.patch {color:green}SUCCESS:{color} +1 due to 9 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17143 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21942/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21942/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21942/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13001129 - PreCommit-HIVE-Build > "get_splits" udf ignores limit constraint while creating splits > --- > > Key: HIVE-23230 > URL: https://issues.apache.org/jira/browse/HIVE-23230 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 3.1.0 >Reporter: Adesh Kumar Rao >Assignee: Adesh Kumar Rao >Priority: Major > Attachments: HIVE-23230.1.patch, HIVE-23230.2.patch, > HIVE-23230.3.patch, HIVE-23230.4.patch, HIVE-23230.patch > > > Issue: Running the query {noformat}select * from limit n{noformat} > from spark via hive warehouse connector may return more rows than "n". > This happens because "get_splits" udf creates splits ignoring the limit > constraint. These splits when submitted to multiple llap daemons will return > "n" rows each. > How to reproduce: Needs spark-shell, hive-warehouse-connector and hive on > llap with more that 1 llap daemons running. > run below commands via beeline to create and populate the table > > {noformat} > create table test (id int); > insert into table test values (1); > insert into table test values (2); > insert into table test values (3); > insert into table test values (4); > insert into table test values (5); > insert into table test values (6); > insert into table test values (7); > delete from test where id = 7;{noformat} > now running below query via spark-shell > {noformat} > import com.hortonworks.hwc.HiveWarehouseSession > val hive = HiveWarehouseSession.session(spark).build() > hive.executeQuery("select * from test limit 1").show() > {noformat} > will return more than 1 rows. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23230) "get_splits" udf ignores limit constraint while creating splits
[ https://issues.apache.org/jira/browse/HIVE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092455#comment-17092455 ] Hive QA commented on HIVE-23230: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 14s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 0s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 45s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 50s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21942/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21942/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > "get_splits" udf ignores limit constraint while creating splits > --- > > Key: HIVE-23230 > URL: https://issues.apache.org/jira/browse/HIVE-23230 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 3.1.0 >Reporter: Adesh Kumar Rao >Assignee: Adesh Kumar Rao >Priority: Major > Attachments: HIVE-23230.1.patch, HIVE-23230.2.patch, > HIVE-23230.3.patch, HIVE-23230.4.patch, HIVE-23230.patch > > > Issue: Running the query {noformat}select * from limit n{noformat} > from spark via hive warehouse connector may return more rows than "n". > This happens because "get_splits" udf creates splits ignoring the limit > constraint. These splits when submitted to multiple llap daemons will return > "n" rows each. > How to reproduce: Needs spark-shell, hive-warehouse-connector and hive on > llap with more that 1 llap daemons running. > run below commands via beeline to create and populate the table > > {noformat} > create table test (id int); > insert into table test values (1); > insert into table test values (2); > insert into table test
[jira] [Comment Edited] (HIVE-23240) loadDynamicPartition complains about static partitions even when they are provided in the description
[ https://issues.apache.org/jira/browse/HIVE-23240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092453#comment-17092453 ] Ashutosh Chauhan edited comment on HIVE-23240 at 4/26/20, 2:35 AM: --- [~rezasafi] will following work: {code} - if (!Warehouse.makeSpecFromName(fullPartSpec, partPath, new HashSet<>(partSpec.keySet( { + String staticPart = Warehouse.makeDynamicPartName(partSpec); + Path computedPath = new Path(new Path(partPath.getParent(),staticPart),partPath.getName()); + if (!Warehouse.makeSpecFromName(fullPartSpec, computedPath, new HashSet<>(partSpec.keySet( { {code} I think its equivalent to your original patch but is more readable and uses Path objects to massage strings instead operating on them directly. What do you think? was (Author: ashutoshc): [~rezasafi] will following work: {code} - if (!Warehouse.makeSpecFromName(fullPartSpec, partPath, new HashSet<>(partSpec.keySet( { + String staticPart = Warehouse.makeDynamicPartName(partSpec); + Path computedPath = new Path(new Path(partPath.getParent(),staticPart),partPath.getName()); + if (!Warehouse.makeSpecFromName(fullPartSpec, computePath, new HashSet<>(partSpec.keySet( { {code} I think its equivalent to your original patch but is more readable and uses Path objects to massage strings instead operating on them directly. What do you think? > loadDynamicPartition complains about static partitions even when they are > provided in the description > -- > > Key: HIVE-23240 > URL: https://issues.apache.org/jira/browse/HIVE-23240 > Project: Hive > Issue Type: Bug >Reporter: Reza Safi >Priority: Minor > Attachments: HIVE-23240.2.patch, HIVE-23240.patch > > > Hive is computing valid dynamic partitions here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2853 > However it later uses the specification provided by client here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2879 > (partSpec is exactly what client has provided and partSpec.keySet() contains > both static and dynamic partitions key) > As a result the makeSpecFromName here will expect both static and dynamic > partitions in requiredKeys: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java#L580 > However since the curPath that is passed to the above method is just like > "somePath/dynamicPart=value" which miss the static partitions and a result > the method will ignore static partition keys then complains in log a warning > that the static partition keys are missing. Returning false to Hive.java, a > log warning that "dynamicPart=value" is an invalid partition will be issued, > despite the fact that the dynamic partition has been validated before: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2880 > > This will cause a silent data corruption in some clients. As an example spark > will suffer from this when working with hive metastore in master branch. > It seems that if the goal was just to warn the client, there is no need to > ignore the valid dynamic partition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23240) loadDynamicPartition complains about static partitions even when they are provided in the description
[ https://issues.apache.org/jira/browse/HIVE-23240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092453#comment-17092453 ] Ashutosh Chauhan commented on HIVE-23240: - [~rezasafi] will following work: {code} - if (!Warehouse.makeSpecFromName(fullPartSpec, partPath, new HashSet<>(partSpec.keySet( { + String staticPart = Warehouse.makeDynamicPartName(partSpec); + Path computedPath = new Path(new Path(partPath.getParent(),staticPart),partPath.getName()); + if (!Warehouse.makeSpecFromName(fullPartSpec, computePath, new HashSet<>(partSpec.keySet( { {code} I think its equivalent to your original patch but is more readable and uses Path objects to massage strings instead operating on them directly. What do you think? > loadDynamicPartition complains about static partitions even when they are > provided in the description > -- > > Key: HIVE-23240 > URL: https://issues.apache.org/jira/browse/HIVE-23240 > Project: Hive > Issue Type: Bug >Reporter: Reza Safi >Priority: Minor > Attachments: HIVE-23240.2.patch, HIVE-23240.patch > > > Hive is computing valid dynamic partitions here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2853 > However it later uses the specification provided by client here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2879 > (partSpec is exactly what client has provided and partSpec.keySet() contains > both static and dynamic partitions key) > As a result the makeSpecFromName here will expect both static and dynamic > partitions in requiredKeys: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java#L580 > However since the curPath that is passed to the above method is just like > "somePath/dynamicPart=value" which miss the static partitions and a result > the method will ignore static partition keys then complains in log a warning > that the static partition keys are missing. Returning false to Hive.java, a > log warning that "dynamicPart=value" is an invalid partition will be issued, > despite the fact that the dynamic partition has been validated before: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2880 > > This will cause a silent data corruption in some clients. As an example spark > will suffer from this when working with hive metastore in master branch. > It seems that if the goal was just to warn the client, there is no need to > ignore the valid dynamic partition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22737) Concurrency: FunctionRegistry::getFunctionInfo is static object locked
[ https://issues.apache.org/jira/browse/HIVE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-22737: Assignee: Ashutosh Chauhan Status: Patch Available (was: Open) > Concurrency: FunctionRegistry::getFunctionInfo is static object locked > -- > > Key: HIVE-22737 > URL: https://issues.apache.org/jira/browse/HIVE-22737 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer, UDF >Reporter: Gopal Vijayaraghavan >Assignee: Ashutosh Chauhan >Priority: Major > Attachments: FunctionRegistry-lock.png, HIVE-22737.patch > > > The lock is inside a HS2-wide static object > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java#L191 > {code} > // registry for system functions > private static final Registry system = new Registry(true); > {code} > And this is the lock itself > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java#L332 > {code} > public FunctionInfo getFunctionInfo(String functionName) throws > SemanticException { > lock.lock(); > {code} > !FunctionRegistry-lock.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22737) Concurrency: FunctionRegistry::getFunctionInfo is static object locked
[ https://issues.apache.org/jira/browse/HIVE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-22737: Attachment: HIVE-22737.patch > Concurrency: FunctionRegistry::getFunctionInfo is static object locked > -- > > Key: HIVE-22737 > URL: https://issues.apache.org/jira/browse/HIVE-22737 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer, UDF >Reporter: Gopal Vijayaraghavan >Priority: Major > Attachments: FunctionRegistry-lock.png, HIVE-22737.patch > > > The lock is inside a HS2-wide static object > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java#L191 > {code} > // registry for system functions > private static final Registry system = new Registry(true); > {code} > And this is the lock itself > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java#L332 > {code} > public FunctionInfo getFunctionInfo(String functionName) throws > SemanticException { > lock.lock(); > {code} > !FunctionRegistry-lock.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23240) loadDynamicPartition complains about static partitions even when they are provided in the description
[ https://issues.apache.org/jira/browse/HIVE-23240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092447#comment-17092447 ] Hive QA commented on HIVE-23240: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001125/HIVE-23240.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17143 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21941/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21941/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21941/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13001125 - PreCommit-HIVE-Build > loadDynamicPartition complains about static partitions even when they are > provided in the description > -- > > Key: HIVE-23240 > URL: https://issues.apache.org/jira/browse/HIVE-23240 > Project: Hive > Issue Type: Bug >Reporter: Reza Safi >Priority: Minor > Attachments: HIVE-23240.2.patch, HIVE-23240.patch > > > Hive is computing valid dynamic partitions here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2853 > However it later uses the specification provided by client here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2879 > (partSpec is exactly what client has provided and partSpec.keySet() contains > both static and dynamic partitions key) > As a result the makeSpecFromName here will expect both static and dynamic > partitions in requiredKeys: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java#L580 > However since the curPath that is passed to the above method is just like > "somePath/dynamicPart=value" which miss the static partitions and a result > the method will ignore static partition keys then complains in log a warning > that the static partition keys are missing. Returning false to Hive.java, a > log warning that "dynamicPart=value" is an invalid partition will be issued, > despite the fact that the dynamic partition has been validated before: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2880 > > This will cause a silent data corruption in some clients. As an example spark > will suffer from this when working with hive metastore in master branch. > It seems that if the goal was just to warn the client, there is no need to > ignore the valid dynamic partition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23240) loadDynamicPartition complains about static partitions even when they are provided in the description
[ https://issues.apache.org/jira/browse/HIVE-23240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092440#comment-17092440 ] Hive QA commented on HIVE-23240: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 2s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 2s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21941/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21941/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > loadDynamicPartition complains about static partitions even when they are > provided in the description > -- > > Key: HIVE-23240 > URL: https://issues.apache.org/jira/browse/HIVE-23240 > Project: Hive > Issue Type: Bug >Reporter: Reza Safi >Priority: Minor > Attachments: HIVE-23240.2.patch, HIVE-23240.patch > > > Hive is computing valid dynamic partitions here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2853 > However it later uses the specification provided by client here: > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2879 > (partSpec is exactly what client has provided and partSpec.keySet() contains > both static and dynamic partitions key) > As a result the makeSpecFromName here will expect both static and dynamic > partitions in requiredKeys: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java#L580 > However since the curPath that is passed to the above method is just like > "somePath/dynamicPart=value" which miss the static partitions and a result > the method will ignore static partition keys then complains in log a warning > that the static partition keys are missing. Returning false to Hive.java, a > log warning that "dynamicPart=value" is an invalid partition will be issued, > despite the fact that the dynamic partition has been validated before: >
[jira] [Commented] (HIVE-23216) Add new api as replacement of get_partitions_by_expr to return PartitionSpec instead of Partitions
[ https://issues.apache.org/jira/browse/HIVE-23216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092433#comment-17092433 ] Hive QA commented on HIVE-23216: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001123/HIVE-23216.7.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17163 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[partition_wise_fileformat15] (batchId=80) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21940/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21940/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21940/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001123 - PreCommit-HIVE-Build > Add new api as replacement of get_partitions_by_expr to return PartitionSpec > instead of Partitions > -- > > Key: HIVE-23216 > URL: https://issues.apache.org/jira/browse/HIVE-23216 > Project: Hive > Issue Type: Improvement > Components: Metastore >Affects Versions: 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-23216.1.patch, HIVE-23216.2.patch, > HIVE-23216.3.patch, HIVE-23216.4.patch, HIVE-23216.5.patch, > HIVE-23216.6.patch, HIVE-23216.7.patch > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23216) Add new api as replacement of get_partitions_by_expr to return PartitionSpec instead of Partitions
[ https://issues.apache.org/jira/browse/HIVE-23216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092431#comment-17092431 ] Hive QA commented on HIVE-23216: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 27s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 46s{color} | {color:blue} standalone-metastore/metastore-common in master has 35 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 20s{color} | {color:blue} standalone-metastore/metastore-server in master has 189 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 3s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 21s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s{color} | {color:red} standalone-metastore/metastore-common: The patch generated 3 new + 499 unchanged - 0 fixed = 502 total (was 499) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 26s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 663 unchanged - 0 fixed = 664 total (was 663) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 8s{color} | {color:red} standalone-metastore_metastore-common generated 4 new + 61 unchanged - 0 fixed = 65 total (was 61) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 44m 13s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21940/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21940/yetus/diff-checkstyle-standalone-metastore_metastore-common.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21940/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-21940/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-common.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21940/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Add new api as replacement of get_partitions_by_expr to return PartitionSpec > instead of Partitions >
[jira] [Commented] (HIVE-23040) Checkpointing for repl dump incremental phase
[ https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092423#comment-17092423 ] Hive QA commented on HIVE-23040: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001122/HIVE-23040.07.patch {color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17160 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21939/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21939/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21939/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13001122 - PreCommit-HIVE-Build > Checkpointing for repl dump incremental phase > - > > Key: HIVE-23040 > URL: https://issues.apache.org/jira/browse/HIVE-23040 > Project: Hive > Issue Type: Improvement >Reporter: Aasha Medhi >Assignee: PRAVIN KUMAR SINHA >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, > HIVE-23040.03.patch, HIVE-23040.04.patch, HIVE-23040.05.patch, > HIVE-23040.06.patch, HIVE-23040.06.patch, HIVE-23040.07.patch > > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23040) Checkpointing for repl dump incremental phase
[ https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092416#comment-17092416 ] Hive QA commented on HIVE-23040: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 30s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 7s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 46s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 14s{color} | {color:green} ql generated 0 new + 1528 unchanged - 2 fixed = 1528 total (was 1530) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 53s{color} | {color:green} hive-unit in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 34m 31s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21939/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21939/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Checkpointing for repl dump incremental phase > - > > Key: HIVE-23040 > URL: https://issues.apache.org/jira/browse/HIVE-23040 > Project: Hive > Issue Type: Improvement >Reporter: Aasha Medhi >Assignee: PRAVIN KUMAR SINHA >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, > HIVE-23040.03.patch, HIVE-23040.04.patch, HIVE-23040.05.patch, > HIVE-23040.06.patch, HIVE-23040.06.patch, HIVE-23040.07.patch > > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23287) Reduce dependency on icu4j
[ https://issues.apache.org/jira/browse/HIVE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-23287: Status: Patch Available (was: Open) > Reduce dependency on icu4j > -- > > Key: HIVE-23287 > URL: https://issues.apache.org/jira/browse/HIVE-23287 > Project: Hive > Issue Type: Improvement > Components: Druid integration >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan >Priority: Major > Attachments: HIVE-23287.2.patch, HIVE-23287.patch > > > Brought in transitively via druid. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23287) Reduce dependency on icu4j
[ https://issues.apache.org/jira/browse/HIVE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-23287: Attachment: HIVE-23287.2.patch > Reduce dependency on icu4j > -- > > Key: HIVE-23287 > URL: https://issues.apache.org/jira/browse/HIVE-23287 > Project: Hive > Issue Type: Improvement > Components: Druid integration >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan >Priority: Major > Attachments: HIVE-23287.2.patch, HIVE-23287.patch > > > Brought in transitively via druid. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23287) Reduce dependency on icu4j
[ https://issues.apache.org/jira/browse/HIVE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-23287: Status: Open (was: Patch Available) > Reduce dependency on icu4j > -- > > Key: HIVE-23287 > URL: https://issues.apache.org/jira/browse/HIVE-23287 > Project: Hive > Issue Type: Improvement > Components: Druid integration >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan >Priority: Major > Attachments: HIVE-23287.2.patch, HIVE-23287.patch > > > Brought in transitively via druid. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23241) Reduce transitive dependencies
[ https://issues.apache.org/jira/browse/HIVE-23241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-23241: Resolution: Fixed Status: Resolved (was: Patch Available) > Reduce transitive dependencies > -- > > Key: HIVE-23241 > URL: https://issues.apache.org/jira/browse/HIVE-23241 > Project: Hive > Issue Type: Improvement >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan >Priority: Major > Attachments: HIVE-23241.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23298) Disable RS deduplication step in Optimizer if it is run in TezCompiler
[ https://issues.apache.org/jira/browse/HIVE-23298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092400#comment-17092400 ] Hive QA commented on HIVE-23298: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001099/HIVE-23298.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 43 failed/errored test(s), 17143 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[except_distinct] (batchId=59) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[explainuser_2] (batchId=59) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[intersect_all] (batchId=58) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[intersect_distinct] (batchId=60) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[reduce_deduplicate] (batchId=60) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=58) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket2] (batchId=94) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket4] (batchId=110) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_num_reducers2] (batchId=109) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[check_constraint] (batchId=73) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[disable_merge_for_bucketing] (batchId=112) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_optimization2] (batchId=63) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[enforce_constraint_notnull] (batchId=73) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1] (batchId=84) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_into_default_keyword] (batchId=63) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[limit_pushdown] (batchId=107) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mrr] (batchId=71) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[offset_limit_ppd_optimizer] (batchId=105) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ptf] (batchId=72) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[reduce_deduplicate_extended] (batchId=101) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[reducesink_dedup] (batchId=76) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_ANY] (batchId=99) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in] (batchId=102) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_notin] (batchId=107) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=87) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select] (batchId=87) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_dml] (batchId=82) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_union2] (batchId=64) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_union_multiinsert] (batchId=83) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[unionDistinct_3] (batchId=91) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_6] (batchId=70) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_reduce] (batchId=98) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_outer_reference_windowed] (batchId=81) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_ptf_1] (batchId=111) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing] (batchId=119) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_limit] (batchId=84) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_ptf] (batchId=103) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query51] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query53] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query63] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query51] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query53] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query63] (batchId=228) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21938/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21938/console Test logs:
[jira] [Commented] (HIVE-23298) Disable RS deduplication step in Optimizer if it is run in TezCompiler
[ https://issues.apache.org/jira/browse/HIVE-23298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092395#comment-17092395 ] Hive QA commented on HIVE-23298: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 14s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 28m 3s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21938/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21938/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Disable RS deduplication step in Optimizer if it is run in TezCompiler > -- > > Key: HIVE-23298 > URL: https://issues.apache.org/jira/browse/HIVE-23298 > Project: Hive > Issue Type: Improvement > Components: Physical Optimizer >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23298.patch > > > HIVE-20703 introduced an additional RS deduplication step in TezCompiler. We > could possibly try to disable the one that runs in {{Optimizer}} if we are > using Tez so we do not run the optimization twice. > This issue is to explore that possibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23048) Use sequences for TXN_ID generation
[ https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23048: --- Attachment: (was: HIVE-23048.13.patch) > Use sequences for TXN_ID generation > --- > > Key: HIVE-23048 > URL: https://issues.apache.org/jira/browse/HIVE-23048 > Project: Hive > Issue Type: Bug >Reporter: Peter Vary >Assignee: Peter Varga >Priority: Major > Attachments: HIVE-23048.1.patch, HIVE-23048.10.patch, > HIVE-23048.11.patch, HIVE-23048.12.patch, HIVE-23048.13.patch, > HIVE-23048.2.patch, HIVE-23048.3.patch, HIVE-23048.4.patch, > HIVE-23048.5.patch, HIVE-23048.6.patch, HIVE-23048.7.patch, > HIVE-23048.8.patch, HIVE-23048.9.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23048) Use sequences for TXN_ID generation
[ https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23048: --- Attachment: HIVE-23048.13.patch > Use sequences for TXN_ID generation > --- > > Key: HIVE-23048 > URL: https://issues.apache.org/jira/browse/HIVE-23048 > Project: Hive > Issue Type: Bug >Reporter: Peter Vary >Assignee: Peter Varga >Priority: Major > Attachments: HIVE-23048.1.patch, HIVE-23048.10.patch, > HIVE-23048.11.patch, HIVE-23048.12.patch, HIVE-23048.13.patch, > HIVE-23048.2.patch, HIVE-23048.3.patch, HIVE-23048.4.patch, > HIVE-23048.5.patch, HIVE-23048.6.patch, HIVE-23048.7.patch, > HIVE-23048.8.patch, HIVE-23048.9.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23207) Create integration tests for TxnManager for different rdbms metastores
[ https://issues.apache.org/jira/browse/HIVE-23207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23207: --- Status: In Progress (was: Patch Available) > Create integration tests for TxnManager for different rdbms metastores > -- > > Key: HIVE-23207 > URL: https://issues.apache.org/jira/browse/HIVE-23207 > Project: Hive > Issue Type: Improvement >Reporter: Peter Varga >Assignee: Peter Varga >Priority: Minor > Attachments: HIVE-23207.1.patch, HIVE-23207.2.patch, > HIVE-23207.3.patch, HIVE-23207.4.patch, HIVE-23207.5.patch, > HIVE-23207.6.patch, HIVE-23207.7.patch, HIVE-23207.8.patch, HIVE-23207.9.patch > > > Create an integration test suite that runs tests for TxnManager with the > metastore configured to use different kind of RDBMS-s. Use the different > DatabaseRule-s defined in the standalone-metastore for docker environments, > and use the real init schema for every database type instead of the hardwired > TxnDbUtil.prepDb. > This test will be useful for easy manual validation of schema changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23048) Use sequences for TXN_ID generation
[ https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23048: --- Status: In Progress (was: Patch Available) > Use sequences for TXN_ID generation > --- > > Key: HIVE-23048 > URL: https://issues.apache.org/jira/browse/HIVE-23048 > Project: Hive > Issue Type: Bug >Reporter: Peter Vary >Assignee: Peter Varga >Priority: Major > Attachments: HIVE-23048.1.patch, HIVE-23048.10.patch, > HIVE-23048.11.patch, HIVE-23048.12.patch, HIVE-23048.13.patch, > HIVE-23048.2.patch, HIVE-23048.3.patch, HIVE-23048.4.patch, > HIVE-23048.5.patch, HIVE-23048.6.patch, HIVE-23048.7.patch, > HIVE-23048.8.patch, HIVE-23048.9.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23207) Create integration tests for TxnManager for different rdbms metastores
[ https://issues.apache.org/jira/browse/HIVE-23207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23207: --- Status: Patch Available (was: In Progress) > Create integration tests for TxnManager for different rdbms metastores > -- > > Key: HIVE-23207 > URL: https://issues.apache.org/jira/browse/HIVE-23207 > Project: Hive > Issue Type: Improvement >Reporter: Peter Varga >Assignee: Peter Varga >Priority: Minor > Attachments: HIVE-23207.1.patch, HIVE-23207.2.patch, > HIVE-23207.3.patch, HIVE-23207.4.patch, HIVE-23207.5.patch, > HIVE-23207.6.patch, HIVE-23207.7.patch, HIVE-23207.8.patch, HIVE-23207.9.patch > > > Create an integration test suite that runs tests for TxnManager with the > metastore configured to use different kind of RDBMS-s. Use the different > DatabaseRule-s defined in the standalone-metastore for docker environments, > and use the real init schema for every database type instead of the hardwired > TxnDbUtil.prepDb. > This test will be useful for easy manual validation of schema changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23207) Create integration tests for TxnManager for different rdbms metastores
[ https://issues.apache.org/jira/browse/HIVE-23207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23207: --- Attachment: (was: HIVE-23207.9.patch) > Create integration tests for TxnManager for different rdbms metastores > -- > > Key: HIVE-23207 > URL: https://issues.apache.org/jira/browse/HIVE-23207 > Project: Hive > Issue Type: Improvement >Reporter: Peter Varga >Assignee: Peter Varga >Priority: Minor > Attachments: HIVE-23207.1.patch, HIVE-23207.2.patch, > HIVE-23207.3.patch, HIVE-23207.4.patch, HIVE-23207.5.patch, > HIVE-23207.6.patch, HIVE-23207.7.patch, HIVE-23207.8.patch, HIVE-23207.9.patch > > > Create an integration test suite that runs tests for TxnManager with the > metastore configured to use different kind of RDBMS-s. Use the different > DatabaseRule-s defined in the standalone-metastore for docker environments, > and use the real init schema for every database type instead of the hardwired > TxnDbUtil.prepDb. > This test will be useful for easy manual validation of schema changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23207) Create integration tests for TxnManager for different rdbms metastores
[ https://issues.apache.org/jira/browse/HIVE-23207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Varga updated HIVE-23207: --- Attachment: HIVE-23207.9.patch > Create integration tests for TxnManager for different rdbms metastores > -- > > Key: HIVE-23207 > URL: https://issues.apache.org/jira/browse/HIVE-23207 > Project: Hive > Issue Type: Improvement >Reporter: Peter Varga >Assignee: Peter Varga >Priority: Minor > Attachments: HIVE-23207.1.patch, HIVE-23207.2.patch, > HIVE-23207.3.patch, HIVE-23207.4.patch, HIVE-23207.5.patch, > HIVE-23207.6.patch, HIVE-23207.7.patch, HIVE-23207.8.patch, HIVE-23207.9.patch > > > Create an integration test suite that runs tests for TxnManager with the > metastore configured to use different kind of RDBMS-s. Use the different > DatabaseRule-s defined in the standalone-metastore for docker environments, > and use the real init schema for every database type instead of the hardwired > TxnDbUtil.prepDb. > This test will be useful for easy manual validation of schema changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23284) Remove dependency on mariadb-java-client
[ https://issues.apache.org/jira/browse/HIVE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092383#comment-17092383 ] Hive QA commented on HIVE-23284: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001100/HIVE-23284.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17143 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multi_insert_partitioned] (batchId=98) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schq_materialized] (batchId=99) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21937/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21937/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21937/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001100 - PreCommit-HIVE-Build > Remove dependency on mariadb-java-client > > > Key: HIVE-23284 > URL: https://issues.apache.org/jira/browse/HIVE-23284 > Project: Hive > Issue Type: Improvement >Reporter: Karen Coppage >Assignee: Karen Coppage >Priority: Major > Attachments: HIVE-23284.01.patch, HIVE-23284.01.patch > > > It has GNU Lesser General Public License which is [Category > X|https://www.apache.org/legal/resolved.html#category-x]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23284) Remove dependency on mariadb-java-client
[ https://issues.apache.org/jira/browse/HIVE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092368#comment-17092368 ] Hive QA commented on HIVE-23284: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 8s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 18s{color} | {color:blue} standalone-metastore/metastore-server in master has 189 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc xml compile findbugs checkstyle | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21937/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21937/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Remove dependency on mariadb-java-client > > > Key: HIVE-23284 > URL: https://issues.apache.org/jira/browse/HIVE-23284 > Project: Hive > Issue Type: Improvement >Reporter: Karen Coppage >Assignee: Karen Coppage >Priority: Major > Attachments: HIVE-23284.01.patch, HIVE-23284.01.patch > > > It has GNU Lesser General Public License which is [Category > X|https://www.apache.org/legal/resolved.html#category-x]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23206) Project not defined correctly after reordering a join
[ https://issues.apache.org/jira/browse/HIVE-23206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092352#comment-17092352 ] Hive QA commented on HIVE-23206: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001097/HIVE-23206.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 18 failed/errored test(s), 17144 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[correlationoptimizer3] (batchId=116) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[keep_uniform] (batchId=108) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sharedwork] (batchId=108) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select] (batchId=87) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query2] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query59] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query95] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query2] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query59] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query95] (batchId=229) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query14] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query2] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query59] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query95] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query14] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query2] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query59] (batchId=228) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query95] (batchId=228) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21936/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21936/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21936/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 18 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001097 - PreCommit-HIVE-Build > Project not defined correctly after reordering a join > - > > Key: HIVE-23206 > URL: https://issues.apache.org/jira/browse/HIVE-23206 > Project: Hive > Issue Type: Bug > Components: CBO >Reporter: Steve Carlin >Assignee: Krisztian Kasa >Priority: Major > Attachments: HIVE-23206.1.patch, HIVE-23206.2.patch > > > The following highlighted line seems to be incorrect in the test suite: > [https://github.com/apache/hive/blob/master/ql/src/test/results/clientpositive/perf/tez/cbo_query95.q.out#L89] > Note that the project takes all the columns from the table scan, yet it only > needs a couple of them. > I did some very small debugging on this. When I removed the > applyJoinOrderingTransform here: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1897] > ... the problem goes away. So presumably one of the rules in there is > causing the problem. > Here is a slightly simplified version of the query which has the same problem > (using the same tpc-ds database): > explain cbo with ws_wh as > (select ws1.ws_order_number > from web_sales ws1,web_returns wr2 > where ws1.ws_order_number = wr2.wr_order_number) > select > ws_order_number > from > web_sales ws1 > where > ws1.ws_order_number in (select wr_order_number > from web_returns,ws_wh > where wr_order_number = ws_wh.ws_order_number) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23206) Project not defined correctly after reordering a join
[ https://issues.apache.org/jira/browse/HIVE-23206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092341#comment-17092341 ] Hive QA commented on HIVE-23206: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 40s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 9s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 56s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21936/dev-support/hive-personality.sh | | git revision | master / abbe72e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21936/yetus/diff-checkstyle-ql.txt | | modules | C: ql itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21936/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Project not defined correctly after reordering a join > - > > Key: HIVE-23206 > URL: https://issues.apache.org/jira/browse/HIVE-23206 > Project: Hive > Issue Type: Bug > Components: CBO >Reporter: Steve Carlin >Assignee: Krisztian Kasa >Priority: Major > Attachments: HIVE-23206.1.patch, HIVE-23206.2.patch > > > The following highlighted line seems to be incorrect in the test suite: > [https://github.com/apache/hive/blob/master/ql/src/test/results/clientpositive/perf/tez/cbo_query95.q.out#L89] > Note that the project takes all the columns from the table scan, yet it only > needs a couple of them. > I did some very small debugging on this. When I removed the > applyJoinOrderingTransform here: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1897] > ... the problem goes away. So presumably one of the rules in there is > causing the problem. > Here is a slightly simplified version of the query which has the same problem > (using the same tpc-ds database): > explain cbo with ws_wh as > (select ws1.ws_order_number > from web_sales
[jira] [Updated] (HIVE-23134) Hive & Kudu interaction not available on ARM
[ https://issues.apache.org/jira/browse/HIVE-23134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinna Rao Lalam updated HIVE-23134: Fix Version/s: 4.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) HIVE-23134.2.patch committed to master. Thank you for the patch Zhenyu Zheng. > Hive & Kudu interaction not available on ARM > > > Key: HIVE-23134 > URL: https://issues.apache.org/jira/browse/HIVE-23134 > Project: Hive > Issue Type: Sub-task >Reporter: Zhenyu Zheng >Assignee: Zhenyu Zheng >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-23134.1.patch, HIVE-23134.2.patch > > > Currently, we have set up an ARM CI to test out how Hive works on ARM > platform: > https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/ > According to the results, Hive & Kudu interaction is not available on ARM > platform: > https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/25/testReport/org.apache.hadoop.hive.kudu/ > this is because that we use Kudu version 1.10 and that version does not come > with ARM workable packages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly
[ https://issues.apache.org/jira/browse/HIVE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-23275: --- Attachment: HIVE-23275.01.patch > Represent UNBOUNDED in window functions in CBO correctly > > > Key: HIVE-23275 > URL: https://issues.apache.org/jira/browse/HIVE-23275 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23275.01.patch, HIVE-23275.01.patch, > HIVE-23275.01.patch, HIVE-23275.patch, HIVE-23275.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we use a bounded representation with bound set to > Integer.MAX_VALUE, which works correctly since that is the Hive > implementation. However, Calcite has a specific boundary class > {{RexWindowBoundUnbounded}} that we should be using instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23134) Hive & Kudu interaction not available on ARM
[ https://issues.apache.org/jira/browse/HIVE-23134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092294#comment-17092294 ] Chinna Rao Lalam commented on HIVE-23134: - +1 > Hive & Kudu interaction not available on ARM > > > Key: HIVE-23134 > URL: https://issues.apache.org/jira/browse/HIVE-23134 > Project: Hive > Issue Type: Sub-task >Reporter: Zhenyu Zheng >Assignee: Zhenyu Zheng >Priority: Major > Attachments: HIVE-23134.1.patch, HIVE-23134.2.patch > > > Currently, we have set up an ARM CI to test out how Hive works on ARM > platform: > https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/ > According to the results, Hive & Kudu interaction is not available on ARM > platform: > https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/25/testReport/org.apache.hadoop.hive.kudu/ > this is because that we use Kudu version 1.10 and that version does not come > with ARM workable packages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23134) Hive & Kudu interaction not available on ARM
[ https://issues.apache.org/jira/browse/HIVE-23134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092293#comment-17092293 ] Chinna Rao Lalam commented on HIVE-23134: - Currently KUDU ARM64 support is not there, so as we can not execute these tests on ARM64. Its look good to exclude these tests on arm64 platform. > Hive & Kudu interaction not available on ARM > > > Key: HIVE-23134 > URL: https://issues.apache.org/jira/browse/HIVE-23134 > Project: Hive > Issue Type: Sub-task >Reporter: Zhenyu Zheng >Assignee: Zhenyu Zheng >Priority: Major > Attachments: HIVE-23134.1.patch, HIVE-23134.2.patch > > > Currently, we have set up an ARM CI to test out how Hive works on ARM > platform: > https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/ > According to the results, Hive & Kudu interaction is not available on ARM > platform: > https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/25/testReport/org.apache.hadoop.hive.kudu/ > this is because that we use Kudu version 1.10 and that version does not come > with ARM workable packages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22769) Incorrect query results and query failure during split generation for compressed text files
[ https://issues.apache.org/jira/browse/HIVE-22769?focusedWorklogId=427206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427206 ] ASF GitHub Bot logged work on HIVE-22769: - Author: ASF GitHub Bot Created on: 25/Apr/20 15:08 Start Date: 25/Apr/20 15:08 Worklog Time Spent: 10m Work Description: pgaref opened a new pull request #996: URL: https://github.com/apache/hive/pull/996 * SkippingTextInputFormat should not do any header/footer removal * LLAP record reader now does header footer tracking * TODO: Record reader should know if its reading the first or last split Change-Id: I872cbdb5ec19d67fbc32b8db8b85551af54a0d7a This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 427206) Remaining Estimate: 0h Time Spent: 10m > Incorrect query results and query failure during split generation for > compressed text files > --- > > Key: HIVE-22769 > URL: https://issues.apache.org/jira/browse/HIVE-22769 > Project: Hive > Issue Type: Bug > Components: File Formats >Affects Versions: 3.0.0, 3.1.0 >Reporter: Chiran Ravani >Assignee: Marta Kuczora >Priority: Critical > Attachments: testcase1.csv.bz2, testcase2.csv.bz2 > > Time Spent: 10m > Remaining Estimate: 0h > > Hive Query produces incorrect results when data is in text format and > compressed and for certain data the query fails during split generation. > This behavior is seen when skip.header.line.count and skip.footer.line.count > are set for table. > Case 1: Select count/aggregate query produces Incorrect row counts/displays > all rows (when hive.fetch.task.conversion=none) > Steps to reproduce: > 1. Create table as below > {code} > CREATE EXTERNAL TABLE `testcase1`(id int, name string) ROW FORMAT SERDE > 'org.apache.hadoop.hive.serde2.OpenCSVSerde' LOCATION '/user/hive/testcase1' > TBLPROPERTIES ("skip.header.line.count"="1", "skip.footer.line.count"="1"); > {code} > 2. Upload attached testcase1.csv.bz2 file to /user/hive/testcase1 > 3. Run count(*) on table. > {code} > > select * from testcase1; > INFO : Compiling > command(queryId=hive_20200124053854_454b03c1-d4c5-4dba-a2c2-91c09f4b670f): > select * from testcase1 > INFO : Semantic Analysis Completed (retrial = false) > INFO : Returning Hive schema: > Schema(fieldSchemas:[FieldSchema(name:testcase1.id, type:string, > comment:null), FieldSchema(name:testcase1.name, type:string, comment:null)], > properties:null) > INFO : Completed compiling > command(queryId=hive_20200124053854_454b03c1-d4c5-4dba-a2c2-91c09f4b670f); > Time taken: 0.07 seconds > INFO : Executing > command(queryId=hive_20200124053854_454b03c1-d4c5-4dba-a2c2-91c09f4b670f): > select * from testcase1 > INFO : Completed executing > command(queryId=hive_20200124053854_454b03c1-d4c5-4dba-a2c2-91c09f4b670f); > Time taken: 0.007 seconds > INFO : OK > +---+-+ > | testcase1.id | testcase1.name | > +---+-+ > | 2 | 2019-12-31 | > +---+-+ > 1 row selected (0.111 seconds) > > select count(*) from testcase1 > INFO : Compiling > command(queryId=hive_20200124053645_a7d699b7-c7e1-4d92-8d99-666b0a010ba7): > select count(*) from testcase1 > INFO : Semantic Analysis Completed (retrial = false) > INFO : Returning Hive schema: Schema(fieldSchemas:[FieldSchema(name:_c0, > type:bigint, comment:null)], properties:null) > INFO : Completed compiling > command(queryId=hive_20200124053645_a7d699b7-c7e1-4d92-8d99-666b0a010ba7); > Time taken: 0.073 seconds > INFO : Executing > command(queryId=hive_20200124053645_a7d699b7-c7e1-4d92-8d99-666b0a010ba7): > select count(*) from testcase1 > INFO : Query ID = hive_20200124053645_a7d699b7-c7e1-4d92-8d99-666b0a010ba7 > INFO : Total jobs = 1 > INFO : Launching Job 1 out of 1 > INFO : Starting task [Stage-1:MAPRED] in serial mode > INFO : Subscribed to counters: [] for queryId: > hive_20200124053645_a7d699b7-c7e1-4d92-8d99-666b0a010ba7 > INFO : Session is already open > INFO : Dag name: select count(*) from testcase1 (Stage-1) > INFO : Status: Running (Executing on YARN cluster with App id > application_1579811438512_0046) > . > . > . > INFO : Completed executing > command(queryId=hive_20200124053645_a7d699b7-c7e1-4d92-8d99-666b0a010ba7); > Time taken: 4.228 seconds > INFO : OK > +--+ >
[jira] [Comment Edited] (HIVE-23296) Setting Tez caller ID with the actual Hive user
[ https://issues.apache.org/jira/browse/HIVE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092254#comment-17092254 ] Eugene Chung edited comment on HIVE-23296 at 4/25/20, 2:39 PM: --- The result of some tests are strange. For example, there's ClassNotFoundException of XXXTest.class. I think the test itself had some problems. {code:java} java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassNotFoundException: org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest at org.apache.hadoop.hive.ql.session.SessionState.setupAuth(SessionState.java:951) at org.apache.hadoop.hive.ql.session.SessionState.getAuthenticator(SessionState.java:1696) at org.apache.hadoop.hive.ql.session.SessionState.getUserFromAuthenticator(SessionState.java:1306) at org.apache.hadoop.hive.ql.session.SessionState.getUser(SessionState.java:1291) at org.apache.hadoop.hive.ql.QueryPlan.makeQueryId(QueryPlan.java:204) at org.apache.hadoop.hive.ql.QueryState$Builder.build(QueryState.java:265) at org.apache.hive.service.cli.operation.Operation.(Operation.java:107) at org.apache.hive.service.cli.operation.Operation.(Operation.java:87) at org.apache.hive.service.cli.operation.MetadataOperation.(MetadataOperation.java:48) at org.apache.hive.service.cli.session.TestSessionManagerMetrics$BlockingOperation.(TestSessionManagerMetrics.java:123) at org.apache.hive.service.cli.session.TestSessionManagerMetrics.testActiveSessionMetrics(TestSessionManagerMetrics.java:277) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413) Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassNotFoundException: org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest at org.apache.hadoop.hive.ql.metadata.HiveUtils.getAuthorizeProviderManager(HiveUtils.java:366) at org.apache.hadoop.hive.ql.session.SessionState.setupAuth(SessionState.java:927) ... 36 more Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at org.apache.hadoop.hive.ql.metadata.HiveUtils.getAuthorizeProviderManager(HiveUtils.java:356) ... 37 more {code} was
[jira] [Commented] (HIVE-23296) Setting Tez caller ID with the actual Hive user
[ https://issues.apache.org/jira/browse/HIVE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092254#comment-17092254 ] Eugene Chung commented on HIVE-23296: - The result of some tests are strange; there's ClassNotFoundException. I think the test itself had some problems. {code:java} java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassNotFoundException: org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest at org.apache.hadoop.hive.ql.session.SessionState.setupAuth(SessionState.java:951) at org.apache.hadoop.hive.ql.session.SessionState.getAuthenticator(SessionState.java:1696) at org.apache.hadoop.hive.ql.session.SessionState.getUserFromAuthenticator(SessionState.java:1306) at org.apache.hadoop.hive.ql.session.SessionState.getUser(SessionState.java:1291) at org.apache.hadoop.hive.ql.QueryPlan.makeQueryId(QueryPlan.java:204) at org.apache.hadoop.hive.ql.QueryState$Builder.build(QueryState.java:265) at org.apache.hive.service.cli.operation.Operation.(Operation.java:107) at org.apache.hive.service.cli.operation.Operation.(Operation.java:87) at org.apache.hive.service.cli.operation.MetadataOperation.(MetadataOperation.java:48) at org.apache.hive.service.cli.session.TestSessionManagerMetrics$BlockingOperation.(TestSessionManagerMetrics.java:123) at org.apache.hive.service.cli.session.TestSessionManagerMetrics.testActiveSessionMetrics(TestSessionManagerMetrics.java:277) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413) Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassNotFoundException: org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest at org.apache.hadoop.hive.ql.metadata.HiveUtils.getAuthorizeProviderManager(HiveUtils.java:366) at org.apache.hadoop.hive.ql.session.SessionState.setupAuth(SessionState.java:927) ... 36 more Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at org.apache.hadoop.hive.ql.metadata.HiveUtils.getAuthorizeProviderManager(HiveUtils.java:356) ... 37 more {code} > Setting Tez caller ID with the actual Hive user >
[jira] [Updated] (HIVE-23300) alter_partitions codahale mertric does not close properly
[ https://issues.apache.org/jira/browse/HIVE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Katipally updated HIVE-23300: --- Affects Version/s: (was: 2.3.7) (was: 2.3.6) All Versions > alter_partitions codahale mertric does not close properly > - > > Key: HIVE-23300 > URL: https://issues.apache.org/jira/browse/HIVE-23300 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: All Versions >Reporter: Akash Katipally >Priority: Major > Attachments: HIVE-23300.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hello, > > We were noticing in a rise in the number of alter partition calls in our > metric dashboard. Upon further investigation, it seems like we do not close > the call properly. Here is the error. > > {code:java} > org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics Scope named > api_alter_partitions is not closed, cannot be opened. > {code} > The piece of line that looks incorrect is here: > [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L5542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23300) alter_partitions codahale mertric does not close properly
[ https://issues.apache.org/jira/browse/HIVE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Katipally updated HIVE-23300: --- Attachment: HIVE-23300.1.patch Target Version/s: All Versions Status: Patch Available (was: Open) > alter_partitions codahale mertric does not close properly > - > > Key: HIVE-23300 > URL: https://issues.apache.org/jira/browse/HIVE-23300 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 2.3.7, 2.3.6 >Reporter: Akash Katipally >Priority: Major > Attachments: HIVE-23300.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hello, > > We were noticing in a rise in the number of alter partition calls in our > metric dashboard. Upon further investigation, it seems like we do not close > the call properly. Here is the error. > > {code:java} > org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics Scope named > api_alter_partitions is not closed, cannot be opened. > {code} > The piece of line that looks incorrect is here: > [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L5542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23300) alter_partitions codahale mertric does not close properly
[ https://issues.apache.org/jira/browse/HIVE-23300?focusedWorklogId=427203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427203 ] ASF GitHub Bot logged work on HIVE-23300: - Author: ASF GitHub Bot Created on: 25/Apr/20 14:05 Start Date: 25/Apr/20 14:05 Worklog Time Spent: 10m Work Description: kash159 opened a new pull request #995: URL: https://github.com/apache/hive/pull/995 As described in the JIRA, this made it hard to view the number of active api calls correctly for alter_paritions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 427203) Remaining Estimate: 0h Time Spent: 10m > alter_partitions codahale mertric does not close properly > - > > Key: HIVE-23300 > URL: https://issues.apache.org/jira/browse/HIVE-23300 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 2.3.6, 2.3.7 >Reporter: Akash Katipally >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Hello, > > We were noticing in a rise in the number of alter partition calls in our > metric dashboard. Upon further investigation, it seems like we do not close > the call properly. Here is the error. > > {code:java} > org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics Scope named > api_alter_partitions is not closed, cannot be opened. > {code} > The piece of line that looks incorrect is here: > [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L5542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23300) alter_partitions codahale mertric does not close properly
[ https://issues.apache.org/jira/browse/HIVE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Katipally updated HIVE-23300: --- Description: Hello, We were noticing in a rise in the number of alter partition calls in our metric dashboard. Upon further investigation, it seems like we do not close the call properly. Here is the error. {code:java} org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics Scope named api_alter_partitions is not closed, cannot be opened. {code} The piece of line that looks incorrect is here: [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L5542] > alter_partitions codahale mertric does not close properly > - > > Key: HIVE-23300 > URL: https://issues.apache.org/jira/browse/HIVE-23300 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 2.3.6, 2.3.7 >Reporter: Akash Katipally >Priority: Major > > Hello, > > We were noticing in a rise in the number of alter partition calls in our > metric dashboard. Upon further investigation, it seems like we do not close > the call properly. Here is the error. > > {code:java} > org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics Scope named > api_alter_partitions is not closed, cannot be opened. > {code} > The piece of line that looks incorrect is here: > [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L5542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly
[ https://issues.apache.org/jira/browse/HIVE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092241#comment-17092241 ] Zoltan Haindrich commented on HIVE-23275: - +1 > Represent UNBOUNDED in window functions in CBO correctly > > > Key: HIVE-23275 > URL: https://issues.apache.org/jira/browse/HIVE-23275 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23275.01.patch, HIVE-23275.01.patch, > HIVE-23275.patch, HIVE-23275.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we use a bounded representation with bound set to > Integer.MAX_VALUE, which works correctly since that is the Hive > implementation. However, Calcite has a specific boundary class > {{RexWindowBoundUnbounded}} that we should be using instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23048) Use sequences for TXN_ID generation
[ https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092177#comment-17092177 ] Hive QA commented on HIVE-23048: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001094/HIVE-23048.13.patch {color:green}SUCCESS:{color} +1 due to 11 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17152 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schq_ingest] (batchId=102) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21935/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21935/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21935/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001094 - PreCommit-HIVE-Build > Use sequences for TXN_ID generation > --- > > Key: HIVE-23048 > URL: https://issues.apache.org/jira/browse/HIVE-23048 > Project: Hive > Issue Type: Bug >Reporter: Peter Vary >Assignee: Peter Varga >Priority: Major > Attachments: HIVE-23048.1.patch, HIVE-23048.10.patch, > HIVE-23048.11.patch, HIVE-23048.12.patch, HIVE-23048.13.patch, > HIVE-23048.2.patch, HIVE-23048.3.patch, HIVE-23048.4.patch, > HIVE-23048.5.patch, HIVE-23048.6.patch, HIVE-23048.7.patch, > HIVE-23048.8.patch, HIVE-23048.9.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23048) Use sequences for TXN_ID generation
[ https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092175#comment-17092175 ] Hive QA commented on HIVE-23048: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 6s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 28s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 40s{color} | {color:blue} standalone-metastore/metastore-common in master has 35 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 18s{color} | {color:blue} standalone-metastore/metastore-server in master has 189 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 59s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 13s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 7s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 27s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 6 new + 585 unchanged - 27 fixed = 591 total (was 612) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 49s{color} | {color:red} ql: The patch generated 11 new + 786 unchanged - 3 fixed = 797 total (was 789) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 25s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 188 unchanged - 1 fixed = 189 total (was 189) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 22s{color} | {color:red} standalone-metastore_metastore-server generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 43m 15s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore/metastore-server | | | Write to static field org.apache.hadoop.hive.metastore.txn.TxnHandler.openTxnTimeOutMillis from instance method org.apache.hadoop.hive.metastore.txn.TxnHandler.setOpenTxnTimeOutMillis(long) At TxnHandler.java:from instance method org.apache.hadoop.hive.metastore.txn.TxnHandler.setOpenTxnTimeOutMillis(long) At TxnHandler.java:[line 885] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21935/dev-support/hive-personality.sh | | git revision | master / 730b026 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21935/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21935/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-21935/yetus/new-findbugs-standalone-metastore_metastore-server.html | | javadoc |
[jira] [Updated] (HIVE-23272) Fix and reenable timestamptz_2.q
[ https://issues.apache.org/jira/browse/HIVE-23272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-23272: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Fix and reenable timestamptz_2.q > > > Key: HIVE-23272 > URL: https://issues.apache.org/jira/browse/HIVE-23272 > Project: Hive > Issue Type: Test >Reporter: Peter Vary >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23272.01.patch, HIVE-23272.02.patch, > HIVE-23272.03.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly
[ https://issues.apache.org/jira/browse/HIVE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092158#comment-17092158 ] Hive QA commented on HIVE-23275: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001090/HIVE-23275.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17141 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testComplexQuery (batchId=215) org.apache.hive.service.auth.TestImproperTrustDomainAuthenticationBinary.org.apache.hive.service.auth.TestImproperTrustDomainAuthenticationBinary (batchId=210) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21934/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21934/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21934/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001090 - PreCommit-HIVE-Build > Represent UNBOUNDED in window functions in CBO correctly > > > Key: HIVE-23275 > URL: https://issues.apache.org/jira/browse/HIVE-23275 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23275.01.patch, HIVE-23275.01.patch, > HIVE-23275.patch, HIVE-23275.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we use a bounded representation with bound set to > Integer.MAX_VALUE, which works correctly since that is the Hive > implementation. However, Calcite has a specific boundary class > {{RexWindowBoundUnbounded}} that we should be using instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23244) Extract Create View analyzer from SemanticAnalyzer
[ https://issues.apache.org/jira/browse/HIVE-23244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-23244: -- Attachment: (was: HIVE-23244.03.patch) > Extract Create View analyzer from SemanticAnalyzer > -- > > Key: HIVE-23244 > URL: https://issues.apache.org/jira/browse/HIVE-23244 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23244.01.patch, HIVE-23244.02.patch, > HIVE-23244.03.patch > > > Create View commands are not queries, but commands which have queries as a > part of them. Therefore a separate CreateViewAnalyzer is needed which uses > SemanticAnalyer to analyze it's query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23244) Extract Create View analyzer from SemanticAnalyzer
[ https://issues.apache.org/jira/browse/HIVE-23244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-23244: -- Attachment: HIVE-23244.03.patch > Extract Create View analyzer from SemanticAnalyzer > -- > > Key: HIVE-23244 > URL: https://issues.apache.org/jira/browse/HIVE-23244 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23244.01.patch, HIVE-23244.02.patch, > HIVE-23244.03.patch > > > Create View commands are not queries, but commands which have queries as a > part of them. Therefore a separate CreateViewAnalyzer is needed which uses > SemanticAnalyer to analyze it's query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly
[ https://issues.apache.org/jira/browse/HIVE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092143#comment-17092143 ] Hive QA commented on HIVE-23275: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 55s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 12s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21934/dev-support/hive-personality.sh | | git revision | master / 88053b2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21934/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Represent UNBOUNDED in window functions in CBO correctly > > > Key: HIVE-23275 > URL: https://issues.apache.org/jira/browse/HIVE-23275 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-23275.01.patch, HIVE-23275.01.patch, > HIVE-23275.patch, HIVE-23275.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we use a bounded representation with bound set to > Integer.MAX_VALUE, which works correctly since that is the Hive > implementation. However, Calcite has a specific boundary class > {{RexWindowBoundUnbounded}} that we should be using instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23244) Extract Create View analyzer from SemanticAnalyzer
[ https://issues.apache.org/jira/browse/HIVE-23244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092129#comment-17092129 ] Hive QA commented on HIVE-23244: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001096/HIVE-23244.03.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 17141 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multi_insert_partitioned] (batchId=98) org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable (batchId=153) org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testComplexQuery (batchId=219) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21933/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21933/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21933/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001096 - PreCommit-HIVE-Build > Extract Create View analyzer from SemanticAnalyzer > -- > > Key: HIVE-23244 > URL: https://issues.apache.org/jira/browse/HIVE-23244 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23244.01.patch, HIVE-23244.02.patch, > HIVE-23244.03.patch > > > Create View commands are not queries, but commands which have queries as a > part of them. Therefore a separate CreateViewAnalyzer is needed which uses > SemanticAnalyer to analyze it's query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23244) Extract Create View analyzer from SemanticAnalyzer
[ https://issues.apache.org/jira/browse/HIVE-23244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092123#comment-17092123 ] Hive QA commented on HIVE-23244: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 8s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 12s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 57s{color} | {color:blue} parser in master has 3 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 51s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 48s{color} | {color:red} ql: The patch generated 2 new + 590 unchanged - 8 fixed = 592 total (was 598) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 56s{color} | {color:red} ql generated 1 new + 1529 unchanged - 1 fixed = 1530 total (was 1530) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 34m 54s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | The field org.apache.hadoop.hive.ql.plan.LoadFileDesc.createViewDesc is transient but isn't set by deserialization In LoadFileDesc.java:but isn't set by deserialization In LoadFileDesc.java | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21933/dev-support/hive-personality.sh | | git revision | master / 88053b2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21933/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-21933/yetus/new-findbugs-ql.html | | modules | C: common parser ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21933/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Extract Create View analyzer from SemanticAnalyzer > -- > > Key: HIVE-23244 > URL: https://issues.apache.org/jira/browse/HIVE-23244 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23244.01.patch, HIVE-23244.02.patch, > HIVE-23244.03.patch > > > Create View commands are not queries,
[jira] [Commented] (HIVE-23272) Fix and reenable timestamptz_2.q
[ https://issues.apache.org/jira/browse/HIVE-23272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092100#comment-17092100 ] Hive QA commented on HIVE-23272: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001084/HIVE-23272.03.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17143 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21932/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21932/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21932/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13001084 - PreCommit-HIVE-Build > Fix and reenable timestamptz_2.q > > > Key: HIVE-23272 > URL: https://issues.apache.org/jira/browse/HIVE-23272 > Project: Hive > Issue Type: Test >Reporter: Peter Vary >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23272.01.patch, HIVE-23272.02.patch, > HIVE-23272.03.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23272) Fix and reenable timestamptz_2.q
[ https://issues.apache.org/jira/browse/HIVE-23272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092094#comment-17092094 ] Hive QA commented on HIVE-23272: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 16s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 43s{color} | {color:blue} serde in master has 198 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 55s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 52s{color} | {color:blue} itests/util in master has 53 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 38s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 35m 57s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21932/dev-support/hive-personality.sh | | git revision | master / 88053b2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: serde ql itests/util U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21932/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Fix and reenable timestamptz_2.q > > > Key: HIVE-23272 > URL: https://issues.apache.org/jira/browse/HIVE-23272 > Project: Hive > Issue Type: Test >Reporter: Peter Vary >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-23272.01.patch, HIVE-23272.02.patch, > HIVE-23272.03.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23295) Possible NPE when on getting predicate literal list when dynamic values are not available
[ https://issues.apache.org/jira/browse/HIVE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092059#comment-17092059 ] Hive QA commented on HIVE-23295: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001073/HIVE-23295.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17141 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21931/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21931/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21931/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13001073 - PreCommit-HIVE-Build > Possible NPE when on getting predicate literal list when dynamic values are > not available > - > > Key: HIVE-23295 > URL: https://issues.apache.org/jira/browse/HIVE-23295 > Project: Hive > Issue Type: Bug > Components: storage-api >Reporter: Attila Magyar >Assignee: Attila Magyar >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-23295.1.patch > > > getLiteralList() in SearchArgumentImpl$PredicateLeafImpl returns null if > dynamic values are not available. > {code:java} > @Override > public List getLiteralList() { > if (literalList != null && literalList.size() > 0 && literalList.get(0) > instanceof LiteralDelegate) { > List newLiteraList = new ArrayList(); > try { > for (Object litertalObj : literalList) { > Object literal = ((LiteralDelegate) litertalObj).getLiteral(); > if (literal != null) { > newLiteraList.add(literal); > } > } > } catch (NoDynamicValuesException err) { > LOG.debug("Error while retrieving literalList, returning null", err); > return null; > } > return newLiteraList; > } > return literalList; > } {code} > > There are multiple call sites where the return value is used without a null > check. E.g: leaf.getLiteralList().stream(). > > The return null was added as part of HIVE-18827 to avoid having an > unimportant warning message when dynamic values have not been delivered yet. > > [~sershe], [~jdere], I propose return an empty list instead of null in a case > like this. What do you think? -- This message was sent by Atlassian Jira (v8.3.4#803005)