[jira] [Work logged] (HIVE-25048) Refine the start/end functions in HMSHandler
[ https://issues.apache.org/jira/browse/HIVE-25048?focusedWorklogId=627431=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627431 ] ASF GitHub Bot logged work on HIVE-25048: - Author: ASF GitHub Bot Created on: 25/Jul/21 05:32 Start Date: 25/Jul/21 05:32 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #2441: URL: https://github.com/apache/hive/pull/2441 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 627431) Time Spent: 1h 40m (was: 1.5h) > Refine the start/end functions in HMSHandler > > > Key: HIVE-25048 > URL: https://issues.apache.org/jira/browse/HIVE-25048 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Zhihua Deng >Assignee: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > Some start/end functions are incomplete and wrong in the HMSHandler, these > functions audit actions, monitor the performance, and notify the end function > listeners. We have already measured the performance of the HMSHandler in > PerfLogger, and covered more methods than these functions that have done, so > we can remove the monitoring from the start/end functions, move the end > function listeners to the RetryingHMSHandler to eliminate the try-finally > blocks that spread across many different methods. After these, we can try to > cleanup the functions to make HMSHandler be more simplified. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25048) Refine the start/end functions in HMSHandler
[ https://issues.apache.org/jira/browse/HIVE-25048?focusedWorklogId=627430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627430 ] ASF GitHub Bot logged work on HIVE-25048: - Author: ASF GitHub Bot Created on: 25/Jul/21 05:31 Start Date: 25/Jul/21 05:31 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #2441: URL: https://github.com/apache/hive/pull/2441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 627430) Time Spent: 1.5h (was: 1h 20m) > Refine the start/end functions in HMSHandler > > > Key: HIVE-25048 > URL: https://issues.apache.org/jira/browse/HIVE-25048 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Zhihua Deng >Assignee: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Some start/end functions are incomplete and wrong in the HMSHandler, these > functions audit actions, monitor the performance, and notify the end function > listeners. We have already measured the performance of the HMSHandler in > PerfLogger, and covered more methods than these functions that have done, so > we can remove the monitoring from the start/end functions, move the end > function listeners to the RetryingHMSHandler to eliminate the try-finally > blocks that spread across many different methods. After these, we can try to > cleanup the functions to make HMSHandler be more simplified. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25368) Code does not build in IDE and a small fix
[
https://issues.apache.org/jira/browse/HIVE-25368?focusedWorklogId=627429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627429
]
ASF GitHub Bot logged work on HIVE-25368:
-
Author: ASF GitHub Bot
Created on: 25/Jul/21 04:35
Start Date: 25/Jul/21 04:35
Worklog Time Spent: 10m
Work Description: pvary merged pull request #2517:
URL: https://github.com/apache/hive/pull/2517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627429)
Time Spent: 20m (was: 10m)
> Code does not build in IDE and a small fix
> --
>
> Key: HIVE-25368
> URL: https://issues.apache.org/jira/browse/HIVE-25368
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The code does not build in IntelliJ because of the generic usage.
> Also there is a small test case issue in {{WarehouseInstance.java}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25332) Refactor UDF CAST( as DATE)
[ https://issues.apache.org/jira/browse/HIVE-25332?focusedWorklogId=627428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627428 ] ASF GitHub Bot logged work on HIVE-25332: - Author: ASF GitHub Bot Created on: 25/Jul/21 04:28 Start Date: 25/Jul/21 04:28 Worklog Time Spent: 10m Work Description: ashish-kumar-sharma commented on pull request #2480: URL: https://github.com/apache/hive/pull/2480#issuecomment-886145070 @zabetak Could you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 627428) Time Spent: 0.5h (was: 20m) > Refactor UDF CAST( as DATE) > > > Key: HIVE-25332 > URL: https://issues.apache.org/jira/browse/HIVE-25332 > Project: Hive > Issue Type: Sub-task >Reporter: Ashish Sharma >Assignee: Ashish Sharma >Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Description > CAST( as DATE) is done by GenericUDFToDate.class which is > written back in 2013 and hasn't been refactor after since also there is code > duplicate as well. > DOD > Refactor entire UDF -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=627425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627425 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 25/Jul/21 00:08 Start Date: 25/Jul/21 00:08 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2151: URL: https://github.com/apache/hive/pull/2151#issuecomment-886126479 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 627425) Time Spent: 1h 10m (was: 1h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-25381) Hive impersonation Failed when load data of managed tables set as hive
[
https://issues.apache.org/jira/browse/HIVE-25381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386715#comment-17386715
]
Ranith Sardar commented on HIVE-25381:
--
hive code is getting used for impersonating
{code}
public static boolean isOwnerOfFileHierarchy(final FileSystem fs,
final FileStatus fileStatus, final String userName, final boolean recurse)
throws IOException, InterruptedException {
UserGroupInformation proxyUser =
UserGroupInformation.createProxyUser(userName,
UserGroupInformation.getLoginUser());
try {
boolean isOwner = proxyUser.doAs(new PrivilegedExceptionAction()
{
@Override
public Boolean run() throws Exception {
FileSystem fsAsUser = FileSystem.get(fs.getUri(), fs.getConf());
return checkIsOwnerOfFileHierarchy(fsAsUser, fileStatus, userName,
recurse);
}
});
return isOwner;
} finally {
FileSystem.closeAllForUGI(proxyUser);
}{code}
Here userName is coming from
{code:java}
String configuredOwner = HiveConf.getVar(conf,
ConfVars.HIVE_LOAD_DATA_OWNER);{code}
which basically means UserGroupInformation.getLoginUser() is impersonating
"userName".
> Hive impersonation Failed when load data of managed tables set as hive
> --
>
> Key: HIVE-25381
> URL: https://issues.apache.org/jira/browse/HIVE-25381
> Project: Hive
> Issue Type: Bug
>Reporter: Ranith Sardar
>Assignee: Ranith Sardar
>Priority: Minor
> Fix For: 3.1.0, 4.0.0
>
>
> When hive.server2.enable.doAs = True and setting hive as the default value
> for "hive.load.data.owner" property, this will cause below logic(in
> Hive.java-needToCopy{color:#24292e}({color})) to fail always as the
> framework is validating the owner of the file against the value which we set
> in the property hive.load.data.owner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-25381) Hive impersonation Failed when load data of managed tables set as hive
[
https://issues.apache.org/jira/browse/HIVE-25381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ranith Sardar updated HIVE-25381:
-
Description: When hive.server2.enable.doAs = True and setting hive as the
default value for "hive.load.data.owner" property, this will cause below
logic(in Hive.java-needToCopy{color:#24292e}({color})) to fail always as the
framework is validating the owner of the file against the value which we set in
the property hive.load.data.owner. (was: When hive.server2.enable.doAs = True
and **
when setting hive as the default value for "hive.load.data.owner" property,
this will cause below logic(in Hive.java-needToCopy{color:#24292e}({color}))
to fail always as the framework is validating the owner of the file against the
value which we set in the property hive.load.data.owner.)
> Hive impersonation Failed when load data of managed tables set as hive
> --
>
> Key: HIVE-25381
> URL: https://issues.apache.org/jira/browse/HIVE-25381
> Project: Hive
> Issue Type: Bug
>Reporter: Ranith Sardar
>Assignee: Ranith Sardar
>Priority: Minor
> Fix For: 3.1.0, 4.0.0
>
>
> When hive.server2.enable.doAs = True and setting hive as the default value
> for "hive.load.data.owner" property, this will cause below logic(in
> Hive.java-needToCopy{color:#24292e}({color})) to fail always as the
> framework is validating the owner of the file against the value which we set
> in the property hive.load.data.owner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HIVE-25381) Hive impersonation Failed when load data of managed tables set as hive
[
https://issues.apache.org/jira/browse/HIVE-25381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ranith Sardar reassigned HIVE-25381:
> Hive impersonation Failed when load data of managed tables set as hive
> --
>
> Key: HIVE-25381
> URL: https://issues.apache.org/jira/browse/HIVE-25381
> Project: Hive
> Issue Type: Bug
>Reporter: Ranith Sardar
>Assignee: Ranith Sardar
>Priority: Minor
> Fix For: 4.0.0, 3.1.0
>
>
> When hive.server2.enable.doAs = True and **
> when setting hive as the default value for "hive.load.data.owner" property,
> this will cause below logic(in Hive.java-needToCopy{color:#24292e}({color}))
> to fail always as the framework is validating the owner of the file against
> the value which we set in the property hive.load.data.owner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-19928) Load Data for managed tables should set the owner of loaded files to a configurable user
[ https://issues.apache.org/jira/browse/HIVE-19928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranith Sardar updated HIVE-19928: - Description: load data of managed tables should set the owner of the loaded files to a configurable user. the default user should be hive.` If the owner of existing file is not hive, then a rename/move operation should be replaced by copy with the copied file having hive as owner. was: load data of managed tables should set the owner of the loaded files to a configurable user. the default user should be hive. If the owner of existing file is not hive, then a rename/move operation should be replaced by copy with the copied file having hive as owner. > Load Data for managed tables should set the owner of loaded files to a > configurable user > > > Key: HIVE-19928 > URL: https://issues.apache.org/jira/browse/HIVE-19928 > Project: Hive > Issue Type: Task >Reporter: Deepak Jaiswal >Assignee: Deepak Jaiswal >Priority: Major > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-19928.01-branch-3.patch, > HIVE-19928.02-branch-3.patch, HIVE-19928.1.patch, HIVE-19928.2.patch, > HIVE-19928.3.patch, HIVE-19928.4.patch, HIVE-19928.5.patch, > HIVE-19928.6.patch, HIVE-19928.7.patch > > > load data of managed tables should set the owner of the loaded files to a > configurable user. the default user should be hive.` > If the owner of existing file is not hive, then a rename/move operation > should be replaced by copy with the copied file having hive as owner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25095) Beeline/hive -e command can't deal with query with trailing quote
[
https://issues.apache.org/jira/browse/HIVE-25095?focusedWorklogId=627399=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627399
]
ASF GitHub Bot logged work on HIVE-25095:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 11:18
Start Date: 24/Jul/21 11:18
Worklog Time Spent: 10m
Work Description: ujc714 edited a comment on pull request #2255:
URL: https://github.com/apache/hive/pull/2255#issuecomment-886038213
The branch was lost in my fork for some reason. I restored it and had to
open a new PR so close this one. Could you please review PR-2526 after it
passes tests? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627399)
Time Spent: 1h 10m (was: 1h)
> Beeline/hive -e command can't deal with query with trailing quote
> -
>
> Key: HIVE-25095
> URL: https://issues.apache.org/jira/browse/HIVE-25095
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The command
> {code:java}
> hive -e 'select "hive"'{code}
> and
> {code:java}
> beeline -e 'select "hive"'{code}
> fail with such error:
> {code:java}
> Error: Error while compiling statement: FAILED: ParseException line 1:12
> character '' not supported here (state=42000,code=4){code}
> The reason is that org.apache.commons.cli.Util.stripLeadingAndTrailingQuotes
> in commons-cli-1.2.jar strips the trailing quote so the query string is
> changed to
> {code:java}
> select "hive{code}
> This bug is fixed in commons-cli-1.3.1 and commons-cli-1.4.jar. The
> workaround is to overwrite commons-cli-1.2.jar with commons-cli-1.3.1 or
> commons-cli-1.4.jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25095) Beeline/hive -e command can't deal with query with trailing quote
[
https://issues.apache.org/jira/browse/HIVE-25095?focusedWorklogId=627398=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627398
]
ASF GitHub Bot logged work on HIVE-25095:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 11:16
Start Date: 24/Jul/21 11:16
Worklog Time Spent: 10m
Work Description: ujc714 commented on pull request #2255:
URL: https://github.com/apache/hive/pull/2255#issuecomment-886038213
The branch was lost in my fork for some reason. I restored it and have to
open a new PR so close this one. Could you please review PR-2526 after it
passes tests? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627398)
Time Spent: 1h (was: 50m)
> Beeline/hive -e command can't deal with query with trailing quote
> -
>
> Key: HIVE-25095
> URL: https://issues.apache.org/jira/browse/HIVE-25095
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The command
> {code:java}
> hive -e 'select "hive"'{code}
> and
> {code:java}
> beeline -e 'select "hive"'{code}
> fail with such error:
> {code:java}
> Error: Error while compiling statement: FAILED: ParseException line 1:12
> character '' not supported here (state=42000,code=4){code}
> The reason is that org.apache.commons.cli.Util.stripLeadingAndTrailingQuotes
> in commons-cli-1.2.jar strips the trailing quote so the query string is
> changed to
> {code:java}
> select "hive{code}
> This bug is fixed in commons-cli-1.3.1 and commons-cli-1.4.jar. The
> workaround is to overwrite commons-cli-1.2.jar with commons-cli-1.3.1 or
> commons-cli-1.4.jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25095) Beeline/hive -e command can't deal with query with trailing quote
[
https://issues.apache.org/jira/browse/HIVE-25095?focusedWorklogId=627396=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627396
]
ASF GitHub Bot logged work on HIVE-25095:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 11:14
Start Date: 24/Jul/21 11:14
Worklog Time Spent: 10m
Work Description: ujc714 commented on pull request #2255:
URL: https://github.com/apache/hive/pull/2255#issuecomment-886038014
> LGTM +1, please squash your commits and rebase on top of the current
master to get a clean test run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627396)
Time Spent: 40m (was: 0.5h)
> Beeline/hive -e command can't deal with query with trailing quote
> -
>
> Key: HIVE-25095
> URL: https://issues.apache.org/jira/browse/HIVE-25095
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The command
> {code:java}
> hive -e 'select "hive"'{code}
> and
> {code:java}
> beeline -e 'select "hive"'{code}
> fail with such error:
> {code:java}
> Error: Error while compiling statement: FAILED: ParseException line 1:12
> character '' not supported here (state=42000,code=4){code}
> The reason is that org.apache.commons.cli.Util.stripLeadingAndTrailingQuotes
> in commons-cli-1.2.jar strips the trailing quote so the query string is
> changed to
> {code:java}
> select "hive{code}
> This bug is fixed in commons-cli-1.3.1 and commons-cli-1.4.jar. The
> workaround is to overwrite commons-cli-1.2.jar with commons-cli-1.3.1 or
> commons-cli-1.4.jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25095) Beeline/hive -e command can't deal with query with trailing quote
[
https://issues.apache.org/jira/browse/HIVE-25095?focusedWorklogId=627395=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627395
]
ASF GitHub Bot logged work on HIVE-25095:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 11:14
Start Date: 24/Jul/21 11:14
Worklog Time Spent: 10m
Work Description: ujc714 closed pull request #2255:
URL: https://github.com/apache/hive/pull/2255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627395)
Time Spent: 0.5h (was: 20m)
> Beeline/hive -e command can't deal with query with trailing quote
> -
>
> Key: HIVE-25095
> URL: https://issues.apache.org/jira/browse/HIVE-25095
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The command
> {code:java}
> hive -e 'select "hive"'{code}
> and
> {code:java}
> beeline -e 'select "hive"'{code}
> fail with such error:
> {code:java}
> Error: Error while compiling statement: FAILED: ParseException line 1:12
> character '' not supported here (state=42000,code=4){code}
> The reason is that org.apache.commons.cli.Util.stripLeadingAndTrailingQuotes
> in commons-cli-1.2.jar strips the trailing quote so the query string is
> changed to
> {code:java}
> select "hive{code}
> This bug is fixed in commons-cli-1.3.1 and commons-cli-1.4.jar. The
> workaround is to overwrite commons-cli-1.2.jar with commons-cli-1.3.1 or
> commons-cli-1.4.jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25095) Beeline/hive -e command can't deal with query with trailing quote
[
https://issues.apache.org/jira/browse/HIVE-25095?focusedWorklogId=627397=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627397
]
ASF GitHub Bot logged work on HIVE-25095:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 11:14
Start Date: 24/Jul/21 11:14
Worklog Time Spent: 10m
Work Description: ujc714 opened a new pull request #2255:
URL: https://github.com/apache/hive/pull/2255
…### What changes were proposed in this pull request?
Upgrade commons-cli to 1.4.
### Why are the changes needed?
There is a bug in commons-cli-1.2 which trips trailing quote improperly.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
mvn test -Dtest=org.apache.hive.beeline.cli.TestHiveCli
mvn test -Dtest=org.apache.hive.beeline.TestBeelineArgParsing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627397)
Time Spent: 50m (was: 40m)
> Beeline/hive -e command can't deal with query with trailing quote
> -
>
> Key: HIVE-25095
> URL: https://issues.apache.org/jira/browse/HIVE-25095
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The command
> {code:java}
> hive -e 'select "hive"'{code}
> and
> {code:java}
> beeline -e 'select "hive"'{code}
> fail with such error:
> {code:java}
> Error: Error while compiling statement: FAILED: ParseException line 1:12
> character '' not supported here (state=42000,code=4){code}
> The reason is that org.apache.commons.cli.Util.stripLeadingAndTrailingQuotes
> in commons-cli-1.2.jar strips the trailing quote so the query string is
> changed to
> {code:java}
> select "hive{code}
> This bug is fixed in commons-cli-1.3.1 and commons-cli-1.4.jar. The
> workaround is to overwrite commons-cli-1.2.jar with commons-cli-1.3.1 or
> commons-cli-1.4.jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25095) Beeline/hive -e command can't deal with query with trailing quote
[
https://issues.apache.org/jira/browse/HIVE-25095?focusedWorklogId=627394=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627394
]
ASF GitHub Bot logged work on HIVE-25095:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 11:13
Start Date: 24/Jul/21 11:13
Worklog Time Spent: 10m
Work Description: ujc714 opened a new pull request #2526:
URL: https://github.com/apache/hive/pull/2526
### What changes were proposed in this pull request?
Upgrade commons-cli to 1.4.
### Why are the changes needed?
There is a bug in commons-cli-1.2 which trips trailing quote improperly.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
mvn test -Dtest=org.apache.hive.beeline.cli.TestHiveCli
mvn test -Dtest=org.apache.hive.beeline.TestBeelineArgParsing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627394)
Time Spent: 20m (was: 10m)
> Beeline/hive -e command can't deal with query with trailing quote
> -
>
> Key: HIVE-25095
> URL: https://issues.apache.org/jira/browse/HIVE-25095
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The command
> {code:java}
> hive -e 'select "hive"'{code}
> and
> {code:java}
> beeline -e 'select "hive"'{code}
> fail with such error:
> {code:java}
> Error: Error while compiling statement: FAILED: ParseException line 1:12
> character '' not supported here (state=42000,code=4){code}
> The reason is that org.apache.commons.cli.Util.stripLeadingAndTrailingQuotes
> in commons-cli-1.2.jar strips the trailing quote so the query string is
> changed to
> {code:java}
> select "hive{code}
> This bug is fixed in commons-cli-1.3.1 and commons-cli-1.4.jar. The
> workaround is to overwrite commons-cli-1.2.jar with commons-cli-1.3.1 or
> commons-cli-1.4.jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25376) Iceberg vectorized ORC reads fail on reordered partition columns
[
https://issues.apache.org/jira/browse/HIVE-25376?focusedWorklogId=627386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627386
]
ASF GitHub Bot logged work on HIVE-25376:
-
Author: ASF GitHub Bot
Created on: 24/Jul/21 08:38
Start Date: 24/Jul/21 08:38
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #2523:
URL: https://github.com/apache/hive/pull/2523#discussion_r675969829
##
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java
##
@@ -60,7 +61,8 @@ private HiveVectorizedReader() {
public static CloseableIterable reader(InputFile inputFile,
FileScanTask task, Map idToConstant,
TaskAttemptContext context) {
-JobConf job = (JobConf) context.getConfiguration();
+// Tweaks on jobConf here are relevant for this task only, so we need to
copy it first as context's conf is reused..
Review comment:
Hm what I meant is that any changes we make to the jobConf instance in
the code below, should not affect anyone else. And for that reason I need to
take a copy of it and do the adjustments on the copied instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627386)
Time Spent: 0.5h (was: 20m)
> Iceberg vectorized ORC reads fail on reordered partition columns
>
>
> Key: HIVE-25376
> URL: https://issues.apache.org/jira/browse/HIVE-25376
> Project: Hive
> Issue Type: Bug
>Reporter: Ádám Szita
>Assignee: Ádám Szita
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Similarly to HIVE-25360 reordering partition columns can cause a problem,
> this time when constant value filling happens for partition columns. Column
> indices must be mapped to the current schema (which may contain the columns
> reordered)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
