[jira] [Work logged] (HIVE-25397) Snapshot support for controlled failover

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25397?focusedWorklogId=648392=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648392
 ]

ASF GitHub Bot logged work on HIVE-25397:
-

Author: ASF GitHub Bot
Created on: 09/Sep/21 05:35
Start Date: 09/Sep/21 05:35
Worklog Time Spent: 10m 
  Work Description: ArkoSharma closed pull request #2539:
URL: https://github.com/apache/hive/pull/2539


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648392)
Time Spent: 1h 10m  (was: 1h)

> Snapshot support for controlled failover
> 
>
> Key: HIVE-25397
> URL: https://issues.apache.org/jira/browse/HIVE-25397
> Project: Hive
>  Issue Type: Bug
>Reporter: Arko Sharma
>Assignee: Arko Sharma
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In case the same locations are used for external tables on the source and 
> target, then the snapshots created during replication can be re-used during 
> reverse replication. This patch enables re-using the snapshots  during 
> reverse replication using a configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25365) Insufficient privileges to show partitions when partition columns are authorized

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25365?focusedWorklogId=648391=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648391
 ]

ASF GitHub Bot logged work on HIVE-25365:
-

Author: ASF GitHub Bot
Created on: 09/Sep/21 05:17
Start Date: 09/Sep/21 05:17
Worklog Time Spent: 10m 
  Work Description: dengzhhu653 commented on pull request #2515:
URL: https://github.com/apache/hive/pull/2515#issuecomment-915771280


   Hi, @kgyrtkirk. any other comments about this pr?  
   Thanks,
   Zhihua Deng


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648391)
Time Spent: 40m  (was: 0.5h)

> Insufficient privileges to show partitions when partition columns are 
> authorized
> 
>
> Key: HIVE-25365
> URL: https://issues.apache.org/jira/browse/HIVE-25365
> Project: Hive
>  Issue Type: Bug
>  Components: Authorization
>Reporter: Zhihua Deng
>Assignee: Zhihua Deng
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When the privileges of partition columns have granted to users, showing 
> partitions still needs select privilege on the table, though they are able to 
> query from partition columns.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-23633) Metastore some JDO query objects do not close properly

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=648390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648390
 ]

ASF GitHub Bot logged work on HIVE-23633:
-

Author: ASF GitHub Bot
Created on: 09/Sep/21 05:15
Start Date: 09/Sep/21 05:15
Worklog Time Spent: 10m 
  Work Description: dengzhhu653 commented on pull request #2344:
URL: https://github.com/apache/hive/pull/2344#issuecomment-915770438


   Hi @pvary, any comments about the latest changes?   
   Thanks,
   Zhihua Deng


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648390)
Time Spent: 13h  (was: 12h 50m)

> Metastore some JDO query objects do not close properly
> --
>
> Key: HIVE-23633
> URL: https://issues.apache.org/jira/browse/HIVE-23633
> Project: Hive
>  Issue Type: Bug
>Reporter: Zhihua Deng
>Assignee: Zhihua Deng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-23633.01.patch
>
>  Time Spent: 13h
>  Remaining Estimate: 0h
>
> After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895],  
> The metastore still has seen a memory leak on db resources: many 
> StatementImpls left unclosed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25365) Insufficient privileges to show partitions when partition columns are authorized

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25365?focusedWorklogId=648386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648386
 ]

ASF GitHub Bot logged work on HIVE-25365:
-

Author: ASF GitHub Bot
Created on: 09/Sep/21 04:56
Start Date: 09/Sep/21 04:56
Worklog Time Spent: 10m 
  Work Description: dengzhhu653 removed a comment on pull request #2515:
URL: https://github.com/apache/hive/pull/2515#issuecomment-907565160


   Hi @kgyrtkirk, cloud this changes be merged if have no problem? 
   Thanks,
   Zhihua Deng


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648386)
Time Spent: 0.5h  (was: 20m)

> Insufficient privileges to show partitions when partition columns are 
> authorized
> 
>
> Key: HIVE-25365
> URL: https://issues.apache.org/jira/browse/HIVE-25365
> Project: Hive
>  Issue Type: Bug
>  Components: Authorization
>Reporter: Zhihua Deng
>Assignee: Zhihua Deng
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When the privileges of partition columns have granted to users, showing 
> partitions still needs select privilege on the table, though they are able to 
> query from partition columns.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-25498) Query with more than 31 count distinct functions returns wrong result

2021-09-08 Thread Robbie Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Zhang updated HIVE-25498:

Summary: Query with more than 31 count distinct functions returns wrong 
result  (was: Query with more than 32 count distinct functions returns wrong 
result)

> Query with more than 31 count distinct functions returns wrong result
> -
>
> Key: HIVE-25498
> URL: https://issues.apache.org/jira/browse/HIVE-25498
> Project: Hive
>  Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If there are more than 32 "COUNT(DISTINCT COL)" functions in a query, all 
> these COUNT functions in this query return 0 instead of the proper values.
> Here are the queries to reproduce this issue:
> {code:java}
> set hive.cbo.enable=true;
> create table test_count (c0 string, c1 string, c2 string, c3 string, c4 
> string, c5 string, c6 string, c7 string, c8 string, c9 string, c10 string, 
> c11 string, c12 string, c13 string, c14 string, c15 string, c16 string, c17 
> string, c18 string, c19 string, c20 string, c21 string, c22 string, c23 
> string, c24 string, c25 string, c26 string, c27 string, c28 string, c29 
> string, c30 string, c31 string, c32 string);
> INSERT INTO test_count values ('c0', 'c1', 'c2', 'c3', 'c4', 'c5', 'c6', 
> 'c7', 'c8', 'c9', 'c10', 'c11', 'c12', 'c13', 'c14', 'c15', 'c16', 'c17', 
> 'c18', 'c19', 'c20', 'c21', 'c22', 'c23', 'c24', 'c25', 'c26', 'c27', 'c28', 
> 'c29', 'c30', 'c31', 'c32'); 
> select count (distinct c0), count(distinct c1), count(distinct c2), 
> count(distinct c3), count(distinct c4), count(distinct c5), count(distinct 
> c6), count(distinct c7), count(distinct c8), count(distinct c9), 
> count(distinct c10), count(distinct c11), count(distinct c12), count(distinct 
> c13), count(distinct c14), count(distinct c15), count(distinct c16), 
> count(distinct c17), count(distinct c18), count(distinct c19), count(distinct 
> c20), count(distinct c21), count(distinct c22), count(distinct c23), 
> count(distinct c24), count(distinct c25), count(distinct c26), count(distinct 
> c27), count(distinct c28), count(distinct c29), count(distinct c30), 
> count(distinct c31), count(distinct c32) from test_count;
> {code}
>  This bug is caused by HiveExpandDistinctAggregatesRule.getGroupingIdValue() 
> which uses int type. When there are more than 32 groupings the values 
> overflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-25498) Query with more than 31 count distinct functions returns wrong result

2021-09-08 Thread Robbie Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Zhang updated HIVE-25498:

Description: 
If there are more than 32 "COUNT(DISTINCT COL)" functions in a query, some or 
even all these COUNT functions in this query return 0 instead of the proper 
values.

Here are the queries to reproduce this issue:
{code:java}
set hive.cbo.enable=true;
create table test_count (c0 string, c1 string, c2 string, c3 string, c4 string, 
c5 string, c6 string, c7 string, c8 string, c9 string, c10 string, c11 string, 
c12 string, c13 string, c14 string, c15 string, c16 string, c17 string, c18 
string, c19 string, c20 string, c21 string, c22 string, c23 string, c24 string, 
c25 string, c26 string, c27 string, c28 string, c29 string, c30 string, c31 
string, c32 string);
INSERT INTO test_count values ('c0', 'c1', 'c2', 'c3', 'c4', 'c5', 'c6', 'c7', 
'c8', 'c9', 'c10', 'c11', 'c12', 'c13', 'c14', 'c15', 'c16', 'c17', 'c18', 
'c19', 'c20', 'c21', 'c22', 'c23', 'c24', 'c25', 'c26', 'c27', 'c28', 'c29', 
'c30', 'c31', 'c32'); 
select count (distinct c0), count(distinct c1), count(distinct c2), 
count(distinct c3), count(distinct c4), count(distinct c5), count(distinct c6), 
count(distinct c7), count(distinct c8), count(distinct c9), count(distinct 
c10), count(distinct c11), count(distinct c12), count(distinct c13), 
count(distinct c14), count(distinct c15), count(distinct c16), count(distinct 
c17), count(distinct c18), count(distinct c19), count(distinct c20), 
count(distinct c21), count(distinct c22), count(distinct c23), count(distinct 
c24), count(distinct c25), count(distinct c26), count(distinct c27), 
count(distinct c28), count(distinct c29), count(distinct c30), count(distinct 
c31), count(distinct c32) from test_count;
{code}
 This bug is caused by HiveExpandDistinctAggregatesRule.getGroupingIdValue() 
which uses int type. When there are more than 32 groupings the values overflow.

  was:
If there are more than 32 "COUNT(DISTINCT COL)" functions in a query, all these 
COUNT functions in this query return 0 instead of the proper values.

Here are the queries to reproduce this issue:
{code:java}
set hive.cbo.enable=true;
create table test_count (c0 string, c1 string, c2 string, c3 string, c4 string, 
c5 string, c6 string, c7 string, c8 string, c9 string, c10 string, c11 string, 
c12 string, c13 string, c14 string, c15 string, c16 string, c17 string, c18 
string, c19 string, c20 string, c21 string, c22 string, c23 string, c24 string, 
c25 string, c26 string, c27 string, c28 string, c29 string, c30 string, c31 
string, c32 string);
INSERT INTO test_count values ('c0', 'c1', 'c2', 'c3', 'c4', 'c5', 'c6', 'c7', 
'c8', 'c9', 'c10', 'c11', 'c12', 'c13', 'c14', 'c15', 'c16', 'c17', 'c18', 
'c19', 'c20', 'c21', 'c22', 'c23', 'c24', 'c25', 'c26', 'c27', 'c28', 'c29', 
'c30', 'c31', 'c32'); 
select count (distinct c0), count(distinct c1), count(distinct c2), 
count(distinct c3), count(distinct c4), count(distinct c5), count(distinct c6), 
count(distinct c7), count(distinct c8), count(distinct c9), count(distinct 
c10), count(distinct c11), count(distinct c12), count(distinct c13), 
count(distinct c14), count(distinct c15), count(distinct c16), count(distinct 
c17), count(distinct c18), count(distinct c19), count(distinct c20), 
count(distinct c21), count(distinct c22), count(distinct c23), count(distinct 
c24), count(distinct c25), count(distinct c26), count(distinct c27), 
count(distinct c28), count(distinct c29), count(distinct c30), count(distinct 
c31), count(distinct c32) from test_count;
{code}
 This bug is caused by HiveExpandDistinctAggregatesRule.getGroupingIdValue() 
which uses int type. When there are more than 32 groupings the values overflow.


> Query with more than 31 count distinct functions returns wrong result
> -
>
> Key: HIVE-25498
> URL: https://issues.apache.org/jira/browse/HIVE-25498
> Project: Hive
>  Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If there are more than 32 "COUNT(DISTINCT COL)" functions in a query, some or 
> even all these COUNT functions in this query return 0 instead of the proper 
> values.
> Here are the queries to reproduce this issue:
> {code:java}
> set hive.cbo.enable=true;
> create table test_count (c0 string, c1 string, c2 string, c3 string, c4 
> string, c5 string, c6 string, c7 string, c8 string, c9 string, c10 string, 
> c11 string, c12 string, c13 string, c14 string, c15 string, c16 string, c17 
> string, c18 string, c19 string, c20 string, c21 string, c22 string, c23 
> string, c24 string, c25 string, c26 string, c27 string, c28 string, c29 
> string, c30 string, c31 

[jira] [Updated] (HIVE-25506) Ignore mulitple password sources in JdbcStorageHandler.

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-25506:
--
Labels: pull-request-available  (was: )

> Ignore mulitple password sources in JdbcStorageHandler.
> ---
>
> Key: HIVE-25506
> URL: https://issues.apache.org/jira/browse/HIVE-25506
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Harish JP
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The https://issues.apache.org/jira/browse/HIVE-25445 introduced check against 
> setting multiple sources. But the implementation is flawed, since the 
> password is set in JobConf and we merge JobConf and TableDesc properties. 
> This results in the exception being thrown when executing a part of Tez job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25506) Ignore mulitple password sources in JdbcStorageHandler.

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25506?focusedWorklogId=648264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648264
 ]

ASF GitHub Bot logged work on HIVE-25506:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 23:08
Start Date: 08/Sep/21 23:08
Worklog Time Spent: 10m 
  Work Description: harishjp opened a new pull request #2625:
URL: https://github.com/apache/hive/pull/2625


   Removing multiple source check to prevent job failure. 
   
   Tested using UT and in a cluster with these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648264)
Remaining Estimate: 0h
Time Spent: 10m

> Ignore mulitple password sources in JdbcStorageHandler.
> ---
>
> Key: HIVE-25506
> URL: https://issues.apache.org/jira/browse/HIVE-25506
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Harish JP
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The https://issues.apache.org/jira/browse/HIVE-25445 introduced check against 
> setting multiple sources. But the implementation is flawed, since the 
> password is set in JobConf and we merge JobConf and TableDesc properties. 
> This results in the exception being thrown when executing a part of Tez job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-25445) Enable JdbcStorageHandler to get password from AWS Secrets Service.

2021-09-08 Thread Harish JP (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harish JP updated HIVE-25445:
-
   Fix Version/s: 4.0.0
Target Version/s: 4.0.0
  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

> Enable JdbcStorageHandler to get password from AWS Secrets Service.
> ---
>
> Key: HIVE-25445
> URL: https://issues.apache.org/jira/browse/HIVE-25445
> Project: Hive
>  Issue Type: New Feature
>  Components: HiveServer2
>Reporter: Harish JP
>Assignee: Harish JP
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, password for JdbcStorageHandler can be set only via the password 
> field or keystore. This Jira is to add framework to fetch password from any 
> source and implement AWS Secrets Manager as a source.
>  
> The approach takes is to use a new table property dbcp.password.uri which 
> will be used if password and keyfile are not available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25468) Create/Drop functions should be authorized in HMS

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25468?focusedWorklogId=648120=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648120
 ]

ASF GitHub Bot logged work on HIVE-25468:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 17:58
Start Date: 08/Sep/21 17:58
Worklog Time Spent: 10m 
  Work Description: nrg4878 commented on a change in pull request #2595:
URL: https://github.com/apache/hive/pull/2595#discussion_r704611073



##
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/PreCreateFunctionEvent.java
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hadoop.hive.metastore.events;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.hadoop.hive.metastore.IHMSHandler;
+import org.apache.hadoop.hive.metastore.api.Function;
+import org.apache.hadoop.hive.metastore.api.Table;

Review comment:
   Unnecessary import ?

##
File path: 
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
##
@@ -180,7 +180,7 @@ public void testCreateFunctionDefaultValues() throws 
Exception {
 
 Function createdFunction = client.getFunction(function.getDbName(),
 function.getFunctionName());
-Assert.assertNull("Comparing OwnerName", createdFunction.getOwnerName());
+Assert.assertEquals("Comparing OwnerName", createdFunction.getOwnerName(), 
createdFunction.getOwnerName());

Review comment:
   Comparing the same values (createdFunction.getOwnerName())  will 
obviously be true.

##
File path: 
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/DropFunctionEvent.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package 
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hive.metastore.api.Function;
+import org.apache.hadoop.hive.metastore.api.ResourceUri;
+import org.apache.hadoop.hive.metastore.events.PreCreateFunctionEvent;
+import org.apache.hadoop.hive.metastore.events.PreDropFunctionEvent;
+import org.apache.hadoop.hive.metastore.events.PreEventContext;
+import 
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveOperationType;
+import 
org.apache.hadoop.hive.ql.security.authorization.plugin.HivePrivilegeObject;
+import 
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizableEvent;
+import 
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthzInfo;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/*
+ Authorizable Event for HiveMetaStore operation DropFunction
+ */
+public class DropFunctionEvent extends HiveMetaStoreAuthorizableEvent {
+private static final Logger LOG = 
LoggerFactory.getLogger(DropFunctionEvent.class);
+
+private String COMMAND_STR = "drop function";
+
+public DropFunctionEvent(PreEventContext preEventContext) {
+super(preEventContext);
+}
+
+@Override
+public HiveMetaStoreAuthzInfo getAuthzContext() {
+

[jira] [Work logged] (HIVE-24484) Upgrade Hadoop to 3.3.1

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-24484?focusedWorklogId=648096=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648096
 ]

ASF GitHub Bot logged work on HIVE-24484:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 17:10
Start Date: 08/Sep/21 17:10
Worklog Time Spent: 10m 
  Work Description: ayushtkn commented on pull request #1742:
URL: https://github.com/apache/hive/pull/1742#issuecomment-915417026


   Seems the tests are failing with
   ``
   java.lang.NoSuchMethodError: 
org.jline.reader.impl.completer.StringsCompleter.([Lorg/jline/reader/Candidate;)V
   ``
   Should be fixable in the Hive Code itself?
   If there is something required in the Hadoop Code, we can get that in now, 
3.3.2 release is being planned out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648096)
Time Spent: 5h 43m  (was: 5.55h)

> Upgrade Hadoop to 3.3.1
> ---
>
> Key: HIVE-24484
> URL: https://issues.apache.org/jira/browse/HIVE-24484
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 5h 43m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25500) Switch back to alter_partition(s) in HMS client for Hive 2.3.x

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25500?focusedWorklogId=648094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648094
 ]

ASF GitHub Bot logged work on HIVE-25500:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 17:09
Start Date: 08/Sep/21 17:09
Worklog Time Spent: 10m 
  Work Description: sunchao merged pull request #2618:
URL: https://github.com/apache/hive/pull/2618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648094)
Time Spent: 20m  (was: 10m)

> Switch back to alter_partition(s) in HMS client for Hive 2.3.x
> --
>
> Key: HIVE-25500
> URL: https://issues.apache.org/jira/browse/HIVE-25500
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 2.3.9
>Reporter: dzcxzl
>Assignee: dzcxzl
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> HIVE-12730 uses alter_partition_with_environment_context and 
> alter_partitions_with_environment_context instead of alter_partition and 
> alter_partitions when the EnvironmentContext is null.
>  This causes the client version to be greater than 2.1 to connect to 
> server<2.1, and this error will occur.
> {code:java}
> Caused by: org.apache.thrift.TApplicationException: Invalid method name: 
> 'alter_partitions_with_environment_context'
>   at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
>   at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HIVE-25500) Switch back to alter_partition(s) in HMS client for Hive 2.3.x

2021-09-08 Thread Chao Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chao Sun resolved HIVE-25500.
-
Fix Version/s: 2.3.9
   Resolution: Fixed

> Switch back to alter_partition(s) in HMS client for Hive 2.3.x
> --
>
> Key: HIVE-25500
> URL: https://issues.apache.org/jira/browse/HIVE-25500
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 2.3.9
>Reporter: dzcxzl
>Assignee: dzcxzl
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.3.9
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> HIVE-12730 uses alter_partition_with_environment_context and 
> alter_partitions_with_environment_context instead of alter_partition and 
> alter_partitions when the EnvironmentContext is null.
>  This causes the client version to be greater than 2.1 to connect to 
> server<2.1, and this error will occur.
> {code:java}
> Caused by: org.apache.thrift.TApplicationException: Invalid method name: 
> 'alter_partitions_with_environment_context'
>   at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
>   at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25500) Switch back to alter_partition(s) in HMS client for Hive 2.3.x

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25500?focusedWorklogId=648095=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648095
 ]

ASF GitHub Bot logged work on HIVE-25500:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 17:09
Start Date: 08/Sep/21 17:09
Worklog Time Spent: 10m 
  Work Description: sunchao commented on pull request #2618:
URL: https://github.com/apache/hive/pull/2618#issuecomment-915416210


   Merged to branch-2.3 Thanks @cxzl25 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648095)
Time Spent: 0.5h  (was: 20m)

> Switch back to alter_partition(s) in HMS client for Hive 2.3.x
> --
>
> Key: HIVE-25500
> URL: https://issues.apache.org/jira/browse/HIVE-25500
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 2.3.9
>Reporter: dzcxzl
>Assignee: dzcxzl
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> HIVE-12730 uses alter_partition_with_environment_context and 
> alter_partitions_with_environment_context instead of alter_partition and 
> alter_partitions when the EnvironmentContext is null.
>  This causes the client version to be greater than 2.1 to connect to 
> server<2.1, and this error will occur.
> {code:java}
> Caused by: org.apache.thrift.TApplicationException: Invalid method name: 
> 'alter_partitions_with_environment_context'
>   at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
>   at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-25505) Incorrect results with header. skip.header.line.count if first line is blank

2021-09-08 Thread Zoltan Haindrich (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412069#comment-17412069
 ] 

Zoltan Haindrich commented on HIVE-25505:
-

I thinked we've already fixed this - however I just found HIVE-19943 which is 
still unresolved

> Incorrect results with header. skip.header.line.count if first line is blank
> 
>
> Key: HIVE-25505
> URL: https://issues.apache.org/jira/browse/HIVE-25505
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Steve Carlin
>Priority: Major
>
> aAtable with header. skip.header.line.count=1 does not skip the first line if 
> it is blank, except in a fetch task.
> To reproduce, create a csv table, ans set header. skip.header.line.count=1 in 
> table properties.
> In the table location, create a single file, with a blank (empty) first line, 
> and say 2 further lines.
> If you do a select * on it, you see 2 rows (correct)
> If you do select count(\*) on it, you get 3 (incorrect)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25303) CTAS hive.create.as.external.legacy tries to place data files in managed WH path

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25303?focusedWorklogId=648057=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648057
 ]

ASF GitHub Bot logged work on HIVE-25303:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 16:06
Start Date: 08/Sep/21 16:06
Worklog Time Spent: 10m 
  Work Description: kgyrtkirk commented on a change in pull request #2442:
URL: https://github.com/apache/hive/pull/2442#discussion_r704566022



##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java
##
@@ -472,6 +474,28 @@ private void setLoadFileLocation(
   loc = cmv.getLocation();
 }
 Path location = (loc == null) ? getDefaultCtasLocation(pCtx) : new 
Path(loc);
+if (pCtx.getQueryProperties().isCTAS()) {
+  boolean isExternal = pCtx.getCreateTable().isExternal();
+  boolean isAcid = pCtx.getCreateTable().getTblProps().getOrDefault(
+  hive_metastoreConstants.TABLE_IS_TRANSACTIONAL, 
"false").equalsIgnoreCase("true") ||
+  
pCtx.getCreateTable().getTblProps().containsKey(hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES);
+  if ((HiveConf.getBoolVar(conf, 
HiveConf.ConfVars.CREATE_TABLE_AS_EXTERNAL) || isExternal) && !isAcid) {

Review comment:
   I think this condition should be removed - let the transformer decide in 
which case it wants to act

##
File path: ql/src/test/results/clientpositive/llap/tez_join_result_complex.q.out
##
@@ -298,6 +298,7 @@ STAGE PLANS:
   bucketing_version -1
   columns 
contact_event_id,ce_create_dt,ce_end_dt,contact_type,cnctevs_cd,contact_mode,cntvnst_stts_cd,total_transfers,ce_notes,svcrqst_id,svcrqct_cds,svcrtyp_cd,cmpltyp_cd,src,cnctmd_cd,notes
   columns.types 
string:string:string:string:string:string:string:int:array:string:array:string:string:string:string:array
+  created_with_ctas true

Review comment:
   do you know what is this - and why it started appearing with this patch?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648057)
Time Spent: 2h 40m  (was: 2.5h)

> CTAS hive.create.as.external.legacy tries to place data files in managed WH 
> path
> 
>
> Key: HIVE-25303
> URL: https://issues.apache.org/jira/browse/HIVE-25303
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2, Standalone Metastore
>Reporter: Sai Hemanth Gantasala
>Assignee: Sai Hemanth Gantasala
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Under legacy table creation mode (hive.create.as.external.legacy=true), when 
> a database has been created in a specific LOCATION, in a session where that 
> database is Used, tables are created using the following command:
> {code:java}
> CREATE TABLE  AS SELECT {code}
> should inherit the HDFS path from the database's location. Instead, Hive is 
> trying to write the table data into 
> /warehouse/tablespace/managed/hive//
> +Design+: 
> In the CTAS query, first data is written in the target directory (which 
> happens in HS2) and then the table is created(This happens in HMS). So here 
> two decisions are being made i) target directory location ii) how the table 
> should be created (table type, sd e.t.c).
> When HS2 needs a target location that needs to be set, it'll make create 
> table dry run call to HMS (where table translation happens) and i) and ii) 
> decisions are made within HMS and returns table object. Then HS2 will use 
> this location set by HMS for placing the data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25498) Query with more than 32 count distinct functions returns wrong result

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25498?focusedWorklogId=648041=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648041
 ]

ASF GitHub Bot logged work on HIVE-25498:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 15:48
Start Date: 08/Sep/21 15:48
Worklog Time Spent: 10m 
  Work Description: pgaref commented on pull request #2616:
URL: https://github.com/apache/hive/pull/2616#issuecomment-915356626


   > @ujc714
   > With this patch the maximum number of `count(distinct)` expressions can be 
handled by the `HiveExpandDistinctAggregatesRule` is increased to 63 from 31. 
But this limitation still exists. Could you please add a check here:
   > 
https://github.com/apache/hive/blob/72d860ad7721e705c830ca5f141a79e899cc86f7/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java#L115
   > 
   > like
   > 
   > ```
   >   if (numCountDistinct == 0 || numCountDistinct > 63 || 
aggregate.getGroupType() != Group.SIMPLE) {
   >   return;
   >   }
   > ```
   
   Agree with @kasakrisz -- an alternative would be to change 
**getGroupingIdValue** logic but that could be tricky.
   At the end of the day we should not be limited by the number of count 
distinct functions so having this extra check as part of the onMatch method 
makes sense to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 648041)
Time Spent: 0.5h  (was: 20m)

> Query with more than 32 count distinct functions returns wrong result
> -
>
> Key: HIVE-25498
> URL: https://issues.apache.org/jira/browse/HIVE-25498
> Project: Hive
>  Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If there are more than 32 "COUNT(DISTINCT COL)" functions in a query, all 
> these COUNT functions in this query return 0 instead of the proper values.
> Here are the queries to reproduce this issue:
> {code:java}
> set hive.cbo.enable=true;
> create table test_count (c0 string, c1 string, c2 string, c3 string, c4 
> string, c5 string, c6 string, c7 string, c8 string, c9 string, c10 string, 
> c11 string, c12 string, c13 string, c14 string, c15 string, c16 string, c17 
> string, c18 string, c19 string, c20 string, c21 string, c22 string, c23 
> string, c24 string, c25 string, c26 string, c27 string, c28 string, c29 
> string, c30 string, c31 string, c32 string);
> INSERT INTO test_count values ('c0', 'c1', 'c2', 'c3', 'c4', 'c5', 'c6', 
> 'c7', 'c8', 'c9', 'c10', 'c11', 'c12', 'c13', 'c14', 'c15', 'c16', 'c17', 
> 'c18', 'c19', 'c20', 'c21', 'c22', 'c23', 'c24', 'c25', 'c26', 'c27', 'c28', 
> 'c29', 'c30', 'c31', 'c32'); 
> select count (distinct c0), count(distinct c1), count(distinct c2), 
> count(distinct c3), count(distinct c4), count(distinct c5), count(distinct 
> c6), count(distinct c7), count(distinct c8), count(distinct c9), 
> count(distinct c10), count(distinct c11), count(distinct c12), count(distinct 
> c13), count(distinct c14), count(distinct c15), count(distinct c16), 
> count(distinct c17), count(distinct c18), count(distinct c19), count(distinct 
> c20), count(distinct c21), count(distinct c22), count(distinct c23), 
> count(distinct c24), count(distinct c25), count(distinct c26), count(distinct 
> c27), count(distinct c28), count(distinct c29), count(distinct c30), 
> count(distinct c31), count(distinct c32) from test_count;
> {code}
>  This bug is caused by HiveExpandDistinctAggregatesRule.getGroupingIdValue() 
> which uses int type. When there are more than 32 groupings the values 
> overflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25498) Query with more than 32 count distinct functions returns wrong result

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25498?focusedWorklogId=647963=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647963
 ]

ASF GitHub Bot logged work on HIVE-25498:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 13:32
Start Date: 08/Sep/21 13:32
Worklog Time Spent: 10m 
  Work Description: kasakrisz commented on pull request #2616:
URL: https://github.com/apache/hive/pull/2616#issuecomment-915242945


   @ujc714 
   With this patch the maximum number of `count(distinct)` expressions can be 
handled by the `HiveExpandDistinctAggregatesRule` is increased to 63 from 31. 
But this limitation still exists. Could you please add a check here:
   
https://github.com/apache/hive/blob/72d860ad7721e705c830ca5f141a79e899cc86f7/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java#L115
   
   like 
   ```
 if (numCountDistinct == 0 || numCountDistinct > 63 || 
aggregate.getGroupType() != Group.SIMPLE) {
 return;
 }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 647963)
Time Spent: 20m  (was: 10m)

> Query with more than 32 count distinct functions returns wrong result
> -
>
> Key: HIVE-25498
> URL: https://issues.apache.org/jira/browse/HIVE-25498
> Project: Hive
>  Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If there are more than 32 "COUNT(DISTINCT COL)" functions in a query, all 
> these COUNT functions in this query return 0 instead of the proper values.
> Here are the queries to reproduce this issue:
> {code:java}
> set hive.cbo.enable=true;
> create table test_count (c0 string, c1 string, c2 string, c3 string, c4 
> string, c5 string, c6 string, c7 string, c8 string, c9 string, c10 string, 
> c11 string, c12 string, c13 string, c14 string, c15 string, c16 string, c17 
> string, c18 string, c19 string, c20 string, c21 string, c22 string, c23 
> string, c24 string, c25 string, c26 string, c27 string, c28 string, c29 
> string, c30 string, c31 string, c32 string);
> INSERT INTO test_count values ('c0', 'c1', 'c2', 'c3', 'c4', 'c5', 'c6', 
> 'c7', 'c8', 'c9', 'c10', 'c11', 'c12', 'c13', 'c14', 'c15', 'c16', 'c17', 
> 'c18', 'c19', 'c20', 'c21', 'c22', 'c23', 'c24', 'c25', 'c26', 'c27', 'c28', 
> 'c29', 'c30', 'c31', 'c32'); 
> select count (distinct c0), count(distinct c1), count(distinct c2), 
> count(distinct c3), count(distinct c4), count(distinct c5), count(distinct 
> c6), count(distinct c7), count(distinct c8), count(distinct c9), 
> count(distinct c10), count(distinct c11), count(distinct c12), count(distinct 
> c13), count(distinct c14), count(distinct c15), count(distinct c16), 
> count(distinct c17), count(distinct c18), count(distinct c19), count(distinct 
> c20), count(distinct c21), count(distinct c22), count(distinct c23), 
> count(distinct c24), count(distinct c25), count(distinct c26), count(distinct 
> c27), count(distinct c28), count(distinct c29), count(distinct c30), 
> count(distinct c31), count(distinct c32) from test_count;
> {code}
>  This bug is caused by HiveExpandDistinctAggregatesRule.getGroupingIdValue() 
> which uses int type. When there are more than 32 groupings the values 
> overflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25346) cleanTxnToWriteIdTable breaks SNAPSHOT isolation

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25346?focusedWorklogId=647928=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647928
 ]

ASF GitHub Bot logged work on HIVE-25346:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 12:41
Start Date: 08/Sep/21 12:41
Worklog Time Spent: 10m 
  Work Description: zchovan commented on pull request #2547:
URL: https://github.com/apache/hive/pull/2547#issuecomment-915204071


   @deniskuzZ I did some benchmarks on commitTxns, please find the results 
below:
   
   
   `
   Before HIVE-25346
   
   Result 
"org.apache.hadoop.hive.metastore.tools.ACIDBenchmarks.TestOpenTxn.openTxn":
 N = 100
 mean = 58.136 ±(99.9%) 1.757 ms/op
   
 Histogram, ms/op:
   [40.000, 42.500) = 0
   [42.500, 45.000) = 0
   [45.000, 47.500) = 0
   [47.500, 50.000) = 2
   [50.000, 52.500) = 11
   [52.500, 55.000) = 14
   [55.000, 57.500) = 20
   [57.500, 60.000) = 26
   [60.000, 62.500) = 13
   [62.500, 65.000) = 7
   [65.000, 67.500) = 1
   [67.500, 70.000) = 3
   [70.000, 72.500) = 0
   [72.500, 75.000) = 1
   [75.000, 77.500) = 1
   
 Percentiles, ms/op:
 p(0.) = 49.111 ms/op
p(50.) = 57.856 ms/op
p(90.) = 63.579 ms/op
p(95.) = 67.901 ms/op
p(99.) = 79.537 ms/op
p(99.9000) = 79.567 ms/op
p(99.9900) = 79.567 ms/op
p(99.9990) = 79.567 ms/op
p(99.) = 79.567 ms/op
   p(100.) = 79.567 ms/op
   
   
   After HIVE-25346
   
   
   Result 
"org.apache.hadoop.hive.metastore.tools.ACIDBenchmarks.TestOpenTxn.openTxn":
 N = 100
 mean = 51.015 ±(99.9%) 2.947 ms/op
   
 Histogram, ms/op:
   [30.000, 35.000) = 0
   [35.000, 40.000) = 3
   [40.000, 45.000) = 26
   [45.000, 50.000) = 27
   [50.000, 55.000) = 17
   [55.000, 60.000) = 11
   [60.000, 65.000) = 9
   [65.000, 70.000) = 4
   [70.000, 75.000) = 1
   [75.000, 80.000) = 1
   [80.000, 85.000) = 1
   
 Percentiles, ms/op:
 p(0.) = 38.385 ms/op
p(50.) = 48.248 ms/op
p(90.) = 64.176 ms/op
p(95.) = 68.280 ms/op
p(99.) = 81.816 ms/op
p(99.9000) = 81.838 ms/op
p(99.9900) = 81.838 ms/op
p(99.9990) = 81.838 ms/op
p(99.) = 81.838 ms/op
   p(100.) = 81.838 ms/op
   
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 647928)
Time Spent: 4h 40m  (was: 4.5h)

> cleanTxnToWriteIdTable breaks SNAPSHOT isolation
> 
>
> Key: HIVE-25346
> URL: https://issues.apache.org/jira/browse/HIVE-25346
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22247) HiveHFileOutputFormat throws FileNotFoundException when partition's task output empty

2021-09-08 Thread Aasha Medhi (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411865#comment-17411865
 ] 

Aasha Medhi commented on HIVE-22247:


Thank you for the patch [~ayushtkn]. Committed to master.

> HiveHFileOutputFormat throws FileNotFoundException when partition's task 
> output empty
> -
>
> Key: HIVE-22247
> URL: https://issues.apache.org/jira/browse/HIVE-22247
> Project: Hive
>  Issue Type: Bug
>  Components: HBase Handler
>Affects Versions: 2.2.0, 3.0.0
>Reporter: xiepengjie
>Assignee: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When partition's task output empty, HiveHFileOutputFormat throws 
> FileNotFoundException like this:
> {code:java}
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: 1 finished. closing... 
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: FS[1]: records written - 0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Writing to temp file: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: New Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,915 INFO [main] 
> org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: File Output 
> Committer Algorithm version is 1
> 2019-09-24 19:15:55,954 INFO [main] 
> org.apache.hadoop.conf.Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 2019-09-24 19:15:56,089 ERROR [main] ExecReducer: Hit error while closing 
> operators - failing tree
> 2019-09-24 19:15:56,090 WARN [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child : java.lang.RuntimeException: Hive Runtime Error 
> while closing operators: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:287)
>   at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:453)
>   at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392)
>   at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1923)
>   at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:200)
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:1016)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:617)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:631)
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:278)
>   ... 7 more
> Caused by: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:880)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.access$700(DistributedFileSystem.java:109)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:938)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:934)
>   at 
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:945)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1592)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1632)
>   at 
> 

[jira] [Work logged] (HIVE-22247) HiveHFileOutputFormat throws FileNotFoundException when partition's task output empty

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22247?focusedWorklogId=647890=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647890
 ]

ASF GitHub Bot logged work on HIVE-22247:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 11:14
Start Date: 08/Sep/21 11:14
Worklog Time Spent: 10m 
  Work Description: aasha merged pull request #2609:
URL: https://github.com/apache/hive/pull/2609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 647890)
Time Spent: 20m  (was: 10m)

> HiveHFileOutputFormat throws FileNotFoundException when partition's task 
> output empty
> -
>
> Key: HIVE-22247
> URL: https://issues.apache.org/jira/browse/HIVE-22247
> Project: Hive
>  Issue Type: Bug
>  Components: HBase Handler
>Affects Versions: 2.2.0, 3.0.0
>Reporter: xiepengjie
>Assignee: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When partition's task output empty, HiveHFileOutputFormat throws 
> FileNotFoundException like this:
> {code:java}
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: 1 finished. closing... 
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: FS[1]: records written - 0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Writing to temp file: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: New Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,915 INFO [main] 
> org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: File Output 
> Committer Algorithm version is 1
> 2019-09-24 19:15:55,954 INFO [main] 
> org.apache.hadoop.conf.Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 2019-09-24 19:15:56,089 ERROR [main] ExecReducer: Hit error while closing 
> operators - failing tree
> 2019-09-24 19:15:56,090 WARN [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child : java.lang.RuntimeException: Hive Runtime Error 
> while closing operators: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:287)
>   at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:453)
>   at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392)
>   at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1923)
>   at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:200)
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:1016)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:617)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:631)
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:278)
>   ... 7 more
> Caused by: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:880)
> 

[jira] [Resolved] (HIVE-22247) HiveHFileOutputFormat throws FileNotFoundException when partition's task output empty

2021-09-08 Thread Aasha Medhi (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aasha Medhi resolved HIVE-22247.

Resolution: Fixed

> HiveHFileOutputFormat throws FileNotFoundException when partition's task 
> output empty
> -
>
> Key: HIVE-22247
> URL: https://issues.apache.org/jira/browse/HIVE-22247
> Project: Hive
>  Issue Type: Bug
>  Components: HBase Handler
>Affects Versions: 2.2.0, 3.0.0
>Reporter: xiepengjie
>Assignee: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When partition's task output empty, HiveHFileOutputFormat throws 
> FileNotFoundException like this:
> {code:java}
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: 1 finished. closing... 
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: FS[1]: records written - 0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Writing to temp file: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: New Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,915 INFO [main] 
> org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: File Output 
> Committer Algorithm version is 1
> 2019-09-24 19:15:55,954 INFO [main] 
> org.apache.hadoop.conf.Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 2019-09-24 19:15:56,089 ERROR [main] ExecReducer: Hit error while closing 
> operators - failing tree
> 2019-09-24 19:15:56,090 WARN [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child : java.lang.RuntimeException: Hive Runtime Error 
> while closing operators: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:287)
>   at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:453)
>   at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392)
>   at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1923)
>   at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:200)
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:1016)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:617)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:631)
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:278)
>   ... 7 more
> Caused by: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:880)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.access$700(DistributedFileSystem.java:109)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:938)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:934)
>   at 
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:945)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1592)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1632)
>   at 
> 

[jira] [Assigned] (HIVE-25502) Cleaner causes data loss when processing aborted txn with DP

2021-09-08 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko reassigned HIVE-25502:
-

Assignee: Denys Kuzmenko

> Cleaner causes data loss when processing aborted txn with DP 
> -
>
> Key: HIVE-25502
> URL: https://issues.apache.org/jira/browse/HIVE-25502
> Project: Hive
>  Issue Type: Task
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Steps to reproduce:
> 1) CREATE TABLE cws (b STRING) PARTITIONED BY (a INT) STORED AS ORC;
> 2)  insert into cws partition (a) values (1, '1');
>  update csw set b='2' where a=1;
> 3) open HiveStreamingConnection with batch size set to 1, begin txn, write 
> something and abort the txn
> 4) insert into cws partition (a) values (2, '2');
>  update csw set b='3' where a=2;
> 5) manually trigger the compaction and verify that data for part a=1 is gone



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work started] (HIVE-25502) Cleaner causes data loss when processing aborted txn with DP

2021-09-08 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-25502 started by Denys Kuzmenko.
-
> Cleaner causes data loss when processing aborted txn with DP 
> -
>
> Key: HIVE-25502
> URL: https://issues.apache.org/jira/browse/HIVE-25502
> Project: Hive
>  Issue Type: Task
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Steps to reproduce:
> 1) CREATE TABLE cws (b STRING) PARTITIONED BY (a INT) STORED AS ORC;
> 2)  insert into cws partition (a) values (1, '1');
>  update csw set b='2' where a=1;
> 3) open HiveStreamingConnection with batch size set to 1, begin txn, write 
> something and abort the txn
> 4) insert into cws partition (a) values (2, '2');
>  update csw set b='3' where a=2;
> 5) manually trigger the compaction and verify that data for part a=1 is gone



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-25505) Incorrect results with header. skip.header.line.count if first line is blank

2021-09-08 Thread Peter Vary (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated HIVE-25505:
--
Description: 
aAtable with header. skip.header.line.count=1 does not skip the first line if 
it is blank, except in a fetch task.

To reproduce, create a csv table, ans set header. skip.header.line.count=1 in 
table properties.

In the table location, create a single file, with a blank (empty) first line, 
and say 2 further lines.

If you do a select * on it, you see 2 rows (correct)
If you do select count(\*) on it, you get 3 (incorrect)

  was:
aAtable with header. skip.header.line.count=1 does not skip the first line if 
it is blank, except in a fetch task.

To reproduce, create a csv table, ans set header. skip.header.line.count=1 in 
table properties.

In the table location, create a single file, with a blank (empty) first line, 
and say 2 further lines.

If you do a select * on it, you see 2 rows (correct)
If you do select count(*) on it, you get 3 (incorrect)


> Incorrect results with header. skip.header.line.count if first line is blank
> 
>
> Key: HIVE-25505
> URL: https://issues.apache.org/jira/browse/HIVE-25505
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Steve Carlin
>Priority: Major
>
> aAtable with header. skip.header.line.count=1 does not skip the first line if 
> it is blank, except in a fetch task.
> To reproduce, create a csv table, ans set header. skip.header.line.count=1 in 
> table properties.
> In the table location, create a single file, with a blank (empty) first line, 
> and say 2 further lines.
> If you do a select * on it, you see 2 rows (correct)
> If you do select count(\*) on it, you get 3 (incorrect)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-22247) HiveHFileOutputFormat throws FileNotFoundException when partition's task output empty

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22247?focusedWorklogId=647827=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647827
 ]

ASF GitHub Bot logged work on HIVE-22247:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 09:04
Start Date: 08/Sep/21 09:04
Worklog Time Spent: 10m 
  Work Description: aasha commented on a change in pull request #2609:
URL: https://github.com/apache/hive/pull/2609#discussion_r704204772



##
File path: 
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java
##
@@ -163,8 +164,14 @@ public void close(boolean abort) throws IOException {
   FileSystem fs = outputdir.getFileSystem(jc);
   fs.mkdirs(columnFamilyPath);
   Path srcDir = taskAttemptOutputdir;
-  for (;;) {

Review comment:
   add a test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 647827)
Remaining Estimate: 0h
Time Spent: 10m

> HiveHFileOutputFormat throws FileNotFoundException when partition's task 
> output empty
> -
>
> Key: HIVE-22247
> URL: https://issues.apache.org/jira/browse/HIVE-22247
> Project: Hive
>  Issue Type: Bug
>  Components: HBase Handler
>Affects Versions: 2.2.0, 3.0.0
>Reporter: xiepengjie
>Assignee: Ayush Saxena
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When partition's task output empty, HiveHFileOutputFormat throws 
> FileNotFoundException like this:
> {code:java}
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: 1 finished. closing... 
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: FS[1]: records written - 0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Writing to temp file: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: New Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,915 INFO [main] 
> org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: File Output 
> Committer Algorithm version is 1
> 2019-09-24 19:15:55,954 INFO [main] 
> org.apache.hadoop.conf.Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 2019-09-24 19:15:56,089 ERROR [main] ExecReducer: Hit error while closing 
> operators - failing tree
> 2019-09-24 19:15:56,090 WARN [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child : java.lang.RuntimeException: Hive Runtime Error 
> while closing operators: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:287)
>   at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:453)
>   at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392)
>   at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1923)
>   at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:200)
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:1016)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:617)
>   at 

[jira] [Updated] (HIVE-22247) HiveHFileOutputFormat throws FileNotFoundException when partition's task output empty

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-22247:
--
Labels: pull-request-available  (was: )

> HiveHFileOutputFormat throws FileNotFoundException when partition's task 
> output empty
> -
>
> Key: HIVE-22247
> URL: https://issues.apache.org/jira/browse/HIVE-22247
> Project: Hive
>  Issue Type: Bug
>  Components: HBase Handler
>Affects Versions: 2.2.0, 3.0.0
>Reporter: xiepengjie
>Assignee: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When partition's task output empty, HiveHFileOutputFormat throws 
> FileNotFoundException like this:
> {code:java}
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: 1 finished. closing... 
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: FS[1]: records written - 0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Writing to temp file: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: New Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,915 INFO [main] 
> org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: File Output 
> Committer Algorithm version is 1
> 2019-09-24 19:15:55,954 INFO [main] 
> org.apache.hadoop.conf.Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 2019-09-24 19:15:56,089 ERROR [main] ExecReducer: Hit error while closing 
> operators - failing tree
> 2019-09-24 19:15:56,090 WARN [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child : java.lang.RuntimeException: Hive Runtime Error 
> while closing operators: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:287)
>   at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:453)
>   at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392)
>   at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1923)
>   at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:200)
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:1016)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:617)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:631)
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:278)
>   ... 7 more
> Caused by: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:880)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.access$700(DistributedFileSystem.java:109)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:938)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:934)
>   at 
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:945)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1592)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1632)
>   at 
> 

[jira] [Assigned] (HIVE-22247) HiveHFileOutputFormat throws FileNotFoundException when partition's task output empty

2021-09-08 Thread Ayush Saxena (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayush Saxena reassigned HIVE-22247:
---

Assignee: Ayush Saxena  (was: xiepengjie)

> HiveHFileOutputFormat throws FileNotFoundException when partition's task 
> output empty
> -
>
> Key: HIVE-22247
> URL: https://issues.apache.org/jira/browse/HIVE-22247
> Project: Hive
>  Issue Type: Bug
>  Components: HBase Handler
>Affects Versions: 2.2.0, 3.0.0
>Reporter: xiepengjie
>Assignee: Ayush Saxena
>Priority: Major
>
> When partition's task output empty, HiveHFileOutputFormat throws 
> FileNotFoundException like this:
> {code:java}
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: 1 finished. closing... 
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: FS[1]: records written - 0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: Writing to temp file: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
> 2019-09-24 19:15:55,886 INFO [main] 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator: New Final Path: FS 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_tmp.-ext-10002/02_0
> 2019-09-24 19:15:55,915 INFO [main] 
> org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: File Output 
> Committer Algorithm version is 1
> 2019-09-24 19:15:55,954 INFO [main] 
> org.apache.hadoop.conf.Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 2019-09-24 19:15:56,089 ERROR [main] ExecReducer: Hit error while closing 
> operators - failing tree
> 2019-09-24 19:15:56,090 WARN [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child : java.lang.RuntimeException: Hive Runtime Error 
> while closing operators: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:287)
>   at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:453)
>   at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392)
>   at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1923)
>   at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:200)
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:1016)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:617)
>   at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:631)
>   at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.close(ExecReducer.java:278)
>   ... 7 more
> Caused by: java.io.FileNotFoundException: File 
> hdfs://Hdptest-mini-nmg/tmp/hive-staging/hadoop_hive_2019-09-24_19-15-26_453_1697529445006435790-5/_task_tmp.-ext-10002/_tmp.02_0
>  does not exist.
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:880)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.access$700(DistributedFileSystem.java:109)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:938)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:934)
>   at 
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
>   at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:945)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1592)
>   at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1632)
>   at 
> org.apache.hadoop.hive.hbase.HiveHFileOutputFormat$1.close(HiveHFileOutputFormat.java:153)
>   at 
> 

[jira] [Work logged] (HIVE-24762) StringValueBoundaryScanner ignores boundary which leads to incorrect results

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-24762?focusedWorklogId=647811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647811
 ]

ASF GitHub Bot logged work on HIVE-24762:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 08:18
Start Date: 08/Sep/21 08:18
Worklog Time Spent: 10m 
  Work Description: abstractdog opened a new pull request #1965:
URL: https://github.com/apache/hive/pull/1965


   ### What changes were proposed in this pull request?
   StringValueBoundaryScanner.isDistanceGreater to take amt into account.
   
   
   ### Why are the changes needed?
   Described in jira.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Added string based range window to ptf.q.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 647811)
Time Spent: 2h  (was: 1h 50m)

>  StringValueBoundaryScanner ignores boundary which leads to incorrect results
> -
>
> Key: HIVE-24762
> URL: https://issues.apache.org/jira/browse/HIVE-24762
> Project: Hive
>  Issue Type: Bug
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java#L901
> {code}
>   public boolean isDistanceGreater(Object v1, Object v2, int amt) {
> ...
> return s1 != null && s2 != null && s1.compareTo(s2) > 0;
> {code}
> Like other boundary scanners, StringValueBoundaryScanner should take amt into 
> account, otherwise it'll result in the same range regardless of the given 
> window size. This typically affects queries where the range is defined on a 
> string column:
> {code}
> select p_mfgr, p_name, p_retailprice,
> count(*) over(partition by p_mfgr order by p_name range between 1 preceding 
> and current row) as cs1,
> count(*) over(partition by p_mfgr order by p_name range between 3 preceding 
> and current row) as cs2
> from vector_ptf_part_simple_orc;
> {code} 
> with "> 0" cs1 and cs2 will be calculated on the same window, so cs1 == cs2, 
> but actually it should be different, this is the correct result (see "almond 
> antique olive coral navajo"):
> {code}
> +-+-+--+--+
> | p_mfgr  |   p_name| cs1  | cs2  
> |
> +-+-+--+--+
> | Manufacturer#1  | almond antique burnished rose metallic  | 2| 2
> |
> | Manufacturer#1  | almond antique burnished rose metallic  | 2| 2
> |
> | Manufacturer#1  | almond antique chartreuse lavender yellow   | 6| 6
> |
> | Manufacturer#1  | almond antique chartreuse lavender yellow   | 6| 6
> |
> | Manufacturer#1  | almond antique chartreuse lavender yellow   | 6| 6
> |
> | Manufacturer#1  | almond antique chartreuse lavender yellow   | 6| 6
> |
> | Manufacturer#1  | almond antique salmon chartreuse burlywood  | 1| 1
> |
> | Manufacturer#1  | almond aquamarine burnished black steel | 1| 8
> |
> | Manufacturer#1  | almond aquamarine pink moccasin thistle | 4| 4
> |
> | Manufacturer#1  | almond aquamarine pink moccasin thistle | 4| 4
> |
> | Manufacturer#1  | almond aquamarine pink moccasin thistle | 4| 4
> |
> | Manufacturer#1  | almond aquamarine pink moccasin thistle | 4| 4
> |
> | Manufacturer#2  | almond antique violet chocolate turquoise   | 1| 1
> |
> | Manufacturer#2  | almond antique violet turquoise frosted | 3| 3
> |
> | Manufacturer#2  | almond antique violet turquoise frosted | 3| 3
> |
> | Manufacturer#2  | almond antique violet turquoise frosted | 3| 3
> |
> | Manufacturer#2  | almond aquamarine midnight light salmon | 1| 5
> |
> | Manufacturer#2  | almond aquamarine rose maroon antique   | 2| 2
> |
> | Manufacturer#2  | almond aquamarine rose maroon antique   | 2| 2
> |
> | Manufacturer#2  | almond aquamarine sandy cyan gainsboro  | 3| 3
> |
> | Manufacturer#3  | almond antique chartreuse khaki white   | 1| 1
> |
> | Manufacturer#3  | almond antique forest lavender goldenrod| 4| 5
> |
> | 

[jira] [Updated] (HIVE-25500) Switch back to alter_partition(s) in HMS client for Hive 2.3.x

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-25500:
--
Labels: pull-request-available  (was: )

> Switch back to alter_partition(s) in HMS client for Hive 2.3.x
> --
>
> Key: HIVE-25500
> URL: https://issues.apache.org/jira/browse/HIVE-25500
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 2.3.9
>Reporter: dzcxzl
>Assignee: dzcxzl
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> HIVE-12730 uses alter_partition_with_environment_context and 
> alter_partitions_with_environment_context instead of alter_partition and 
> alter_partitions when the EnvironmentContext is null.
>  This causes the client version to be greater than 2.1 to connect to 
> server<2.1, and this error will occur.
> {code:java}
> Caused by: org.apache.thrift.TApplicationException: Invalid method name: 
> 'alter_partitions_with_environment_context'
>   at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
>   at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-25500) Switch back to alter_partition(s) in HMS client for Hive 2.3.x

2021-09-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-25500?focusedWorklogId=647760=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647760
 ]

ASF GitHub Bot logged work on HIVE-25500:
-

Author: ASF GitHub Bot
Created on: 08/Sep/21 06:45
Start Date: 08/Sep/21 06:45
Worklog Time Spent: 10m 
  Work Description: cxzl25 commented on pull request #2618:
URL: https://github.com/apache/hive/pull/2618#issuecomment-914965475


   > Thanks @cxzl25 ! this is a good catch and it LGTM. Could you open another 
one for branch-3.1 as well? Ideally we should also fix this in master but seems 
the code path has changed a lot there.
   
   Submitted a PR (https://github.com/apache/hive/pull/2623) on branch3.1 .
   master branch: HIVE-19820 uses `alter_partitions_req` instead of 
`alter_partitions` .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 647760)
Remaining Estimate: 0h
Time Spent: 10m

> Switch back to alter_partition(s) in HMS client for Hive 2.3.x
> --
>
> Key: HIVE-25500
> URL: https://issues.apache.org/jira/browse/HIVE-25500
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 2.3.9
>Reporter: dzcxzl
>Assignee: dzcxzl
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> HIVE-12730 uses alter_partition_with_environment_context and 
> alter_partitions_with_environment_context instead of alter_partition and 
> alter_partitions when the EnvironmentContext is null.
>  This causes the client version to be greater than 2.1 to connect to 
> server<2.1, and this error will occur.
> {code:java}
> Caused by: org.apache.thrift.TApplicationException: Invalid method name: 
> 'alter_partitions_with_environment_context'
>   at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
>   at 
> org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
>   at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)