[jira] [Resolved] (HIVE-27578) Refactor genJoinRelNode to use genAllRexNode instead of genAllExprNodeDesc

2023-08-17 Thread Soumyakanti Das (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Soumyakanti Das resolved HIVE-27578.

Resolution: Fixed

> Refactor genJoinRelNode to use genAllRexNode instead of genAllExprNodeDesc
> --
>
> Key: HIVE-27578
> URL: https://issues.apache.org/jira/browse/HIVE-27578
> Project: Hive
>  Issue Type: Improvement
>Reporter: Soumyakanti Das
>Assignee: Soumyakanti Das
>Priority: Major
>  Labels: pull-request-available
>
> Currently {{genJoinRelNode}} method relies on {{genAllExprNodeDesc}} for 
> adding backticks to the ON clause conditions, but we can use 
> {{genAllRexNode}} method instead, and not rely on ExprNodes.
> There was a previous effort to try to get RexNodes directly from AST, and 
> this method call was probably overlooked. We can see that changes were made 
> around this method call to use RexNodes instead of ExprNodes, 
> [here|https://github.com/apache/hive/pull/970/files#diff-fc58b141b1cc612eb221bb781c83e1a5c98e054790b2803be60b4842d0e9a5d9R2753].
>  
> Relevant previous Jiras: 
>  # HIVE-23100
>  # HIVE-22746
> With this change, we can avoid going through the method 
> {{genAllExprNodeDesc}} and avoid mixing RexNodes and ExprNodes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-27632) ClassCast Exception in Vectorization converting decimal64 to decimal

2023-08-17 Thread Riju Trivedi (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Riju Trivedi updated HIVE-27632:

 Attachment: vectortest.q
Component/s: Vectorization
Description: 
Attached [^vectortest.q] which fails with the below ClassCast Exception
{code:java}
Caused by: java.lang.ClassCastException: 
org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector cannot be cast to 
org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
at 
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FilterDecimalColEqualDecimalScalar.evaluate(FilterDecimalColEqualDecimalScalar.java:64)
at 
org.apache.hadoop.hive.ql.exec.vector.VectorFilterOperator.process(VectorFilterOperator.java:125)
at org.apache.hadoop.hive.ql.exec.Operator.vectorForward(Operator.java:919)
at 
org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:171)
at 
org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.deliverVectorizedRowBatch(VectorMapOperator.java:809)
at 
org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:878)
 {code}
This seems related to HIVE-26208 , which avoids Decimal64 to Decimal conversion 
for the vector expressions that explicitly handle decimal64 types. However, in 
this scenario exception comes from `FilterDecimalColEqualDecimalScalar`. 
Summary: ClassCast Exception in Vectorization converting decimal64 to 
decimal  (was: ClassCast Exception in FilterDecimalColEqualDecimalScalar 
converting decimal64 to decimal)

> ClassCast Exception in Vectorization converting decimal64 to decimal
> 
>
> Key: HIVE-27632
> URL: https://issues.apache.org/jira/browse/HIVE-27632
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Reporter: Riju Trivedi
>Priority: Major
> Attachments: vectortest.q
>
>
> Attached [^vectortest.q] which fails with the below ClassCast Exception
> {code:java}
> Caused by: java.lang.ClassCastException: 
> org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector cannot be cast to 
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
> at 
> org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FilterDecimalColEqualDecimalScalar.evaluate(FilterDecimalColEqualDecimalScalar.java:64)
> at 
> org.apache.hadoop.hive.ql.exec.vector.VectorFilterOperator.process(VectorFilterOperator.java:125)
> at 
> org.apache.hadoop.hive.ql.exec.Operator.vectorForward(Operator.java:919)
> at 
> org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:171)
> at 
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.deliverVectorizedRowBatch(VectorMapOperator.java:809)
> at 
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:878)
>  {code}
> This seems related to HIVE-26208 , which avoids Decimal64 to Decimal 
> conversion for the vector expressions that explicitly handle decimal64 types. 
> However, in this scenario exception comes from 
> `FilterDecimalColEqualDecimalScalar`. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HIVE-27632) ClassCast Exception in FilterDecimalColEqualDecimalScalar converting decimal64 to decimal

2023-08-17 Thread Riju Trivedi (Jira)
Riju Trivedi created HIVE-27632:
---

 Summary: ClassCast Exception in FilterDecimalColEqualDecimalScalar 
converting decimal64 to decimal
 Key: HIVE-27632
 URL: https://issues.apache.org/jira/browse/HIVE-27632
 Project: Hive
  Issue Type: Bug
Reporter: Riju Trivedi






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HIVE-27237) Iceberg: DROP TAG SQL implementation

2023-08-17 Thread Denys Kuzmenko (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-27237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755490#comment-17755490
 ] 

Denys Kuzmenko commented on HIVE-27237:
---

Merged to master.
Thanks for the contribution, [~zhangbutao]!

> Iceberg: DROP TAG SQL implementation
> 
>
> Key: HIVE-27237
> URL: https://issues.apache.org/jira/browse/HIVE-27237
> Project: Hive
>  Issue Type: Sub-task
>  Components: Iceberg integration
>Reporter: zhangbutao
>Assignee: zhangbutao
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HIVE-27237) Iceberg: DROP TAG SQL implementation

2023-08-17 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko resolved HIVE-27237.
---
Resolution: Fixed

> Iceberg: DROP TAG SQL implementation
> 
>
> Key: HIVE-27237
> URL: https://issues.apache.org/jira/browse/HIVE-27237
> Project: Hive
>  Issue Type: Sub-task
>  Components: Iceberg integration
>Reporter: zhangbutao
>Assignee: zhangbutao
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HIVE-27619) Backport of HIVE-12371: Adding a timeout connection parameter for JDBC

2023-08-17 Thread Zhihua Deng (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihua Deng resolved HIVE-27619.

Fix Version/s: 3.2.0
   Resolution: Fixed

Fix has been merged. Thank you for the PR [~amanraj2520]!

> Backport of HIVE-12371: Adding a timeout connection parameter for JDBC
> --
>
> Key: HIVE-27619
> URL: https://issues.apache.org/jira/browse/HIVE-27619
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Aman Raj
>Assignee: Aman Raj
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.2.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-27631) CCE while use Alluxio ShimFilesystem to adapt hdfs

2023-08-17 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-27631:
--
Labels: pull-request-available  (was: )

> CCE while use Alluxio ShimFilesystem to adapt hdfs
> --
>
> Key: HIVE-27631
> URL: https://issues.apache.org/jira/browse/HIVE-27631
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 2.3.5, 2.3.7, 3.1.3
>Reporter: Baolong Mao
>Assignee: Baolong Mao
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2023-08-17-17-01-15-753.png
>
>
> !image-2023-08-17-17-01-15-753.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-27631) CCE while use Alluxio ShimFilesystem to adapt hdfs

2023-08-17 Thread Baolong Mao (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Baolong Mao updated HIVE-27631:
---
Attachment: image-2023-08-17-17-01-15-753.png

> CCE while use Alluxio ShimFilesystem to adapt hdfs
> --
>
> Key: HIVE-27631
> URL: https://issues.apache.org/jira/browse/HIVE-27631
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 2.3.5, 2.3.7, 3.1.3
>Reporter: Baolong Mao
>Assignee: Baolong Mao
>Priority: Major
> Attachments: image-2023-08-17-17-01-15-753.png
>
>
> !image-2023-08-17-17-01-15-753.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-27631) CCE while use Alluxio ShimFilesystem to adapt hdfs

2023-08-17 Thread Baolong Mao (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Baolong Mao updated HIVE-27631:
---
Description: !image-2023-08-17-17-01-15-753.png!

> CCE while use Alluxio ShimFilesystem to adapt hdfs
> --
>
> Key: HIVE-27631
> URL: https://issues.apache.org/jira/browse/HIVE-27631
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 2.3.5, 2.3.7, 3.1.3
>Reporter: Baolong Mao
>Assignee: Baolong Mao
>Priority: Major
> Attachments: image-2023-08-17-17-01-15-753.png
>
>
> !image-2023-08-17-17-01-15-753.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HIVE-27596) Make JdbcInputFormat thread-safe

2023-08-17 Thread Zhihua Deng (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihua Deng reassigned HIVE-27596:
--

Assignee: (was: Zhihua Deng)

> Make JdbcInputFormat thread-safe
> 
>
> Key: HIVE-27596
> URL: https://issues.apache.org/jira/browse/HIVE-27596
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
>
> InputFormat is cached in FetchOperator:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233|https://github.com/ganeshashree/hive/blob/c2fb5827761b99b1270582bd9c41c9ab5a6ab549/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233]
> and HiveFileInputFormat:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java#L391]
> which makes the InputFormat instance is accessible across different sessions, 
> so it's better to be stateless to avoid concurrency problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HIVE-27631) CCE while use Alluxio ShimFilesystem to adapt hdfs

2023-08-17 Thread Baolong Mao (Jira)
Baolong Mao created HIVE-27631:
--

 Summary: CCE while use Alluxio ShimFilesystem to adapt hdfs
 Key: HIVE-27631
 URL: https://issues.apache.org/jira/browse/HIVE-27631
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 3.1.3, 2.3.7, 2.3.5
Reporter: Baolong Mao
Assignee: Baolong Mao






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HIVE-27596) Make JdbcInputFormat thread-safe

2023-08-17 Thread Zhihua Deng (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihua Deng resolved HIVE-27596.

Resolution: Not A Problem

The JdbcInputFormat has implemented the JobConfigurable interface, it won't be 
cached in FetchOperator.

> Make JdbcInputFormat thread-safe
> 
>
> Key: HIVE-27596
> URL: https://issues.apache.org/jira/browse/HIVE-27596
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zhihua Deng
>Assignee: Zhihua Deng
>Priority: Major
>
> InputFormat is cached in FetchOperator:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233|https://github.com/ganeshashree/hive/blob/c2fb5827761b99b1270582bd9c41c9ab5a6ab549/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233]
> and HiveFileInputFormat:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java#L391]
> which makes the InputFormat instance is accessible across different sessions, 
> so it's better to be stateless to avoid concurrency problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HIVE-27596) Make JdbcInputFormat thread-safe

2023-08-17 Thread Zhihua Deng (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihua Deng reassigned HIVE-27596:
--

Assignee: Zhihua Deng

> Make JdbcInputFormat thread-safe
> 
>
> Key: HIVE-27596
> URL: https://issues.apache.org/jira/browse/HIVE-27596
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zhihua Deng
>Assignee: Zhihua Deng
>Priority: Major
>
> InputFormat is cached in FetchOperator:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233|https://github.com/ganeshashree/hive/blob/c2fb5827761b99b1270582bd9c41c9ab5a6ab549/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233]
> and HiveFileInputFormat:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java#L391]
> which makes the InputFormat instance is accessible across different sessions, 
> so it's better to be stateless to avoid concurrency problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-27596) Make JdbcInputFormat thread-safe

2023-08-17 Thread Zhihua Deng (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihua Deng updated HIVE-27596:
---
Summary: Make JdbcInputFormat thread-safe  (was: Make the cached 
InputFormat stateless)

> Make JdbcInputFormat thread-safe
> 
>
> Key: HIVE-27596
> URL: https://issues.apache.org/jira/browse/HIVE-27596
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
>
> InputFormat is cached in FetchOperator:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233|https://github.com/ganeshashree/hive/blob/c2fb5827761b99b1270582bd9c41c9ab5a6ab549/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java#L233]
> and HiveFileInputFormat:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java#L391]
> which makes the InputFormat instance is accessible across different sessions, 
> so it's better to be stateless to avoid concurrency problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)