[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-31 Thread Ashutosh Chauhan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-15723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan reopened HIVE-15723:
-

> Hive should report a warning about missing table/column statistics to user.
> ---
>
> Key: HIVE-15723
> URL: https://issues.apache.org/jira/browse/HIVE-15723
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Reporter: Remus Rusanu
>Assignee: Remus Rusanu
>Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-15723.01.patch, HIVE-15723.02.patch, 
> HIVE-15723.03.patch, HIVE-15723.04.patch
>
>
> Many Hive performance issues are due to missing statistics. Either all, table 
> or column statistics are missing. Potentially a new partition has been added 
> and customer forgot to gather stats for that partition.
> A simple warning about a table or column missing statistics can be very 
> helpful and makes hive more user friendly. Hive already has this information, 
> its a matter of printing it out.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-31 Thread Nita Dembla (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-15723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847570#comment-15847570
 ] 

Nita Dembla commented on HIVE-15723:


hive.cbo.show.warnings should be set to to 'true' by default, since the user 
may not really know if he is missing statistics and may not even look for this 
setting. I couldn't reopen the bug. 

> Hive should report a warning about missing table/column statistics to user.
> ---
>
> Key: HIVE-15723
> URL: https://issues.apache.org/jira/browse/HIVE-15723
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Reporter: Remus Rusanu
>Assignee: Remus Rusanu
>Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-15723.01.patch, HIVE-15723.02.patch, 
> HIVE-15723.03.patch, HIVE-15723.04.patch
>
>
> Many Hive performance issues are due to missing statistics. Either all, table 
> or column statistics are missing. Potentially a new partition has been added 
> and customer forgot to gather stats for that partition.
> A simple warning about a table or column missing statistics can be very 
> helpful and makes hive more user friendly. Hive already has this information, 
> its a matter of printing it out.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-31 Thread Remus Rusanu (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Remus Rusanu updated  HIVE-15723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Hive /  HIVE-15723 
 
 
 
  Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Remus Rusanu 
 
 
 

Resolution:
 
 Fixed 
 
 
 

Release Note:
 
 hive.cbo.show.warnings (default false) is added to control display of cost-based-optimizer compiler warnings, like missing stats. 
 
 
 

Status:
 
 Patch Available Resolved 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-31 Thread Peter Vary (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Peter Vary commented on  HIVE-15723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 
Remus Rusanu: Currently you would need too many small patches to make it work. It is not committed yet. (See: HIVE-15051) 
What you can do is use HIVE-15725, and run the command which runs the yetus checkstyle check: 

 

cd ql
mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch 
 

 
Yetus found no other error in your patch. 
Thanks, Peter 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Remus Rusanu (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Remus Rusanu edited a comment on  HIVE-15723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 @ [~ pvary ]  Hi Peter, is there an easy way I can run Yetus on a patch locally so I can test it before upload? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Remus Rusanu (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Remus Rusanu commented on  HIVE-15723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 
@pvary Hi Peter, is there an easy way I can run Yetus on a patch locally so I can test it before upload? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Remus Rusanu (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Remus Rusanu updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Hive /  HIVE-15723 
 
 
 
  Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 
04.patch with Yetus warnings addressed 
 
 
 
 
 
 
 
 
 

Change By:
 
 Remus Rusanu 
 
 
 

Attachment:
 
 HIVE-15723.04.patch 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Peter Vary assigned an issue to Remus Rusanu 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
Sorry, actually fatthumbed on it on my mobile   
 
 
 
 
 
 
 
 
 
 Hive /  HIVE-15723 
 
 
 
  Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Peter Vary 
 
 
 

Assignee:
 
 Peter Vary Remus Rusanu 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Peter Vary assigned an issue to Peter Vary 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Hive /  HIVE-15723 
 
 
 
  Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Peter Vary 
 
 
 

Assignee:
 
 Remus Rusanu Peter Vary 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Ashutosh Chauhan (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ashutosh Chauhan commented on  HIVE-15723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 
+1 Remus Rusanu you may address Peter Vary review comments on RB while committing the patch. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Hive QA (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hive QA commented on  HIVE-15723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 
Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12849937/HIVE-15723.03.patch 
SUCCESS: +1 due to 1 test(s) being added or modified. 
ERROR: -1 due to 4 failed/errored test(s), 11010 tests executed Failed tests: 

 
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple] (batchId=147)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223)
 

 
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3256/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3256/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3256/ 
Messages: 

 
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
 

 
This message is automatically generated. 
ATTACHMENT ID: 12849937 - PreCommit-HIVE-Build 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
   

[jira] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Remus Rusanu (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Remus Rusanu updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Hive /  HIVE-15723 
 
 
 
  Hive should report a warning about missing table/column statistics to user.  
 
 
 
 
 
 
 
 
 
 
Removed Driver and Context changes, logging to console straight from RelOpMdTable 
 
 
 
 
 
 
 
 
 

Change By:
 
 Remus Rusanu 
 
 
 

Attachment:
 
 HIVE-15723.03.patch 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)