[jira] [Comment Edited] (HIVE-28293) TestGracefulStopHS2 runs too long

2024-06-03 Thread Zhihua Deng (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-28293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851550#comment-17851550
 ] 

Zhihua Deng edited comment on HIVE-28293 at 6/3/24 8:18 AM:


Sounds like the query is still running on cancellation until it completes(Tez) 
in this case, or could we remove this line?

[https://github.com/apache/hive/blob/8c90ec0ce576d6319470f7dc4dd27daebb654dec/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java#L420]


was (Author: dengzh):
Sounds like the query is still running on cancellation until it completes(Tez) 
in this case, or could we remove this line?

[https://github.com/apache/hive/blob/8c90ec0ce576d6319470f7dc4dd27daebb654dec/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java#L420]

 

 

> TestGracefulStopHS2 runs too long
> -
>
> Key: HIVE-28293
> URL: https://issues.apache.org/jira/browse/HIVE-28293
> Project: Hive
>  Issue Type: Bug
>Reporter: László Bodor
>Assignee: Zhihua Deng
>Priority: Major
>  Labels: newbie
>
> it tests whether long queries are finished successfully in the event of a 
> graceful shutdown, however 10 minutes seems to be too long: 
> https://github.com/apache/hive/blob/8c90ec0ce576d6319470f7dc4dd27daebb654dec/itests/hive-unit/src/test/java/org/apache/hive/service/server/TestGracefulStopHS2.java#L85
> I'm pretty sure we can validate this in a few minutes
> {code}
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running org.apache.hive.service.server.TestGracefulStopHS2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1,225.833 s - in org.apache.hive.service.server.TestGracefulStopHS2
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (HIVE-28293) TestGracefulStopHS2 runs too long

2024-06-02 Thread Zhihua Deng (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-28293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851517#comment-17851517
 ] 

Zhihua Deng edited comment on HIVE-28293 at 6/3/24 4:42 AM:


The second query with 60ms is supposed to timeout and failed as the HS2 has 
been shutdown in 60s,

[https://github.com/apache/hive/blob/8c90ec0ce576d6319470f7dc4dd27daebb654dec/itests/hive-unit/src/test/java/org/apache/hive/service/server/TestGracefulStopHS2.java#L55]

it shouldn't have been running for 10min when the shutdown is triggered.

Not sure why the test spends so much time, when I test on my local laptop, it 
finishes within one minutes.


was (Author: dengzh):
The second query with 60ms is supposed to timeout and failed as the HS2 has 
been shutdown in 60s,

https://github.com/apache/hive/blob/8c90ec0ce576d6319470f7dc4dd27daebb654dec/itests/hive-unit/src/test/java/org/apache/hive/service/server/TestGracefulStopHS2.java#L55

it shouldn't have been running for 10min when the shutdown is triggered.

Not sure why the test spends so much time, when I test on my local laptop, it 
finishes within one minutes.

 

> TestGracefulStopHS2 runs too long
> -
>
> Key: HIVE-28293
> URL: https://issues.apache.org/jira/browse/HIVE-28293
> Project: Hive
>  Issue Type: Bug
>Reporter: László Bodor
>Assignee: Zhihua Deng
>Priority: Major
>  Labels: newbie
>
> it tests whether long queries are finished successfully in the event of a 
> graceful shutdown, however 10 minutes seems to be too long: 
> https://github.com/apache/hive/blob/8c90ec0ce576d6319470f7dc4dd27daebb654dec/itests/hive-unit/src/test/java/org/apache/hive/service/server/TestGracefulStopHS2.java#L85
> I'm pretty sure we can validate this in a few minutes
> {code}
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running org.apache.hive.service.server.TestGracefulStopHS2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1,225.833 s - in org.apache.hive.service.server.TestGracefulStopHS2
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)