[jira] [Commented] (HIVE-10173) ThreadLocal synchronized initialvalue() is irrelevant in JDK7

2015-06-23 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598566#comment-14598566
 ] 

Ashutosh Chauhan commented on HIVE-10173:
-

+1 LGTM

> ThreadLocal synchronized initialvalue() is irrelevant in JDK7
> -
>
> Key: HIVE-10173
> URL: https://issues.apache.org/jira/browse/HIVE-10173
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Affects Versions: 1.2.0
>Reporter: Gopal V
>Assignee: Ferdinand Xu
>Priority: Minor
> Attachments: HIVE-10173.patch
>
>
> The threadlocals need not synchronize the calls to initialvalue(), since that 
> is effectively going to be called once per-thread in JDK7.
> The anti-pattern lives on due to a very old JDK bug - 
> https://bugs.openjdk.java.net/browse/JDK-6550283
> {code}
> $ git grep --name-only -c "protected.*synchronized.*initialValue"
> common/src/java/org/apache/hadoop/hive/conf/LoopingByteArrayInputStream.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesOutput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordOutput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableOutput.java
> metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
> ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java
> serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
> serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java
> service/src/java/org/apache/hive/service/auth/TSetIpAddressProcessor.java
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java
> shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-10173) ThreadLocal synchronized initialvalue() is irrelevant in JDK7

2015-04-19 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502401#comment-14502401
 ] 

Ferdinand Xu commented on HIVE-10173:
-

Hi [~gopalv], could you help me review this jira? The failed cases are 
irrelevant. Thank you!

> ThreadLocal synchronized initialvalue() is irrelevant in JDK7
> -
>
> Key: HIVE-10173
> URL: https://issues.apache.org/jira/browse/HIVE-10173
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Affects Versions: 1.2.0
>Reporter: Gopal V
>Assignee: Ferdinand Xu
>Priority: Minor
> Attachments: HIVE-10173.patch
>
>
> The threadlocals need not synchronize the calls to initialvalue(), since that 
> is effectively going to be called once per-thread in JDK7.
> The anti-pattern lives on due to a very old JDK bug - 
> https://bugs.openjdk.java.net/browse/JDK-6550283
> {code}
> $ git grep --name-only -c "protected.*synchronized.*initialValue"
> common/src/java/org/apache/hadoop/hive/conf/LoopingByteArrayInputStream.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesOutput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordOutput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableOutput.java
> metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
> ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java
> serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
> serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java
> service/src/java/org/apache/hive/service/auth/TSetIpAddressProcessor.java
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java
> shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-10173) ThreadLocal synchronized initialvalue() is irrelevant in JDK7

2015-04-01 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391114#comment-14391114
 ] 

Hive QA commented on HIVE-10173:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12708622/HIVE-10173.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8692 tests executed
*Failed tests:*
{noformat}
TestMinimrCliDriver-smb_mapjoin_8.q - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_2
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3238/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3238/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3238/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12708622 - PreCommit-HIVE-TRUNK-Build

> ThreadLocal synchronized initialvalue() is irrelevant in JDK7
> -
>
> Key: HIVE-10173
> URL: https://issues.apache.org/jira/browse/HIVE-10173
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Affects Versions: 1.2.0
>Reporter: Gopal V
>Assignee: Ferdinand Xu
>Priority: Minor
> Attachments: HIVE-10173.patch
>
>
> The threadlocals need not synchronize the calls to initialvalue(), since that 
> is effectively going to be called once per-thread in JDK7.
> The anti-pattern lives on due to a very old JDK bug - 
> https://bugs.openjdk.java.net/browse/JDK-6550283
> {code}
> $ git grep --name-only -c "protected.*synchronized.*initialValue"
> common/src/java/org/apache/hadoop/hive/conf/LoopingByteArrayInputStream.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesOutput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordOutput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableInput.java
> contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableOutput.java
> metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
> ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java
> serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
> serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java
> service/src/java/org/apache/hive/service/auth/TSetIpAddressProcessor.java
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java
> shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)