[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955411#comment-14955411 ] Sergey Shelukhin commented on HIVE-10965: - Well, this patch by itself covers many cases and doesn't cause a regression (the case that is broken in this patch is also broken before it). > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.1, 1.0.2 > > Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch, > HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954231#comment-14954231 ] Sushanth Sowmyan commented on HIVE-10965: - Note, this fix introduces a bug that is fixed by https://issues.apache.org/jira/browse/HIVE-12083 , and thus, that patch must be present on all branches this was patched with. > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.1, 1.0.2 > > Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch, > HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936395#comment-14936395 ] Lefty Leverenz commented on HIVE-10965: --- Thanks, I wasn't sure if I should change the fix version myself, but this is better. > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.1, 1.0.2 > > Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch, > HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935570#comment-14935570 ] Thejas M Nair commented on HIVE-10965: -- Thanks for catching that [~leftylev]! [~pxiong] was back porting some critical fixes to 1.0 line. I had an offline discussion with him now clarifying the process to him, he is going to update the fix version for couple of other jiras that were backported. > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.1, 1.0.2 > > Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch, > HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934663#comment-14934663 ] Lefty Leverenz commented on HIVE-10965: --- This was also committed to branch-1.0 (for release 1.0.2). Shouldn't 1.0.2 be listed in Fix Version/s so it will get picked up for the release notes? See commit 0b511cad47b61236da48e2b9768b3e6e8148b4e1. > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.1 > > Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch, > HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[
https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581083#comment-14581083
]
Hive QA commented on HIVE-10965:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12738896/HIVE-10965.02.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9007 tests executed
*Failed tests:*
{noformat}
org.apache.hive.beeline.TestSchemaTool.testSchemaInit
org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4238/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4238/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4238/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12738896 - PreCommit-HIVE-TRUNK-Build
> direct SQL for stats fails in 0-column case
> ---
>
> Key: HIVE-10965
> URL: https://issues.apache.org/jira/browse/HIVE-10965
> Project: Hive
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Fix For: 1.3.0, 1.2.1, 2.0.0
>
> Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch,
> HIVE-10965.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580993#comment-14580993 ] Sushanth Sowmyan commented on HIVE-10965: - You can go ahead and commit to branch-1.2 after you commit to branch-1 and master. The branch is still open as long as you add it to the wiki : https://cwiki.apache.org/confluence/display/Hive/Hive+1.2+Release+Status > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.3.0, 1.2.1, 2.0.0 > > Attachments: HIVE-10965.01.patch, HIVE-10965.02.patch, > HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[
https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579993#comment-14579993
]
Hive QA commented on HIVE-10965:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12738677/HIVE-10965.01.patch
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 9006 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_part
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_cbo_stats
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_cbo_stats
org.apache.hive.beeline.TestSchemaTool.testSchemaInit
org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4233/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4233/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4233/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12738677 - PreCommit-HIVE-TRUNK-Build
> direct SQL for stats fails in 0-column case
> ---
>
> Key: HIVE-10965
> URL: https://issues.apache.org/jira/browse/HIVE-10965
> Project: Hive
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Fix For: 1.3.0, 1.2.1, 2.0.0
>
> Attachments: HIVE-10965.01.patch, HIVE-10965.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577938#comment-14577938 ] Ashutosh Chauhan commented on HIVE-10965: - Patch looks good. I will also suggest to add this check on client side too, i.e., HiveMetaStorClient::getAggrColStatsFor() so that we dont do a trip to metastore in such cases just to get a null object. > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.3.0, 1.2.1, 2.0.0 > > Attachments: HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[
https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577932#comment-14577932
]
Hive QA commented on HIVE-10965:
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12738419/HIVE-10965.patch
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4217/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4217/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4217/
Messages:
{noformat}
This message was trimmed, see log for full details
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
hive-hwi ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/data/hive-ptest/working/apache-github-source-source/hwi/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-hwi ---
[INFO] Executing tasks
main:
[delete] Deleting directory
/data/hive-ptest/working/apache-github-source-source/hwi/target/tmp
[delete] Deleting directory
/data/hive-ptest/working/apache-github-source-source/hwi/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/hwi/target/tmp
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/hwi/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/hwi/target/tmp/conf
[copy] Copying 11 files to
/data/hive-ptest/working/apache-github-source-source/hwi/target/tmp/conf
[INFO] Executed tasks
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
hive-hwi ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.16:test (default-test) @ hive-hwi ---
[INFO]
[INFO]
[INFO] Building Hive ODBC 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-no-snapshots) @
hive-odbc ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ hive-odbc ---
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-odbc ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-odbc ---
[INFO] Executing tasks
main:
[delete] Deleting directory
/data/hive-ptest/working/apache-github-source-source/odbc/target/tmp
[delete] Deleting directory
/data/hive-ptest/working/apache-github-source-source/odbc/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/odbc/target/tmp
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/odbc/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/odbc/target/tmp/conf
[copy] Copying 11 files to
/data/hive-ptest/working/apache-github-source-source/odbc/target/tmp/conf
[INFO] Executed tasks
[INFO]
[INFO]
[INFO] Building Hive Shims Aggregator 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-no-snapshots) @
hive-shims-aggregator ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @
hive-shims-aggregator ---
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @
hive-shims-aggregator ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @
hive-shims-aggregator ---
[INFO] Executing tasks
main:
[delete] Deleting directory
/data/hive-ptest/working/apache-github-source-source/shims/target/tmp
[delete] Deleting directory
/data/hive-ptest/working/apache-github-source-source/shims/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/shims/target/tmp
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/shims/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-github-source-source/shims/target/tmp/conf
[copy] Copying 11 files to
/data/hive-ptest/working/apache-github-source-source/shims/target/tmp/conf
[INFO] Executed tasks
[INFO]
[INFO] --
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577808#comment-14577808 ] Pengcheng Xiong commented on HIVE-10965: I have no idea but I would start from the query that request stats with 0 columns. And if I remembered correctly, I remembered that [~ashutoshc] committed a patch to deal with a similar issue (empty partition or empty columns) several weeks ago. He may have a better answer. Thanks. > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.3.0, 1.2.1, 2.0.0 > > Attachments: HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577792#comment-14577792 ] Sergey Shelukhin commented on HIVE-10965: - [~pxiong] do you know why it would request stats with 0 columns? > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.3.0, 1.2.1, 2.0.0 > > Attachments: HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577789#comment-14577789 ] Pengcheng Xiong commented on HIVE-10965: LGTM. Thanks! > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.3.0, 1.2.1, 2.0.0 > > Attachments: HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10965) direct SQL for stats fails in 0-column case
[ https://issues.apache.org/jira/browse/HIVE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577689#comment-14577689 ] Sergey Shelukhin commented on HIVE-10965: - [~pxiong] can you take a look? [~sushanth] ok for 1.2? > direct SQL for stats fails in 0-column case > --- > > Key: HIVE-10965 > URL: https://issues.apache.org/jira/browse/HIVE-10965 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.3.0, 1.2.1, 2.0.0 > > Attachments: HIVE-10965.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
