[jira] [Commented] (HIVE-10970) Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
[ https://issues.apache.org/jira/browse/HIVE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593803#comment-14593803 ] Yongzhi Chen commented on HIVE-10970: - [~vgumashta], do you find a reproduce? If you have, could you share with me? HIVE-10453 has to be fixed. Thanks Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs Key: HIVE-10970 URL: https://issues.apache.org/jira/browse/HIVE-10970 Project: Hive Issue Type: Bug Reporter: Vaibhav Gumashta Assignee: Vaibhav Gumashta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10970) Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
[ https://issues.apache.org/jira/browse/HIVE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581131#comment-14581131 ] Vaibhav Gumashta commented on HIVE-10970: - [~ychena] Still trying to reproduce, but I do see one issue which I'm trying dig into. On a close, we're closing the thread's classloader, using Utilities#getSessionSpecifiedClassLoader. I'm trying to see what will happen if that thread was later used for handling some other session. If the chain leads to a call to this: http://docs.oracle.com/javase/7/docs/api/java/net/URLClassLoader.html#close(), closing the thread's classloader may not be desirable. Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs Key: HIVE-10970 URL: https://issues.apache.org/jira/browse/HIVE-10970 Project: Hive Issue Type: Bug Reporter: Vaibhav Gumashta Assignee: Vaibhav Gumashta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10970) Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
[ https://issues.apache.org/jira/browse/HIVE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581125#comment-14581125 ] Yongzhi Chen commented on HIVE-10970: - Hi [~vgumashta], have you found the test case? Thanks Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs Key: HIVE-10970 URL: https://issues.apache.org/jira/browse/HIVE-10970 Project: Hive Issue Type: Bug Reporter: Vaibhav Gumashta Assignee: Vaibhav Gumashta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10970) Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
[
https://issues.apache.org/jira/browse/HIVE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581461#comment-14581461
]
Yongzhi Chen commented on HIVE-10970:
-
[~vgumashta], there are perhaps some issues related to thread switch sessions,
following is the code in SessionState.java:
{noformat}
/**
* set current session to existing session object if a thread is running
* multiple sessions - it must call this method with the new session object
* when switching from one session to another.
*/
public static SessionState start(SessionState startSs) {
setCurrentSessionState(startSs);
.
{noformat}
This setCurrentSessionState method will end up calling :
{noformat}
private void attach(HiveConf conf) {
this.conf = conf;
ClassLoader classLoader = conf.getClassLoader();
if (classLoader != null) {
Thread.currentThread().setContextClassLoader(classLoader);
}
}
{noformat}
I wonder if (classLoader == null), what the thread session should be? It looks
not right just use previous session's, should it get some ini classloader for
the new session?
Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
Key: HIVE-10970
URL: https://issues.apache.org/jira/browse/HIVE-10970
Project: Hive
Issue Type: Bug
Reporter: Vaibhav Gumashta
Assignee: Vaibhav Gumashta
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10970) Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
[ https://issues.apache.org/jira/browse/HIVE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579597#comment-14579597 ] Vaibhav Gumashta commented on HIVE-10970: - [~xuefuz] I'm trying to reproduce it locally. Internally, we saw TestJdbcDriver2 fail with several classnotfound exception. As a quick fix, I tried reverting this and it seems to fix the issue. However, before reverting on apache, I'm going to try to get a repro and also come up with why that was happening. Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs Key: HIVE-10970 URL: https://issues.apache.org/jira/browse/HIVE-10970 Project: Hive Issue Type: Bug Reporter: Vaibhav Gumashta Assignee: Vaibhav Gumashta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10970) Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs
[ https://issues.apache.org/jira/browse/HIVE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578852#comment-14578852 ] Xuefu Zhang commented on HIVE-10970: Could you please add description giving the reasoning? Thanks. Revert HIVE-10453: HS2 leaking open file descriptors when using UDFs Key: HIVE-10970 URL: https://issues.apache.org/jira/browse/HIVE-10970 Project: Hive Issue Type: Bug Reporter: Vaibhav Gumashta Assignee: Vaibhav Gumashta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
