[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[ https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582135#comment-14582135 ] Jimmy Xiang commented on HIVE-10976: [~ctang.ma], is it possible to remove the whole method from CLIService? Redundant HiveMetaStore connect check in HS2 CLIService start - Key: HIVE-10976 URL: https://issues.apache.org/jira/browse/HIVE-10976 Project: Hive Issue Type: Bug Components: HiveServer2 Reporter: Chaoyu Tang Assignee: Chaoyu Tang Priority: Trivial Attachments: HIVE-10976.patch During HS2 startup, CLIService start() does a HMS connection test to HMS. It is redundant, since in its init stage, CLIService calls applyAuthorizationConfigPolicy where it starts a sessionState and establishes a connection to HMS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[ https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582182#comment-14582182 ] Chaoyu Tang commented on HIVE-10976: [~jxiang] It is possible since it only calls the upperclass start(), but I thought that but still left it there because 1) to be consistent with the stop method; 2) in case in future CLIService needs add something especially in start, whose method already exists. Redundant HiveMetaStore connect check in HS2 CLIService start - Key: HIVE-10976 URL: https://issues.apache.org/jira/browse/HIVE-10976 Project: Hive Issue Type: Bug Components: HiveServer2 Reporter: Chaoyu Tang Assignee: Chaoyu Tang Priority: Trivial Attachments: HIVE-10976.patch During HS2 startup, CLIService start() does a HMS connection test to HMS. It is redundant, since in its init stage, CLIService calls applyAuthorizationConfigPolicy where it starts a sessionState and establishes a connection to HMS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[ https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582190#comment-14582190 ] Jimmy Xiang commented on HIVE-10976: I see. The other choice is to remove the stop() as well :). Either way is fine with me. Thanks. Redundant HiveMetaStore connect check in HS2 CLIService start - Key: HIVE-10976 URL: https://issues.apache.org/jira/browse/HIVE-10976 Project: Hive Issue Type: Bug Components: HiveServer2 Reporter: Chaoyu Tang Assignee: Chaoyu Tang Priority: Trivial Attachments: HIVE-10976.patch During HS2 startup, CLIService start() does a HMS connection test to HMS. It is redundant, since in its init stage, CLIService calls applyAuthorizationConfigPolicy where it starts a sessionState and establishes a connection to HMS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[ https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582207#comment-14582207 ] Chaoyu Tang commented on HIVE-10976: Thanks, [~jxiang]. Could you help to commit it? Redundant HiveMetaStore connect check in HS2 CLIService start - Key: HIVE-10976 URL: https://issues.apache.org/jira/browse/HIVE-10976 Project: Hive Issue Type: Bug Components: HiveServer2 Reporter: Chaoyu Tang Assignee: Chaoyu Tang Priority: Trivial Attachments: HIVE-10976.patch During HS2 startup, CLIService start() does a HMS connection test to HMS. It is redundant, since in its init stage, CLIService calls applyAuthorizationConfigPolicy where it starts a sessionState and establishes a connection to HMS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[ https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580586#comment-14580586 ] Jimmy Xiang commented on HIVE-10976: +1 Redundant HiveMetaStore connect check in HS2 CLIService start - Key: HIVE-10976 URL: https://issues.apache.org/jira/browse/HIVE-10976 Project: Hive Issue Type: Bug Components: HiveServer2 Reporter: Chaoyu Tang Assignee: Chaoyu Tang Priority: Trivial Attachments: HIVE-10976.patch During HS2 startup, CLIService start() does a HMS connection test to HMS. It is redundant, since in its init stage, CLIService calls applyAuthorizationConfigPolicy where it starts a sessionState and establishes a connection to HMS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[ https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580717#comment-14580717 ] Chaoyu Tang commented on HIVE-10976: These failed tests seem not relevant to this patch. Redundant HiveMetaStore connect check in HS2 CLIService start - Key: HIVE-10976 URL: https://issues.apache.org/jira/browse/HIVE-10976 Project: Hive Issue Type: Bug Components: HiveServer2 Reporter: Chaoyu Tang Assignee: Chaoyu Tang Priority: Trivial Attachments: HIVE-10976.patch During HS2 startup, CLIService start() does a HMS connection test to HMS. It is redundant, since in its init stage, CLIService calls applyAuthorizationConfigPolicy where it starts a sessionState and establishes a connection to HMS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10976) Redundant HiveMetaStore connect check in HS2 CLIService start
[
https://issues.apache.org/jira/browse/HIVE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580633#comment-14580633
]
Hive QA commented on HIVE-10976:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12738823/HIVE-10976.patch
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 8993 tests executed
*Failed tests:*
{noformat}
TestCliDriver-auto_join_reordering_values.q-auto_sortmerge_join_7.q-progress_1.q-and-12-more
- did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_index_bitmap3
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_stats_counter_partitioned
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_join28
org.apache.hive.beeline.TestSchemaTool.testSchemaInit
org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4236/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4236/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4236/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12738823 - PreCommit-HIVE-TRUNK-Build
Redundant HiveMetaStore connect check in HS2 CLIService start
-
Key: HIVE-10976
URL: https://issues.apache.org/jira/browse/HIVE-10976
Project: Hive
Issue Type: Bug
Components: HiveServer2
Reporter: Chaoyu Tang
Assignee: Chaoyu Tang
Priority: Trivial
Attachments: HIVE-10976.patch
During HS2 startup, CLIService start() does a HMS connection test to HMS.
It is redundant, since in its init stage, CLIService calls
applyAuthorizationConfigPolicy where it starts a sessionState and establishes
a connection to HMS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
