[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726411#comment-14726411
]
Sushanth Sowmyan commented on HIVE-11123:
-
I think HIVE-11668 is close to committing (after I verify), so I think we can
hold off on reverting this, since it is actually still useful. Otherwise, I'd
agree that this was a revert-candidate.
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch, HIVE-11123.4a.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726217#comment-14726217
]
Xuefu Zhang commented on HIVE-11123:
Thanks, guys. Should we revert this commit though?
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch, HIVE-11123.4a.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720402#comment-14720402
]
Sushanth Sowmyan commented on HIVE-11123:
-
Also, this patch broke hive working against mysql and potentially other dbs - I
will follow up with comments on HIVE-11668. Testing with derby alone in unit
test mode is problematic. Sorry I didn't catch this before it was committed.
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch, HIVE-11123.4a.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717268#comment-14717268
]
Sergey Shelukhin commented on HIVE-11123:
-
HIVE-11668
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch, HIVE-11123.4a.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717225#comment-14717225
]
Sergey Shelukhin commented on HIVE-11123:
-
Hmm.. it's a good point. It was only called during init before, though, I
wonder how it ever worked. Luck? Magic? I will make a fix on top
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch, HIVE-11123.4a.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717193#comment-14717193
]
Ashutosh Chauhan commented on HIVE-11123:
-
I am not sure if this will work for mysql. Earlier, determineDbType() was
overloaded which also executed actual logic alongwith db detection which will
no longer be the case. e.g, {{SET @@session.sql_mode=ANSI_QUOTES}} will not
execute any longer for mysql, which may cause problems.
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717128#comment-14717128
]
Sergey Shelukhin commented on HIVE-11123:
-
This has been around for a while... I will commit today if there are no
objections.
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710538#comment-14710538
]
Shinichi Yamashita commented on HIVE-11123:
---
[~deepesh] Thank you for your comment. I confirmed version Oracle 11g R2 and
12c. And I could get the same value "Oracle" by both versions.
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710109#comment-14710109
]
Deepesh Khandelwal commented on HIVE-11123:
---
[~sinchii] thanks for the patch! What version of Oracle did you use for testing
this? We saw some issues with existing code (without your patch) on Oracle 12
whereas it worked fine on Oracle 11. Just want to make sure that it works as
expected between different Oracle versions.
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch, HIVE-11123.4.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608967#comment-14608967
]
Hive QA commented on HIVE-11123:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12742828/HIVE-11123.3.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9034 tests executed
*Failed tests:*
{noformat}
TestMarkPartition - did not produce a TEST-*.xml file
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4446/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4446/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4446/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12742828 - PreCommit-HIVE-TRUNK-Build
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch,
> HIVE-11123.3.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606544#comment-14606544
]
Sergey Shelukhin commented on HIVE-11123:
-
+1. Small nit: null check can be done once
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606018#comment-14606018
]
Hive QA commented on HIVE-11123:
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12742520/HIVE-11123.2.patch
{color:green}SUCCESS:{color} +1 9034 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4431/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4431/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4431/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12742520 - PreCommit-HIVE-TRUNK-Build
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch, HIVE-11123.2.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604380#comment-14604380
]
Ashutosh Chauhan commented on HIVE-11123:
-
Have you tested this with other DBs like mysql, MS sql server and oracle?
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11123) Fix how to confirm the RDBMS product name at Metastore.
[
https://issues.apache.org/jira/browse/HIVE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604124#comment-14604124
]
Hive QA commented on HIVE-11123:
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12742290/HIVE-11123.1.patch
{color:green}SUCCESS:{color} +1 9030 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4408/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4408/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4408/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12742290 - PreCommit-HIVE-TRUNK-Build
> Fix how to confirm the RDBMS product name at Metastore.
> ---
>
> Key: HIVE-11123
> URL: https://issues.apache.org/jira/browse/HIVE-11123
> Project: Hive
> Issue Type: Bug
> Components: Metastore
>Affects Versions: 1.2.0
> Environment: PostgreSQL
>Reporter: Shinichi Yamashita
>Assignee: Shinichi Yamashita
> Attachments: HIVE-11123.1.patch
>
>
> I use PostgreSQL to Hive Metastore. And I saw the following message at
> PostgreSQL log.
> {code}
> < 2015-06-26 10:58:15.488 JST >ERROR: syntax error at or near "@@" at
> character 5
> < 2015-06-26 10:58:15.488 JST >STATEMENT: SET @@session.sql_mode=ANSI_QUOTES
> < 2015-06-26 10:58:15.489 JST >ERROR: relation "v$instance" does not exist
> at character 21
> < 2015-06-26 10:58:15.489 JST >STATEMENT: SELECT version FROM v$instance
> < 2015-06-26 10:58:15.490 JST >ERROR: column "version" does not exist at
> character 10
> < 2015-06-26 10:58:15.490 JST >STATEMENT: SELECT @@version
> {code}
> When Hive CLI and Beeline embedded mode are carried out, this message is
> output to PostgreSQL log.
> These queries are called from MetaStoreDirectSql#determineDbType. And if we
> use MetaStoreDirectSql#getProductName, we need not to call these queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
