[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-19 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632989#comment-14632989
 ] 

Ferdinand Xu commented on HIVE-11244:
-

+1

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.1.patch, HIVE-11244.2.patch, 
> HIVE-11244.patch, HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-18 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632306#comment-14632306
 ] 

Hive QA commented on HIVE-11244:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12745920/HIVE-11244.2.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9226 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cbo_rp_join0
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4648/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4648/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4648/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12745920 - PreCommit-HIVE-TRUNK-Build

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.1.patch, HIVE-11244.2.patch, 
> HIVE-11244.patch, HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-16 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630664#comment-14630664
 ] 

Ferdinand Xu commented on HIVE-11244:
-

Could you take a look at the failed test case 
"org.apache.hive.jdbc.TestJdbcWithLocalClusterSpark.testTempTable"?
Also some minor issues about code style, you can refer the wiki for details. 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions
{noformat}
1236  return getPrompt(getDatabaseConnections().getIndex()  1238
  return getPrompt(getDatabaseConnections().getIndex()
1237  + ": " + getDatabaseConnection().getUrl()) + printClosed + "> 
";  1239  + ": " + url) + printClosed + "> ";
{noformat}
No need for breaking line.
{noformat}
181 \  --showConnectedUrl=[true/false] prompt HiveServer2's 
IP to which this beeline connected.Only works for HiveServer2 cluster mode.\n \
{noformat}
Extra space needed after the first sentence and IP should be URI.

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.1.patch, HIVE-11244.patch, HIVE-11244.patch, 
> HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-16 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630051#comment-14630051
 ] 

Hive QA commented on HIVE-11244:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12745623/HIVE-11244.1.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9220 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cbo_rp_join0
org.apache.hive.jdbc.TestJdbcWithLocalClusterSpark.testTempTable
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4629/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4629/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4629/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12745623 - PreCommit-HIVE-TRUNK-Build

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.1.patch, HIVE-11244.patch, HIVE-11244.patch, 
> HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-15 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629137#comment-14629137
 ] 

Ferdinand Xu commented on HIVE-11244:
-

It will be great to follow the instructions in 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-UpdatingaPatch
 when you update the patch.

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.patch, HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-15 Thread Nemon Lou (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628158#comment-14628158
 ] 

Nemon Lou commented on HIVE-11244:
--

Will fire CI tests later when i'm sure it works.

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.patch, HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-15 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627685#comment-14627685
 ] 

Ferdinand Xu commented on HIVE-11244:
-

Hi [~nemon], regards backward compatibility, we should have an option changing 
back to the previous prompt format. Could you update your patch for that?

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>  Labels: TODOC2.0
> Attachments: HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-15 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627643#comment-14627643
 ] 

Ferdinand Xu commented on HIVE-11244:
-

+1

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
> Attachments: HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-14 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627618#comment-14627618
 ] 

Hive QA commented on HIVE-11244:




{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12745276/HIVE-11244.patch

{color:green}SUCCESS:{color} +1 9190 tests passed

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4616/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4616/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4616/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12745276 - PreCommit-HIVE-TRUNK-Build

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
> Attachments: HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-14 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626047#comment-14626047
 ] 

Ferdinand Xu commented on HIVE-11244:
-

Please indent two (2) spaces per level, not four (4). 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
> Attachments: HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-14 Thread Nemon Lou (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625998#comment-14625998
 ] 

Nemon Lou commented on HIVE-11244:
--

The basic idea is adding a new getUrl method for prompt display and using some 
hook to get current HiveConnection's connected URI.
Since connected URI  already exists in HiveConnection's jdbcUriString 
property,it's easy to get it.

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode

2015-07-13 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625943#comment-14625943
 ] 

Ferdinand Xu commented on HIVE-11244:
-

Could you explain more about your steps? I take a look at the code and seems 
it's using the current connection url as part of the prompt info.

> Beeline prompt info improvement for cluster mode
> 
>
> Key: HIVE-11244
> URL: https://issues.apache.org/jira/browse/HIVE-11244
> Project: Hive
>  Issue Type: Improvement
>  Components: Beeline
>Affects Versions: 1.2.0
>Reporter: Nemon Lou
>Assignee: Nemon Lou
>Priority: Minor
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful 
> for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)