[jira] [Commented] (HIVE-11311) Avoid dumping AST tree String in Explain unless necessary

2015-07-21 Thread Hari Sankar Sivarama Subramaniyan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634882#comment-14634882
 ] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-11311:
--

+1

> Avoid dumping AST tree String in Explain unless necessary
> -
>
> Key: HIVE-11311
> URL: https://issues.apache.org/jira/browse/HIVE-11311
> Project: Hive
>  Issue Type: Bug
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-11311.patch
>
>
> Currently, the AST tree String representation is created even if it is not 
> used; we should dump it only if we are going to use it (explain extended).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11311) Avoid dumping AST tree String in Explain unless necessary

2015-07-21 Thread Jesus Camacho Rodriguez (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634827#comment-14634827
 ] 

Jesus Camacho Rodriguez commented on HIVE-11311:


[~hsubramaniyan], could you review this one? Thanks

> Avoid dumping AST tree String in Explain unless necessary
> -
>
> Key: HIVE-11311
> URL: https://issues.apache.org/jira/browse/HIVE-11311
> Project: Hive
>  Issue Type: Bug
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-11311.patch
>
>
> Currently, the AST tree String representation is created even if it is not 
> used; we should dump it only if we are going to use it (explain extended).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11311) Avoid dumping AST tree String in Explain unless necessary

2015-07-19 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632834#comment-14632834
 ] 

Hive QA commented on HIVE-11311:




{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12746001/HIVE-11311.patch

{color:green}SUCCESS:{color} +1 9226 tests passed

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4657/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4657/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4657/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12746001 - PreCommit-HIVE-TRUNK-Build

> Avoid dumping AST tree String in Explain unless necessary
> -
>
> Key: HIVE-11311
> URL: https://issues.apache.org/jira/browse/HIVE-11311
> Project: Hive
>  Issue Type: Bug
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-11311.patch
>
>
> Currently, the AST tree String representation is created even if it is not 
> used; we should dump it only if we are going to use it (explain extended).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)