[jira] [Commented] (HIVE-11498) HIVE Authorization v2 should not check permission for dummy entity
[
https://issues.apache.org/jira/browse/HIVE-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681190#comment-14681190
]
Dapeng Sun commented on HIVE-11498:
---
Thank [~thejas] and [~dongc] for your review.
> HIVE Authorization v2 should not check permission for dummy entity
> --
>
> Key: HIVE-11498
> URL: https://issues.apache.org/jira/browse/HIVE-11498
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Affects Versions: 1.2.0, 1.3.0, 2.0.0
>Reporter: Dapeng Sun
>Assignee: Dapeng Sun
> Fix For: 1.3.0, 1.2.1, 2.0.0
>
> Attachments: HIVE-11498.001.patch, HIVE-11498.002.patch,
> HIVE-11498.003.patch
>
>
> The queries like {{SELECT 1+1;}}, The target table and database will set to
> {{_dummy_database}} {{_dummy_table}}, authorization should skip these kinds
> of databases or tables.
> For authz v1. it has skip them.
> eg1. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L600]
> {noformat}
> for (WriteEntity write : outputs) {
> if (write.isDummy() || write.isPathType()) {
> continue;
> }
> {noformat}
> eg2. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L633]
> {noformat}
> for (ReadEntity read : inputs) {
> if (read.isDummy() || read.isPathType()) {
> continue;
> }
>...
> }
> {noformat}
> ...
> This patch will fix authz v2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11498) HIVE Authorization v2 should not check permission for dummy entity
[
https://issues.apache.org/jira/browse/HIVE-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681187#comment-14681187
]
Dong Chen commented on HIVE-11498:
--
Thanks for your review on this patch! [~thejas]
> HIVE Authorization v2 should not check permission for dummy entity
> --
>
> Key: HIVE-11498
> URL: https://issues.apache.org/jira/browse/HIVE-11498
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Affects Versions: 1.2.0, 1.3.0, 2.0.0
>Reporter: Dapeng Sun
>Assignee: Dapeng Sun
> Fix For: 1.3.0, 1.2.1, 2.0.0
>
> Attachments: HIVE-11498.001.patch, HIVE-11498.002.patch,
> HIVE-11498.003.patch
>
>
> The queries like {{SELECT 1+1;}}, The target table and database will set to
> {{_dummy_database}} {{_dummy_table}}, authorization should skip these kinds
> of databases or tables.
> For authz v1. it has skip them.
> eg1. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L600]
> {noformat}
> for (WriteEntity write : outputs) {
> if (write.isDummy() || write.isPathType()) {
> continue;
> }
> {noformat}
> eg2. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L633]
> {noformat}
> for (ReadEntity read : inputs) {
> if (read.isDummy() || read.isPathType()) {
> continue;
> }
>...
> }
> {noformat}
> ...
> This patch will fix authz v2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11498) HIVE Authorization v2 should not check permission for dummy entity
[
https://issues.apache.org/jira/browse/HIVE-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681180#comment-14681180
]
Dong Chen commented on HIVE-11498:
--
[~dapengsun] Thanks for your contribution! I have commit this to master,
branch-1, and branch-1.2.
> HIVE Authorization v2 should not check permission for dummy entity
> --
>
> Key: HIVE-11498
> URL: https://issues.apache.org/jira/browse/HIVE-11498
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Affects Versions: 1.2.0, 1.3.0, 2.0.0
>Reporter: Dapeng Sun
>Assignee: Dapeng Sun
> Fix For: 1.3.0, 1.2.1, 2.0.0
>
> Attachments: HIVE-11498.001.patch, HIVE-11498.002.patch,
> HIVE-11498.003.patch
>
>
> The queries like {{SELECT 1+1;}}, The target table and database will set to
> {{_dummy_database}} {{_dummy_table}}, authorization should skip these kinds
> of databases or tables.
> For authz v1. it has skip them.
> eg1. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L600]
> {noformat}
> for (WriteEntity write : outputs) {
> if (write.isDummy() || write.isPathType()) {
> continue;
> }
> {noformat}
> eg2. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L633]
> {noformat}
> for (ReadEntity read : inputs) {
> if (read.isDummy() || read.isPathType()) {
> continue;
> }
>...
> }
> {noformat}
> ...
> This patch will fix authz v2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11498) HIVE Authorization v2 should not check permission for dummy entity
[
https://issues.apache.org/jira/browse/HIVE-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663067#comment-14663067
]
Hive QA commented on HIVE-11498:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749206/HIVE-11498.003.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9344 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4874/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4874/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4874/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12749206 - PreCommit-HIVE-TRUNK-Build
> HIVE Authorization v2 should not check permission for dummy entity
> --
>
> Key: HIVE-11498
> URL: https://issues.apache.org/jira/browse/HIVE-11498
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Affects Versions: 1.2.0, 1.3.0, 2.0.0
>Reporter: Dapeng Sun
>Assignee: Dapeng Sun
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11498.001.patch, HIVE-11498.002.patch,
> HIVE-11498.003.patch
>
>
> The queries like {{SELECT 1+1;}}, The target table and database will set to
> {{_dummy_database}} {{_dummy_table}}, authorization should skip these kinds
> of databases or tables.
> For authz v1. it has skip them.
> eg1. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L600]
> {noformat}
> for (WriteEntity write : outputs) {
> if (write.isDummy() || write.isPathType()) {
> continue;
> }
> {noformat}
> eg2. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L633]
> {noformat}
> for (ReadEntity read : inputs) {
> if (read.isDummy() || read.isPathType()) {
> continue;
> }
>...
> }
> {noformat}
> ...
> This patch will fix authz v2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11498) HIVE Authorization v2 should not check permission for dummy entity
[
https://issues.apache.org/jira/browse/HIVE-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662456#comment-14662456
]
Thejas M Nair commented on HIVE-11498:
--
+1
Thanks for the patch [~dapengsun]
Thanks for pointing me to this change [~dongc]
> HIVE Authorization v2 should not check permission for dummy entity
> --
>
> Key: HIVE-11498
> URL: https://issues.apache.org/jira/browse/HIVE-11498
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Affects Versions: 1.2.0, 1.3.0, 2.0.0
>Reporter: Dapeng Sun
>Assignee: Dapeng Sun
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11498.001.patch, HIVE-11498.002.patch,
> HIVE-11498.003.patch
>
>
> The queries like {{SELECT 1+1;}}, The target table and database will set to
> {{_dummy_database}} {{_dummy_table}}, authorization should skip these kinds
> of databases or tables.
> For authz v1. it has skip them.
> eg1. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L600]
> {noformat}
> for (WriteEntity write : outputs) {
> if (write.isDummy() || write.isPathType()) {
> continue;
> }
> {noformat}
> eg2. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L633]
> {noformat}
> for (ReadEntity read : inputs) {
> if (read.isDummy() || read.isPathType()) {
> continue;
> }
>...
> }
> {noformat}
> ...
> This patch will fix authz v2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11498) HIVE Authorization v2 should not check permission for dummy entity
[
https://issues.apache.org/jira/browse/HIVE-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661515#comment-14661515
]
Dong Chen commented on HIVE-11498:
--
[~dapengsun], thanks for the patch.
LGTM, pending tests.
[~thejas] would you like to take a look at this change about auth v2, and
further comments? Thanks.
> HIVE Authorization v2 should not check permission for dummy entity
> --
>
> Key: HIVE-11498
> URL: https://issues.apache.org/jira/browse/HIVE-11498
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Affects Versions: 1.2.0, 1.3.0, 2.0.0
>Reporter: Dapeng Sun
>Assignee: Dapeng Sun
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11498.001.patch, HIVE-11498.002.patch,
> HIVE-11498.003.patch
>
>
> The queries like {{SELECT 1+1;}}, The target table and database will set to
> {{_dummy_database}} {{_dummy_table}}, authorization should skip these kinds
> of databases or tables.
> For authz v1. it has skip them.
> eg1. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L600]
> {noformat}
> for (WriteEntity write : outputs) {
> if (write.isDummy() || write.isPathType()) {
> continue;
> }
> {noformat}
> eg2. [Source code at
> github|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L633]
> {noformat}
> for (ReadEntity read : inputs) {
> if (read.isDummy() || read.isPathType()) {
> continue;
> }
>...
> }
> {noformat}
> ...
> This patch will fix authz v2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
