[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-11-11 Thread Ferdinand Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001620#comment-15001620
 ] 

Ferdinand Xu commented on HIVE-11504:
-

Yes, it depends on HIVE-11618. I tried to backport HIVE-11618 first but failed 
since it has many other depends. Do you have any suggestions? Thank you!

> Predicate pushing down doesn't work for float type for Parquet
> --
>
> Key: HIVE-11504
> URL: https://issues.apache.org/jira/browse/HIVE-11504
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Ferdinand Xu
>Assignee: Ferdinand Xu
> Fix For: 2.0.0
>
> Attachments: HIVE-11504.1.patch, HIVE-11504.1.patch, 
> HIVE-11504.2.patch, HIVE-11504.2.patch, HIVE-11504.3.patch, 
> HIVE-11504.4.patch, HIVE-11504.patch
>
>
> Predicate builder should use PrimitiveTypeName type in parquet side to 
> construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-31 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723521#comment-14723521
 ] 

Sergio Peña commented on HIVE-11504:


+1
Thanks [~Ferd] for this, and [~owen.omalley] for your review of the past patch.

> Predicate pushing down doesn't work for float type for Parquet
> --
>
> Key: HIVE-11504
> URL: https://issues.apache.org/jira/browse/HIVE-11504
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Ferdinand Xu
>Assignee: Ferdinand Xu
> Attachments: HIVE-11504.1.patch, HIVE-11504.1.patch, 
> HIVE-11504.2.patch, HIVE-11504.2.patch, HIVE-11504.3.patch, 
> HIVE-11504.4.patch, HIVE-11504.patch
>
>
> Predicate builder should use PrimitiveTypeName type in parquet side to 
> construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-31 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723388#comment-14723388
 ] 

Hive QA commented on HIVE-11504:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12753250/HIVE-11504.4.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9383 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5122/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5122/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5122/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12753250 - PreCommit-HIVE-TRUNK-Build

> Predicate pushing down doesn't work for float type for Parquet
> --
>
> Key: HIVE-11504
> URL: https://issues.apache.org/jira/browse/HIVE-11504
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Ferdinand Xu
>Assignee: Ferdinand Xu
> Attachments: HIVE-11504.1.patch, HIVE-11504.1.patch, 
> HIVE-11504.2.patch, HIVE-11504.2.patch, HIVE-11504.3.patch, 
> HIVE-11504.4.patch, HIVE-11504.patch
>
>
> Predicate builder should use PrimitiveTypeName type in parquet side to 
> construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-28 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720752#comment-14720752
 ] 

Sergio Peña commented on HIVE-11504:


Thanks [~Ferd] for the patch.

I committed the patch from HIVE-11618 that uses INTEGER/LONG. Could you take a 
look at the current commit and make the changes for FLOAT/DOUBLE? I think that 
patch look easier.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.1.patch, 
 HIVE-11504.2.patch, HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-24 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709482#comment-14709482
 ] 

Owen O'Malley commented on HIVE-11504:
--

Ok, I wrote the patch that addresses Parquet's problem without needlessly 
complicating the SARG API by splitting out the integer or float types. Please 
see HIVE-11618.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-21 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706981#comment-14706981
 ] 

Owen O'Malley commented on HIVE-11504:
--

The goal is simplicity.

For the types that are strict super-type, there is no point in distinguishing 
them. It will just make all of the users of the api add more switch statements.

So my point is the x = 1000 means exactly the same thing if x and 1000 are 
longs or integers. Note that this is completely different than if x were double 
or string.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-21 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706990#comment-14706990
 ] 

Owen O'Malley commented on HIVE-11504:
--

If you need to differentiate the types for parquet, please do that in the 
parquet bindings and not in the generic api. Hive of course gives you the 
precise types so the input format has the necessary information already.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-18 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700784#comment-14700784
 ] 

Hive QA commented on HIVE-11504:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12750950/HIVE-11504.3.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9366 tests executed
*Failed tests:*
{noformat}
TestJdbcWithMiniKdc - did not produce a TEST-*.xml file
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4992/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4992/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4992/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12750950 - PreCommit-HIVE-TRUNK-Build

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-18 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701763#comment-14701763
 ] 

Owen O'Malley commented on HIVE-11504:
--

This patch seems problematic. 

The SARGs were better done with no distinction between int/long and 
float/double. What was the original motivation for the change? 

I believe we should roll back both changes, so I'm -1 on this patch for now.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-18 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702070#comment-14702070
 ] 

Sergio Peña commented on HIVE-11504:


Thanks for your comment [~owen.omalley].  
What's the problem with differentiating between float and double? I see int and 
long are already implemented.

The motivation for this is that we want to get the type of the expression so 
that we can push the correct filter to Parquet. Right now we cannot push FLOAT 
because the expression gets DOUBLE.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-18 Thread Ferdinand Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702238#comment-14702238
 ] 

Ferdinand Xu commented on HIVE-11504:
-

Thanks for your review [~owen.omalley] and your clarification [~spena]. 
Parquet uses the Hive search argument to construct its predication and it 
treats float/double and int/long as different types. So we have to pass in with 
its original types. You can find detailed information in HIVE-8122. I think 
this patch should have no impact since it's converted to double type finally in 
the method RecordReaderImpl#getBaseObjectForComparison. Feel free to let me 
what's your thoughts.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-18 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701390#comment-14701390
 ] 

Sergio Peña commented on HIVE-11504:


Thanks [~Ferd]. This looks much better.
+1

[~prasanth_j] I see you made some improvements on ORC predicate. Ferdinand 
added support for DOUBLE types on the ConvertAstToSearchArg class. He added 
such type on a couple of ORC files. Could you help us verify the change looks 
correct, and if there is anything else from ORC to change?

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-17 Thread Ferdinand Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700642#comment-14700642
 ] 

Ferdinand Xu commented on HIVE-11504:
-

Hi [~spena], can you help me review this patch? Thanks!

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.3.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-11 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681667#comment-14681667
 ] 

Hive QA commented on HIVE-11504:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749733/HIVE-11504.2.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9350 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_parquet_predicate_pushdown
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4917/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4917/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4917/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12749733 - PreCommit-HIVE-TRUNK-Build

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-11 Thread Ferdinand Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682039#comment-14682039
 ] 

Ferdinand Xu commented on HIVE-11504:
-

Thanks [~spena] for your comments. I remove the default constructor since we 
can only evaluate the real type for certain column with the help of schema. You 
can see that the predicate leaf has a limited type and for float and double, 
they should use different builders for parquet.

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.2.patch, 
 HIVE-11504.2.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-10 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680749#comment-14680749
 ] 

Hive QA commented on HIVE-11504:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749615/HIVE-11504.1.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9348 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.io.parquet.read.TestParquetFilterPredicate.testFilterColumnsThatDoNoExistOnSchema
org.apache.hadoop.hive.ql.io.parquet.read.TestParquetFilterPredicate.testFilterFloatColumns
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4908/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4908/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4908/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12749615 - PreCommit-HIVE-TRUNK-Build

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.1.patch, HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-11504) Predicate pushing down doesn't work for float type for Parquet

2015-08-10 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679785#comment-14679785
 ] 

Hive QA commented on HIVE-11504:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749516/HIVE-11504.patch

{color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 9347 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.io.parquet.TestParquetRecordReaderWrapper.testBuilder
org.apache.hadoop.hive.ql.io.parquet.TestParquetRecordReaderWrapper.testBuilderComplexTypes
org.apache.hadoop.hive.ql.io.parquet.TestParquetRecordReaderWrapper.testBuilderComplexTypes2
org.apache.hadoop.hive.ql.io.parquet.TestParquetRecordReaderWrapper.testBuilderFloat
org.apache.hadoop.hive.ql.io.parquet.read.TestParquetFilterPredicate.testFilterColumnsThatDoNoExistOnSchema
org.apache.hadoop.hive.ql.io.parquet.read.TestParquetFilterPredicate.testFilterFloatColumns
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression1
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression10
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression2
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression3
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression4
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression5
org.apache.hadoop.hive.ql.io.sarg.TestConvertAstToSearchArg.testExpression7
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4899/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4899/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4899/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 14 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12749516 - PreCommit-HIVE-TRUNK-Build

 Predicate pushing down doesn't work for float type for Parquet
 --

 Key: HIVE-11504
 URL: https://issues.apache.org/jira/browse/HIVE-11504
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu
 Attachments: HIVE-11504.patch


 Predicate builder should use PrimitiveTypeName type in parquet side to 
 construct predicate leaf instead of the type provided by PredicateLeaf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)