[jira] [Commented] (HIVE-11688) OrcRawRecordMerger does not close primary reader if not fully consumed
[
https://issues.apache.org/jira/browse/HIVE-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737030#comment-14737030
]
Sudheesh Katkam commented on HIVE-11688:
*ping*
> OrcRawRecordMerger does not close primary reader if not fully consumed
> --
>
> Key: HIVE-11688
> URL: https://issues.apache.org/jira/browse/HIVE-11688
> Project: Hive
> Issue Type: Bug
> Components: File Formats
>Reporter: Sudheesh Katkam
>Assignee: Sudheesh Katkam
> Labels: orc
> Attachments: HIVE-11688.patch
>
>
> If {{OrcRawRecordMerger#close}} is called before fully reading an orc file,
> the {{primary}} reader is not closed.
> The {{primary}} reader is assigned using {{readers.pollFirstEntry()}} which
> deletes the reader from {{readers}}, and currently the
> {{OrcRawRecordMerger#close}} method only closes readers in the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11688) OrcRawRecordMerger does not close primary reader if not fully consumed
[
https://issues.apache.org/jira/browse/HIVE-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725718#comment-14725718
]
Sudheesh Katkam commented on HIVE-11688:
[~prasanth_j] can this be merged? Or do the tests need to be run again, now
that the master has moved?
> OrcRawRecordMerger does not close primary reader if not fully consumed
> --
>
> Key: HIVE-11688
> URL: https://issues.apache.org/jira/browse/HIVE-11688
> Project: Hive
> Issue Type: Bug
> Components: File Formats
>Reporter: Sudheesh Katkam
>Assignee: Sudheesh Katkam
> Labels: orc
> Attachments: HIVE-11688.patch
>
>
> If {{OrcRawRecordMerger#close}} is called before fully reading an orc file,
> the {{primary}} reader is not closed.
> The {{primary}} reader is assigned using {{readers.pollFirstEntry()}} which
> deletes the reader from {{readers}}, and currently the
> {{OrcRawRecordMerger#close}} method only closes readers in the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11688) OrcRawRecordMerger does not close primary reader if not fully consumed
[
https://issues.apache.org/jira/browse/HIVE-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723807#comment-14723807
]
Prasanth Jayachandran commented on HIVE-11688:
--
LGTM, +1. The test failure seems to be unrelated.
> OrcRawRecordMerger does not close primary reader if not fully consumed
> --
>
> Key: HIVE-11688
> URL: https://issues.apache.org/jira/browse/HIVE-11688
> Project: Hive
> Issue Type: Bug
> Components: File Formats
>Reporter: Sudheesh Katkam
>Assignee: Sudheesh Katkam
> Labels: orc
> Attachments: HIVE-11688.patch
>
>
> If {{OrcRawRecordMerger#close}} is called before fully reading an orc file,
> the {{primary}} reader is not closed.
> The {{primary}} reader is assigned using {{readers.pollFirstEntry()}} which
> deletes the reader from {{readers}}, and currently the
> {{OrcRawRecordMerger#close}} method only closes readers in the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11688) OrcRawRecordMerger does not close primary reader if not fully consumed
[
https://issues.apache.org/jira/browse/HIVE-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720986#comment-14720986
]
Hive QA commented on HIVE-11688:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12753083/HIVE-11688.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9380 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5110/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5110/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5110/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12753083 - PreCommit-HIVE-TRUNK-Build
OrcRawRecordMerger does not close primary reader if not fully consumed
--
Key: HIVE-11688
URL: https://issues.apache.org/jira/browse/HIVE-11688
Project: Hive
Issue Type: Bug
Components: File Formats
Reporter: Sudheesh Katkam
Labels: orc
Attachments: HIVE-11688.patch
If {{OrcRawRecordMerger#close}} is called before fully reading an orc file,
the {{primary}} reader is not closed.
The {{primary}} reader is assigned using {{readers.pollFirstEntry()}} which
deletes the reader from {{readers}}, and currently the
{{OrcRawRecordMerger#close}} method only closes readers in the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11688) OrcRawRecordMerger does not close primary reader if not fully consumed
[
https://issues.apache.org/jira/browse/HIVE-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720723#comment-14720723
]
Sudheesh Katkam commented on HIVE-11688:
Review board [link|https://reviews.apache.org/r/37909/].
OrcRawRecordMerger does not close primary reader if not fully consumed
--
Key: HIVE-11688
URL: https://issues.apache.org/jira/browse/HIVE-11688
Project: Hive
Issue Type: Bug
Components: File Formats
Reporter: Sudheesh Katkam
Labels: orc
Attachments: HIVE-11688.patch
If {{OrcRawRecordMerger#close}} is called before fully reading an orc file,
the {{primary}} reader is not closed.
The {{primary}} reader is assigned using {{readers.pollFirstEntry()}} which
deletes the reader from {{readers}}, and currently the
{{OrcRawRecordMerger#close}} method only closes readers in the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
