[jira] [Commented] (HIVE-11883) 'transactional' table property for ACID should be case insensitive

2015-10-03 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942147#comment-14942147
 ] 

Lefty Leverenz commented on HIVE-11883:
---

Doc note:  The "Table Properties" section of the Hive Transactions wikidoc 
needs to be updated for this change, with version information.

* [Hive Transactions -- Table Properties | 
https://cwiki.apache.org/confluence/display/Hive/Hive+Transactions#HiveTransactions-TableProperties]

The DDL wikidoc doesn't need any change -- it just shows lowercase 
"transactional" and refers to Hive Transactions for more information.  (However 
it does need revision for HIVE-8308, which made "NO_AUTO_COMPACTION" 
case-insensitive in 1.1.0.)

> 'transactional' table property for ACID should be case insensitive
> --
>
> Key: HIVE-11883
> URL: https://issues.apache.org/jira/browse/HIVE-11883
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 1.0.0
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
>  Labels: TODOC1.3
> Fix For: 1.3.0
>
> Attachments: HIVE-11883.patch
>
>
> Given:
> {noformat}
> CREATE TABLE mytable (col1 int, col2 string)
> CLUSTERED BY (col1) INTO 2 BUCKETS
> STORED AS ORC TBLPROPERTIES('TRANSACTIONAL'='TRUE');
> {noformat}
> update/delete statements will fail with 
> {noformat}
> FAILED: SemanticException [Error 10122]: Bucketized tables do not support 
> INSERT INTO: Table: default.mytable
> {noformat}
> but 'transactional' (in lower case) works fine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11883) 'transactional' table property for ACID should be case insensitive

2015-09-30 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936818#comment-14936818
 ] 

Hive QA commented on HIVE-11883:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12764174/HIVE-11883.patch

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 9638 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vector_groupby_reduce
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_groupby_reduce
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5469/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5469/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5469/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12764174 - PreCommit-HIVE-TRUNK-Build

> 'transactional' table property for ACID should be case insensitive
> --
>
> Key: HIVE-11883
> URL: https://issues.apache.org/jira/browse/HIVE-11883
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 1.0.0
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-11883.patch
>
>
> Given:
> {noformat}
> CREATE TABLE mytable (col1 int, col2 string)
> CLUSTERED BY (col1) INTO 2 BUCKETS
> STORED AS ORC TBLPROPERTIES('TRANSACTIONAL'='TRUE');
> {noformat}
> update/delete statements will fail with 
> {noformat}
> FAILED: SemanticException [Error 10122]: Bucketized tables do not support 
> INSERT INTO: Table: default.mytable
> {noformat}
> but 'transactional' (in lower case) works fine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11883) 'transactional' table property for ACID should be case insensitive

2015-09-30 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937689#comment-14937689
 ] 

Ashutosh Chauhan commented on HIVE-11883:
-

+1 
Although it doesn't cover mixed case {{TRANSACTIONAL}} I believe that is rare.

> 'transactional' table property for ACID should be case insensitive
> --
>
> Key: HIVE-11883
> URL: https://issues.apache.org/jira/browse/HIVE-11883
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 1.0.0
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-11883.patch
>
>
> Given:
> {noformat}
> CREATE TABLE mytable (col1 int, col2 string)
> CLUSTERED BY (col1) INTO 2 BUCKETS
> STORED AS ORC TBLPROPERTIES('TRANSACTIONAL'='TRUE');
> {noformat}
> update/delete statements will fail with 
> {noformat}
> FAILED: SemanticException [Error 10122]: Bucketized tables do not support 
> INSERT INTO: Table: default.mytable
> {noformat}
> but 'transactional' (in lower case) works fine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-11883) 'transactional' table property for ACID should be case insensitive

2015-09-18 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876056#comment-14876056
 ] 

Eugene Koifman commented on HIVE-11883:
---

SemanticAnalyzer.isAcidTable(Table)

> 'transactional' table property for ACID should be case insensitive
> --
>
> Key: HIVE-11883
> URL: https://issues.apache.org/jira/browse/HIVE-11883
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 1.0.0
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
>
> Given:
> {noformat}
> CREATE TABLE mytable (col1 int, col2 string)
> CLUSTERED BY (col1) INTO 2 BUCKETS
> STORED AS ORC TBLPROPERTIES('TRANSACTIONAL'='TRUE');
> {noformat}
> update/delete statements will fail with 
> {noformat}
> FAILED: SemanticException [Error 10122]: Bucketized tables do not support 
> INSERT INTO: Table: default.mytable
> {noformat}
> but 'transactional' (in lower case) works fine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)