[jira] [Commented] (HIVE-12238) Vectorization: Thread-safety errors in VectorUDFDate
[ https://issues.apache.org/jira/browse/HIVE-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977729#comment-14977729 ] Gopal V commented on HIVE-12238: [~hagleitn]: replaced static with mutable state with thread-local - review? > Vectorization: Thread-safety errors in VectorUDFDate > > > Key: HIVE-12238 > URL: https://issues.apache.org/jira/browse/HIVE-12238 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 1.2.1, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12238.1.patch > > > {code} > Caused by: java.lang.NumberFormatException: For input string: "" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) > at java.lang.Long.parseLong(Long.java:601) > at java.lang.Long.parseLong(Long.java:631) > at java.text.DigitList.getLong(DigitList.java:195) > at java.text.DecimalFormat.parse(DecimalFormat.java:2051) > at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:1869) > at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514) > at java.text.DateFormat.parse(DateFormat.java:364) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateString$1.evaluate(VectorUDFDateString.java:48) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringUnaryUDF.evaluate(StringUnaryUDF.java:90) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringGroupColConcatStringScalar.evaluate(StringGroupColConcatStringScalar.java:50) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFAdaptor.evaluate(VectorUDFAdaptor.java:112) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFTimestampFieldLong.evaluate(VectorUDFTimestampFieldLong.java:93) > at > org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:123) > ... 22 more > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12238) Vectorization: Thread-safety errors in VectorUDFDate
[ https://issues.apache.org/jira/browse/HIVE-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979260#comment-14979260 ] Gunther Hagleitner commented on HIVE-12238: --- LGTM +1 > Vectorization: Thread-safety errors in VectorUDFDate > > > Key: HIVE-12238 > URL: https://issues.apache.org/jira/browse/HIVE-12238 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 1.2.1, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12238.1.patch > > > {code} > Caused by: java.lang.NumberFormatException: For input string: "" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) > at java.lang.Long.parseLong(Long.java:601) > at java.lang.Long.parseLong(Long.java:631) > at java.text.DigitList.getLong(DigitList.java:195) > at java.text.DecimalFormat.parse(DecimalFormat.java:2051) > at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:1869) > at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514) > at java.text.DateFormat.parse(DateFormat.java:364) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateString$1.evaluate(VectorUDFDateString.java:48) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringUnaryUDF.evaluate(StringUnaryUDF.java:90) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringGroupColConcatStringScalar.evaluate(StringGroupColConcatStringScalar.java:50) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFAdaptor.evaluate(VectorUDFAdaptor.java:112) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFTimestampFieldLong.evaluate(VectorUDFTimestampFieldLong.java:93) > at > org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:123) > ... 22 more > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12238) Vectorization: Thread-safety errors in VectorUDFDate
[ https://issues.apache.org/jira/browse/HIVE-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979678#comment-14979678 ] Hive QA commented on HIVE-12238: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12769184/HIVE-12238.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5837/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5837/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5837/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]] + export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-5837/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 53fc319 HIVE-12276 Fix messages in InvalidTable (Eugene Koifman, reviewed by Jason Dere) + git clean -f -d Removing beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java.orig + git checkout master Already on 'master' + git reset --hard origin/master HEAD is now at 53fc319 HIVE-12276 Fix messages in InvalidTable (Eugene Koifman, reviewed by Jason Dere) + git merge --ff-only origin/master Already up-to-date. + git gc + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12769184 - PreCommit-HIVE-TRUNK-Build > Vectorization: Thread-safety errors in VectorUDFDate > > > Key: HIVE-12238 > URL: https://issues.apache.org/jira/browse/HIVE-12238 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 1.2.1, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12238.1.patch > > > {code} > Caused by: java.lang.NumberFormatException: For input string: "" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) > at java.lang.Long.parseLong(Long.java:601) > at java.lang.Long.parseLong(Long.java:631) > at java.text.DigitList.getLong(DigitList.java:195) > at java.text.DecimalFormat.parse(DecimalFormat.java:2051) > at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:1869) > at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514) > at java.text.DateFormat.parse(DateFormat.java:364) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateString$1.evaluate(VectorUDFDateString.java:48) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringUnaryUDF.evaluate(StringUnaryUDF.java:90) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringGroupColConcatStri
[jira] [Commented] (HIVE-12238) Vectorization: Thread-safety errors in VectorUDFDate
[ https://issues.apache.org/jira/browse/HIVE-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982536#comment-14982536 ] Hive QA commented on HIVE-12238: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12769732/HIVE-12238.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 9735 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testMetastoreProxyUser org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testSaslWithHiveMetaStore org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5862/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5862/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5862/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12769732 - PreCommit-HIVE-TRUNK-Build > Vectorization: Thread-safety errors in VectorUDFDate > > > Key: HIVE-12238 > URL: https://issues.apache.org/jira/browse/HIVE-12238 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 1.2.1, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12238.1.patch, HIVE-12238.2.patch > > > {code} > Caused by: java.lang.NumberFormatException: For input string: "" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) > at java.lang.Long.parseLong(Long.java:601) > at java.lang.Long.parseLong(Long.java:631) > at java.text.DigitList.getLong(DigitList.java:195) > at java.text.DecimalFormat.parse(DecimalFormat.java:2051) > at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:1869) > at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514) > at java.text.DateFormat.parse(DateFormat.java:364) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateString$1.evaluate(VectorUDFDateString.java:48) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringUnaryUDF.evaluate(StringUnaryUDF.java:90) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringGroupColConcatStringScalar.evaluate(StringGroupColConcatStringScalar.java:50) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFAdaptor.evaluate(VectorUDFAdaptor.java:112) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFTimestampFieldLong.evaluate(VectorUDFTimestampFieldLong.java:93) > at > org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:123) > ... 22 more > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12238) Vectorization: Thread-safety errors in VectorUDFDate
[ https://issues.apache.org/jira/browse/HIVE-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001573#comment-15001573 ] Gopal V commented on HIVE-12238: [~sershe]: not sure if you can trigger it without LLAP (HS2 FetchTask doesn't run vector mode). > Vectorization: Thread-safety errors in VectorUDFDate > > > Key: HIVE-12238 > URL: https://issues.apache.org/jira/browse/HIVE-12238 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 1.2.1, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Fix For: 2.0.0 > > Attachments: HIVE-12238.1.patch, HIVE-12238.2.patch > > > {code} > Caused by: java.lang.NumberFormatException: For input string: "" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) > at java.lang.Long.parseLong(Long.java:601) > at java.lang.Long.parseLong(Long.java:631) > at java.text.DigitList.getLong(DigitList.java:195) > at java.text.DecimalFormat.parse(DecimalFormat.java:2051) > at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:1869) > at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514) > at java.text.DateFormat.parse(DateFormat.java:364) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateString$1.evaluate(VectorUDFDateString.java:48) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringUnaryUDF.evaluate(StringUnaryUDF.java:90) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.StringGroupColConcatStringScalar.evaluate(StringGroupColConcatStringScalar.java:50) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFAdaptor.evaluate(VectorUDFAdaptor.java:112) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:121) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFTimestampFieldLong.evaluate(VectorUDFTimestampFieldLong.java:93) > at > org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:123) > ... 22 more > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)