[jira] [Commented] (HIVE-12479) Vectorization: Vectorized Date UDFs with up-stream Joins
[ https://issues.apache.org/jira/browse/HIVE-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032547#comment-15032547 ] Ashutosh Chauhan commented on HIVE-12479: - Agreed, these failures doesnt seem to be related to the patch. Commit can go ahead. > Vectorization: Vectorized Date UDFs with up-stream Joins > > > Key: HIVE-12479 > URL: https://issues.apache.org/jira/browse/HIVE-12479 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12479.1.patch, HIVE-12479.tar.gz > > > The row-counts expected with and without vectorization differ. > The attached small-scale repro case produces 5 rows with vectorized multi-key > joins and 53 rows without the vectorized join. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12479) Vectorization: Vectorized Date UDFs with up-stream Joins
[ https://issues.apache.org/jira/browse/HIVE-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032474#comment-15032474 ] Sergey Shelukhin commented on HIVE-12479: - The tests appear unrelated. Should I commit? > Vectorization: Vectorized Date UDFs with up-stream Joins > > > Key: HIVE-12479 > URL: https://issues.apache.org/jira/browse/HIVE-12479 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12479.1.patch, HIVE-12479.tar.gz > > > The row-counts expected with and without vectorization differ. > The attached small-scale repro case produces 5 rows with vectorized multi-key > joins and 53 rows without the vectorized join. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12479) Vectorization: Vectorized Date UDFs with up-stream Joins
[
https://issues.apache.org/jira/browse/HIVE-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030868#comment-15030868
]
Hive QA commented on HIVE-12479:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12774310/HIVE-12479.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 9865 tests executed
*Failed tests:*
{noformat}
TestHWISessionManager - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testFetchingPartitionsWithDifferentSchemas
org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testGetPartitionSpecs_WithAndWithoutPartitionGrouping
org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testRevokeTimedOutWorkers
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6161/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6161/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6161/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12774310 - PreCommit-HIVE-TRUNK-Build
> Vectorization: Vectorized Date UDFs with up-stream Joins
>
>
> Key: HIVE-12479
> URL: https://issues.apache.org/jira/browse/HIVE-12479
> Project: Hive
> Issue Type: Bug
> Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
> Attachments: HIVE-12479.1.patch, HIVE-12479.tar.gz
>
>
> The row-counts expected with and without vectorization differ.
> The attached small-scale repro case produces 5 rows with vectorized multi-key
> joins and 53 rows without the vectorized join.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12479) Vectorization: Vectorized Date UDFs with up-stream Joins
[ https://issues.apache.org/jira/browse/HIVE-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027720#comment-15027720 ] Prasanth Jayachandran commented on HIVE-12479: -- LGTM, +1. Pending tests > Vectorization: Vectorized Date UDFs with up-stream Joins > > > Key: HIVE-12479 > URL: https://issues.apache.org/jira/browse/HIVE-12479 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12479.1.patch, HIVE-12479.tar.gz > > > The row-counts expected with and without vectorization differ. > The attached small-scale repro case produces 5 rows with vectorized multi-key > joins and 53 rows without the vectorized join. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12479) Vectorization: Vectorized Date UDFs with up-stream Joins
[ https://issues.apache.org/jira/browse/HIVE-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026558#comment-15026558 ] Gopal V commented on HIVE-12479: The batch.selectedInUse and col.isRepeating were interfering with each other's semantics. Fix for all Date UDFS + added test-case with 1 value column, with isRepeating=true, isSelectedInUse=true & .selected[0] = 42; After the fix, it should not be trying to read col[42], but should operate on col[0] because isRepeating is true. > Vectorization: Vectorized Date UDFs with up-stream Joins > > > Key: HIVE-12479 > URL: https://issues.apache.org/jira/browse/HIVE-12479 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12479.1.patch, HIVE-12479.tar.gz > > > The row-counts expected with and without vectorization differ. > The attached small-scale repro case produces 5 rows with vectorized multi-key > joins and 53 rows without the vectorized join. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12479) Vectorization: Vectorized Date UDFs with up-stream Joins
[ https://issues.apache.org/jira/browse/HIVE-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026559#comment-15026559 ] Gopal V commented on HIVE-12479: [~prasanth_j]: can you take a look? > Vectorization: Vectorized Date UDFs with up-stream Joins > > > Key: HIVE-12479 > URL: https://issues.apache.org/jira/browse/HIVE-12479 > Project: Hive > Issue Type: Bug > Components: Vectorization >Affects Versions: 1.3.0, 2.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-12479.1.patch, HIVE-12479.tar.gz > > > The row-counts expected with and without vectorization differ. > The attached small-scale repro case produces 5 rows with vectorized multi-key > joins and 53 rows without the vectorized join. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
