[jira] [Commented] (HIVE-12787) Trace improvement - Inconsistent logging upon shutdown-start of the Hive metastore process

2016-01-19 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106775#comment-15106775
 ] 

Aihua Xu commented on HIVE-12787:
-

+1. Makes sense to me. 

> Trace improvement - Inconsistent logging upon shutdown-start of the Hive 
> metastore process
> --
>
> Key: HIVE-12787
> URL: https://issues.apache.org/jira/browse/HIVE-12787
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.1
>Reporter: Siddharth Ahuja
>Assignee: Siddharth Ahuja
>Priority: Minor
> Attachments: HIVE-12787.1.patch
>
>
> The log at: 
> https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L793
>  logged at the start of the shutdown of the Hive metastore process can be 
> improved to match the finish of the shutdown log at: 
> https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L793
> by rephrasing from: "Shutting down the object store..." to: "Metastore 
> shutdown started...". This will match the shutdown completion log: "Metastore 
> shutdown complete.".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-12787) Trace improvement - Inconsistent logging upon shutdown-start of the Hive metastore process

2016-01-10 Thread Siddharth Ahuja (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091302#comment-15091302
 ] 

Siddharth Ahuja commented on HIVE-12787:


The test failure seem not related to the changes in this JIRA.

> Trace improvement - Inconsistent logging upon shutdown-start of the Hive 
> metastore process
> --
>
> Key: HIVE-12787
> URL: https://issues.apache.org/jira/browse/HIVE-12787
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.1
>Reporter: Siddharth Ahuja
>Assignee: Siddharth Ahuja
>Priority: Minor
> Attachments: HIVE-12787.1.patch
>
>
> The log at: 
> https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L793
>  logged at the start of the shutdown of the Hive metastore process can be 
> improved to match the finish of the shutdown log at: 
> https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L793
> by rephrasing from: "Shutting down the object store..." to: "Metastore 
> shutdown started...". This will match the shutdown completion log: "Metastore 
> shutdown complete.".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-12787) Trace improvement - Inconsistent logging upon shutdown-start of the Hive metastore process

2016-01-09 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090820#comment-15090820
 ] 

Hive QA commented on HIVE-12787:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12781125/HIVE-12787.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 9985 tests 
executed
*Failed tests:*
{noformat}
TestHWISessionManager - did not produce a TEST-*.xml file
TestSparkCliDriver-timestamp_lazy.q-bucketsortoptimize_insert_4.q-date_udf.q-and-12-more
 - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testMultiSessionMultipleUse
org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testSingleSessionMultipleUse
org.apache.hive.jdbc.TestSSL.testSSLVersion
org.apache.hive.spark.client.TestSparkClient.testAddJarsAndFiles
org.apache.hive.spark.client.TestSparkClient.testCounters
org.apache.hive.spark.client.TestSparkClient.testErrorJob
org.apache.hive.spark.client.TestSparkClient.testJobSubmission
org.apache.hive.spark.client.TestSparkClient.testMetricsCollection
org.apache.hive.spark.client.TestSparkClient.testRemoteClient
org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob
org.apache.hive.spark.client.TestSparkClient.testSyncRpc
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6566/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6566/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6566/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 14 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12781125 - PreCommit-HIVE-TRUNK-Build

> Trace improvement - Inconsistent logging upon shutdown-start of the Hive 
> metastore process
> --
>
> Key: HIVE-12787
> URL: https://issues.apache.org/jira/browse/HIVE-12787
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.1
>Reporter: Siddharth Ahuja
>Assignee: Siddharth Ahuja
>Priority: Minor
> Attachments: HIVE-12787.1.patch
>
>
> The log at: 
> https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L793
>  logged at the start of the shutdown of the Hive metastore process can be 
> improved to match the finish of the shutdown log at: 
> https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L793
> by rephrasing from: "Shutting down the object store..." to: "Metastore 
> shutdown started...". This will match the shutdown completion log: "Metastore 
> shutdown complete.".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)