[jira] [Commented] (HIVE-12865) Exchange partition does not show inputs field for post/pre execute hooks
[ https://issues.apache.org/jira/browse/HIVE-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111022#comment-15111022 ] Hive QA commented on HIVE-12865: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12783389/HIVE-12865.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10024 tests executed *Failed tests:* {noformat} TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6695/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6695/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6695/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12783389 - PreCommit-HIVE-TRUNK-Build > Exchange partition does not show inputs field for post/pre execute hooks > > > Key: HIVE-12865 > URL: https://issues.apache.org/jira/browse/HIVE-12865 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.12.0 >Reporter: Paul Yang >Assignee: Aihua Xu > Attachments: HIVE-12865.2.patch, HIVE-12865.patch > > > The pre/post execute hook interface has fields that indicate which Hive > objects were read / written to as a result of running the query. For the > exchange partition operation, the read entity field is empty. > This is an important issue as the hook interface may be configured to perform > critical warehouse operations. > See > ql/src/test/results/clientpositive/exchange_partition3.q.out > {code} > --- a/ql/src/test/results/clientpositive/exchange_partition3.q.out > +++ b/ql/src/test/results/clientpositive/exchange_partition3.q.out > @@ -65,9 +65,17 @@ ds=2013-04-05/hr=2 > PREHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > PREHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +PREHOOK: Output: default@exchange_part_test1 > +PREHOOK: Output: default@exchange_part_test2 > POSTHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > POSTHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +POSTHOOK: Output: default@exchange_part_test1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=2 > +POSTHOOK: Output: default@exchange_part_test2 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=2 > PREHOOK: query: SHOW PARTITIONS exchange_part_test1 > PREHOOK: type: SHOWPARTITIONS > PREHOOK: Input: default@exchange_part_test1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12865) Exchange partition does not show inputs field for post/pre execute hooks
[ https://issues.apache.org/jira/browse/HIVE-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109137#comment-15109137 ] Aihua Xu commented on HIVE-12865: - Attached the patch 2: to fix the unit test failure. > Exchange partition does not show inputs field for post/pre execute hooks > > > Key: HIVE-12865 > URL: https://issues.apache.org/jira/browse/HIVE-12865 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.12.0 >Reporter: Paul Yang >Assignee: Aihua Xu > Attachments: HIVE-12865.2.patch, HIVE-12865.patch > > > The pre/post execute hook interface has fields that indicate which Hive > objects were read / written to as a result of running the query. For the > exchange partition operation, the read entity field is empty. > This is an important issue as the hook interface may be configured to perform > critical warehouse operations. > See > ql/src/test/results/clientpositive/exchange_partition3.q.out > {code} > --- a/ql/src/test/results/clientpositive/exchange_partition3.q.out > +++ b/ql/src/test/results/clientpositive/exchange_partition3.q.out > @@ -65,9 +65,17 @@ ds=2013-04-05/hr=2 > PREHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > PREHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +PREHOOK: Output: default@exchange_part_test1 > +PREHOOK: Output: default@exchange_part_test2 > POSTHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > POSTHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +POSTHOOK: Output: default@exchange_part_test1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=2 > +POSTHOOK: Output: default@exchange_part_test2 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=2 > PREHOOK: query: SHOW PARTITIONS exchange_part_test1 > PREHOOK: type: SHOWPARTITIONS > PREHOOK: Input: default@exchange_part_test1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12865) Exchange partition does not show inputs field for post/pre execute hooks
[ https://issues.apache.org/jira/browse/HIVE-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108826#comment-15108826 ] Hive QA commented on HIVE-12865: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12783201/HIVE-12865.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10023 tests executed *Failed tests:* {noformat} TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_exchgpartition2lel org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6683/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6683/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6683/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12783201 - PreCommit-HIVE-TRUNK-Build > Exchange partition does not show inputs field for post/pre execute hooks > > > Key: HIVE-12865 > URL: https://issues.apache.org/jira/browse/HIVE-12865 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.12.0 >Reporter: Paul Yang >Assignee: Aihua Xu > Attachments: HIVE-12865.patch > > > The pre/post execute hook interface has fields that indicate which Hive > objects were read / written to as a result of running the query. For the > exchange partition operation, the read entity field is empty. > This is an important issue as the hook interface may be configured to perform > critical warehouse operations. > See > ql/src/test/results/clientpositive/exchange_partition3.q.out > {code} > --- a/ql/src/test/results/clientpositive/exchange_partition3.q.out > +++ b/ql/src/test/results/clientpositive/exchange_partition3.q.out > @@ -65,9 +65,17 @@ ds=2013-04-05/hr=2 > PREHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > PREHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +PREHOOK: Output: default@exchange_part_test1 > +PREHOOK: Output: default@exchange_part_test2 > POSTHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > POSTHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +POSTHOOK: Output: default@exchange_part_test1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=2 > +POSTHOOK: Output: default@exchange_part_test2 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=2 > PREHOOK: query: SHOW PARTITIONS exchange_part_test1 > PREHOOK: type: SHOWPARTITIONS > PREHOOK: Input: default@exchange_part_test1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12865) Exchange partition does not show inputs field for post/pre execute hooks
[ https://issues.apache.org/jira/browse/HIVE-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109213#comment-15109213 ] Chaoyu Tang commented on HIVE-12865: +1, pending the tests > Exchange partition does not show inputs field for post/pre execute hooks > > > Key: HIVE-12865 > URL: https://issues.apache.org/jira/browse/HIVE-12865 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.12.0 >Reporter: Paul Yang >Assignee: Aihua Xu > Attachments: HIVE-12865.2.patch, HIVE-12865.patch > > > The pre/post execute hook interface has fields that indicate which Hive > objects were read / written to as a result of running the query. For the > exchange partition operation, the read entity field is empty. > This is an important issue as the hook interface may be configured to perform > critical warehouse operations. > See > ql/src/test/results/clientpositive/exchange_partition3.q.out > {code} > --- a/ql/src/test/results/clientpositive/exchange_partition3.q.out > +++ b/ql/src/test/results/clientpositive/exchange_partition3.q.out > @@ -65,9 +65,17 @@ ds=2013-04-05/hr=2 > PREHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > PREHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +PREHOOK: Output: default@exchange_part_test1 > +PREHOOK: Output: default@exchange_part_test2 > POSTHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > POSTHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +POSTHOOK: Output: default@exchange_part_test1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=2 > +POSTHOOK: Output: default@exchange_part_test2 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=2 > PREHOOK: query: SHOW PARTITIONS exchange_part_test1 > PREHOOK: type: SHOWPARTITIONS > PREHOOK: Input: default@exchange_part_test1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12865) Exchange partition does not show inputs field for post/pre execute hooks
[ https://issues.apache.org/jira/browse/HIVE-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107564#comment-15107564 ] Aihua Xu commented on HIVE-12865: - Attached the initial patch: added the source table and the partitions to be exchanged as the inputs. [~ctang.ma] and [~xuefuz] Can you help review the code? [~pauly] Could you also take a look if this is what you are expecting? > Exchange partition does not show inputs field for post/pre execute hooks > > > Key: HIVE-12865 > URL: https://issues.apache.org/jira/browse/HIVE-12865 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.12.0 >Reporter: Paul Yang >Assignee: Aihua Xu > Attachments: HIVE-12865.patch > > > The pre/post execute hook interface has fields that indicate which Hive > objects were read / written to as a result of running the query. For the > exchange partition operation, the read entity field is empty. > This is an important issue as the hook interface may be configured to perform > critical warehouse operations. > See > ql/src/test/results/clientpositive/exchange_partition3.q.out > {code} > --- a/ql/src/test/results/clientpositive/exchange_partition3.q.out > +++ b/ql/src/test/results/clientpositive/exchange_partition3.q.out > @@ -65,9 +65,17 @@ ds=2013-04-05/hr=2 > PREHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > PREHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +PREHOOK: Output: default@exchange_part_test1 > +PREHOOK: Output: default@exchange_part_test2 > POSTHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > POSTHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +POSTHOOK: Output: default@exchange_part_test1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=2 > +POSTHOOK: Output: default@exchange_part_test2 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=2 > PREHOOK: query: SHOW PARTITIONS exchange_part_test1 > PREHOOK: type: SHOWPARTITIONS > PREHOOK: Input: default@exchange_part_test1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12865) Exchange partition does not show inputs field for post/pre execute hooks
[ https://issues.apache.org/jira/browse/HIVE-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107830#comment-15107830 ] Paul Yang commented on HIVE-12865: -- Looks great to me - thanks Aihua! > Exchange partition does not show inputs field for post/pre execute hooks > > > Key: HIVE-12865 > URL: https://issues.apache.org/jira/browse/HIVE-12865 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.12.0 >Reporter: Paul Yang >Assignee: Aihua Xu > Attachments: HIVE-12865.patch > > > The pre/post execute hook interface has fields that indicate which Hive > objects were read / written to as a result of running the query. For the > exchange partition operation, the read entity field is empty. > This is an important issue as the hook interface may be configured to perform > critical warehouse operations. > See > ql/src/test/results/clientpositive/exchange_partition3.q.out > {code} > --- a/ql/src/test/results/clientpositive/exchange_partition3.q.out > +++ b/ql/src/test/results/clientpositive/exchange_partition3.q.out > @@ -65,9 +65,17 @@ ds=2013-04-05/hr=2 > PREHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > PREHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +PREHOOK: Output: default@exchange_part_test1 > +PREHOOK: Output: default@exchange_part_test2 > POSTHOOK: query: -- This will exchange both partitions hr=1 and hr=2 > ALTER TABLE exchange_part_test1 EXCHANGE PARTITION (ds='2013-04-05') WITH > TABLE exchange_part_test2 > POSTHOOK: type: ALTERTABLE_EXCHANGEPARTITION > +POSTHOOK: Output: default@exchange_part_test1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test1@ds=2013-04-05/hr=2 > +POSTHOOK: Output: default@exchange_part_test2 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=1 > +POSTHOOK: Output: default@exchange_part_test2@ds=2013-04-05/hr=2 > PREHOOK: query: SHOW PARTITIONS exchange_part_test1 > PREHOOK: type: SHOWPARTITIONS > PREHOOK: Input: default@exchange_part_test1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)