[jira] [Commented] (HIVE-12954) NPE with str_to_map on null strings

2016-08-01 Thread Aihua Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402163#comment-15402163
 ] 

Aihua Xu commented on HIVE-12954:
-

+1. The change looks good.

> NPE with str_to_map on null strings
> ---
>
> Key: HIVE-12954
> URL: https://issues.apache.org/jira/browse/HIVE-12954
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.14.0, 1.0.0
>Reporter: Charles Pritchard
>Assignee: Marta Kuczora
> Attachments: HIVE-12954.2.patch, HIVE-12954.patch
>
>
> Running str_to_map on a null string will return a NullPointerException.
> Workaround is to use coalesce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12954) NPE with str_to_map on null strings

2016-08-01 Thread Marta Kuczora (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401759#comment-15401759
 ] 

Marta Kuczora commented on HIVE-12954:
--

The failing tests are not related to this patch.

> NPE with str_to_map on null strings
> ---
>
> Key: HIVE-12954
> URL: https://issues.apache.org/jira/browse/HIVE-12954
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.14.0, 1.0.0
>Reporter: Charles Pritchard
>Assignee: Marta Kuczora
> Attachments: HIVE-12954.2.patch, HIVE-12954.patch
>
>
> Running str_to_map on a null string will return a NullPointerException.
> Workaround is to use coalesce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12954) NPE with str_to_map on null strings

2016-07-31 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401054#comment-15401054
 ] 

Hive QA commented on HIVE-12954:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12820934/HIVE-12954.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10426 tests 
executed
*Failed tests:*
{noformat}
TestMsgBusConnection - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_nullable_union
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_12
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_orc_llap_counters
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_avro_non_nullable_union
org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.stringifyValidTxns
org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxnRange
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/705/testReport
Console output: 
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/705/console
Test logs: 
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-705/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12820934 - PreCommit-HIVE-MASTER-Build

> NPE with str_to_map on null strings
> ---
>
> Key: HIVE-12954
> URL: https://issues.apache.org/jira/browse/HIVE-12954
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.14.0, 1.0.0
>Reporter: Charles Pritchard
>Assignee: Marta Kuczora
> Attachments: HIVE-12954.2.patch, HIVE-12954.patch
>
>
> Running str_to_map on a null string will return a NullPointerException.
> Workaround is to use coalesce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12954) NPE with str_to_map on null strings

2016-07-28 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398400#comment-15398400
 ] 

Hive QA commented on HIVE-12954:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12820461/HIVE-12954.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10381 tests 
executed
*Failed tests:*
{noformat}
TestHBaseAggrStatsCacheIntegration - did not produce a TEST-*.xml file
TestMsgBusConnection - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_nullable_union
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_avro_non_nullable_union
org.apache.hive.spark.client.TestSparkClient.testJobSubmission
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/677/testReport
Console output: 
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/677/console
Test logs: 
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-677/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12820461 - PreCommit-HIVE-MASTER-Build

> NPE with str_to_map on null strings
> ---
>
> Key: HIVE-12954
> URL: https://issues.apache.org/jira/browse/HIVE-12954
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.14.0, 1.0.0
>Reporter: Charles Pritchard
>Assignee: Marta Kuczora
> Attachments: HIVE-12954.patch
>
>
> Running str_to_map on a null string will return a NullPointerException.
> Workaround is to use coalesce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12954) NPE with str_to_map on null strings

2016-07-27 Thread Marta Kuczora (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395799#comment-15395799
 ] 

Marta Kuczora commented on HIVE-12954:
--

Review is created and linked. Please review the patch.

> NPE with str_to_map on null strings
> ---
>
> Key: HIVE-12954
> URL: https://issues.apache.org/jira/browse/HIVE-12954
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.14.0, 1.0.0
>Reporter: Charles Pritchard
>Assignee: Marta Kuczora
> Attachments: HIVE-12954.patch
>
>
> Running str_to_map on a null string will return a NullPointerException.
> Workaround is to use coalesce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12954) NPE with str_to_map on null strings

2016-04-11 Thread Janick Bernet (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235962#comment-15235962
 ] 

Janick Bernet commented on HIVE-12954:
--

This also appears to be in Hive 1.0. The closely related 'split' function does 
handle NULL transparently, without an NPE.

> NPE with str_to_map on null strings
> ---
>
> Key: HIVE-12954
> URL: https://issues.apache.org/jira/browse/HIVE-12954
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.14.0, 1.0.0
>Reporter: Charles Pritchard
>
> Running str_to_map on a null string will return a NullPointerException.
> Workaround is to use coalesce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)