[jira] [Commented] (HIVE-12998) ORC FileDump.printJsonData() does not close RecordReader

[Gopal V (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143443#comment-15143443
 ] 

Gopal V commented on HIVE-12998:


Pushed to master, signed-off

> ORC FileDump.printJsonData() does not close RecordReader
> 
>
> Key: HIVE-12998
> URL: https://issues.apache.org/jira/browse/HIVE-12998
> Project: Hive
>  Issue Type: Bug
>  Components: ORC
>Reporter: Jason Dere
>Assignee: Jason Dere
> Fix For: 2.1.0
>
> Attachments: HIVE-12998.1.patch, HIVE-12998.2.patch
>
>
> This causes TestFileDump to fail on Windows, because the test ORC file does 
> not get deleted between tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12998) ORC FileDump.printJsonData() does not close RecordReader

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135022#comment-15135022
 ] 

Hive QA commented on HIVE-12998:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12786183/HIVE-12998.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10036 tests 
executed
*Failed tests:*
{noformat}
TestSparkCliDriver-timestamp_lazy.q-bucketsortoptimize_insert_4.q-date_udf.q-and-12-more
 - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStore.testSimpleTable
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6877/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6877/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6877/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12786183 - PreCommit-HIVE-TRUNK-Build

> ORC FileDump.printJsonData() does not close RecordReader
> 
>
> Key: HIVE-12998
> URL: https://issues.apache.org/jira/browse/HIVE-12998
> Project: Hive
>  Issue Type: Bug
>  Components: ORC
>Reporter: Jason Dere
>Assignee: Jason Dere
> Attachments: HIVE-12998.1.patch, HIVE-12998.2.patch
>
>
> This causes TestFileDump to fail on Windows, because the test ORC file does 
> not get deleted between tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12998) ORC FileDump.printJsonData() does not close RecordReader

[Gopal V (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135051#comment-15135051
 ] 

Gopal V commented on HIVE-12998:


LGTM - +1

> ORC FileDump.printJsonData() does not close RecordReader
> 
>
> Key: HIVE-12998
> URL: https://issues.apache.org/jira/browse/HIVE-12998
> Project: Hive
>  Issue Type: Bug
>  Components: ORC
>Reporter: Jason Dere
>Assignee: Jason Dere
> Attachments: HIVE-12998.1.patch, HIVE-12998.2.patch
>
>
> This causes TestFileDump to fail on Windows, because the test ORC file does 
> not get deleted between tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12998) ORC FileDump.printJsonData() does not close RecordReader

[Gopal V (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131620#comment-15131620
 ] 

Gopal V commented on HIVE-12998:


We can also wrap a try {} finally {} around  printJsonData(reader);?

> ORC FileDump.printJsonData() does not close RecordReader
> 
>
> Key: HIVE-12998
> URL: https://issues.apache.org/jira/browse/HIVE-12998
> Project: Hive
>  Issue Type: Bug
>  Components: ORC
>Reporter: Jason Dere
>Assignee: Jason Dere
> Attachments: HIVE-12998.1.patch
>
>
> This causes TestFileDump to fail on Windows, because the test ORC file does 
> not get deleted between tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)