[jira] [Commented] (HIVE-13021) GenericUDAFEvaluator.isEstimable(agg) always returns false
[
https://issues.apache.org/jira/browse/HIVE-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155372#comment-15155372
]
Gopal V commented on HIVE-13021:
I investigated both failures on CliDriver and came up with nothing.
Thanks for point out the 2nd failure, I think compute_stats is broken in
StatsOptimizer when Tez is enabled.
{code}
java.lang.NullPointerException
at
org.apache.hadoop.hive.ql.udf.generic.GenericUDAFComputeStats$GenericUDAFNumericStatsEvaluator$NumericStatsAgg.estimate(GenericUDAFComputeStats.java:434)
at
org.apache.hadoop.hive.ql.udf.generic.GenericUDAFComputeStats$GenericUDAFDoubleStatsEvaluator$DoubleStatsAgg.estimate(GenericUDAFComputeStats.java:643)
at
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$GroupByStatsRule.checkMapSideAggregation(StatsRulesProcFactory.java:996)
at
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$GroupByStatsRule.process(StatsRulesProcFactory.java:726)
at
org.apache.hadoop.hive.ql.lib.DefaultRuleDispatcher.dispatch(DefaultRuleDispatcher.java:90)
{code}
> GenericUDAFEvaluator.isEstimable(agg) always returns false
> --
>
> Key: HIVE-13021
> URL: https://issues.apache.org/jira/browse/HIVE-13021
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Affects Versions: 1.2.1
>Reporter: Sergey Zadoroshnyak
>Assignee: Gopal V
>Priority: Critical
> Labels: Performance
> Fix For: 1.3.0, 2.1.0
>
> Attachments: HIVE-13021.1.patch
>
>
> GenericUDAFEvaluator.isEstimable(agg) always returns false, because
> annotation AggregationType has default RetentionPolicy.CLASS and cannot be
> retained by the VM at run time.
> As result estimate method will never be executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13021) GenericUDAFEvaluator.isEstimable(agg) always returns false
[ https://issues.apache.org/jira/browse/HIVE-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155368#comment-15155368 ] Pengcheng Xiong commented on HIVE-13021: [~gopalv], thanks for your fast response. Please correct me if my understanding is wrong: if this patch breaks any test cases on master, they should be revolved before checked in, right? :) > GenericUDAFEvaluator.isEstimable(agg) always returns false > -- > > Key: HIVE-13021 > URL: https://issues.apache.org/jira/browse/HIVE-13021 > Project: Hive > Issue Type: Bug > Components: UDF >Affects Versions: 1.2.1 >Reporter: Sergey Zadoroshnyak >Assignee: Gopal V >Priority: Critical > Labels: Performance > Fix For: 1.3.0, 2.1.0 > > Attachments: HIVE-13021.1.patch > > > GenericUDAFEvaluator.isEstimable(agg) always returns false, because > annotation AggregationType has default RetentionPolicy.CLASS and cannot be > retained by the VM at run time. > As result estimate method will never be executed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13021) GenericUDAFEvaluator.isEstimable(agg) always returns false
[
https://issues.apache.org/jira/browse/HIVE-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155355#comment-15155355
]
Gopal V commented on HIVE-13021:
Yes, but the failure looks like it's not from a query at all.
{code}
Begin query: stats_only_null.q
Exception: Client Execution failed with error code = 4 running
analyze table stats_null_part compute statistics for columns
{code}
The exception being thrown before a query kicks in?
> GenericUDAFEvaluator.isEstimable(agg) always returns false
> --
>
> Key: HIVE-13021
> URL: https://issues.apache.org/jira/browse/HIVE-13021
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Affects Versions: 1.2.1
>Reporter: Sergey Zadoroshnyak
>Assignee: Gopal V
>Priority: Critical
> Labels: Performance
> Fix For: 1.3.0, 2.1.0
>
> Attachments: HIVE-13021.1.patch
>
>
> GenericUDAFEvaluator.isEstimable(agg) always returns false, because
> annotation AggregationType has default RetentionPolicy.CLASS and cannot be
> retained by the VM at run time.
> As result estimate method will never be executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13021) GenericUDAFEvaluator.isEstimable(agg) always returns false
[
https://issues.apache.org/jira/browse/HIVE-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155353#comment-15155353
]
Pengcheng Xiong commented on HIVE-13021:
Hi [~gopalv] and [~prasanth_j], while i was taking a look at the current
failures in master, i found that this patch broke
{code}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_partition_coltype_literals
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_stats_only_null
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_stats_only_null
{code}
More information could be found at
"http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7015/#showFailuresLink";
Could you please double check it? Thanks.
> GenericUDAFEvaluator.isEstimable(agg) always returns false
> --
>
> Key: HIVE-13021
> URL: https://issues.apache.org/jira/browse/HIVE-13021
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Affects Versions: 1.2.1
>Reporter: Sergey Zadoroshnyak
>Assignee: Gopal V
>Priority: Critical
> Labels: Performance
> Fix For: 1.3.0, 2.1.0
>
> Attachments: HIVE-13021.1.patch
>
>
> GenericUDAFEvaluator.isEstimable(agg) always returns false, because
> annotation AggregationType has default RetentionPolicy.CLASS and cannot be
> retained by the VM at run time.
> As result estimate method will never be executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13021) GenericUDAFEvaluator.isEstimable(agg) always returns false
[
https://issues.apache.org/jira/browse/HIVE-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146037#comment-15146037
]
Hive QA commented on HIVE-13021:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12787538/HIVE-13021.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 9776 tests
executed
*Failed tests:*
{noformat}
TestParseNegative - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_5
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_mat_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_mat_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_mat_3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_mat_4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_mat_5
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_partition_coltype_literals
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_cte_5
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_cte_mat_1
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_cte_mat_2
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_cte_mat_3
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_cte_mat_4
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_cte_mat_5
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_stats_only_null
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_stats_only_null
org.apache.hadoop.hive.ql.TestTxnCommands2.testInitiatorWithMultipleFailedCompactions
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6968/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6968/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6968/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 19 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12787538 - PreCommit-HIVE-TRUNK-Build
> GenericUDAFEvaluator.isEstimable(agg) always returns false
> --
>
> Key: HIVE-13021
> URL: https://issues.apache.org/jira/browse/HIVE-13021
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Affects Versions: 1.2.1
>Reporter: Sergey Zadoroshnyak
>Assignee: Gopal V
>Priority: Critical
> Labels: Performance
> Attachments: HIVE-13021.1.patch
>
>
> GenericUDAFEvaluator.isEstimable(agg) always returns false, because
> annotation AggregationType has default RetentionPolicy.CLASS and cannot be
> retained by the VM at run time.
> As result estimate method will never be executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13021) GenericUDAFEvaluator.isEstimable(agg) always returns false
[ https://issues.apache.org/jira/browse/HIVE-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143672#comment-15143672 ] Prasanth Jayachandran commented on HIVE-13021: -- lgmt, +1 > GenericUDAFEvaluator.isEstimable(agg) always returns false > -- > > Key: HIVE-13021 > URL: https://issues.apache.org/jira/browse/HIVE-13021 > Project: Hive > Issue Type: Bug > Components: UDF >Affects Versions: 1.2.1 >Reporter: Sergey Zadoroshnyak >Assignee: Gopal V >Priority: Critical > Labels: Performance > Attachments: HIVE-13021.1.patch > > > GenericUDAFEvaluator.isEstimable(agg) always returns false, because > annotation AggregationType has default RetentionPolicy.CLASS and cannot be > retained by the VM at run time. > As result estimate method will never be executed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
