[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226865#comment-15226865 ] Prasanth Jayachandran commented on HIVE-13199: -- Patch committed to branch-2.0 > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Sergey Shelukhin >Assignee: Prasanth Jayachandran > Fix For: 2.1.0, 2.0.1 > > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182028#comment-15182028 ] Prasanth Jayachandran commented on HIVE-13199: -- Patch yet to be committed for 2.0.1 as it depends on other logging patches to be committed first. > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Sergey Shelukhin >Assignee: Prasanth Jayachandran > Fix For: 2.1.0 > > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[
https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181568#comment-15181568
]
Hive QA commented on HIVE-13199:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12791072/HIVE-13199.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 9781 tests executed
*Failed tests:*
{noformat}
TestSparkCliDriver-groupby3_map.q-sample2.q-auto_join14.q-and-12-more - did not
produce a TEST-*.xml file
TestSparkCliDriver-groupby_map_ppr_multi_distinct.q-table_access_keys_stats.q-groupby4_noskew.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-join_rc.q-insert1.q-vectorized_rcfile_columnar.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-ppd_join4.q-join9.q-ppd_join3.q-and-12-more - did not
produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7165/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7165/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-7165/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12791072 - PreCommit-HIVE-TRUNK-Build
> NDC stopped working in LLAP logging
> ---
>
> Key: HIVE-13199
> URL: https://issues.apache.org/jira/browse/HIVE-13199
> Project: Hive
> Issue Type: Bug
> Components: llap, Logging
>Affects Versions: 2.1.0
>Reporter: Sergey Shelukhin
>Assignee: Prasanth Jayachandran
> Attachments: HIVE-13199.1.patch
>
>
> NDC context were missing from the log lines. Reason for it is NDC class is
> part of log4j-1.2-api (bridge jar). This is added as compile time dependency.
> Due to the absence of this jar in llap daemons, the NDC context failed to
> initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge
> jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178498#comment-15178498 ] Prasanth Jayachandran commented on HIVE-13199: -- I think it will get picked from hive-jdbc-standalone jar as it shades the world. > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Sergey Shelukhin >Assignee: Prasanth Jayachandran > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178483#comment-15178483 ] Sergey Shelukhin commented on HIVE-13199: - I think we should backport both to 2.0.1. Otherwise, the logging doesn't work there, does it? > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Sergey Shelukhin >Assignee: Prasanth Jayachandran > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177402#comment-15177402 ] Prasanth Jayachandran commented on HIVE-13199: -- I am not sure yet. HIVE-13110 seems to have committed only to master. This patch should have been part of HIVE-13110. > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Sergey Shelukhin >Assignee: Prasanth Jayachandran > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176935#comment-15176935 ] Sergey Shelukhin commented on HIVE-13199: - +1.. Does this also affect 2.0? I assume all the logging fixes need to be backported to branch-2 > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Sergey Shelukhin >Assignee: Prasanth Jayachandran > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13199) NDC stopped working in LLAP logging
[ https://issues.apache.org/jira/browse/HIVE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176863#comment-15176863 ] Prasanth Jayachandran commented on HIVE-13199: -- [~gopalv] Could you take a look this? > NDC stopped working in LLAP logging > --- > > Key: HIVE-13199 > URL: https://issues.apache.org/jira/browse/HIVE-13199 > Project: Hive > Issue Type: Bug > Components: llap, Logging >Affects Versions: 2.1.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran > Attachments: HIVE-13199.1.patch > > > NDC context were missing from the log lines. Reason for it is NDC class is > part of log4j-1.2-api (bridge jar). This is added as compile time dependency. > Due to the absence of this jar in llap daemons, the NDC context failed to > initialize. Log4j2 replaced NDC with ThreadContext. Hence we need the bridge > jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
