[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282916#comment-15282916
]
Anthony Hsu commented on HIVE-13363:
Thanks for the reminder, [~leftylev]. Added documentation at the end of
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-HiveMetastoreSecurity.
Note that this property was originally added in HIVE-1696 in Hive 0.7.0; this
ticket simply added it to the HiveConf so it's more easily discoverable and
defined in one place instead of being hardcoded in several different files.
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Labels: TODOC2.1
> Fix For: 2.1.0
>
> Attachments: HIVE-13363.1.patch, HIVE-13363.2.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281218#comment-15281218
]
Lefty Leverenz commented on HIVE-13363:
---
Doc note: *hive.metastore.token.signature* will need to be documented in the
wiki for release 2.1.0.
* [Configuration Properties -- MetaStore |
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-MetaStore]
Added a TODOC2.1 label.
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Labels: TODOC2.1
> Fix For: 2.1.0
>
> Attachments: HIVE-13363.1.patch, HIVE-13363.2.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273375#comment-15273375
]
Hive QA commented on HIVE-13363:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12802092/HIVE-13363.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 9932 tests
executed
*Failed tests:*
{noformat}
TestCliDriver-gen_udf_example_add10.q-ppd_join4.q-union27.q-and-12-more - did
not produce a TEST-*.xml file
TestCliDriver-partition_timestamp.q-ppd_random.q-vector_outer_join5.q-and-12-more
- did not produce a TEST-*.xml file
TestCliDriver-ptf_general_queries.q-unionDistinct_1.q-groupby1_noskew.q-and-12-more
- did not produce a TEST-*.xml file
TestHWISessionManager - did not produce a TEST-*.xml file
TestMiniLlapCliDriver - did not produce a TEST-*.xml file
TestMiniTezCliDriver-enforce_order.q-vector_partition_diff_num_cols.q-unionDistinct_1.q-and-12-more
- did not produce a TEST-*.xml file
TestMiniTezCliDriver-insert_values_non_partitioned.q-join1.q-schema_evol_orc_nonvec_mapwork_part.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-bucketsortoptimize_insert_7.q-smb_mapjoin_15.q-mapreduce1.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-skewjoinopt3.q-union27.q-multigroupby_singlemr.q-and-12-more
- did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
org.apache.hadoop.hive.llap.tez.TestConverters.testFragmentSpecToTaskSpec
org.apache.hadoop.hive.llap.tezplugins.TestLlapTaskCommunicator.testFinishableStateUpdateFailure
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfDefault
org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveOperationType.checkHiveOperationTypeMatch
org.apache.hive.service.cli.session.TestHiveSessionImpl.testLeakOperationHandle
{noformat}
Test results:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/190/testReport
Console output:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/190/console
Test logs:
http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-190/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12802092 - PreCommit-HIVE-MASTER-Build
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Attachments: HIVE-13363.1.patch, HIVE-13363.2.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271349#comment-15271349
]
Carl Steinbach commented on HIVE-13363:
---
+1
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Attachments: HIVE-13363.1.patch, HIVE-13363.2.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271014#comment-15271014
]
Ratandeep Ratti commented on HIVE-13363:
The patch looks good to me
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Attachments: HIVE-13363.1.patch, HIVE-13363.2.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269979#comment-15269979
]
Anthony Hsu commented on HIVE-13363:
Attached updated patch to fix the build.
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Attachments: HIVE-13363.1.patch, HIVE-13363.2.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214459#comment-15214459
]
Hive QA commented on HIVE-13363:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12795494/HIVE-13363.1.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7397/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7397/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-7397/
Messages:
{noformat}
This message was trimmed, see log for full details
[WARNING] -
org.apache.hadoop.hive.shims.HadoopShimsSecure$CombineFileInputFormatShim
[WARNING] - 64 more...
[WARNING] hive-exec-2.1.0-SNAPSHOT.jar, snappy-0.2.jar define 16 overlappping
classes:
[WARNING] - org.iq80.snappy.SnappyCompressor
[WARNING] - org.iq80.snappy.SlowMemory
[WARNING] - org.iq80.snappy.Crc32C
[WARNING] - org.iq80.snappy.CorruptionException
[WARNING] - org.iq80.snappy.UnsafeMemory
[WARNING] - org.iq80.snappy.Memory
[WARNING] - org.iq80.snappy.Snappy
[WARNING] - org.iq80.snappy.Main
[WARNING] - org.iq80.snappy.HadoopSnappyCodec
[WARNING] - org.iq80.snappy.SnappyDecompressor
[WARNING] - 6 more...
[WARNING] hive-serde-2.1.0-SNAPSHOT.jar, hive-exec-2.1.0-SNAPSHOT.jar define
588 overlappping classes:
[WARNING] -
org.apache.hadoop.hive.serde2.objectinspector.UnionStructObjectInspector
[WARNING] - org.apache.hadoop.hive.serde2.lazy.LazySerDeParameters
[WARNING] - org.apache.hadoop.hive.serde2.dynamic_type.DynamicSerDeXception
[WARNING] - org.apache.hadoop.hive.serde2.proto.test.Complexpb$Complex
[WARNING] - org.apache.hadoop.hive.serde2.dynamic_type.DynamicSerDeStructBase
[WARNING] -
org.apache.hadoop.hive.serde.test.ThriftTestObj$ThriftTestObjTupleSchemeFactory
[WARNING] - org.apache.hadoop.hive.serde2.thrift.test.Complex$1
[WARNING] - org.apache.hadoop.hive.serde2.thrift.test.MiniStruct
[WARNING] -
org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaLongObjectInspector
[WARNING] -
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorConverter$1
[WARNING] - 578 more...
[WARNING] jackson-mapper-asl-1.9.2.jar, hive-exec-2.1.0-SNAPSHOT.jar define 494
overlappping classes:
[WARNING] - org.codehaus.jackson.map.ser.impl.SerializerCache$TypeKey
[WARNING] - org.codehaus.jackson.map.DeserializerProvider
[WARNING] - org.codehaus.jackson.map.deser.std.StdKeyDeserializer$LongKD
[WARNING] - org.codehaus.jackson.node.ValueNode
[WARNING] - org.codehaus.jackson.map.ser.std.CollectionSerializer
[WARNING] - org.codehaus.jackson.map.ser.impl.PropertySerializerMap$Double
[WARNING] - org.codehaus.jackson.map.deser.FromStringDeserializer
[WARNING] - org.codehaus.jackson.map.deser.std.StdKeyDeserializer$FloatKD
[WARNING] - org.codehaus.jackson.map.Deserializers
[WARNING] - org.codehaus.jackson.map.ser.StdSerializers$SerializableSerializer
[WARNING] - 484 more...
[WARNING] hadoop-yarn-common-2.6.0.jar, hadoop-yarn-api-2.6.0.jar define 3
overlappping classes:
[WARNING] - org.apache.hadoop.yarn.factories.package-info
[WARNING] - org.apache.hadoop.yarn.util.package-info
[WARNING] - org.apache.hadoop.yarn.factory.providers.package-info
[WARNING] commons-beanutils-core-1.8.0.jar, commons-beanutils-1.7.0.jar,
commons-collections-3.2.2.jar define 10 overlappping classes:
[WARNING] - org.apache.commons.collections.FastHashMap$EntrySet
[WARNING] - org.apache.commons.collections.ArrayStack
[WARNING] - org.apache.commons.collections.FastHashMap$1
[WARNING] - org.apache.commons.collections.FastHashMap$KeySet
[WARNING] - org.apache.commons.collections.FastHashMap$CollectionView
[WARNING] - org.apache.commons.collections.BufferUnderflowException
[WARNING] - org.apache.commons.collections.Buffer
[WARNING] -
org.apache.commons.collections.FastHashMap$CollectionView$CollectionViewIterator
[WARNING] - org.apache.commons.collections.FastHashMap$Values
[WARNING] - org.apache.commons.collections.FastHashMap
[WARNING] hive-shims-0.23-2.1.0-SNAPSHOT.jar, hive-exec-2.1.0-SNAPSHOT.jar
define 29 overlappping classes:
[WARNING] -
org.apache.hadoop.hive.shims.Hadoop23Shims$HdfsFileStatusWithIdImpl
[WARNING] - org.apache.hadoop.hive.shims.Hadoop23Shims$HdfsEncryptionShim
[WARNING] - org.apache.hadoop.hive.shims.Jetty23Shims$Server
[WARNING] - org.apache.hadoop.mapred.WebHCatJTShim23
[WARNING] - org.apache.hadoop.hive.shims.Hadoop23Shims$MiniTezShim
[WARNING] - org.apache.hadoop.hive.shims.Jetty23Shims$1
[WARNING] - org.apache.hadoop.hive.thrift.HadoopThriftAuthBridge23
[WARNING] - org.apache.hadoop.hive.shims.Jetty23Shims
[WARNING] -
[jira] [Commented] (HIVE-13363) Add hive.metastore.token.signature property to HiveConf
[
https://issues.apache.org/jira/browse/HIVE-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212725#comment-15212725
]
Anthony Hsu commented on HIVE-13363:
RB: https://reviews.apache.org/r/45348/
> Add hive.metastore.token.signature property to HiveConf
> ---
>
> Key: HIVE-13363
> URL: https://issues.apache.org/jira/browse/HIVE-13363
> Project: Hive
> Issue Type: Improvement
>Reporter: Anthony Hsu
>Assignee: Anthony Hsu
> Attachments: HIVE-13363.1.patch
>
>
> I noticed that the {{hive.metastore.token.signature}} property is not defined
> in HiveConf.java, but hardcoded everywhere it's used in the Hive codebase.
> [HIVE-2963] fixes this but was never committed due to being resolved as a
> duplicate ticket.
> We should add {{hive.metastore.token.signature}} to HiveConf.java to
> centralize its definition and make the property more discoverable (it's
> useful to set it when talking to multiple metastores).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
