[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282901#comment-15282901 ] Aihua Xu commented on HIVE-13705: - Tried a couple of tests and they passed locally. Also doesn't look related. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch, > HIVE-13705.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282236#comment-15282236
]
Hive QA commented on HIVE-13705:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12803506/HIVE-13705.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 52 failed/errored test(s), 9923 tests
executed
*Failed tests:*
{noformat}
TestHWISessionManager - did not produce a TEST-*.xml file
TestMiniLlapCliDriver - did not produce a TEST-*.xml file
TestMiniTezCliDriver-join1.q-mapjoin_decimal.q-union5.q-and-12-more - did not
produce a TEST-*.xml file
TestMiniTezCliDriver-mapjoin_mapjoin.q-insert_into1.q-vector_decimal_2.q-and-12-more
- did not produce a TEST-*.xml file
TestMiniTezCliDriver-script_pipe.q-vector_decimal_aggregate.q-vector_data_types.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-auto_join_reordering_values.q-ptf_seqfile.q-auto_join18.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-avro_joins.q-join36.q-join1.q-and-12-more - did not produce
a TEST-*.xml file
TestSparkCliDriver-join_cond_pushdown_3.q-groupby7.q-auto_join17.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-table_access_keys_stats.q-bucketsortoptimize_insert_4.q-runtime_skewjoin_mapjoin_spark.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-vector_distinct_2.q-join15.q-load_dyn_part3.q-and-12-more -
did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ivyDownload
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_join8
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_join9
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_cross_join
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_escape_clusterby1
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_escape_orderby1
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_groupby_map_ppr
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_index_auto_self_join
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_join_thrift
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_ppd_join3
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_smb_mapjoin_6
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_udaf_collect_set
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union10
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union28
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union_remove_6_subq
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_vector_count_distinct
org.apache.hadoop.hive.llap.daemon.impl.comparator.TestShortestJobFirstComparator.testWaitQueueComparatorWithinDagPriority
org.apache.hadoop.hive.llap.tez.TestConverters.testFragmentSpecToTaskSpec
org.apache.hadoop.hive.llap.tezplugins.TestLlapTaskCommunicator.testFinishableStateUpdateFailure
org.apache.hadoop.hive.metastore.TestAuthzApiEmbedAuthorizerInRemote.org.apache.hadoop.hive.metastore.TestAuthzApiEmbedAuthorizerInRemote
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf
org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs
org.apache.hadoop.hive.metastore.TestHiveMetaStoreStatsMerge.testStatsMerge
org.apache.hadoop.hive.metastore.TestMetaStoreEventListenerOnlyOnCommit.testEventStatus
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAddPartitionWithUnicode
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAddPartitionWithValidPartVal
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAppendPartitionWithCommas
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAppendPartitionWithUnicode
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAppendPartitionWithValidCharacters
org.apache.hadoop.hive.metastore.hbase.TestHBaseSchemaTool.oneMondoTest
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider.testOrcSplitsLocationAffinity
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testShowLocksFilterOptions
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking4
org.apache.hadoop.hive.ql.security.TestClientSideAuthorizationProvider.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestMetastoreAuthorizationProvider.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProvider.testSimplePrivileges
org.apache.hive.hcatalog.listener.TestDbNotificationListener.cleanupNotifs
org.apache.hive.hcatalog.listener.Te
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280757#comment-15280757 ] Ashutosh Chauhan commented on HIVE-13705: - +1 > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch, > HIVE-13705.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280733#comment-15280733 ] Aihua Xu commented on HIVE-13705: - Thanks. Didn't know there is a reset. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280726#comment-15280726
]
Ashutosh Chauhan commented on HIVE-13705:
-
I was thinking of {{rest fs.defaultFS;}} which should restore it to its default
config value.
> Insert into table removes existing data
> ---
>
> Key: HIVE-13705
> URL: https://issues.apache.org/jira/browse/HIVE-13705
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280681#comment-15280681
]
Aihua Xu commented on HIVE-13705:
-
[~ashutoshc] Seems we may not need to unset in the test. I checked existing
tests like groupby1.q test which sets {set fs.default.name=file:///;}} but
doesn't unset. Are you thinking of unseting {{set fs.defaultFS=;}} at the end
of the test?
> Insert into table removes existing data
> ---
>
> Key: HIVE-13705
> URL: https://issues.apache.org/jira/browse/HIVE-13705
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278989#comment-15278989 ] Aihua Xu commented on HIVE-13705: - ServiceLoader will load LocalFileSystem and other FileSystem providers in the context after loading from the configuration file, which causes the file scheme mapping to be overwritten. So I added this to let ProxyLocalFileSystem to take precedence. I didn't find another way to workaround that. I will unset that for the test. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278761#comment-15278761 ] Ashutosh Chauhan commented on HIVE-13705: - Do we need both of following +org.apache.hadoop.fs.LocalFileSystem +org.apache.hadoop.hive.ql.io.ProxyLocalFileSystem Also, can you unset fs.DefaultFS at the end of test so that config doesn't leak for subsequent tests. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278654#comment-15278654 ] Aihua Xu commented on HIVE-13705: - Patch-2: created a ProxyLocalFileSystem to workaround the existing LocalFileSystem issue. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch, HIVE-13705.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278120#comment-15278120 ] Aihua Xu commented on HIVE-13705: - Created HDFS-10385 for the HDFS work. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276980#comment-15276980 ] Ashutosh Chauhan commented on HIVE-13705: - Also, you may want to create HDFS ticket for this bug in LocalFileSystem. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276977#comment-15276977
]
Ashutosh Chauhan commented on HIVE-13705:
-
yeah.. we already have similar arrangement for {{NullScanFileSystem}} in
ql/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
> Insert into table removes existing data
> ---
>
> Key: HIVE-13705
> URL: https://issues.apache.org/jira/browse/HIVE-13705
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-13705.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276949#comment-15276949
]
Aihua Xu commented on HIVE-13705:
-
[~ashutoshc] Want to double check with you your thoughts. I checked the logic
to plug in ProxyFileSystem. Seems we need to register ProxyFileSystem to let
ServiceLoader to load. Is that what you think?
{noformat}
private static void loadFileSystems() {
synchronized (FileSystem.class) {
if (!FILE_SYSTEMS_LOADED) {
ServiceLoader serviceLoader =
ServiceLoader.load(FileSystem.class);
for (FileSystem fs : serviceLoader) {
SERVICE_FILE_SYSTEMS.put(fs.getScheme(), fs.getClass());
}
FILE_SYSTEMS_LOADED = true;
}
}
}
{noformat}
> Insert into table removes existing data
> ---
>
> Key: HIVE-13705
> URL: https://issues.apache.org/jira/browse/HIVE-13705
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-13705.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275806#comment-15275806
]
Hive QA commented on HIVE-13705:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12802724/HIVE-13705.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 9938 tests
executed
*Failed tests:*
{noformat}
TestCliDriver-gen_udf_example_add10.q-ppd_join4.q-union27.q-and-12-more - did
not produce a TEST-*.xml file
TestCliDriver-partition_timestamp.q-ppd_random.q-vector_outer_join5.q-and-12-more
- did not produce a TEST-*.xml file
TestCliDriver-ptf_general_queries.q-unionDistinct_1.q-groupby1_noskew.q-and-12-more
- did not produce a TEST-*.xml file
TestHWISessionManager - did not produce a TEST-*.xml file
TestMiniLlapCliDriver - did not produce a TEST-*.xml file
TestMiniTezCliDriver-enforce_order.q-vector_partition_diff_num_cols.q-unionDistinct_1.q-and-12-more
- did not produce a TEST-*.xml file
TestMiniTezCliDriver-insert_values_non_partitioned.q-join1.q-schema_evol_orc_nonvec_mapwork_part.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-bucketsortoptimize_insert_7.q-smb_mapjoin_15.q-mapreduce1.q-and-12-more
- did not produce a TEST-*.xml file
TestSparkCliDriver-skewjoinopt3.q-union27.q-multigroupby_singlemr.q-and-12-more
- did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
org.apache.hadoop.hive.llap.tez.TestConverters.testFragmentSpecToTaskSpec
org.apache.hadoop.hive.llap.tezplugins.TestLlapTaskCommunicator.testFinishableStateUpdateFailure
org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveOperationType.checkHiveOperationTypeMatch
org.apache.hive.service.cli.session.TestHiveSessionImpl.testLeakOperationHandle
{noformat}
Test results:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/216/testReport
Console output:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/216/console
Test logs:
http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-216/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 14 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12802724 - PreCommit-HIVE-MASTER-Build
> Insert into table removes existing data
> ---
>
> Key: HIVE-13705
> URL: https://issues.apache.org/jira/browse/HIVE-13705
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-13705.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275018#comment-15275018 ] Aihua Xu commented on HIVE-13705: - Yeah. That makes sense. I notice there exists ProxyFileSystem in Hive. I will take a look at that. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[
https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274791#comment-15274791
]
Ashutosh Chauhan commented on HIVE-13705:
-
I see. Thats the bug in Hadoop's {{LocalFileSystem}} implementation. To work
around I put this in
https://github.com/apache/hive/blob/master/shims/common/src/main/java/org/apache/hadoop/fs/ProxyFileSystem.java#L179
I think best way to workaround this issue of Hadoop's {{LocalFileSystem}} not
honoring contract of Hadoop's {{FileSystem}} api is to place in our own local
FileSystem (like ProxyFileSystem) in Hive tree. Open to other ideas as well.
> Insert into table removes existing data
> ---
>
> Key: HIVE-13705
> URL: https://issues.apache.org/jira/browse/HIVE-13705
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-13705.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274779#comment-15274779 ] Aihua Xu commented on HIVE-13705: - I will add a test case for that. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274778#comment-15274778 ] Aihua Xu commented on HIVE-13705: - I didn't check HDFS call. From local call, it will return true and overwrite existing file. Let me test on the hdfs. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274672#comment-15274672 ] Ashutosh Chauhan commented on HIVE-13705: - According to https://github.com/apache/hadoop/blob/branch-2.6.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java#L458 rename will return false if file already exists. Are you finding that to be incorrect? I would like to understand thats the case, otherwise proposed solution *always* makes 2 calls to NN, instead of current solution which does it only when needed. > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13705) Insert into table removes existing data
[ https://issues.apache.org/jira/browse/HIVE-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274655#comment-15274655 ] Yongzhi Chen commented on HIVE-13705: - [~aihuaxu], the change looks fine. Could you add a test which insert into a table twice and list the result? > Insert into table removes existing data > --- > > Key: HIVE-13705 > URL: https://issues.apache.org/jira/browse/HIVE-13705 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-13705.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
