[jira] [Commented] (HIVE-13832) Add missing license header to files
[
https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299676#comment-15299676
]
Jesus Camacho Rodriguez commented on HIVE-13832:
{noformat}
Test Name DurationAge
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables
48 sec 1
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager.testHeartbeater 3.5 sec
1
org.apache.hadoop.hive.llap.daemon.impl.comparator.TestShortestJobFirstComparator.testWaitQueueComparatorWithinDagPriority
5 sec 2
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_select_read_only_encrypted_tbl
1 min 25 sec5
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_constprog_partitioner
2.8 sec 6
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_complex_all
12 sec 6
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_static
1 min 27 sec22
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_dynamic
1 min 40 sec22
org.apache.hive.minikdc.TestHiveAuthFactory.testStartTokenManagerForMemoryTokenStore
2.9 sec 22
org.apache.hive.minikdc.TestHiveAuthFactory.testStartTokenManagerForDBTokenStore
0.42 sec22
org.apache.hive.minikdc.TestMiniHiveKdc.testLogin 1 min 53 sec22
org.apache.hadoop.hive.llap.tez.TestConverters.testFragmentSpecToTaskSpec
54 ms 42
org.apache.hadoop.hive.llap.tezplugins.TestLlapTaskCommunicator.testFinishableStateUpdateFailure
3.2 sec 55
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_selectindate14 sec
74
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avrocountemptytbl
11 sec 74
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_order_null 37 sec
74
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_join_with_different_encryption_keys
1 min 33 sec74
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
9.5 sec 74
org.apache.hadoop.hive.cli.TestMinimrCliDriver.org.apache.hadoop.hive.cli.TestMinimrCliDriver
1 min 10 sec74
{noformat}
> Add missing license header to files
> ---
>
> Key: HIVE-13832
> URL: https://issues.apache.org/jira/browse/HIVE-13832
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-13832.1.patch, HIVE-13832.2.patch, HIVE-13832.patch
>
>
> Preparing to cut the branch for 2.1.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13832) Add missing license header to files
[ https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298662#comment-15298662 ] Vikram Dixit K commented on HIVE-13832: --- +1 > Add missing license header to files > --- > > Key: HIVE-13832 > URL: https://issues.apache.org/jira/browse/HIVE-13832 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Vikram Dixit K > Attachments: HIVE-13832.1.patch, HIVE-13832.2.patch, HIVE-13832.patch > > > Preparing to cut the branch for 2.1.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13832) Add missing license header to files
[ https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298661#comment-15298661 ] Jesus Camacho Rodriguez commented on HIVE-13832: Exactly, that is what I thought. I uploaded the new patch, could you check? Thanks! > Add missing license header to files > --- > > Key: HIVE-13832 > URL: https://issues.apache.org/jira/browse/HIVE-13832 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Vikram Dixit K > Attachments: HIVE-13832.1.patch, HIVE-13832.2.patch, HIVE-13832.patch > > > Preparing to cut the branch for 2.1.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13832) Add missing license header to files
[ https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298644#comment-15298644 ] Vikram Dixit K commented on HIVE-13832: --- I think in that case, a change in bin.xml is missing in the original patch. That would work too! > Add missing license header to files > --- > > Key: HIVE-13832 > URL: https://issues.apache.org/jira/browse/HIVE-13832 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Vikram Dixit K > Attachments: HIVE-13832.1.patch, HIVE-13832.patch > > > Preparing to cut the branch for 2.1.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13832) Add missing license header to files
[
https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298642#comment-15298642
]
Jesus Camacho Rodriguez commented on HIVE-13832:
The output folder in {{packaging/src/main/assembly/bin.xml}} would be still the
same, thus that should not impact Ambari? It is not such a big deal to add a
single file to the rat exclusions, but it would be a bit more robust to use the
same convention for the whole project i.e. storing within the _scripts_ folder.
And that would avoid future additional changes.
> Add missing license header to files
> ---
>
> Key: HIVE-13832
> URL: https://issues.apache.org/jira/browse/HIVE-13832
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Vikram Dixit K
> Attachments: HIVE-13832.1.patch, HIVE-13832.patch
>
>
> Preparing to cut the branch for 2.1.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13832) Add missing license header to files
[ https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298473#comment-15298473 ] Sergey Shelukhin commented on HIVE-13832: - [~vikram.dixit] this was a part of HIVE-13438, is it ok to move it? Is there some test? Maybe there could just be a license header added. The rest looks ok > Add missing license header to files > --- > > Key: HIVE-13832 > URL: https://issues.apache.org/jira/browse/HIVE-13832 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez > Attachments: HIVE-13832.patch > > > Preparing to cut the branch for 2.1.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13832) Add missing license header to files
[
https://issues.apache.org/jira/browse/HIVE-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298366#comment-15298366
]
Jesus Camacho Rodriguez commented on HIVE-13832:
[~sershe], {{llap-server/sql/serviceCheckScript.sql}} does not have a license
header. I moved it to {{llap-server/scripts/serviceCheckScript.sql}}, as
{{**/scripts/*}} is already excluded for rat in the POM file. Is that OK?
If all the rest looks good, could you +1 too? Thanks
> Add missing license header to files
> ---
>
> Key: HIVE-13832
> URL: https://issues.apache.org/jira/browse/HIVE-13832
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-13832.patch
>
>
> Preparing to cut the branch for 2.1.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
