[jira] [Commented] (HIVE-13887) LazySimpleSerDe should parse "NULL" dates faster
[ https://issues.apache.org/jira/browse/HIVE-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681553#comment-15681553 ] Sergio Peña commented on HIVE-13887: I'm moving this JIRA out of 2.1.1 release as it is not a blocker nor critical for a 2.1.1 RC version. Feel free to commit it to branch 2.1 if the patch is ready before the release. > LazySimpleSerDe should parse "NULL" dates faster > > > Key: HIVE-13887 > URL: https://issues.apache.org/jira/browse/HIVE-13887 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers, Vectorization >Affects Versions: 2.1.0 >Reporter: Gopal V >Assignee: Gopal V > Labels: Performance > Fix For: 2.2.0 > > Attachments: HIVE-13887.1.patch, HIVE-13887.1.patch > > > Date string which contain "NULL" or "(null)" are being parsed through a very > slow codepath involving exception handling as a normal codepath. > These are currently ~4x slower than parsing an actual date field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13887) LazySimpleSerDe should parse "NULL" dates faster
[ https://issues.apache.org/jira/browse/HIVE-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369187#comment-15369187 ] Ashutosh Chauhan commented on HIVE-13887: - +1 > LazySimpleSerDe should parse "NULL" dates faster > > > Key: HIVE-13887 > URL: https://issues.apache.org/jira/browse/HIVE-13887 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers, Vectorization >Affects Versions: 2.1.0 >Reporter: Gopal V >Assignee: Gopal V > Labels: Performance > Attachments: HIVE-13887.1.patch, HIVE-13887.1.patch > > > Date string which contain "NULL" or "(null)" are being parsed through a very > slow codepath involving exception handling as a normal codepath. > These are currently ~4x slower than parsing an actual date field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13887) LazySimpleSerDe should parse "NULL" dates faster
[
https://issues.apache.org/jira/browse/HIVE-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313103#comment-15313103
]
Hive QA commented on HIVE-13887:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12807407/HIVE-13887.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10197 tests
executed
*Failed tests:*
{noformat}
TestHWISessionManager - did not produce a TEST-*.xml file
TestJdbcWithMiniHA - did not produce a TEST-*.xml file
TestJdbcWithMiniMr - did not produce a TEST-*.xml file
TestOperationLoggingAPIWithTez - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_constprog_partitioner
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
{noformat}
Test results:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/501/testReport
Console output:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/501/console
Test logs:
http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-501/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12807407 - PreCommit-HIVE-MASTER-Build
> LazySimpleSerDe should parse "NULL" dates faster
>
>
> Key: HIVE-13887
> URL: https://issues.apache.org/jira/browse/HIVE-13887
> Project: Hive
> Issue Type: Bug
> Components: Serializers/Deserializers, Vectorization
>Affects Versions: 2.1.0
>Reporter: Gopal V
>Assignee: Gopal V
> Labels: Performance
> Attachments: HIVE-13887.1.patch, HIVE-13887.1.patch
>
>
> Date string which contain "NULL" or "(null)" are being parsed through a very
> slow codepath involving exception handling as a normal codepath.
> These are currently ~4x slower than parsing an actual date field.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13887) LazySimpleSerDe should parse "NULL" dates faster
[ https://issues.apache.org/jira/browse/HIVE-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310176#comment-15310176 ] Gopal V commented on HIVE-13887: Patch apply required HIVE-13876 > LazySimpleSerDe should parse "NULL" dates faster > > > Key: HIVE-13887 > URL: https://issues.apache.org/jira/browse/HIVE-13887 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers, Vectorization >Affects Versions: 2.1.0 >Reporter: Gopal V >Assignee: Gopal V > Labels: Performance > Attachments: HIVE-13887.1.patch, HIVE-13887.1.patch > > > Date string which contain "NULL" or "(null)" are being parsed through a very > slow codepath involving exception handling as a normal codepath. > These are currently ~4x slower than parsing an actual date field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13887) LazySimpleSerDe should parse "NULL" dates faster
[
https://issues.apache.org/jira/browse/HIVE-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309909#comment-15309909
]
Hive QA commented on HIVE-13887:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12806871/HIVE-13887.1.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/477/testReport
Console output:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/477/console
Test logs:
http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-477/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ [[ -n /usr/java/jdk1.8.0_25 ]]
+ export JAVA_HOME=/usr/java/jdk1.8.0_25
+ JAVA_HOME=/usr/java/jdk1.8.0_25
+ export
PATH=/usr/java/jdk1.8.0_25/bin/:/usr/lib64/qt-3.3/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+
PATH=/usr/java/jdk1.8.0_25/bin/:/usr/lib64/qt-3.3/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-MASTER-Build-477/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
4af1be7..77f563f branch-2.1 -> origin/branch-2.1
+ git reset --hard HEAD
HEAD is now at 181a85b HIVE-13867 restore HiveAuthorizer interface changes
(Thejas Nair, reviewed by Sushanth Sowmyan)
+ git clean -f -d
+ git checkout master
Already on 'master'
+ git reset --hard origin/master
HEAD is now at 181a85b HIVE-13867 restore HiveAuthorizer interface changes
(Thejas Nair, reviewed by Sushanth Sowmyan)
+ git merge --ff-only origin/master
Already up-to-date.
+ git gc
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12806871 - PreCommit-HIVE-MASTER-Build
> LazySimpleSerDe should parse "NULL" dates faster
>
>
> Key: HIVE-13887
> URL: https://issues.apache.org/jira/browse/HIVE-13887
> Project: Hive
> Issue Type: Bug
> Components: Serializers/Deserializers, Vectorization
>Affects Versions: 2.1.0
>Reporter: Gopal V
>Assignee: Gopal V
> Labels: Performance
> Attachments: HIVE-13887.1.patch
>
>
> Date string which contain "NULL" or "(null)" are being parsed through a very
> slow codepath involving exception handling as a normal codepath.
> These are currently ~4x slower than parsing an actual date field.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
