[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891893#comment-15891893 ] Peter Vary commented on HIVE-14459: --- Thanks [~kgyrtkirk], [~vihangk1], [~zsombor.klara] for the review, and the commit! > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Fix For: 2.2.0 > > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.6.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888167#comment-15888167 ] Hive QA commented on HIVE-14459: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12855111/HIVE-14459.6.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10275 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_table] (batchId=147) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=140) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3841/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3841/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3841/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12855111 - PreCommit-HIVE-Build > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.6.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887741#comment-15887741 ] Peter Vary commented on HIVE-14459: --- [~kgyrtkirk]: I have found this error when I rebased the patch. The following create statement from {{q_test_init.sql}} is not valid using beeline: {code} CREATE TABLE primitives ( [..] PARTITIONED BY (year INT COMMENT 'default', month INT COMMENT 'default') ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' ESCAPED BY '\\' <-- This causes the error STORED AS TEXTFILE; {code} I did not have time to investigate yet if this is intentional difference between cli and beeline or this is an error. The warning message is caused by this (patch is waiting for commit): HIVE-16007 When the query does not complie the LogRunnable never stops So I changed the init scripts and I was happy that the error went away. After you comment I have checked and found that the message went away because no init script is run at all :). I will submit a new patch to amend this. Thanks for the review, and for helping me find this issue! > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886658#comment-15886658 ] Zoltan Haindrich commented on HIVE-14459: - [~pvary] I've tried to use the 'src' table - which should be loaded by the init_script - but it seems like its not there. i've got back a couple of exceptions: {code} Warning: java.sql.SQLException: Method getQueryLog() failed. Because the stmtHandle in HiveStatement is null and the statement execution might fail. (state=,code=0) {code} > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884591#comment-15884591 ] Zoltan Haindrich commented on HIVE-14459: - [~pvary]: I think MiniHS2 have found a much more accessible home at itests/util :) We need this test enabled - and have it available to add more cases. +1 > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883377#comment-15883377 ] Hive QA commented on HIVE-14459: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854459/HIVE-14459.5.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10259 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3760/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3760/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3760/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12854459 - PreCommit-HIVE-Build > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654463#comment-15654463 ] Peter Vary commented on HIVE-14459: --- Hi, I am pinging you ([~kgyrtkirk], [~sseth], [~ashutoshc]) since we had a discussion before about the test drives, and I think you know these part of the code the most. Do you think it is worth to have a TestBeeLineDriver? The one used in this patch is a good approach or should we tackle it in another way? Or shall I remove the TestBeeLineDriver altogether, since we do not want to have longer test runs and we think the current tests are good enough? If it is only timing problem which keeps you from reviewing this patch then leave it, this one is not that important, but if you have other issues feel free to call it out, so I can solve them. Or if you think so I could try to find another committers, but I do not want to do it without your blessing :) Thanks, Peter > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591299#comment-15591299 ] Peter Vary commented on HIVE-14459: --- The test failures are not related. Any more review comments? > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589287#comment-15589287 ] Hive QA commented on HIVE-14459: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12834169/HIVE-14459.4.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10572 tests executed *Failed tests:* {noformat} TestBeelineWithHS2ConnectionFile - did not produce a TEST-*.xml file (likely timed out) (batchId=199) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_custom_key2] (batchId=208) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_custom_key] (batchId=208) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_joins] (batchId=208) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=208) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=208) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert] (batchId=208) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_globallimit] (batchId=27) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_bulk] (batchId=89) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] (batchId=157) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] (batchId=157) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] (batchId=157) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1665/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1665/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1665/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12834169 - PreCommit-HIVE-Build > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, > HIVE-14459.4.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588769#comment-15588769 ] Hive QA commented on HIVE-14459: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12834119/HIVE-14459.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10566 tests executed *Failed tests:* {noformat} TestBeelineWithHS2ConnectionFile - did not produce a TEST-*.xml file (likely timed out) (batchId=199) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] (batchId=218) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_globallimit] (batchId=27) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] (batchId=157) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] (batchId=157) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] (batchId=157) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1660/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1660/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1660/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12834119 - PreCommit-HIVE-Build > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586017#comment-15586017 ] Hive QA commented on HIVE-14459: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12833959/HIVE-14459.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10593 tests executed *Failed tests:* {noformat} TestBeelineWithHS2ConnectionFile - did not produce a TEST-*.xml file (likely timed out) (batchId=197) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_globallimit] (batchId=27) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[order_null] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_fast_stats] (batchId=46) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] (batchId=155) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] (batchId=155) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] (batchId=155) org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization.testBlackListedUdfUsage (batchId=204) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1626/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1626/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1626/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12833959 - PreCommit-HIVE-Build > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.2.patch, HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14459) TestBeeLineDriver - migration and re-enable
[ https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585357#comment-15585357 ] Hive QA commented on HIVE-14459: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12833898/HIVE-14459.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10593 tests executed *Failed tests:* {noformat} TestBeelineWithHS2ConnectionFile - did not produce a TEST-*.xml file (likely timed out) (batchId=197) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] (batchId=216) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_globallimit] (batchId=27) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[order_null] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_fast_stats] (batchId=46) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] (batchId=155) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] (batchId=155) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] (batchId=155) org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization.testBlackListedUdfUsage (batchId=204) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1620/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1620/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1620/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12833898 - PreCommit-HIVE-Build > TestBeeLineDriver - migration and re-enable > --- > > Key: HIVE-14459 > URL: https://issues.apache.org/jira/browse/HIVE-14459 > Project: Hive > Issue Type: Sub-task > Components: Tests >Reporter: Zoltan Haindrich >Assignee: Peter Vary > Attachments: HIVE-14459.patch > > > this test have been left behind in HIVE-1 because it had some compile > issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)