[jira] [Commented] (HIVE-14625) Minor qtest fixes
[ https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437512#comment-15437512 ] Siddharth Seth commented on HIVE-14625: --- Can't reproduce the test failure locally. Will leave fixing it for HIVE-14628. Committing this. Thanks for the review [~prasanth_j] > Minor qtest fixes > - > > Key: HIVE-14625 > URL: https://issues.apache.org/jira/browse/HIVE-14625 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14625.01.patch, HIVE-14625.02.patch, > HIVE-14625.03.patch > > > Log times for CoreCliDriver > Exit early if cleanup and createsSources fails > Turn PerfLogger off for ptests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[ https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437412#comment-15437412 ] Siddharth Seth commented on HIVE-14625: --- I suspect the early exit bit added to this patch is causing TestPigHBaseStorageHandler to fail. The fact that the test passed earlier would point to the cluster start not being required.. Have created a separate jira to track this. The rest of the failures are unrelated. > Minor qtest fixes > - > > Key: HIVE-14625 > URL: https://issues.apache.org/jira/browse/HIVE-14625 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14625.01.patch, HIVE-14625.02.patch, > HIVE-14625.03.patch > > > Log times for CoreCliDriver > Exit early if cleanup and createsSources fails > Turn PerfLogger off for ptests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[
https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436892#comment-15436892
]
Hive QA commented on HIVE-14625:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12825376/HIVE-14625.03.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10459 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/986/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/986/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-986/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12825376 - PreCommit-HIVE-MASTER-Build
> Minor qtest fixes
> -
>
> Key: HIVE-14625
> URL: https://issues.apache.org/jira/browse/HIVE-14625
> Project: Hive
> Issue Type: Sub-task
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
> Attachments: HIVE-14625.01.patch, HIVE-14625.02.patch,
> HIVE-14625.03.patch
>
>
> Log times for CoreCliDriver
> Exit early if cleanup and createsSources fails
> Turn PerfLogger off for ptests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[
https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436184#comment-15436184
]
Hive QA commented on HIVE-14625:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12825376/HIVE-14625.03.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10459 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler
org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/979/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/979/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-979/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12825376 - PreCommit-HIVE-MASTER-Build
> Minor qtest fixes
> -
>
> Key: HIVE-14625
> URL: https://issues.apache.org/jira/browse/HIVE-14625
> Project: Hive
> Issue Type: Sub-task
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
> Attachments: HIVE-14625.01.patch, HIVE-14625.02.patch,
> HIVE-14625.03.patch
>
>
> Log times for CoreCliDriver
> Exit early if cleanup and createsSources fails
> Turn PerfLogger off for ptests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[
https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435973#comment-15435973
]
Hive QA commented on HIVE-14625:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12825356/HIVE-14625.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 7117 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestContribCliDriver.org.apache.hadoop.hive.cli.TestContribCliDriver
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.org.apache.hadoop.hive.cli.TestMiniLlapCliDriver
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.org.apache.hadoop.hive.cli.TestMiniTezCliDriver
org.apache.hadoop.hive.cli.TestMinimrCliDriver.org.apache.hadoop.hive.cli.TestMinimrCliDriver
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/977/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/977/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-977/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12825356 - PreCommit-HIVE-MASTER-Build
> Minor qtest fixes
> -
>
> Key: HIVE-14625
> URL: https://issues.apache.org/jira/browse/HIVE-14625
> Project: Hive
> Issue Type: Sub-task
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
> Attachments: HIVE-14625.01.patch, HIVE-14625.02.patch,
> HIVE-14625.03.patch
>
>
> Log times for CoreCliDriver
> Exit early if cleanup and createsSources fails
> Turn PerfLogger off for ptests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[ https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435967#comment-15435967 ] Prasanth Jayachandran commented on HIVE-14625: -- +1 > Minor qtest fixes > - > > Key: HIVE-14625 > URL: https://issues.apache.org/jira/browse/HIVE-14625 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14625.01.patch, HIVE-14625.02.patch, > HIVE-14625.03.patch > > > Log times for CoreCliDriver > Exit early if cleanup and createsSources fails > Turn PerfLogger off for ptests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[ https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435890#comment-15435890 ] Siddharth Seth commented on HIVE-14625: --- Saw a lot of PerfLogger noise while debugging. I'm fine leaving it at debug if it's useful. At some point, the logger can be enabled for the specific test that will fail. Removing any log changes for now. bq. Also, junit to RunListener that we can implement for log,computing time etc. I guess that will more cleaner? RunListener requires a custom test runner. It also does not provide hooks for individual sections. > Minor qtest fixes > - > > Key: HIVE-14625 > URL: https://issues.apache.org/jira/browse/HIVE-14625 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14625.01.patch > > > Log times for CoreCliDriver > Exit early if cleanup and createsSources fails > Turn PerfLogger off for ptests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14625) Minor qtest fixes
[ https://issues.apache.org/jira/browse/HIVE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435788#comment-15435788 ] Prasanth Jayachandran commented on HIVE-14625: -- Setting PerfLogger to INFO will cause failures for operation logging tests. https://github.com/apache/hive/blob/master/itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingAPIWithMr.java Why do we want to change perf logger level to INFO? I don't think that will contribute to huge percent of logging. I have seen log lines from blockreaders that are most common than perflogger. I think we should set log level for hive package to be DEBUG and all others at INFO level. Also, junit to RunListener that we can implement for log,computing time etc. I guess that will more cleaner? > Minor qtest fixes > - > > Key: HIVE-14625 > URL: https://issues.apache.org/jira/browse/HIVE-14625 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14625.01.patch > > > Log times for CoreCliDriver > Exit early if cleanup and createsSources fails > Turn PerfLogger off for ptests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
