[jira] [Commented] (HIVE-14710) unify DB product type treatment in directsql and txnhandler

2016-09-07 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471698#comment-15471698
 ] 

Hive QA commented on HIVE-14710:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12827426/HIVE-14710.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10462 tests 
executed
*Failed tests:*
{noformat}
TestBeeLineWithArgs - did not produce a TEST-*.xml file
TestHiveCli - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynpart_sort_optimization_acid]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1123/testReport
Console output: 
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1123/console
Test logs: 
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-1123/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12827426 - PreCommit-HIVE-MASTER-Build

> unify DB product type treatment in directsql and txnhandler
> ---
>
> Key: HIVE-14710
> URL: https://issues.apache.org/jira/browse/HIVE-14710
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-14710.01.patch, HIVE-14710.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14710) unify DB product type treatment in directsql and txnhandler

2016-09-07 Thread Sergey Shelukhin (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471477#comment-15471477
 ] 

Sergey Shelukhin commented on HIVE-14710:
-

hmm, it seems like  METASTORE_DIRECT_SQL_MAX_ELEMENTS_IN_CLAUSE  was added that 
duplicates METASTORE_DIRECT_SQL_PARTITION_BATCH_SIZE. The latter has the value 
that makes the code detect the appropriate batch size; it seems strange to rely 
on another config setting for that - if the user wanted to configure a value 
they could just set it directly instead of having the code detect it.

> unify DB product type treatment in directsql and txnhandler
> ---
>
> Key: HIVE-14710
> URL: https://issues.apache.org/jira/browse/HIVE-14710
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-14710.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14710) unify DB product type treatment in directsql and txnhandler

2016-09-07 Thread Alan Gates (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471460#comment-15471460
 ] 

Alan Gates commented on HIVE-14710:
---

+1

> unify DB product type treatment in directsql and txnhandler
> ---
>
> Key: HIVE-14710
> URL: https://issues.apache.org/jira/browse/HIVE-14710
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-14710.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14710) unify DB product type treatment in directsql and txnhandler

2016-09-06 Thread Eugene Koifman (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468635#comment-15468635
 ] 

Eugene Koifman commented on HIVE-14710:
---

perhaps it should use METASTORE_DIRECT_SQL_MAX_ELEMENTS_IN_CLAUSE rather than 
hardcode it

> unify DB product type treatment in directsql and txnhandler
> ---
>
> Key: HIVE-14710
> URL: https://issues.apache.org/jira/browse/HIVE-14710
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-14710.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)