[jira] [Commented] (HIVE-15107) HiveLexer can throw NPE in allowQuoteId

2016-11-02 Thread Ratandeep Ratti (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630383#comment-15630383
 ] 

Ratandeep Ratti commented on HIVE-15107:


Seems like this has been fixed here HIVE-13101. In HIVE-13101 by default 
{{false}} is returned if Configuration is null.  But isn't the more appropriate 
default response  {{true}} since the default value of 
HiveConf.ConfVars.HIVE_QUOTEDID_SUPPORT is {{column}}??

> HiveLexer can throw NPE in allowQuoteId
> ---
>
> Key: HIVE-15107
> URL: https://issues.apache.org/jira/browse/HIVE-15107
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Ratandeep Ratti
>Assignee: Ratandeep Ratti
> Attachments: HIVE-15107.patch
>
>
> In HiveLexer.allowQuoteId we reference the HiveConf field, which may be null. 
>  The configuration field is set in ParseDriver only if the hive.ql.Context 
> variable is not null. ParseDriver exposes API such as 
> org.apache.hadoop.hive.ql.parse.ParseDriver#parse(java.lang.String) which can 
> result in the hive.ql.Context field to be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-15107) HiveLexer can throw NPE in allowQuoteId

2016-11-01 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627061#comment-15627061
 ] 

Hive QA commented on HIVE-15107:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12836451/HIVE-15107.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1909/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1909/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1909/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2016-11-01 23:35:54.245
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost 
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost 
-Dhttp.proxyPort=3128'
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-1909/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2016-11-01 23:35:54.247
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 95b17e5 HIVE-15099 : PTFOperator.PTFInvocation didn't properly 
reset the input partition (Wei Zheng, reviewed by Ashutosh Chauhan)
+ git clean -f -d
Removing common/src/java/org/apache/hadoop/hive/conf/HiveConf.java.orig
Removing itests/hive-unit/src/test/java/org/apache/hive/service/server/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 95b17e5 HIVE-15099 : PTFOperator.PTFInvocation didn't properly 
reset the input partition (Wei Zheng, reviewed by Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2016-11-01 23:35:55.138
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g:31
error: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g: patch does not 
apply
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12836451 - PreCommit-HIVE-Build

> HiveLexer can throw NPE in allowQuoteId
> ---
>
> Key: HIVE-15107
> URL: https://issues.apache.org/jira/browse/HIVE-15107
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Ratandeep Ratti
>Assignee: Ratandeep Ratti
> Attachments: HIVE-15107.patch
>
>
> In HiveLexer.allowQuoteId we reference the HiveConf field, which may be null. 
>  The configuration field is set in ParseDriver only if the hive.ql.Context 
> variable is not null. ParseDriver exposes API such as 
> org.apache.hadoop.hive.ql.parse.ParseDriver#parse(java.lang.String) which can 
> result in the hive.ql.Context field to be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)