[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024894#comment-16024894 ] Ashutosh Chauhan commented on HIVE-15300: - +1 > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch, > HIVE-15300.3.patch, HIVE-15300.4.patch, HIVE-15300.5.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024256#comment-16024256 ] Hive QA commented on HIVE-15300: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12869797/HIVE-15300.5.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10756 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[index_serde] (batchId=16) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=152) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=145) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_join30] (batchId=150) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5429/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5429/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5429/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12869797 - PreCommit-HIVE-Build > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch, > HIVE-15300.3.patch, HIVE-15300.4.patch, HIVE-15300.5.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023902#comment-16023902 ] Hive QA commented on HIVE-15300: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12869570/HIVE-15300.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10756 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[create_merge_compressed] (batchId=237) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_3] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_4] (batchId=79) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_cond_pushdown2] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lateral_view_onview] (batchId=55) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=152) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=145) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_join30] (batchId=150) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5423/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5423/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5423/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12869570 - PreCommit-HIVE-Build > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch, > HIVE-15300.3.patch, HIVE-15300.4.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022318#comment-16022318 ] Hive QA commented on HIVE-15300: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12869570/HIVE-15300.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10749 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_3] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_4] (batchId=79) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_cond_pushdown2] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lateral_view_onview] (batchId=55) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=151) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=144) org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=287) org.apache.hive.service.cli.session.TestSessionManagerMetrics.testAbandonedSessionMetrics (batchId=192) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5410/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5410/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5410/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12869570 - PreCommit-HIVE-Build > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch, > HIVE-15300.3.patch, HIVE-15300.4.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760106#comment-15760106 ] Hive QA commented on HIVE-15300: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12843786/HIVE-15300.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 18 failed/errored test(s), 10776 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=234) TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=144) [vectorized_rcfile_columnar.q,vector_elt.q,explainuser_1.q,multi_insert.q,tez_dml.q,vector_bround.q,schema_evol_orc_acid_table.q,vector_when_case_null.q,orc_ppd_schema_evol_1b.q,vector_join30.q,vectorization_11.q,cte_3.q,update_tmp_table.q,vector_decimal_cast.q,groupby_grouping_id2.q,vector_decimal_round.q,tez_smb_empty.q,orc_merge6.q,vector_char_mapjoin1.q,vector_decimal_trailing.q,cte_5.q,tez_union.q,vector_decimal_2.q,columnStatsUpdateForStatsOptimizer_1.q,vector_outer_join3.q,schema_evol_text_vec_part_all_complex.q,tez_dynpart_hashjoin_2.q,auto_sortmerge_join_12.q,offset_limit.q,tez_union_multiinsert.q] TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=103) [skewjoinopt19.q,order.q,join_merge_multi_expressions.q,skewjoinopt10.q,union5.q,insert_into1.q,vectorized_math_funcs.q,vectorization_4.q,vectorization_2.q,skewjoinopt6.q,decimal_1_1.q,join14.q,outer_join_ppr.q,rcfile_bigdata.q,load_dyn_part10.q] TestVectorizedColumnReaderBase - did not produce a TEST-*.xml file (likely timed out) (batchId=251) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_view_3] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[druid_basic2] (batchId=10) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sort_array] (batchId=59) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=135) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_based_fetch_decision] (batchId=151) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=93) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_view_2] (batchId=85) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_view_6] (batchId=85) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_view_disable_cbo_2] (batchId=84) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2630/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2630/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2630/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 18 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12843786 - PreCommit-HIVE-Build > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch, > HIVE-15300.3.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741085#comment-15741085 ] Rajesh Balamohan commented on HIVE-15300: - Thanks [~pxiong]. I had tried that and it was throwing errors in view related queries specifically. > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15740976#comment-15740976 ] Pengcheng Xiong commented on HIVE-15300: [~rajesh.balamohan], i just took a look. It seems that we need to catch the exception following the similar way used in other places in SemanticAnalyzer. Just like this {code} Table tab = null; try{ tab = getTableObjectByName(tabName); } catch (HiveException e) { LOG.info("Table " + tabName + " is not found."); } {code} Could u resubmit the patch? Thanks. > Reuse table information in SemanticAnalyzer::getMetaData to reduce > compilation time > --- > > Key: HIVE-15300 > URL: https://issues.apache.org/jira/browse/HIVE-15300 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Attachments: HIVE-15300.1.patch, HIVE-15300.2.patch > > > E.g Q88 in tpc-ds takes lots of time to compile and it ends up getting the > table details for the same table repeatedly. It took 20+seconds to compile > the query. > It would be good to reuse the table information in > SemanticAnalyzer::getMetadata. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15300) Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time
[ https://issues.apache.org/jira/browse/HIVE-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704338#comment-15704338 ] Hive QA commented on HIVE-15300: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12840802/HIVE-15300.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 58 failed/errored test(s), 10734 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_view_3] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cteViews] (batchId=69) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_1] (batchId=77) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_2] (batchId=50) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_3] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_4] (batchId=75) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_5] (batchId=30) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_6] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_7] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_mat_1] (batchId=29) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_mat_2] (batchId=43) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_mat_3] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_mat_4] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_mat_5] (batchId=2) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[druid_basic2] (batchId=10) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynamic_rdd_cache] (batchId=49) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_cond_pushdown2] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_4] (batchId=24) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_disablecbo_4] (batchId=6) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=59) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_paren] (batchId=43) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[cte_2] (batchId=133) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[cte_4] (batchId=135) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=133) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=133) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_rp_views] (batchId=139) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_views] (batchId=141) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_1] (batchId=151) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_3] (batchId=142) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_5] (batchId=141) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_mat_1] (batchId=141) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_mat_2] (batchId=144) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_mat_3] (batchId=139) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_mat_4] (batchId=136) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_mat_5] (batchId=136) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage3] (batchId=144) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lvj_mapjoin] (batchId=139) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[special_character_in_tabnames_1] (batchId=144) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_union] (batchId=142) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3] (batchId=90) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] (batchId=90) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_view_2] (batchId=83) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_view_6] (batchId=83) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_view_disable_cbo_2] (batchId=83) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[cte_with_in_subquery] (batchId=83) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query31] (batchId=219) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query39] (batchId=219)