[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2017-04-30 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990165#comment-15990165
 ] 

Lefty Leverenz commented on HIVE-15321:
---

Thanks, Aihua Xu.

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Fix For: 2.2.0
>
> Attachments: HIVE-15321.1.patch, HIVE-15321.2.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2017-04-26 Thread Aihua Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984804#comment-15984804
 ] 

Aihua Xu commented on HIVE-15321:
-

Right. It doesn't need to change. It's the same value. Sorry, didn't see your 
message until now.

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Fix For: 2.2.0
>
> Attachments: HIVE-15321.1.patch, HIVE-15321.2.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2016-12-02 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717647#comment-15717647
 ] 

Lefty Leverenz commented on HIVE-15321:
---

Presumably the new default for *hive.metastore.server.max.message.size* doesn't 
need to be documented in the wiki, because the change just appends L to 
"100*1024*1024" -- right?

* [Configuration Properties -- hive.metastore.server.max.message.size | 
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.metastore.server.max.message.size]

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Fix For: 2.2.0
>
> Attachments: HIVE-15321.1.patch, HIVE-15321.2.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2016-11-30 Thread Aihua Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710368#comment-15710368
 ] 

Aihua Xu commented on HIVE-15321:
-

The tests are not related.

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-15321.1.patch, HIVE-15321.2.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2016-11-30 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709808#comment-15709808
 ] 

Hive QA commented on HIVE-15321:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12841123/HIVE-15321.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10735 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=59)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a]
 (batchId=134)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] 
(batchId=134)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_4] 
(batchId=92)
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
 (batchId=96)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2347/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2347/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2347/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12841123 - PreCommit-HIVE-Build

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-15321.1.patch, HIVE-15321.2.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2016-11-30 Thread Aihua Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709512#comment-15709512
 ] 

Aihua Xu commented on HIVE-15321:
-

Patch-1: change to conf.getLongVar() so we can handle larger range of message 
size.

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-15321.1.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15321) Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE

2016-11-30 Thread Yongzhi Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709538#comment-15709538
 ] 

Yongzhi Chen commented on HIVE-15321:
-

LGTM  +1

> Change to read as long for HiveConf.ConfVars.METASTORESERVERMAXMESSAGESIZE
> --
>
> Key: HIVE-15321
> URL: https://issues.apache.org/jira/browse/HIVE-15321
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 1.2.0, 1.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-15321.1.patch
>
>
> Follow up on HIVE-11240 which tries to change the type from int to long, 
> while we are still read with {{conf.getIntVar()}}. 
> Seems we should use {{conf.getLongVar()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)