[jira] [Commented] (HIVE-15351) Disable vectorized VectorUDFAdaptor usage with non-column or constant parameters
[ https://issues.apache.org/jira/browse/HIVE-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746087#comment-15746087 ] Thejas M Nair commented on HIVE-15351: -- Setting fix version to 2.2.0 for master commit. > Disable vectorized VectorUDFAdaptor usage with non-column or constant > parameters > > > Key: HIVE-15351 > URL: https://issues.apache.org/jira/browse/HIVE-15351 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Blocker > Fix For: 2.2.0 > > Attachments: HIVE-15351.01.patch, HIVE-15351.02.patch > > > Vectorization using VectorUDFAdaptor is broken and produces wrong results > when the parameter(s) have vectorized expressions that allocate scratch > columns. So, for now, we restrict VectorUDFAdaptor usage to columns or > constant expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15351) Disable vectorized VectorUDFAdaptor usage with non-column or constant parameters
[ https://issues.apache.org/jira/browse/HIVE-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724003#comment-15724003 ] Matt McCline commented on HIVE-15351: - Committed to master. > Disable vectorized VectorUDFAdaptor usage with non-column or constant > parameters > > > Key: HIVE-15351 > URL: https://issues.apache.org/jira/browse/HIVE-15351 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Blocker > Attachments: HIVE-15351.01.patch, HIVE-15351.02.patch > > > Vectorization using VectorUDFAdaptor is broken and produces wrong results > when the parameter(s) have vectorized expressions that allocate scratch > columns. So, for now, we restrict VectorUDFAdaptor usage to columns or > constant expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15351) Disable vectorized VectorUDFAdaptor usage with non-column or constant parameters
[ https://issues.apache.org/jira/browse/HIVE-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723925#comment-15723925 ] Hive QA commented on HIVE-15351: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12841817/HIVE-15351.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10764 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver (batchId=50) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=134) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2425/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2425/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2425/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12841817 - PreCommit-HIVE-Build > Disable vectorized VectorUDFAdaptor usage with non-column or constant > parameters > > > Key: HIVE-15351 > URL: https://issues.apache.org/jira/browse/HIVE-15351 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Blocker > Attachments: HIVE-15351.01.patch, HIVE-15351.02.patch > > > Vectorization using VectorUDFAdaptor is broken and produces wrong results > when the parameter(s) have vectorized expressions that allocate scratch > columns. So, for now, we restrict VectorUDFAdaptor usage to columns or > constant expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15351) Disable vectorized VectorUDFAdaptor usage with non-column or constant parameters
[ https://issues.apache.org/jira/browse/HIVE-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723396#comment-15723396 ] Matt McCline commented on HIVE-15351: - orc_ppd_schema_evol_3a.q is a flakey test. The others are from queries that no long vectorize due to the change. Updating patch. > Disable vectorized VectorUDFAdaptor usage with non-column or constant > parameters > > > Key: HIVE-15351 > URL: https://issues.apache.org/jira/browse/HIVE-15351 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Blocker > Attachments: HIVE-15351.01.patch > > > Vectorization using VectorUDFAdaptor is broken and produces wrong results > when the parameter(s) have vectorized expressions that allocate scratch > columns. So, for now, we restrict VectorUDFAdaptor usage to columns or > constant expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15351) Disable vectorized VectorUDFAdaptor usage with non-column or constant parameters
[ https://issues.apache.org/jira/browse/HIVE-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717765#comment-15717765 ] Hive QA commented on HIVE-15351: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12841591/HIVE-15351.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 29 failed/errored test(s), 10746 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver (batchId=50) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_when_case] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[foldts] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_between_columns] (batchId=62) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_2] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_3] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_math_funcs] (batchId=21) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_when_case_null] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_case] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_casts] (batchId=74) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_math_funcs] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp_ints_casts] (batchId=44) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=134) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=134) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_adaptor_usage_mode] (batchId=150) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_between_columns] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce_2] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_when_case_null] (batchId=143) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_case] (batchId=147) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_casts] (batchId=151) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5] (batchId=91) org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver (batchId=93) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_case] (batchId=117) org.apache.hive.jdbc.TestJdbcWithLocalClusterSpark.testSparkQuery (batchId=214) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2399/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2399/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2399/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 29 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12841591 - PreCommit-HIVE-Build > Disable vectorized VectorUDFAdaptor usage with non-column or constant > parameters > > > Key: HIVE-15351 > URL: https://issues.apache.org/jira/browse/HIVE-15351 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Blocker > Attachments: HIVE-15351.01.patch > > > Vectorization using VectorUDFAdaptor is broken and produces wrong results > when the parameter(s) have vectorized expressions that allocate scratch > columns. So, for now, we restrict VectorUDFAdaptor usage to columns or > constant expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15351) Disable vectorized VectorUDFAdaptor usage with non-column or constant parameters
[ https://issues.apache.org/jira/browse/HIVE-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716920#comment-15716920 ] Prasanth Jayachandran commented on HIVE-15351: -- +1, pending tests. > Disable vectorized VectorUDFAdaptor usage with non-column or constant > parameters > > > Key: HIVE-15351 > URL: https://issues.apache.org/jira/browse/HIVE-15351 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Blocker > Attachments: HIVE-15351.01.patch > > > Vectorization using VectorUDFAdaptor is broken and produces wrong results > when the parameter(s) have vectorized expressions that allocate scratch > columns. So, for now, we restrict VectorUDFAdaptor usage to columns or > constant expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)