[jira] [Commented] (HIVE-15538) Test HIVE-13884 with more complex query predicates
[ https://issues.apache.org/jira/browse/HIVE-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821697#comment-15821697 ] Marta Kuczora commented on HIVE-15538: -- The patch and the link to the review board is attached. Please review the patch. > Test HIVE-13884 with more complex query predicates > -- > > Key: HIVE-15538 > URL: https://issues.apache.org/jira/browse/HIVE-15538 > Project: Hive > Issue Type: Test > Components: Test >Affects Versions: 2.2.0 >Reporter: Marta Kuczora >Assignee: Marta Kuczora > Attachments: HIVE-15538.patch > > > HIVE-13884 introduced a new property hive.metastore.limit.partition.request. > It would be good to have more tests to cover the cases where the query > predicates (such as like, in) could not be pushed down to see if the fail > back from directsql to ORM works properly if hive.metastore.try.direct.sql is > enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15538) Test HIVE-13884 with more complex query predicates
[ https://issues.apache.org/jira/browse/HIVE-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953323#comment-15953323 ] Hive QA commented on HIVE-15538: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12861680/HIVE-15538.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10580 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select] (batchId=148) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=142) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=174) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4513/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4513/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4513/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12861680 - PreCommit-HIVE-Build > Test HIVE-13884 with more complex query predicates > -- > > Key: HIVE-15538 > URL: https://issues.apache.org/jira/browse/HIVE-15538 > Project: Hive > Issue Type: Test > Components: Test >Affects Versions: 2.2.0 >Reporter: Marta Kuczora >Assignee: Marta Kuczora > Attachments: HIVE-15538.2.patch, HIVE-15538.3.patch, HIVE-15538.patch > > > HIVE-13884 introduced a new property hive.metastore.limit.partition.request. > It would be good to have more tests to cover the cases where the query > predicates (such as like, in) could not be pushed down to see if the fail > back from directsql to ORM works properly if hive.metastore.try.direct.sql is > enabled. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15538) Test HIVE-13884 with more complex query predicates
[ https://issues.apache.org/jira/browse/HIVE-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953382#comment-15953382 ] Marta Kuczora commented on HIVE-15538: -- The failures are not related to the patch, the patch only adds a new unit test. These 3 tests failed in previous builds are well. > Test HIVE-13884 with more complex query predicates > -- > > Key: HIVE-15538 > URL: https://issues.apache.org/jira/browse/HIVE-15538 > Project: Hive > Issue Type: Test > Components: Test >Affects Versions: 2.2.0 >Reporter: Marta Kuczora >Assignee: Marta Kuczora > Attachments: HIVE-15538.2.patch, HIVE-15538.3.patch, HIVE-15538.patch > > > HIVE-13884 introduced a new property hive.metastore.limit.partition.request. > It would be good to have more tests to cover the cases where the query > predicates (such as like, in) could not be pushed down to see if the fail > back from directsql to ORM works properly if hive.metastore.try.direct.sql is > enabled. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15538) Test HIVE-13884 with more complex query predicates
[ https://issues.apache.org/jira/browse/HIVE-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957060#comment-15957060 ] Chaoyu Tang commented on HIVE-15538: LGTM, +1 > Test HIVE-13884 with more complex query predicates > -- > > Key: HIVE-15538 > URL: https://issues.apache.org/jira/browse/HIVE-15538 > Project: Hive > Issue Type: Test > Components: Test >Affects Versions: 2.2.0 >Reporter: Marta Kuczora >Assignee: Marta Kuczora > Attachments: HIVE-15538.2.patch, HIVE-15538.3.patch, HIVE-15538.patch > > > HIVE-13884 introduced a new property hive.metastore.limit.partition.request. > It would be good to have more tests to cover the cases where the query > predicates (such as like, in) could not be pushed down to see if the fail > back from directsql to ORM works properly if hive.metastore.try.direct.sql is > enabled. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15538) Test HIVE-13884 with more complex query predicates
[ https://issues.apache.org/jira/browse/HIVE-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960754#comment-15960754 ] Marta Kuczora commented on HIVE-15538: -- Thanks a lot [~ctang.ma] for committing the patch. > Test HIVE-13884 with more complex query predicates > -- > > Key: HIVE-15538 > URL: https://issues.apache.org/jira/browse/HIVE-15538 > Project: Hive > Issue Type: Test > Components: Test >Affects Versions: 2.2.0 >Reporter: Marta Kuczora >Assignee: Marta Kuczora > Fix For: 3.0.0 > > Attachments: HIVE-15538.2.patch, HIVE-15538.3.patch, HIVE-15538.patch > > > HIVE-13884 introduced a new property hive.metastore.limit.partition.request. > It would be good to have more tests to cover the cases where the query > predicates (such as like, in) could not be pushed down to see if the fail > back from directsql to ORM works properly if hive.metastore.try.direct.sql is > enabled. -- This message was sent by Atlassian JIRA (v6.3.15#6346)