[jira] [Commented] (HIVE-15563) Ignore Illegal Operation state transition exception in SQLOperation.runQuery to expose real exception.
[
https://issues.apache.org/jira/browse/HIVE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810197#comment-15810197
]
Hive QA commented on HIVE-15563:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12846241/HIVE-15563.000.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10918 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=233)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[case_sensitivity]
(batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_testxpath]
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_coalesce]
(batchId=75)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=134)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a]
(batchId=135)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2836/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2836/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2836/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12846241 - PreCommit-HIVE-Build
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> --
>
> Key: HIVE-15563
> URL: https://issues.apache.org/jira/browse/HIVE-15563
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Attachments: HIVE-15563.000.patch
>
>
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> setState may create Illegal Operation state transition exception which may
> hide the real exception. we see the following exception happened from
> {{setState(OperationState.ERROR);}} in SQLOperation.runQuery
> {code}
> org.apache.hive.service.cli.operation.Operation: Error running hive query:
> org.apache.hive.service.cli.HiveSQLException: Illegal Operation state
> transition from CLOSED to ERROR
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:91)
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:97)
> at
> org.apache.hive.service.cli.operation.Operation.setState(Operation.java:154)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:241)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:82)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:288)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:301)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15563) Ignore Illegal Operation state transition exception in SQLOperation.runQuery to expose real exception.
[
https://issues.apache.org/jira/browse/HIVE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815852#comment-15815852
]
Jimmy Xiang commented on HIVE-15563:
Instead of catching the state transition exception, should we check the state
before set the new state the same way as HiveSQLException is handled, and log
the exception:
{noformat}
if ((getStatus().getState() == OperationState.CANCELED)
|| (getStatus().getState() == OperationState.TIMEDOUT)
|| (getStatus().getState() == OperationState.CLOSED)) {
return;
}
{noformat}
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> --
>
> Key: HIVE-15563
> URL: https://issues.apache.org/jira/browse/HIVE-15563
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Attachments: HIVE-15563.000.patch
>
>
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> setState may create Illegal Operation state transition exception which may
> hide the real exception. we see the following exception happened from
> {{setState(OperationState.ERROR);}} in SQLOperation.runQuery
> {code}
> org.apache.hive.service.cli.operation.Operation: Error running hive query:
> org.apache.hive.service.cli.HiveSQLException: Illegal Operation state
> transition from CLOSED to ERROR
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:91)
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:97)
> at
> org.apache.hive.service.cli.operation.Operation.setState(Operation.java:154)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:241)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:82)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:288)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:301)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15563) Ignore Illegal Operation state transition exception in SQLOperation.runQuery to expose real exception.
[
https://issues.apache.org/jira/browse/HIVE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816369#comment-15816369
]
zhihai xu commented on HIVE-15563:
--
thanks for the review [~jxiang]! Good suggestions, In this case, handling error
case "Throwable" will be similar as handling HiveSQLException. I will merge
these two error cases, I submit a new patch HIVE-15563.001.patch which share
the code for both "Throwable" and "HiveSQLException" error case. Please review
it!
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> --
>
> Key: HIVE-15563
> URL: https://issues.apache.org/jira/browse/HIVE-15563
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Attachments: HIVE-15563.000.patch, HIVE-15563.001.patch
>
>
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> setState may create Illegal Operation state transition exception which may
> hide the real exception. we see the following exception happened from
> {{setState(OperationState.ERROR);}} in SQLOperation.runQuery
> {code}
> org.apache.hive.service.cli.operation.Operation: Error running hive query:
> org.apache.hive.service.cli.HiveSQLException: Illegal Operation state
> transition from CLOSED to ERROR
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:91)
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:97)
> at
> org.apache.hive.service.cli.operation.Operation.setState(Operation.java:154)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:241)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:82)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:288)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:301)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15563) Ignore Illegal Operation state transition exception in SQLOperation.runQuery to expose real exception.
[
https://issues.apache.org/jira/browse/HIVE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816399#comment-15816399
]
Jimmy Xiang commented on HIVE-15563:
Thanks for making the change. Looks good to me. +1
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> --
>
> Key: HIVE-15563
> URL: https://issues.apache.org/jira/browse/HIVE-15563
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Attachments: HIVE-15563.000.patch, HIVE-15563.001.patch
>
>
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> setState may create Illegal Operation state transition exception which may
> hide the real exception. we see the following exception happened from
> {{setState(OperationState.ERROR);}} in SQLOperation.runQuery
> {code}
> org.apache.hive.service.cli.operation.Operation: Error running hive query:
> org.apache.hive.service.cli.HiveSQLException: Illegal Operation state
> transition from CLOSED to ERROR
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:91)
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:97)
> at
> org.apache.hive.service.cli.operation.Operation.setState(Operation.java:154)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:241)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:82)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:288)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:301)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15563) Ignore Illegal Operation state transition exception in SQLOperation.runQuery to expose real exception.
[
https://issues.apache.org/jira/browse/HIVE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817004#comment-15817004
]
Hive QA commented on HIVE-15563:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12846686/HIVE-15563.001.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10949 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=233)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[case_sensitivity]
(batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_testxpath]
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_coalesce]
(batchId=75)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=134)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=139)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple]
(batchId=151)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join2]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby1_map_skew]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_ptf]
(batchId=121)
org.apache.hive.service.server.TestHS2HttpServer.testContextRootUrlRewrite
(batchId=185)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2871/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2871/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2871/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12846686 - PreCommit-HIVE-Build
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> --
>
> Key: HIVE-15563
> URL: https://issues.apache.org/jira/browse/HIVE-15563
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Attachments: HIVE-15563.000.patch, HIVE-15563.001.patch
>
>
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> setState may create Illegal Operation state transition exception which may
> hide the real exception. we see the following exception happened from
> {{setState(OperationState.ERROR);}} in SQLOperation.runQuery
> {code}
> org.apache.hive.service.cli.operation.Operation: Error running hive query:
> org.apache.hive.service.cli.HiveSQLException: Illegal Operation state
> transition from CLOSED to ERROR
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:91)
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:97)
> at
> org.apache.hive.service.cli.operation.Operation.setState(Operation.java:154)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:241)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:82)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:288)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:301)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15563) Ignore Illegal Operation state transition exception in SQLOperation.runQuery to expose real exception.
[
https://issues.apache.org/jira/browse/HIVE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819748#comment-15819748
]
zhihai xu commented on HIVE-15563:
--
Thanks [~jxiang] for reviewing and committing the patch!
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> --
>
> Key: HIVE-15563
> URL: https://issues.apache.org/jira/browse/HIVE-15563
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-15563.000.patch, HIVE-15563.001.patch
>
>
> Ignore Illegal Operation state transition exception in SQLOperation.runQuery
> to expose real exception.
> setState may create Illegal Operation state transition exception which may
> hide the real exception. we see the following exception happened from
> {{setState(OperationState.ERROR);}} in SQLOperation.runQuery
> {code}
> org.apache.hive.service.cli.operation.Operation: Error running hive query:
> org.apache.hive.service.cli.HiveSQLException: Illegal Operation state
> transition from CLOSED to ERROR
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:91)
> at
> org.apache.hive.service.cli.OperationState.validateTransition(OperationState.java:97)
> at
> org.apache.hive.service.cli.operation.Operation.setState(Operation.java:154)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:241)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:82)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:288)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
> at
> org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:301)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
