[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper and anonymize passwords before logging
[
https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914090#comment-16914090
]
Hive QA commented on HIVE-15931:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12859257/HIVE-15931.5.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18390/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18390/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18390/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-08-23 09:36:55.559
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-18390/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-08-23 09:36:55.562
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
db59ec6..9482a0c master -> origin/master
+ git reset --hard HEAD
HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016
formats (Karen Coppage via Marta Kuczora)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
(use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at 9482a0c HIVE-21828: Tez: Use a pre-parsed TezConfiguration from
DagUtils - Addendum2 (Attila Magyar via Gopal V)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-08-23 09:36:56.968
+ rm -rf ../yetus_PreCommit-HIVE-Build-18390
+ mkdir ../yetus_PreCommit-HIVE-Build-18390
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-18390
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18390/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: a/beeline/src/java/org/apache/hive/beeline/Commands.java: does not exist
in index
error:
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:
does not exist in index
error: a/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java: does not exist
in index
error: a/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java: does not exist in
index
error: a/jdbc/src/java/org/apache/hive/jdbc/Utils.java: does not exist in index
error: a/jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java:
does not exist in index
error: a/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java: does not exist
in index
error: patch failed:
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:2863
Falling back to three-way merge...
Applied patch to
'itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java'
cleanly.
error: patch failed: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:175
Falling back to three-way merge...
Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java' with
conflicts.
error: patch failed: jdbc/src/java/org/apache/hive/jdbc/Utils.java:294
Falling back to three-way merge...
Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/Utils.java' with conflicts.
error: patch failed:
jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java:70
Falling back to three-way merge...
Applied patch to
'jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java' with
conflicts.
Going to apply patch with: git apply -p1
error: patch failed:
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:2863
Falling back to three-way merge...
Applied patch to
'itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriv
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper and anonymize passwords before logging
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956231#comment-15956231 ] Vaibhav Gumashta commented on HIVE-15931: - [~pvary] Sorry, was occupied with other stuff. Will post a follow up tomorrow based on your latest rb feedback. Thanks for the reviews so far. > JDBC: Improve logging when using ZooKeeper and anonymize passwords before > logging > - > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15931.1.patch, HIVE-15931.2.patch, > HIVE-15931.3.patch, HIVE-15931.4.patch, HIVE-15931.5.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper and anonymize passwords before logging
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929613#comment-15929613 ] Vaibhav Gumashta commented on HIVE-15931: - [~pvary] Sorry, corrected > JDBC: Improve logging when using ZooKeeper and anonymize passwords before > logging > - > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15931.1.patch, HIVE-15931.2.patch, > HIVE-15931.3.patch, HIVE-15931.4.patch, HIVE-15931.5.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper and anonymize passwords before logging
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929611#comment-15929611 ] Peter Vary commented on HIVE-15931: --- [~vgumashta]: I think this is not the patch file you wanted to attach :) > JDBC: Improve logging when using ZooKeeper and anonymize passwords before > logging > - > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15766.5.patch, HIVE-15931.1.patch, > HIVE-15931.2.patch, HIVE-15931.3.patch, HIVE-15931.4.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper
[
https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877034#comment-15877034
]
Hive QA commented on HIVE-15931:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853800/HIVE-15931.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10251 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel
(batchId=211)
org.apache.hive.jdbc.TestJdbcDriver2.testBadURL (batchId=215)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3676/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3676/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3676/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12853800 - PreCommit-HIVE-Build
> JDBC: Improve logging when using ZooKeeper
> --
>
> Key: HIVE-15931
> URL: https://issues.apache.org/jira/browse/HIVE-15931
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.2.0
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
> Attachments: HIVE-15931.1.patch, HIVE-15931.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870460#comment-15870460 ] Vaibhav Gumashta commented on HIVE-15931: - [~pvary] Thanks for reviewing. That's a valid concern. We could anonymize the username-password before printing if they're present in connection url. I'll incorporate the change in v2. > JDBC: Improve logging when using ZooKeeper > -- > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15931.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869667#comment-15869667 ] Peter Vary commented on HIVE-15931: --- Hi [~vgumashta], The better logging is really needed here! Thanks for the patch! I have taken a cursory look at the patch and have 1 concern only, that by printing out the URL into the logs we might start to print out usernames and passwords too. Am I too cautious here? Thanks, Peter > JDBC: Improve logging when using ZooKeeper > -- > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15931.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper
[
https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869222#comment-15869222
]
Hive QA commented on HIVE-15931:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12852931/HIVE-15931.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10238 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1]
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join31] (batchId=81)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
(batchId=152)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join31]
(batchId=133)
org.apache.hive.jdbc.TestJdbcDriver2.testBadURL (batchId=215)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3584/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3584/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3584/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12852931 - PreCommit-HIVE-Build
> JDBC: Improve logging when using ZooKeeper
> --
>
> Key: HIVE-15931
> URL: https://issues.apache.org/jira/browse/HIVE-15931
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.2.0
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
> Attachments: HIVE-15931.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869156#comment-15869156 ] Thejas M Nair commented on HIVE-15931: -- [~vgumashta] Can you please include a reviewboard link or github pull request ? > JDBC: Improve logging when using ZooKeeper > -- > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15931.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
