[jira] [Commented] (HIVE-15950) Make DbTxnManager use Metastore client consistently

2017-02-16 Thread Vaibhav Gumashta (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870959#comment-15870959
 ] 

Vaibhav Gumashta commented on HIVE-15950:
-

+1, using TL client makes sense.

> Make DbTxnManager use Metastore client consistently
> ---
>
> Key: HIVE-15950
> URL: https://issues.apache.org/jira/browse/HIVE-15950
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-15950.01.patch, HIVE-15950.02.patch
>
>
> Currently it caches IMetastoreClient on init() but the same connection is 
> indirectly saved using ThreadLocal (since Hive.get() uses ThreadLocal).
> So it may cause something other than DbTxnManager to use the same connection. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15950) Make DbTxnManager use Metastore client consistently

2017-02-16 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870935#comment-15870935
 ] 

Hive QA commented on HIVE-15950:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853148/HIVE-15950.02.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10244 tests 
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1] 
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join31] (batchId=81)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
 (batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
 (batchId=152)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join31] 
(batchId=133)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3610/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3610/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3610/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12853148 - PreCommit-HIVE-Build

> Make DbTxnManager use Metastore client consistently
> ---
>
> Key: HIVE-15950
> URL: https://issues.apache.org/jira/browse/HIVE-15950
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-15950.01.patch, HIVE-15950.02.patch
>
>
> Currently it caches IMetastoreClient on init() but the same connection is 
> indirectly saved using ThreadLocal (since Hive.get() uses ThreadLocal).
> So it may cause something other than DbTxnManager to use the same connection. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15950) Make DbTxnManager use Metastore client consistently

2017-02-16 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870917#comment-15870917
 ] 

Eugene Koifman commented on HIVE-15950:
---

no related failures


> Make DbTxnManager use Metastore client consistently
> ---
>
> Key: HIVE-15950
> URL: https://issues.apache.org/jira/browse/HIVE-15950
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-15950.01.patch, HIVE-15950.02.patch
>
>
> Currently it caches IMetastoreClient on init() but the same connection is 
> indirectly saved using ThreadLocal (since Hive.get() uses ThreadLocal).
> So it may cause something other than DbTxnManager to use the same connection. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15950) Make DbTxnManager use Metastore client consistently

2017-02-16 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870878#comment-15870878
 ] 

Hive QA commented on HIVE-15950:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853148/HIVE-15950.02.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10244 tests 
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1] 
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join31] (batchId=81)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
 (batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
 (batchId=152)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join31] 
(batchId=133)
org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel 
(batchId=211)
org.apache.hive.hcatalog.pig.TestRCFileHCatStorer.testWriteDecimalXY 
(batchId=173)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testPartColsInData 
(batchId=173)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3609/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3609/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3609/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12853148 - PreCommit-HIVE-Build

> Make DbTxnManager use Metastore client consistently
> ---
>
> Key: HIVE-15950
> URL: https://issues.apache.org/jira/browse/HIVE-15950
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-15950.01.patch, HIVE-15950.02.patch
>
>
> Currently it caches IMetastoreClient on init() but the same connection is 
> indirectly saved using ThreadLocal (since Hive.get() uses ThreadLocal).
> So it may cause something other than DbTxnManager to use the same connection. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)