[jira] [Commented] (HIVE-16155) No need for ConditionalTask if no conditional map join is created

2017-03-09 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903270#comment-15903270
 ] 

Hive QA commented on HIVE-16155:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12856983/HIVE-16155.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 10335 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.service.server.TestHS2HttpServer.testContextRootUrlRewrite 
(batchId=187)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4051/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4051/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4051/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12856983 - PreCommit-HIVE-Build

> No need for ConditionalTask if no conditional map join is created
> -
>
> Key: HIVE-16155
> URL: https://issues.apache.org/jira/browse/HIVE-16155
> Project: Hive
>  Issue Type: Bug
>Reporter: Rui Li
>Assignee: Rui Li
>Priority: Minor
> Attachments: HIVE-16155.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16155) No need for ConditionalTask if no conditional map join is created

2017-03-10 Thread Rui Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904708#comment-15904708
 ] 

Rui Li commented on HIVE-16155:
---

The failure can't be reproduced locally.
[~xuefuz] would you mind take a look at the patch? It's trivial and does the 
following changes:
1. Check the small table size first. So if the small table doesn't fit, we 
don't need to clone query plan or creating map join, which can be time 
consuming.
2. Don't create conditional task if no map join is created. Before the patch, 
if no map join is created, we still get a conditional task containing only the 
original common join, which is unnecessary and makes the query plan confusing.

> No need for ConditionalTask if no conditional map join is created
> -
>
> Key: HIVE-16155
> URL: https://issues.apache.org/jira/browse/HIVE-16155
> Project: Hive
>  Issue Type: Bug
>Reporter: Rui Li
>Assignee: Rui Li
>Priority: Minor
> Attachments: HIVE-16155.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16155) No need for ConditionalTask if no conditional map join is created

2017-03-10 Thread Xuefu Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905923#comment-15905923
 ] 

Xuefu Zhang commented on HIVE-16155:


+1

> No need for ConditionalTask if no conditional map join is created
> -
>
> Key: HIVE-16155
> URL: https://issues.apache.org/jira/browse/HIVE-16155
> Project: Hive
>  Issue Type: Bug
>Reporter: Rui Li
>Assignee: Rui Li
>Priority: Minor
> Attachments: HIVE-16155.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)