[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904076#comment-15904076 ] Tao Li commented on HIVE-16161: --- + [~vgumashta] > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904164#comment-15904164 ] Tao Li commented on HIVE-16161: --- The size of jdbc standalone jar increased from 20 MB to 60 MB with this change, which I think is OK. We want to make sure all needed classed are shaded into this jar. > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904169#comment-15904169 ] Vaibhav Gumashta commented on HIVE-16161: - +1 > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904607#comment-15904607 ] Tao Li commented on HIVE-16161: --- [~vgumashta] Thanks! Can you commit it please? > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905429#comment-15905429 ] Vaibhav Gumashta commented on HIVE-16161: - [~taoli-hwx] Waiting for precommit run. Will commit if after the run. > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905470#comment-15905470 ] Tao Li commented on HIVE-16161: --- [~vgumashta] Sounds good. I don't see a build from https://builds.apache.org/job/PreCommit-HIVE-Build/ though. Should I re-submit? > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905509#comment-15905509 ] Tao Li commented on HIVE-16161: --- Resubmission did not help. [~daijy] is kicking off one manually. Thanks. > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[
https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905627#comment-15905627
]
Hive QA commented on HIVE-16161:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12857129/HIVE-16161.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 10336 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4074/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4074/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4074/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12857129 - PreCommit-HIVE-Build
> Disable "packaging.minimizeJar" for JDBC build
> --
>
> Key: HIVE-16161
> URL: https://issues.apache.org/jira/browse/HIVE-16161
> Project: Hive
> Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
>Priority: Critical
> Attachments: HIVE-16161.1.patch
>
>
> "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the
> standalone JDBC jar not having some necessary classes like
> "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to
> set it to false to have the classes shaded into the jdbc jar as expected.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16161) Disable "packaging.minimizeJar" for JDBC build
[ https://issues.apache.org/jira/browse/HIVE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905697#comment-15905697 ] Tao Li commented on HIVE-16161: --- [~vgumashta] Test result looks good. > Disable "packaging.minimizeJar" for JDBC build > -- > > Key: HIVE-16161 > URL: https://issues.apache.org/jira/browse/HIVE-16161 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li >Priority: Critical > Attachments: HIVE-16161.1.patch > > > "packaging.minimizeJar" is set to true for jdbc/pom.xml, which causes the > standalone JDBC jar not having some necessary classes like > "org.apache.hive.org.apache.commons.logging.impl.LogFactoryImpl". We need to > set it to false to have the classes shaded into the jdbc jar as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
