[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-29 Thread Vineet Garg (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948052#comment-15948052
 ] 

Vineet Garg commented on HIVE-16229:


No not yet, I'll open a JIRA

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Fix For: 2.2.0
>
> Attachments: HIVE-16228.2.patch, HIVE-16229.1.patch
>
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-29 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948029#comment-15948029
 ] 

Ashutosh Chauhan commented on HIVE-16229:
-

Did we file a follow-up to optimize for common case of subquery containing an 
aggregate without gby ?

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Fix For: 2.2.0
>
> Attachments: HIVE-16228.2.patch, HIVE-16229.1.patch
>
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937654#comment-15937654
 ] 

Hive QA commented on HIVE-16229:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12860027/HIVE-16228.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 10510 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4302/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4302/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4302/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12860027 - PreCommit-HIVE-Build

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-16228.2.patch, HIVE-16229.1.patch
>
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-22 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937384#comment-15937384
 ] 

Ashutosh Chauhan commented on HIVE-16229:
-

We can optimize this code path by not introducing this count if we know at 
compile time that subq will generate atmost 1 row. We can take that up in a 
follow-up.
+1 

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-16228.2.patch, HIVE-16229.1.patch
>
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-22 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936838#comment-15936838
 ] 

Ashutosh Chauhan commented on HIVE-16229:
-

you may remove commented code. Can you please create RB as well?

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-16229.1.patch
>
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-21 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935772#comment-15935772
 ] 

Hive QA commented on HIVE-16229:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12859826/HIVE-16229.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10497 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query1] (batchId=226)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query30] 
(batchId=226)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query6] (batchId=226)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query81] 
(batchId=226)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4281/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4281/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4281/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12859826 - PreCommit-HIVE-Build

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-16229.1.patch
>
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16229) Wrong result for correlated scalar subquery with aggregate

2017-03-15 Thread Vineet Garg (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927490#comment-15927490
 ] 

Vineet Garg commented on HIVE-16229:


Plan generated for such queries is missing runtime check i.e. {{sq_count_check}}

> Wrong result for correlated scalar subquery with aggregate
> --
>
> Key: HIVE-16229
> URL: https://issues.apache.org/jira/browse/HIVE-16229
> Project: Hive
>  Issue Type: Bug
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>
> Query:
> {code:SQL}
> select * from part where p_size > (select count(*) from part p where p.p_mfgr 
> = part.p_mfgr group by p_type);
> {code}
> Expected results:
> {code}
> ERROR: more than one row produced by subquery
> {code}
> Actual
> {code}
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 49671 almond antique gainsboro frosted violet Manufacturer#4  Brand#41
> SMALL BRUSHED BRASS 10  SM BOX  1620.67 ccounts run quick
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 48427 almond antique violet mint lemonManufacturer#4  Brand#42
> PROMO POLISHED STEEL39  SM CASE 1375.42 hely ironic i
> 
> Time taken: 13.742 seconds, Fetched: 123 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)