[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508517#comment-16508517
]
Vineet Garg commented on HIVE-16505:
This should be documented.
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: todoc4.0
> Fix For: 4.0.0
>
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch, HIVE-16505.04.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507737#comment-16507737
]
Laszlo Bodor commented on HIVE-16505:
-
Thanks for pushing [~kgyrtkirk] !
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch, HIVE-16505.04.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506865#comment-16506865
]
Laszlo Bodor commented on HIVE-16505:
-
Tests passed, could you push it [~kgyrtkirk] ?
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch, HIVE-16505.04.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506796#comment-16506796
]
Hive QA commented on HIVE-16505:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926902/HIVE-16505.04.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14513 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11641/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11641/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11641/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12926902 - PreCommit-HIVE-Build
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch, HIVE-16505.04.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506788#comment-16506788
]
Hive QA commented on HIVE-16505:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
44s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 16s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11641/dev-support/hive-personality.sh
|
| git revision | master / 6454585 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11641/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch, HIVE-16505.04.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503923#comment-16503923
]
Hive QA commented on HIVE-16505:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926468/HIVE-16505.03.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14448 tests
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed
out) (batchId=167)
[bucketsortoptimize_insert_7.q,vectorized_parquet.q,vector_udf_string_to_boolean.q,vector_case_when_2.q,vector_decimal_expressions.q,union_fast_stats.q,cbo_subq_not_in.q,resourceplan.q,identity_project_remove_skip.q,windowing.q,delete_tmp_table.q,bucket2.q,vector_aggregate_without_gby.q,schema_evol_text_nonvec_part_all_primitive.q,vector_windowing_streaming.q,materialized_view_create_rewrite_dummy.q,orc_create.q,vector_distinct_2.q,vector_groupby_rollup1.q,cbo_rp_limit.q,vectorization_13.q,mapjoin_mapjoin.q,bucketmapjoin6.q,update_all_partitioned.q,vector_decimal_precision.q,dynpart_sort_optimization.q,tez_join_hash.q,multi_insert_lateral_view.q,non_native_window_udf.q,schema_evol_orc_vec_part_all_complex.q]
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11567/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11567/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11567/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12926468 - PreCommit-HIVE-Build
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503866#comment-16503866
]
Hive QA commented on HIVE-16505:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
50s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11567/dev-support/hive-personality.sh
|
| git revision | master / 99cb7c0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11567/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500987#comment-16500987
]
Laszlo Bodor commented on HIVE-16505:
-
input31 failure is unrelated, but let's try again with 03.patch
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch,
> HIVE-16505.03.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499317#comment-16499317
]
Hive QA commented on HIVE-16505:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12925899/HIVE-16505.02.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11462/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11462/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11462/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12925899/HIVE-16505.02.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12925899 - PreCommit-HIVE-Build
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499275#comment-16499275
]
Hive QA commented on HIVE-16505:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12925899/HIVE-16505.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 1 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input31] (batchId=63)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11457/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11457/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11457/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12925899 - PreCommit-HIVE-Build
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499259#comment-16499259
]
Hive QA commented on HIVE-16505:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11457/dev-support/hive-personality.sh
|
| git revision | master / 1c5faaa |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11457/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496442#comment-16496442
]
Zoltan Haindrich commented on HIVE-16505:
-
+1 pending tests
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496413#comment-16496413
]
Laszlo Bodor commented on HIVE-16505:
-
Thanks [~kgyrtkirk] , i've uploaded 02.patch
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch, HIVE-16505.02.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496313#comment-16496313
]
Zoltan Haindrich commented on HIVE-16505:
-
not sure if we want to introduce {{UNKNOWN}} as a fully reserved
keyword...probably doesn't; so could you add it to {{nonReserved}} list at the
end of {{IdentifiersParser.g}}
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496311#comment-16496311
]
Zoltan Haindrich commented on HIVE-16505:
-
please remove unknown from booleanValueTok ; that seems to be only used in
{{set autocommit ...}}; and {{set autocommit unknown}} seems to be a very
interesting setting - as a matter of fact I'm not sure if {{autocommit false}}
is supported... (by the way I don't think that having TOK_TRUE/FALSE is usefull)
I see your intention in the test; but {{select 1 where null is not unknown}}
doesn't fit in :D
I think you might probably use {{select assert_true( null is unknown )}} to
check these...as qtest outputs are overwritten all the time...(sometimes even
by mistake)
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-16505) Support "unknown" boolean truth value
[
https://issues.apache.org/jira/browse/HIVE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496252#comment-16496252
]
Laszlo Bodor commented on HIVE-16505:
-
[~kgyrtkirk] : 01.patch attached. Could you please check if the introduced
qtest covers all the relevant cases?
> Support "unknown" boolean truth value
> -
>
> Key: HIVE-16505
> URL: https://issues.apache.org/jira/browse/HIVE-16505
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
>Reporter: Zoltan Haindrich
>Assignee: Laszlo Bodor
>Priority: Major
> Attachments: HIVE-16505.01.patch
>
>
> according to the standard, boolean truth value might be:
> {{TRUE|FALSE|UNKNOWN}}.
> similar queries to the following should be supported:
> {code:java}
> select 1 where null is unknown;
> select 1 where (select cast(null as boolean) ) is unknown;
> {code}
> "unknown" behaves similarily to null. {{(null=null) is null}}
>
> "All boolean values and SQL truth values are comparable and all are
> assignable to a site of type boolean. The value True is greater than the
> value False, and any comparison involving the null value or an Unknown truth
> value will return an Unknown result. The values True and False may be
> assigned to any site having a boolean data type; assignment of Unknown, or
> the null value, is subject to the nullability characteristic of the target."
>
> *Truth table for the AND boolean operator*
> AND True False Unknown
> True True False Unknown
> False False False False
> Unknown Unknown False Unknown
> *Truth table for the OR boolean operator*
> OR True False Unknown
> True True True True
> False True False Unknown
> Unknown True Unknown Unknown
> *Truth table for the IS boolean operator*
> IS TRUE FALSE UNKNOWN
> True True False False
> False False True False
> Unknown False False True
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
