[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022354#comment-16022354
]
Lefty Leverenz commented on HIVE-16723:
---
Doc note: This should be explained on the Hive Schema Tool wiki page, and
*hive.metastore.schema.info.class* should be documented in Configuration
Properties.
* [Hive Schema Tool |
https://cwiki.apache.org/confluence/display/Hive/Hive+Schema+Tool]
* [Configuration Properties -- MetaStore |
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-MetaStore]
Added a TODOC3.0 label.
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Labels: TODOC3.0
> Fix For: 3.0.0
>
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch,
> HIVE-16723.03.patch, HIVE-16723.04.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021530#comment-16021530
]
Vihang Karajgaonkar commented on HIVE-16723:
Thanks for the review [~ngangam]
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch,
> HIVE-16723.03.patch, HIVE-16723.04.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020437#comment-16020437
]
Hive QA commented on HIVE-16723:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12869341/HIVE-16723.04.patch
{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 10749 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5388/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5388/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5388/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12869341 - PreCommit-HIVE-Build
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch,
> HIVE-16723.03.patch, HIVE-16723.04.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020284#comment-16020284
]
Vihang Karajgaonkar commented on HIVE-16723:
Addressed comments on RB. Attaching the latest version of patch for pre-commit
tests
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch,
> HIVE-16723.03.patch, HIVE-16723.04.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020240#comment-16020240
]
Naveen Gangam commented on HIVE-16723:
--
[~vihangk1] Just a nit. Could you update the javadocs for the interface? I dont
recall if the javadocs for the default SchemaInfo is sufficient but I think it
makes sense to have them on the interface. Otherwise looks good to me. +1
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch,
> HIVE-16723.03.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018709#comment-16018709
]
Hive QA commented on HIVE-16723:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12869153/HIVE-16723.03.patch
{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10743 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[compute_stats_boolean]
(batchId=78)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_ppd_decimal]
(batchId=9)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5373/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5373/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5373/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12869153 - PreCommit-HIVE-Build
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch,
> HIVE-16723.03.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018287#comment-16018287
]
Hive QA commented on HIVE-16723:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12869074/HIVE-16723.02.patch
{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10741 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3]
(batchId=97)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
(batchId=97)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query24]
(batchId=231)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5363/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5363/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5363/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12869074 - PreCommit-HIVE-Build
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16723) Enable configurable MetaStoreSchemaInfo
[
https://issues.apache.org/jira/browse/HIVE-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018249#comment-16018249
]
Hive QA commented on HIVE-16723:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12869074/HIVE-16723.02.patch
{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10741 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3]
(batchId=97)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
(batchId=97)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query24]
(batchId=231)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5362/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5362/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5362/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12869074 - PreCommit-HIVE-Build
> Enable configurable MetaStoreSchemaInfo
>
>
> Key: HIVE-16723
> URL: https://issues.apache.org/jira/browse/HIVE-16723
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
> Attachments: HIVE-16723.01.patch, HIVE-16723.02.patch
>
>
> {{MetaStoreSchemaInfo}} class is used by Schema tool to get the schema
> version information. In addition to that schema tool invokes its init and
> upgrade methods to initialize and upgrade the metastore schema. It is
> possible that there are minor schema changes in the metastore schema which
> users have to maintain manually. We can potentially enhance schema tool to
> use a custom MetaStoreSchemaInfo implementation which can be plugged in based
> on configuration and schematool could run these customizations while running
> the upgrade and init scripts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
