[jira] [Commented] (HIVE-16943) MoveTask should separate src FileSystem from dest FileSystem
[
https://issues.apache.org/jira/browse/HIVE-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062490#comment-16062490
]
Fei Hui commented on HIVE-16943:
[~ashutoshc] could you please commit this patch? Thanks
> MoveTask should separate src FileSystem from dest FileSystem
> -
>
> Key: HIVE-16943
> URL: https://issues.apache.org/jira/browse/HIVE-16943
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 3.0.0
>Reporter: Fei Hui
>Assignee: Fei Hui
> Attachments: HIVE-16943.1.patch
>
>
> {code:title=MoveTask.java|borderStyle=solid}
> private void moveFileInDfs (Path sourcePath, Path targetPath, FileSystem fs)
> throws HiveException, IOException {
> // if source exists, rename. Otherwise, create a empty directory
> if (fs.exists(sourcePath)) {
> Path deletePath = null;
> // If it multiple level of folder are there fs.rename is failing so
> first
> // create the targetpath.getParent() if it not exist
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_INSERT_INTO_MULTILEVEL_DIRS)) {
> deletePath = createTargetPath(targetPath, fs);
> }
> Hive.clearDestForSubDirSrc(conf, targetPath, sourcePath, false);
> if (!Hive.moveFile(conf, sourcePath, targetPath, true, false)) {
> try {
> if (deletePath != null) {
> fs.delete(deletePath, true);
> }
> } catch (IOException e) {
> LOG.info("Unable to delete the path created for facilitating rename"
> + deletePath);
> }
> throw new HiveException("Unable to rename: " + sourcePath
> + " to: " + targetPath);
> }
> } else if (!fs.mkdirs(targetPath)) {
> throw new HiveException("Unable to make directory: " + targetPath);
> }
> }
> {code}
> Maybe sourcePath and targetPath come from defferent filesystem, we should
> separate them.
> I see that HIVE-11568 had done it in Hive.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-16943) MoveTask should separate src FileSystem from dest FileSystem
[
https://issues.apache.org/jira/browse/HIVE-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060496#comment-16060496
]
Fei Hui commented on HIVE-16943:
Failed tests are unrelated.
> MoveTask should separate src FileSystem from dest FileSystem
> -
>
> Key: HIVE-16943
> URL: https://issues.apache.org/jira/browse/HIVE-16943
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 3.0.0
>Reporter: Fei Hui
>Assignee: Fei Hui
> Attachments: HIVE-16943.1.patch
>
>
> {code:title=MoveTask.java|borderStyle=solid}
> private void moveFileInDfs (Path sourcePath, Path targetPath, FileSystem fs)
> throws HiveException, IOException {
> // if source exists, rename. Otherwise, create a empty directory
> if (fs.exists(sourcePath)) {
> Path deletePath = null;
> // If it multiple level of folder are there fs.rename is failing so
> first
> // create the targetpath.getParent() if it not exist
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_INSERT_INTO_MULTILEVEL_DIRS)) {
> deletePath = createTargetPath(targetPath, fs);
> }
> Hive.clearDestForSubDirSrc(conf, targetPath, sourcePath, false);
> if (!Hive.moveFile(conf, sourcePath, targetPath, true, false)) {
> try {
> if (deletePath != null) {
> fs.delete(deletePath, true);
> }
> } catch (IOException e) {
> LOG.info("Unable to delete the path created for facilitating rename"
> + deletePath);
> }
> throw new HiveException("Unable to rename: " + sourcePath
> + " to: " + targetPath);
> }
> } else if (!fs.mkdirs(targetPath)) {
> throw new HiveException("Unable to make directory: " + targetPath);
> }
> }
> {code}
> Maybe sourcePath and targetPath come from defferent filesystem, we should
> separate them.
> I see that HIVE-11568 had done it in Hive.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-16943) MoveTask should separate src FileSystem from dest FileSystem
[
https://issues.apache.org/jira/browse/HIVE-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060405#comment-16060405
]
Hive QA commented on HIVE-16943:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12874172/HIVE-16943.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 10730 tests
executed
*Failed tests:*
{noformat}
TestCleaner2 - did not produce a TEST-*.xml file (likely timed out)
(batchId=258)
TestConvertAstToSearchArg - did not produce a TEST-*.xml file (likely timed
out) (batchId=258)
TestIOContextMap - did not produce a TEST-*.xml file (likely timed out)
(batchId=258)
TestInitiator - did not produce a TEST-*.xml file (likely timed out)
(batchId=258)
TestRecordIdentifier - did not produce a TEST-*.xml file (likely timed out)
(batchId=258)
TestSearchArgumentImpl - did not produce a TEST-*.xml file (likely timed out)
(batchId=258)
TestWorker - did not produce a TEST-*.xml file (likely timed out) (batchId=258)
TestWorker2 - did not produce a TEST-*.xml file (likely timed out) (batchId=258)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_smb_main]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=146)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=233)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query16]
(batchId=233)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query94]
(batchId=233)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union24]
(batchId=125)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testBootstrapFunctionReplication
(batchId=217)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionIncrementalReplication
(batchId=217)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionWithFunctionBinaryJarsOnHDFS
(batchId=217)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
(batchId=178)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
(batchId=178)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
(batchId=178)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5738/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5738/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5738/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 20 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12874172 - PreCommit-HIVE-Build
> MoveTask should separate src FileSystem from dest FileSystem
> -
>
> Key: HIVE-16943
> URL: https://issues.apache.org/jira/browse/HIVE-16943
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 3.0.0
>Reporter: Fei Hui
>Assignee: Fei Hui
> Attachments: HIVE-16943.1.patch
>
>
> {code:title=MoveTask.java|borderStyle=solid}
> private void moveFileInDfs (Path sourcePath, Path targetPath, FileSystem fs)
> throws HiveException, IOException {
> // if source exists, rename. Otherwise, create a empty directory
> if (fs.exists(sourcePath)) {
> Path deletePath = null;
> // If it multiple level of folder are there fs.rename is failing so
> first
> // create the targetpath.getParent() if it not exist
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_INSERT_INTO_MULTILEVEL_DIRS)) {
> deletePath = createTargetPath(targetPath, fs);
> }
> Hive.clearDestForSubDirSrc(conf, targetPath, sourcePath, false);
> if (!Hive.moveFile(conf, sourcePath, targetPath, true, false)) {
> try {
> if (deletePath != null) {
> fs.delete(deletePath, true);
> }
> } catch (IOException e) {
> LOG.info("Unable to delete the path created for facilitating rename"
> + deletePath);
> }
> throw new HiveException("Unable to rename: " + sourcePath
> + " to: " + targetPath);
> }
> } else if (!fs.mkdirs(targetPath)) {
> throw new HiveException("Unable to make directory: " + targetPath);
> }
> }
> {code}
> Maybe sourcePath and targetPath come from defferent filesystem, we should
> separate them.
> I see that HIVE-11568 had done it in Hiv
[jira] [Commented] (HIVE-16943) MoveTask should separate src FileSystem from dest FileSystem
[
https://issues.apache.org/jira/browse/HIVE-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060380#comment-16060380
]
Ashutosh Chauhan commented on HIVE-16943:
-
+1 pending tests
> MoveTask should separate src FileSystem from dest FileSystem
> -
>
> Key: HIVE-16943
> URL: https://issues.apache.org/jira/browse/HIVE-16943
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 3.0.0
>Reporter: Fei Hui
>Assignee: Fei Hui
> Attachments: HIVE-16943.1.patch
>
>
> {code:title=MoveTask.java|borderStyle=solid}
> private void moveFileInDfs (Path sourcePath, Path targetPath, FileSystem fs)
> throws HiveException, IOException {
> // if source exists, rename. Otherwise, create a empty directory
> if (fs.exists(sourcePath)) {
> Path deletePath = null;
> // If it multiple level of folder are there fs.rename is failing so
> first
> // create the targetpath.getParent() if it not exist
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_INSERT_INTO_MULTILEVEL_DIRS)) {
> deletePath = createTargetPath(targetPath, fs);
> }
> Hive.clearDestForSubDirSrc(conf, targetPath, sourcePath, false);
> if (!Hive.moveFile(conf, sourcePath, targetPath, true, false)) {
> try {
> if (deletePath != null) {
> fs.delete(deletePath, true);
> }
> } catch (IOException e) {
> LOG.info("Unable to delete the path created for facilitating rename"
> + deletePath);
> }
> throw new HiveException("Unable to rename: " + sourcePath
> + " to: " + targetPath);
> }
> } else if (!fs.mkdirs(targetPath)) {
> throw new HiveException("Unable to make directory: " + targetPath);
> }
> }
> {code}
> Maybe sourcePath and targetPath come from defferent filesystem, we should
> separate them.
> I see that HIVE-11568 had done it in Hive.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-16943) MoveTask should separate src FileSystem from dest FileSystem
[
https://issues.apache.org/jira/browse/HIVE-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060249#comment-16060249
]
Fei Hui commented on HIVE-16943:
CC [~alangates] [~Ferd]
> MoveTask should separate src FileSystem from dest FileSystem
> -
>
> Key: HIVE-16943
> URL: https://issues.apache.org/jira/browse/HIVE-16943
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 3.0.0
>Reporter: Fei Hui
>Assignee: Fei Hui
> Attachments: HIVE-16943.patch
>
>
> {code:title=MoveTask.java|borderStyle=solid}
> private void moveFileInDfs (Path sourcePath, Path targetPath, FileSystem fs)
> throws HiveException, IOException {
> // if source exists, rename. Otherwise, create a empty directory
> if (fs.exists(sourcePath)) {
> Path deletePath = null;
> // If it multiple level of folder are there fs.rename is failing so
> first
> // create the targetpath.getParent() if it not exist
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_INSERT_INTO_MULTILEVEL_DIRS)) {
> deletePath = createTargetPath(targetPath, fs);
> }
> Hive.clearDestForSubDirSrc(conf, targetPath, sourcePath, false);
> if (!Hive.moveFile(conf, sourcePath, targetPath, true, false)) {
> try {
> if (deletePath != null) {
> fs.delete(deletePath, true);
> }
> } catch (IOException e) {
> LOG.info("Unable to delete the path created for facilitating rename"
> + deletePath);
> }
> throw new HiveException("Unable to rename: " + sourcePath
> + " to: " + targetPath);
> }
> } else if (!fs.mkdirs(targetPath)) {
> throw new HiveException("Unable to make directory: " + targetPath);
> }
> }
> {code}
> Maybe sourcePath and targetPath come from defferent filesystem, we should
> separate them.
> I see that HIVE-11568 had done it in Hive.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-16943) MoveTask should separate src FileSystem from dest FileSystem
[
https://issues.apache.org/jira/browse/HIVE-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059499#comment-16059499
]
Fei Hui commented on HIVE-16943:
[~sershe] could you please take a look ? Thanks.
I see you did the similar change in HIVE-11568
> MoveTask should separate src FileSystem from dest FileSystem
> -
>
> Key: HIVE-16943
> URL: https://issues.apache.org/jira/browse/HIVE-16943
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 3.0.0
>Reporter: Fei Hui
> Attachments: HIVE-16943.patch
>
>
> {code:title=MoveTask.java|borderStyle=solid}
> private void moveFileInDfs (Path sourcePath, Path targetPath, FileSystem fs)
> throws HiveException, IOException {
> // if source exists, rename. Otherwise, create a empty directory
> if (fs.exists(sourcePath)) {
> Path deletePath = null;
> // If it multiple level of folder are there fs.rename is failing so
> first
> // create the targetpath.getParent() if it not exist
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_INSERT_INTO_MULTILEVEL_DIRS)) {
> deletePath = createTargetPath(targetPath, fs);
> }
> Hive.clearDestForSubDirSrc(conf, targetPath, sourcePath, false);
> if (!Hive.moveFile(conf, sourcePath, targetPath, true, false)) {
> try {
> if (deletePath != null) {
> fs.delete(deletePath, true);
> }
> } catch (IOException e) {
> LOG.info("Unable to delete the path created for facilitating rename"
> + deletePath);
> }
> throw new HiveException("Unable to rename: " + sourcePath
> + " to: " + targetPath);
> }
> } else if (!fs.mkdirs(targetPath)) {
> throw new HiveException("Unable to make directory: " + targetPath);
> }
> }
> {code}
> Maybe sourcePath and targetPath come from defferent filesystem, we should
> separate them.
> I see that HIVE-11568 had done it in Hive.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
