[jira] [Commented] (HIVE-17682) Vectorization: IF stmt produces wrong results

2017-10-03 Thread Matt McCline (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190715#comment-16190715
 ] 

Matt McCline commented on HIVE-17682:
-

Committed to master.

> Vectorization: IF stmt produces wrong results
> -
>
> Key: HIVE-17682
> URL: https://issues.apache.org/jira/browse/HIVE-17682
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HIVE-17682.01.patch
>
>
> A query using with a vectorized IF(condition, thenExpr, elseExpr) function 
> can produce wrong results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17682) Vectorization: IF stmt produces wrong results

2017-10-03 Thread Matt McCline (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190711#comment-16190711
 ] 

Matt McCline commented on HIVE-17682:
-

No test related failures.

> Vectorization: IF stmt produces wrong results
> -
>
> Key: HIVE-17682
> URL: https://issues.apache.org/jira/browse/HIVE-17682
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HIVE-17682.01.patch
>
>
> A query using with a vectorized IF(condition, thenExpr, elseExpr) function 
> can produce wrong results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17682) Vectorization: IF stmt produces wrong results

2017-10-03 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190693#comment-16190693
 ] 

Hive QA commented on HIVE-17682:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12890231/HIVE-17682.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 11198 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown]
 (batchId=232)
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert]
 (batchId=232)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan]
 (batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
 (batchId=157)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1]
 (batchId=171)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] 
(batchId=101)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] 
(batchId=240)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=203)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testTupleInBagInTupleInBag[0]
 (batchId=184)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testTupleInBagInTupleInBag[1]
 (batchId=184)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDate (batchId=184)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7103/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7103/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7103/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 11 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12890231 - PreCommit-HIVE-Build

> Vectorization: IF stmt produces wrong results
> -
>
> Key: HIVE-17682
> URL: https://issues.apache.org/jira/browse/HIVE-17682
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HIVE-17682.01.patch
>
>
> A query using with a vectorized IF(condition, thenExpr, elseExpr) function 
> can produce wrong results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17682) Vectorization: IF stmt produces wrong results

2017-10-03 Thread Gopal V (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190316#comment-16190316
 ] 

Gopal V commented on HIVE-17682:


LGTM - +1 tests pending.

> Vectorization: IF stmt produces wrong results
> -
>
> Key: HIVE-17682
> URL: https://issues.apache.org/jira/browse/HIVE-17682
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HIVE-17682.01.patch
>
>
> A query using with a vectorized IF(condition, thenExpr, elseExpr) function 
> can produce wrong results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17682) Vectorization: IF stmt produces wrong results

2017-10-03 Thread Matt McCline (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190252#comment-16190252
 ] 

Matt McCline commented on HIVE-17682:
-

Thanks to [~gopalv] for coming up with a very small test case:

{noformat}
drop table if exists foo;
create temporary table foo (x int, y int) stored as orc;
insert into foo values(1,1),(2,NULL),(3,1);
select x, IF(x > 0,y,0) from foo order by x;
{noformat}


> Vectorization: IF stmt produces wrong results
> -
>
> Key: HIVE-17682
> URL: https://issues.apache.org/jira/browse/HIVE-17682
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 3.0.0
>
>
> A query using with a vectorized IF(condition, thenExpr, elseExpr) function 
> can produce wrong results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)